- Pharo-dev - lists.pharo.org

Re: [Pharo-project] [COTDC] 43 - TextStyleFontSelectorDialogWindow
by Marcus Denker April 8, 2011

April 8, 2011

On Apr 7, 2011, at 10:23 PM, laurent laffont wrote: > TextStyleFontSelectorDialogWindow new => error. > > Is it used ?? If it is broken, it is not used. > Should we remove it ? > things that nobody cares about should be removed. Who will maintain them? Nobody. > > For FreeTypeFontSelectorDialogWindow: > > I'm a dialog to select a font. Usage example: > > |fontSelector| > fontSelector := FreeTypeFontSelectorDialogWindow new. > UITheme builder openModal: fontSelector. > fontSelector selectedFont inspect. > > > Laurent. > > > > On Wed, Apr 6, 2011 at 9:52 PM, laurent laffont <laurent.laffont(a)gmail.com> wrote: > Today: TextStyleFontSelectorDialogWindow > > > Comment Of The Day Contest - One Day One Comment > Rules: > #1: Each day a not commented class is elected. Each day the best comment will be integrated with name of the author(s). > #2: If you cannot comment it, deprecate it. > Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest > > Laurent > -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

1 0

[Pharo-project] Issue 3970 in pharo: Finder broken with last updates related to MorphTreeMorph
by pharo＠googlecode.com April 8, 2011

April 8, 2011

Status: Accepted Owner: marcus.d...(a)gmail.com Labels: Milestone-1.3 New issue 3970 by marcus.d...(a)gmail.com: Finder broken with last updates related to MorphTreeMorph http://code.google.com/p/pharo/issues/detail?id=3970 Finder broken with last updates related to MorphTreeMorph

1 1

[Pharo-project] Issue 3602 in pharo: Code evaluation possible in About box ...
by pharo＠googlecode.com April 8, 2011

April 8, 2011

Status: Accepted Owner: Torsten....(a)astares.de Labels: Milestone-1.3 New issue 3602 by Torsten....(a)astares.de: Code evaluation possible in About box ... http://code.google.com/p/pharo/issues/detail?id=3602 One can open the about box, select the word "LICENSE" and hit Cmd+D (which is a "do it"). => gives an error that this class is missing This could also make it possible to "break into" a deployed image that uses the about box for own purposes since one can select "define new class" from the menu then and in the next page (where one typically edits the class creation message one can enter any expression like "Browser open" or whatever).

1 2

[Pharo-project] [COTDC] 43 - TextStyleFontSelectorDialogWindow
by laurent laffont April 8, 2011

April 8, 2011

Today: TextStyleFontSelectorDialogWindow Comment Of The Day Contest - One Day One Comment Rules: #1: Each day a not commented class is elected. Each day the best comment will be integrated with name of the author(s). #2: If you cannot comment it, deprecate it. Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest Laurent

2 2

[Pharo-project] Issue 3430 in pharo: SystemProgressMorph possible enh
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 New issue 3430 by stephane.ducasse: SystemProgressMorph possible enh http://code.google.com/p/pharo/issues/detail?id=3430 Alexander Lazarević uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-laza.488.mcz ==================== Summary ==================== Name: Morphic-laza.488 Author: laza Time: 8 December 2010, 1:24:52.251 pm UUID: 51a452ef-b931-4d4a-9d66-b8bc829fad99 Ancestors: Morphic-laza.487 Try to prevent empty progress morphs after updates when SystemProgressMorph reset is used in a Postscript =============== Diff against Morphic-mha.486 =============== Item was changed: ----- Method: SystemProgressMorph class>>close: (in category 'instance creation') ----- close: aBlock + | slot | + slot := aBlock value: SmallInteger maxVal. "This should prevent a redraw" + aBlock receiver freeSlot: slot. + + ! - UniqueInstance ifNotNil: [UniqueInstance close: aBlock]! Item was removed: - ----- Method: SystemProgressMorph>>close: (in category 'initialization') ----- - close: aBlock - | slot | - slot := aBlock value: SmallInteger maxVal. "This should prevent a redraw" - self freeSlot: slot - - ! Item was changed: ----- Method: SystemProgressMorph>>freeSlot: (in category 'private') ----- freeSlot: number + number > 0 ifFalse: [^self]. + lock critical: [| label | + label := labels at: number. + (label isNil or: [label owner isNil]) ifTrue: [^self]. "Has been freed before" + label delete. + (bars at: number) delete. + activeSlots := activeSlots - 1. + activeSlots = 0 + ifTrue: [self delete] + ifFalse: [self recenter]]! - number > 0 ifTrue: [ - lock critical: [ - (bars at: number) delete. - (labels at: number) delete. - activeSlots := activeSlots - 1. - activeSlots = 0 - ifTrue: [self delete] - ifFalse: [self recenter]]]! Item was changed: (PackageInfo named: 'Morphic') postscript: '(Preferences dictionaryOfPreferences at: #alternativeWindowBoxesLook) defaultValue: false. + "Force SystemProgressMorph to be reset" SystemProgressMorph initialize; reset. TextEditor initialize. SmalltalkEditor initialize. TheWorldMainDockingBar updateInstances'!

1 1

[Pharo-project] Issue 3346 in pharo: Socket bug fixes
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 New issue 3346 by stephane.ducasse: Socket bug fixes http://code.google.com/p/pharo/issues/detail?id=3346 Andreas Raab uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-ar.98.mcz ==================== Summary ==================== Name: Network-ar.98 Author: ar Time: 23 November 2010, 12:12:58.498 am UUID: 5f0637f3-9b53-ab42-a6fa-55077db31f63 Ancestors: Network-ul.97 Fixes for SocketStream: 1) SocketStream>>receiveData: and SocketStream>>upToEnd: had incorrect conditions used to determine when to stop (#isConnected is wrong since there can be data pending on an unconnected socket which is why using #atEnd is the correct test). 2) The former was done to deal with non-signaling SocketStreams in cases where ConnectionClose was used to deal with end conditions (#upToEnd, #next:into:startingAt:, #readInto:startingAt:count:). This was fixed by making these places (temporarily) signaling so that the exception can be caught and handled properly. 3) SocketStream>>isDataAvailable should not attempt to shortcut prematurely; using 'socket dataAvailable' is bad for subclasses such as SecureSocketStream and unnecessary to boot (and has no performance impact). =============== Diff against Network-ul.97 =============== Item was added: + ----- Method: SocketStream>>beSignalingWhile: (in category 'private') ----- + beSignalingWhile: aBlock + "Temporarily turn a non-signaling SocketStream into a signaling one. + Required for some of operations that will catch ConnectionClosed in + order to find out that an operation completed" + + | signaling | + signaling := shouldSignal. + shouldSignal := true. + ^aBlock ensure:[shouldSignal := signaling] + ! Item was changed: ----- Method: SocketStream>>isDataAvailable (in category 'testing') ----- isDataAvailable + "Answer if more data can be read. It the inbuffer is empty, we read more data. - "Answer if more data can be read. It the inbuffer is empty, we check the socket for data. If it claims to have data available to read, we try to read some once and recursively call this method again. If something really was available it is now in the inBuffer. This is because there has been spurious dataAvailable when there really is no data to get. + Note: It is important not to rely on 'socket dataAvailable' here since this will + not work for subclasses such as SecureSocketStream (which can contain + undecrypted contents that has been read from the socket)." - Note: Some subclasses (such as SecureSocketStream) rely on the behavior here since even though data may be available in the underlying socket, it may not result in any output (yet)." self isInBufferEmpty ifFalse: [^true]. + ^self receiveAvailableData < inNextToWrite + ! - ^socket dataAvailable - ifFalse: [false] - ifTrue: [self receiveAvailableData; isDataAvailable]! Item was changed: ----- Method: SocketStream>>next:into:startingAt: (in category 'stream in') ----- next: anInteger into: aCollection startingAt: startIndex "Read n objects into the given collection. Return aCollection or a partial copy if less than n elements have been read." "Implementation note: This method DOES signal timeout if not enough elements are received. It does NOT signal ConnectionClosed as closing the connection is the only way by which partial data can be read." | start amount | + [self beSignalingWhile:[self receiveData: anInteger]] + on: ConnectionClosed do:[:ex| ex return]. - [self receiveData: anInteger] on: ConnectionClosed do:[:ex| ex return]. "Inlined version of nextInBuffer: to avoid copying the contents" amount := anInteger min: (inNextToWrite - lastRead - 1). start := lastRead + 1. lastRead := lastRead + amount. aCollection replaceFrom: startIndex to: startIndex + amount-1 with: inBuffer startingAt: start. ^amount < anInteger ifTrue:[aCollection copyFrom: 1 to: startIndex + amount-1] ifFalse:[aCollection]! Item was changed: ----- Method: SocketStream>>readInto:startingAt:count: (in category 'stream in') ----- readInto: aCollection startingAt: startIndex count: anInteger "Read n objects into the given collection starting at startIndex. Return number of elements that have been read." "Implementation note: This method DOES signal timeout if not enough elements are received. It does NOT signal ConnectionClosed as closing the connection is the only way by which partial data can be read." | start amount | + [self beSignalingWhile:[self receiveData: anInteger]] + on: ConnectionClosed do:[:ex| ex return]. - [self receiveData: anInteger] on: ConnectionClosed do:[:ex| ex return]. "Inlined version of nextInBuffer: to avoid copying the contents" amount := anInteger min: (inNextToWrite - lastRead - 1). start := lastRead + 1. lastRead := lastRead + amount. aCollection replaceFrom: startIndex to: startIndex + amount-1 with: inBuffer startingAt: start. ^amount! Item was changed: ----- Method: SocketStream>>receiveData: (in category 'control') ----- receiveData: nBytes "Keep reading the socket until we have nBytes in the inBuffer or we reach the end. This method does not return data, but can be used to make sure data has been read into the buffer from the Socket before actually reading it from the FastSocketStream. Mainly used internally. We could also adjust the buffer to the expected amount of data and avoiding several incremental grow operations. NOTE: This method doesn't honor timeouts if shouldSignal is false!! And frankly, I am not sure how to handle that case or if I care - I think we should always signal." + [self atEnd not and: [nBytes > self inBufferSize]] - [self isConnected and: [nBytes > self inBufferSize]] whileTrue: [self receiveData]! Item was changed: ----- Method: SocketStream>>upToEnd (in category 'stream in') ----- upToEnd "Answer all data coming in on the socket until the socket is closed by the other end, or we get a timeout. + This means this method catches ConnectionClosed by itself." - This means this method catches ConnectionClosed by itself. - - NOTE: Does not honour timeouts if shouldSignal is false!!" + [[self atEnd] whileFalse: [self beSignalingWhile:[self receiveData]]] - [[self isConnected] whileTrue: [self receiveData]] on: ConnectionClosed do: [:ex | "swallow it"]. ^self nextAllInBuffer!

1 1

Re: [Pharo-project] Issue 3135 in pharo: Monticello Browser does not answer to key position
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Updates: Labels: -Milestone-1.3 Comment #2 on issue 3135 by marcus.d...(a)gmail.com: Monticello Browser does not answer to key position http://code.google.com/p/pharo/issues/detail?id=3135 (No comment was entered for this change.)

1 0

[Pharo-project] Issue 3348 in pharo: use #shouldBePrintedAsLiteral instead of #isLiteral when printing or storing characters and arrays
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 Difficulty-Easy New issue 3348 by stephane.ducasse: use #shouldBePrintedAsLiteral instead of #isLiteral when printing or storing characters and arrays http://code.google.com/p/pharo/issues/detail?id=3348 A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ul.411.mcz ==================== Summary ==================== Name: Collections-ul.411 Author: ul Time: 23 November 2010, 1:56:22.424 pm UUID: 42a0b87a-f525-6345-bd2c-e55186e17c9d Ancestors: Collections-ul.410 - use #shouldBePrintedAsLiteral instead of #isLiteral when printing or storing characters and arrays =============== Diff against Collections-ul.410 =============== Item was changed: ----- Method: Array>>printOn: (in category 'printing') ----- printOn: aStream + self shouldBePrintedAsLiteral ifTrue: [^self printAsLiteralFormOn: aStream]. - self isLiteral ifTrue: [^self printAsLiteralFormOn: aStream]. self class = Array ifTrue: [^self printAsBraceFormOn: aStream]. ^super printOn: aStream! Item was added: + ----- Method: Array>>shouldBePrintedAsLiteral (in category 'testing') ----- + shouldBePrintedAsLiteral + + ^self class == Array and: [ self allSatisfy: [ :each | each shouldBePrintedAsLiteral ] ]! Item was changed: ----- Method: Array>>storeOn: (in category 'printing') ----- storeOn: aStream "Use the literal form if possible." + self shouldBePrintedAsLiteral - self isLiteral ifTrue: [aStream nextPut: $#; nextPut: $(. self do: [:element | element storeOn: aStream. aStream space]. aStream nextPut: $)] ifFalse: [super storeOn: aStream]! Item was changed: ----- Method: Array>>storeOnStream: (in category 'filter streaming') ----- storeOnStream:aStream + + self shouldBePrintedAsLiteral + ifTrue: [ super storeOnStream:aStream ] + ifFalse:[ aStream writeCollection:self ] - self isLiteral ifTrue: [super storeOnStream:aStream] ifFalse:[aStream writeCollection:self]. ! Item was changed: + ----- Method: Character>>isLiteral (in category 'testing') ----- - ----- Method: Character>>isLiteral (in category 'printing') ----- isLiteral ^true! Item was added: + ----- Method: Character>>shouldBePrintedAsLiteral (in category 'testing') ----- + shouldBePrintedAsLiteral + + ^value between: 33 and: 255! Item was changed: ----- Method: Character>>storeOn: (in category 'printing') ----- storeOn: aStream "Common character literals are preceded by '$', however special need to be encoded differently: for some this might be done by using one of the shortcut constructor methods for the rest we have to create them by ascii-value." | name | + self shouldBePrintedAsLiteral - (value between: 33 and: 255) ifTrue: [ aStream nextPut: $$; nextPut: self ] ifFalse: [ name := self class constantNameFor: self. name notNil ifTrue: [ aStream nextPutAll: self class name; space; nextPutAll: name ] ifFalse: [ aStream nextPut: $(; nextPutAll: self class name; nextPutAll: ' value: '; print: value; nextPut: $) ] ].!

1 2

[Pharo-project] Issue 3436 in pharo: #copyFrom: is broken
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: New Owner: ---- New issue 3436 by sebastianconcept: #copyFrom: is broken http://code.google.com/p/pharo/issues/detail?id=3436 1.2 Unstable version 12272 Steps to reproduce: 1. 2. 3. Just do cmd-p on this: ('some shit' copyFrom: 5) = 'some shit' ifTrue:['WTF?!']

5 30

[Pharo-project] Issue 3782 in pharo: Pangrams
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: New Owner: pavel.krivanek New issue 3782 by pavel.krivanek: Pangrams http://code.google.com/p/pharo/issues/detail?id=3782 Pangrams (sentence using every letter of the alphabet at least once) for various languages. It should be part of the preview string of the font chooser. Please add caps if you can. Attachments: pangrams.st 4.5 KB

1 2