- Pharo-dev - lists.pharo.org

[Pharo-project] [TODO 1.3] open issues tagged 1.3
by Marcus Denker April 7, 2011

April 7, 2011

Hello, So I went through the bug tracker and removed 1.3 tags from non-essential items. What is left are 45 issues: http://code.google.com/p/pharo/issues/list?can=2&q=milestone%3D1.3 among them all 25 failing tests of core: https://pharo-ic.lille.inria.fr/hudson/job/Pharo%20Core%201.3/lastCompleted… -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

1 0

[Pharo-project] Issue 3663 in pharo: XMLWriter and MultiByteFileStream
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3663 by stephane...(a)gmail.com: XMLWriter and MultiByteFileStream http://code.google.com/p/pharo/issues/detail?id=3663 Name: Collections-ul.422 Author: ul Time: 31 January 2011, 2:02:00.387 am UUID: 89c6854c-b6d1-1646-a22b-bbc47ce7522f Ancestors: Collections-ul.421 Introduced Stream >> #basicNext:putAll:startingAt: which will be used by MultiByteFileStream to fix http://bugs.squeak.org/view.php?id=7603 . =============== Diff against Collections-ul.421 =============== Item was added: + ----- Method: Stream>>basicNext:putAll:startingAt: (in category 'accessing') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^self next: anInteger putAll: aCollection startingAt: startIndex + ! A fix for http://bugs.squeak.org/view.php?id=7603 . Requires Collections-ul.422. Added TextConverter >> #next:putAll:startingAt:toStream: which is used by MultiByteFileStream and MultiByteBinaryOrTextStream to properly implement #next:putAll:startingAt:. =============== Diff against Multilingual-ul.133 =============== Item was added: + ----- Method: MultiByteBinaryOrTextStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteBinaryOrTextStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^self converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self + ! Item was added: + ----- Method: MultiByteFileStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteFileStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self! Item was changed: ----- Method: MultiByteFileStream>>nextPutAll: (in category 'public') ----- nextPutAll: aCollection (self isBinary or: [aCollection class == ByteArray]) ifTrue: [ ^ super nextPutAll: aCollection. ]. + ^converter nextPutAll: aCollection toStream: self! - converter nextPutAll: aCollection toStream: self. - ^aCollection! Item was added: + ----- Method: TextConverter>>next:putAll:startingAt:toStream: (in category 'conversion') ----- + next: anInteger putAll: aString startingAt: startIndex toStream: aStream + "Handle fast conversion if ByteString" + + | lastIndex nextIndex | + aString class == ByteString ifFalse: [ + startIndex to: startIndex + anInteger - 1 do: [ :index | + self nextPut: (aString at: index) toStream: aStream ]. + ^aString ]. + aStream isBinary ifTrue: [ + aStream basicNext: anInteger putAll: aString startingAt: startIndex. + ^aString ]. + lastIndex := startIndex. + [ (nextIndex := ByteString + findFirstInString: aString + inSet: latin1Map + startingAt: lastIndex) = 0 or: [ nextIndex > anInteger ] ] whileFalse: [ + aStream + basicNext: nextIndex - lastIndex putAll: aString startingAt: lastIndex; + basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex) + 1). + lastIndex := nextIndex + 1 ]. + aStream basicNext: anInteger - lastIndex + 1 putAll: aString startingAt: lastIndex. + ^aString! Item was changed: ----- Method: TextConverter>>nextPutAll:toStream: (in category 'conversion') ----- nextPutAll: aString toStream: aStream "Handle fast conversion if ByteString" + ^self next: aString size putAll: aString startingAt: 1 toStream: aStream! - | lastIndex nextIndex | - aString class == ByteString ifFalse: [ - aString do: [:char | self nextPut: char toStream: aStream]. - ^self]. - - aStream isBinary ifTrue: [ - aStream basicNextPutAll: aString. - ^self]. - lastIndex := 1. - [nextIndex := ByteString findFirstInString: aString inSet: latin1Map startingAt: lastIndex. - nextIndex = 0] whileFalse: - [aStream next: nextIndex-lastIndex putAll: aString startingAt: lastIndex. - aStream basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex)+1). - lastIndex := nextIndex + 1]. - aStream next: aString size-lastIndex+1 putAll: aString startingAt: lastIndex. - ^self - !

1 4

[Pharo-project] 13135 open setting DNU
by stephane ducasse April 7, 2011

April 7, 2011

props layoutInset asPoint asPoint DNU on a rectangle. Stef

1 0

Re: [Pharo-project] Issue 2441 in pharo: Strange behavior of Rectangle
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Updates: Labels: -Milestone-1.3 Comment #9 on issue 2441 by marcus.d...(a)gmail.com: Strange behavior of Rectangle http://code.google.com/p/pharo/issues/detail?id=2441 (No comment was entered for this change.)

1 1

[Pharo-project] Issue 3424 in pharo: Improved class Tests
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 Difficulty-Easy New issue 3424 by stephane.ducasse: Improved class Tests http://code.google.com/p/pharo/issues/detail?id=3424 A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-spd.149.mcz ==================== Summary ==================== Name: KernelTests-spd.149 Author: spd Time: 4 December 2010, 1:33:50.265 pm UUID: 89c23bef-103f-4b9d-885c-bcf19d6b6fa9 Ancestors: KernelTests-cmm.148 * refactored and extended ClassTest, including adding a test for Class>>canFindWithoutEnvironment: (fixed in Kernel-spd.444 in inbox) n.b. no conflicts with trunk as of 12/4/2010 =============== Diff against KernelTests-cmm.148 =============== Item was changed: TestCase subclass: #ClassTest + instanceVariableNames: 'className renamedName subClassName anotherClassName class subclass anotherClass' - instanceVariableNames: 'className renamedName' classVariableNames: '' poolDictionaries: '' category: 'KernelTests-Classes'! Item was added: + ----- Method: ClassTest classSide>>deleteClassNamed: (in category 'setup') ----- + deleteClassNamed: aString + | cl | + cl := Smalltalk at: aString ifAbsent: [^self]. + cl removeFromChanges; removeFromSystemUnlogged + ! Item was removed: - ----- Method: ClassTest>>deleteClass (in category 'setup') ----- - deleteClass - | cl | - cl := Smalltalk at: className ifAbsent: [^self]. - cl removeFromChanges; removeFromSystemUnlogged - ! Item was removed: - ----- Method: ClassTest>>deleteRenamedClass (in category 'setup') ----- - deleteRenamedClass - | cl | - cl := Smalltalk at: renamedName ifAbsent: [^self]. - cl removeFromChanges; removeFromSystemUnlogged - ! Item was added: + ----- Method: ClassTest>>deleteTestClasses (in category 'setup') ----- + deleteTestClasses + + self class deleteClassNamed: class name. + self class deleteClassNamed: subclass name. + self class deleteClassNamed: renamedName. + self class deleteClassNamed: anotherClass name. + ! Item was changed: ----- Method: ClassTest>>setUp (in category 'setup') ----- setUp + - className := #TUTU. renamedName := #RenamedTUTU. + + self deleteTestClasses. + + class := Object subclass: #TUTU - self deleteClass. - self deleteRenamedClass. - Object subclass: className instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' + category: 'KernelTests-Classes'. + + subclass := class subclass: #SubTUTU + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Classes'. + + anotherClass := Object subclass: #AnotherClass + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'KernelTests-Classes'.! - category: 'KernelTests-Classes'! Item was added: + ----- Method: ClassTest>>superclass (in category 'accessing') ----- + superclass + + ^ class.! Item was changed: ----- Method: ClassTest>>tearDown (in category 'setup') ----- tearDown + + self deleteTestClasses.! - self deleteClass. - self deleteRenamedClass! Item was added: + ----- Method: ClassTest>>testAddClassVarName (in category 'testing') ----- + testAddClassVarName + "self run: #testAddClassVarName" + + class addClassVarName: #MyShinyNewClassVar. + self assert: (class classVarNames anySatisfy: [ :name | name = #MyShinyNewClassVar ]). + + ! Item was added: + ----- Method: ClassTest>>testAddClassVarNameWithSameNameAsAGlobal (in category 'testing') ----- + testAddClassVarNameWithSameNameAsAGlobal + "self run: #testAddClassVarName" + + self shouldnt: [ class addClassVarName: anotherClass name ] raise: Exception. + self assert: (class classVarNames anySatisfy: [ :name | name = anotherClass name ]). + + ! Item was changed: ----- Method: ClassTest>>testAddInstVarName (in category 'testing') ----- testAddInstVarName "self run: #testAddInstVarName" + class addInstVarName: 'x'. + self assert: (class instVarNames = #('x')). + class addInstVarName: 'y'. + self assert: (class instVarNames = #('x' 'y')) - | tutu | - tutu := Smalltalk at: #TUTU. - tutu addInstVarName: 'x'. - self assert: (tutu instVarNames = #('x')). - tutu addInstVarName: 'y'. - self assert: (tutu instVarNames = #('x' 'y')) - ! Item was added: + ----- Method: ClassTest>>testCanFindWithoutEnvironment (in category 'testing') ----- + testCanFindWithoutEnvironment + "self debug: #testCanFindWithoutEnvironment" + "self run: #testCanFindWithoutEnvironment" + + self deny: (subclass canFindWithoutEnvironment: #ClassVarInSuperclass). + self deny: (subclass canFindWithoutEnvironment: #PoolVarInSuperclass). + self deny: (subclass canFindWithoutEnvironment: #ClassVar). + self deny: (subclass canFindWithoutEnvironment: #PoolVar). + + subclass addClassVarName: 'ClassVar'. + self assert: (subclass canFindWithoutEnvironment: #ClassVar). + + subclass addSharedPool: (Dictionary newFromPairs: #(PoolVar->5)). + self assert: (subclass canFindWithoutEnvironment: #PoolVar). + + self superclass addClassVarName: 'ClassVarInSupersubclass'. + self assert: (subclass canFindWithoutEnvironment: #ClassVarInSupersubclass). + + self superclass addSharedPool: (Dictionary newFromPairs: #(PoolVarInSupersubclass->5)). + self assert: (subclass canFindWithoutEnvironment: #PoolVarInSupersubclass).! Item was changed: ----- Method: ClassTest>>testRenaming (in category 'testing') ----- testRenaming "self debug: #testRenaming" "self run: #testRenaming" + | newMetaclassName | - | oldName newMetaclassName class | - oldName := className. newMetaclassName := (renamedName, #' class') asSymbol. - class := Smalltalk at: oldName. class class compile: 'dummyMeth'. class rename: renamedName. self assert: class name = renamedName. self assert: (ChangeSet current changedClassNames includes: renamedName). self assert: (ChangeSet current changedClassNames includes: newMetaclassName). !

1 1

[Pharo-project] filesystem changes
by Tudor Girba April 7, 2011

April 7, 2011

Hi, I noticed that Filesystem changed significantly recently both internally and in package structure (I guess it was Colin - the user says cwp). This led to some red tests in Moose that I now fixed. I am writing here to document these changes in case other people are using this nice library. >From a package point of view Filesystem has now a cool structure with basically each category being in a separate package. Furthermore, the original Filesystem is now empty which might create problems if people are loading it like we do in Moose. To get it loading, I created a new baseline (2.0.1-baseline) in the ConfigurationOfFilesystem. There were also some refactorings at the level of the model. Now, FSFilesystem does not have subclasses anymore (e.g., FSDiskFilesystem does not exist anymore). Instead there is a composition with a Store, so you will have FSDiskStore. Thus, if before you used something like "FSDiskFilesystem current", now you will have to use "FSDiskStore currentFilesystem" That was it. Everything is green now in Moose land. Cheers, Doru -- www.tudorgirba.com "Next time you see your life passing by, say 'hi' and get to know her."

2 1

[Pharo-project] Issue 3370 in pharo: NewParagraph and MultiNewParagraph should be merged
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: Accepted Owner: aplantec Labels: Milestone-1.2 New issue 3370 by aplantec: NewParagraph and MultiNewParagraph should be merged http://code.google.com/p/pharo/issues/detail?id=3370 Merged in a Paragraph class then NewParagraph and MultiNewParagraph deprecated in 1.2

1 5

[Pharo-project] abouth nautilus and the removal of CodeHolder hierarchy
by Fernando Olivero April 7, 2011

April 7, 2011

Hi Ben, i was thinking about the discussion of the menus: Since you are using menu pragma builder, and have explicit views for each tool, then the CodeHolder hierarchy is no longer needed. Because the specialized views get the behavior for answering the actions in the menus (which currently is spread across the StringHolder hierarchy). So this is the main reason why you simple need a pluggable text model, for the model of the views. And a pluggable TextModel (or StringHolder in Pharo) would suffice? Is this correct? Thanks, Fernando

10 28

[Pharo-project] Issue 3347 in pharo: simplified and unified String's line-ending changing methods
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 Type-Squeak New issue 3347 by stephane.ducasse: simplified and unified String's line-ending changing methods http://code.google.com/p/pharo/issues/detail?id=3347 Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.409.mcz ==================== Summary ==================== Name: Collections-ul.409 Author: ul Time: 22 November 2010, 1:35:14.026 pm UUID: 849eb41a-5717-9e44-ab23-eae36fb603bb Ancestors: Collections-ul.408 - introduced String >> #withLineEndings: - simplified and unified String's line-ending changing methods: #withInternetLineEndings, #withSqueakLineEndings and #withUnixLineEndings =============== Diff against Collections-ul.408 =============== Item was changed: ----- Method: String>>withInternetLineEndings (in category 'internet') ----- withInternetLineEndings "change line endings from CR's and LF's to CRLF's. This is probably in prepration for sending a string over the Internet" + ^self withLineEndings: String crlf! - ^self class - new: self size * 16 // 15 "provisions for CR-LF pairs" - streamContents: [ :stream | - self lineIndicesDo: [:start :endWithoutDelimiters :end | - stream next: 1 + endWithoutDelimiters - start putAll: self startingAt: start. - endWithoutDelimiters = end ifFalse: [ - stream crlf ] ] ]! Item was added: + ----- Method: String>>withLineEndings: (in category 'internet') ----- + withLineEndings: lineEndingString + + | stream | + stream := nil. + self lineIndicesDo: [ :start :endWithoutDelimiters :end | + (stream isNil and: [ endWithoutDelimiters ~= end ]) ifTrue: [ + (self copyFrom: endWithoutDelimiters + 1 to: end) = lineEndingString ifFalse: [ + stream := WriteStream with: self copy. + stream position: start - 1 ] ]. + stream ifNotNil: [ + stream next: endWithoutDelimiters - start + 1 putAll: self startingAt: start. + endWithoutDelimiters = end ifFalse: [ + stream nextPutAll: lineEndingString ] ] ]. + ^stream + ifNil: [ self ] + ifNotNil: [ + stream position = self size + ifTrue: [ stream originalContents ] + ifFalse: [ stream contents ] ]! Item was changed: ----- Method: String>>withSqueakLineEndings (in category 'internet') ----- withSqueakLineEndings "Assume the string is textual, and that CR, LF, and CRLF are all valid line endings. Replace each occurence with a single CR." + | cr lf indexLF indexCR | - | cr lf inPos outPos outString newOutPos indexLF indexCR | lf := Character linefeed. indexLF := self indexOf: lf startingAt: 1. indexLF = 0 ifTrue: [^self]. cr := Character cr. indexCR := self indexOf: cr startingAt: 1. indexCR = 0 ifTrue: [^self copy replaceAll: lf with: cr]. + ^self withLineEndings: String cr! - inPos := outPos := 1. - outString := String new: self size. - - ["check if next CR (if any) is before next LF" - (indexCR > 0 and: [indexCR < indexLF]) - ifTrue: [ - newOutPos := outPos + 1 + indexCR - inPos. - outString replaceFrom: outPos to: newOutPos - 1 with: self startingAt: inPos. - outPos := newOutPos. - 1 + indexCR = indexLF - ifTrue: ["Caught a CR-LF pair" - inPos := 1 + indexLF. - indexLF := self indexOf: lf startingAt: inPos] - ifFalse: [inPos := 1 + indexCR]. - indexCR := self indexOf: cr startingAt: inPos] - ifFalse: [ - newOutPos := outPos + 1 + indexLF - inPos. - outString replaceFrom: outPos to: newOutPos - 2 with: self startingAt: inPos. - outString at: newOutPos - 1 put: cr. - outPos := newOutPos. - inPos := 1 + indexLF. - indexLF := self indexOf: lf startingAt: inPos]. - indexLF = 0] - whileFalse. - - "no more LF line endings. copy the rest" - newOutPos := outPos + (self size - inPos + 1). - outString replaceFrom: outPos to: newOutPos - 1 with: self startingAt: inPos. - ^outString copyFrom: 1 to: newOutPos - 1! Item was changed: ----- Method: String>>withUnixLineEndings (in category 'internet') ----- withUnixLineEndings "Assume the string is textual, and that CR, LF, and CRLF are all valid line endings. Replace each occurence with a single LF." + | cr lf indexLF indexCR | - | cr lf inPos outPos outString newOutPos indexLF indexCR | cr := Character cr. indexCR := self indexOf: cr startingAt: 1. indexCR = 0 ifTrue: [^self]. lf := Character linefeed. indexLF := self indexOf: lf startingAt: 1. indexLF = 0 ifTrue: [^self copy replaceAll: cr with: lf]. + ^self withLineEndings: String lf! - inPos := outPos := 1. - outString := String new: self size. - - ["check if next CR is before next LF or if there are no more LF" - (indexLF = 0 or: [indexCR < indexLF]) - ifTrue: [ - newOutPos := outPos + 1 + indexCR - inPos. - outString replaceFrom: outPos to: newOutPos - 2 with: self startingAt: inPos. - outString at: newOutPos - 1 put: lf. - outPos := newOutPos. - 1 + indexCR = indexLF - ifTrue: ["Caught a CR-LF pair" - inPos := 1 + indexLF. - indexLF := self indexOf: lf startingAt: inPos] - ifFalse: [inPos := 1 + indexCR]. - indexCR := self indexOf: cr startingAt: inPos] - ifFalse: [ - newOutPos := outPos + 1 + indexLF - inPos. - outString replaceFrom: outPos to: newOutPos - 1 with: self startingAt: inPos. - outPos := newOutPos. - inPos := 1 + indexLF. - indexLF := self indexOf: lf startingAt: inPos]. - indexCR = 0] - whileFalse. - - "no more CR line endings. copy the rest" - newOutPos := outPos + (self size - inPos + 1). - outString replaceFrom: outPos to: newOutPos - 1 with: self startingAt: inPos. - ^outString copyFrom: 1 to: newOutPos - 1!

1 2

[Pharo-project] Issue 3773 in pharo: should get a better completionDialog
by pharo＠googlecode.com April 7, 2011

April 7, 2011

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3773 by stephane...(a)gmail.com: should get a better completionDialog http://code.google.com/p/pharo/issues/detail?id=3773 OBCompletionDialog / OBCompletionRequest come with the OB from Pharo 1.2. The way to use it is like: OBCompletionRequest new prompt: 'Find Class'; searchBlock: [ :string | OBCmdFindClass new findClassIn: Smalltalk pattern: string ]; labelBlock: [ :class | class name ]; iconBlock: [ :class | class browserIcon ]; signal.

1 2