- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] 08756b: 60156
by GitHub July 27, 2016

July 27, 2016

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 08756b83ecbe7ca5470769a9bdca64d032244950 https://github.com/pharo-project/pharo-core/commit/08756b83ecbe7ca5470769a9… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-07-27 (Wed, 27 Jul 2016) Changed paths: M AST-Core.package/RBScanner.class/instance/private-scanning/scanPatternVariable.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60155.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60156.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60155.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60156.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Spec-Core.package/AbstractFormButtonModel.class/README.md A Spec-Core.package/AbstractFormButtonModel.class/definition.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api-events/whenActivatedDo_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api-events/whenActivationActionChanged_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api-events/whenChangedDo_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api-events/whenLabelClickableChanged_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api-valueHolder/labelHolder.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/activationAction_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/click.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/label.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/labelClickable.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/labelClickable_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/label_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/state.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/state_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/api/toggleState.st A Spec-Core.package/AbstractFormButtonModel.class/instance/as yet unclassified/deactivationAction_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/as yet unclassified/whenDeactivatedDo_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/as yet unclassified/whenDeactivationActionChanged_.st A Spec-Core.package/AbstractFormButtonModel.class/instance/initialization/initialize.st R Spec-Core.package/CheckBoxModel.class/instance/api-events/whenActivatedDo_.st R Spec-Core.package/CheckBoxModel.class/instance/api-events/whenActivationActionChanged_.st R Spec-Core.package/CheckBoxModel.class/instance/api-events/whenChangedDo_.st R Spec-Core.package/CheckBoxModel.class/instance/api-events/whenLabelClickableChanged_.st R Spec-Core.package/CheckBoxModel.class/instance/api-valueHolder/labelHolder.st R Spec-Core.package/CheckBoxModel.class/instance/api/activationAction_.st R Spec-Core.package/CheckBoxModel.class/instance/api/click.st R Spec-Core.package/CheckBoxModel.class/instance/api/label.st R Spec-Core.package/CheckBoxModel.class/instance/api/labelClickable.st R Spec-Core.package/CheckBoxModel.class/instance/api/labelClickable_.st R Spec-Core.package/CheckBoxModel.class/instance/api/label_.st R Spec-Core.package/CheckBoxModel.class/instance/api/state.st R Spec-Core.package/CheckBoxModel.class/instance/api/state_.st R Spec-Core.package/CheckBoxModel.class/instance/api/toggleState.st R Spec-Core.package/CheckBoxModel.class/instance/as yet unclassified/deactivationAction_.st R Spec-Core.package/CheckBoxModel.class/instance/as yet unclassified/whenDeactivatedDo_.st R Spec-Core.package/CheckBoxModel.class/instance/as yet unclassified/whenDeactivationActionChanged_.st R Spec-Core.package/CheckBoxModel.class/instance/initialization/initialize.st A Spec-Core.package/ManifestSpecCore.class/README.md A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleEqualsTrueRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleExcessiveMethodsRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleExcessiveVariablesRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleGTExampleNotDefinedRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleImplementedNotSentRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleLongMethodsRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleRBOverridesDeprecatedMethodRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleSubclassResponsibilityNotDefinedRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleUnwindBlocksRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/class/code-critics/ruleUsesTrueRuleV1FalsePositive.st A Spec-Core.package/ManifestSpecCore.class/definition.st R Spec-Core.package/RadioButtonModel.class/instance/api-events/whenActivatedDo_.st R Spec-Core.package/RadioButtonModel.class/instance/api-events/whenActivationActionChanged_.st R Spec-Core.package/RadioButtonModel.class/instance/api-events/whenChangedDo_.st R Spec-Core.package/RadioButtonModel.class/instance/api-events/whenDeactivatedDo_.st R Spec-Core.package/RadioButtonModel.class/instance/api-events/whenDeactivationActionChanged_.st R Spec-Core.package/RadioButtonModel.class/instance/api-events/whenLabelClickableChanged_.st R Spec-Core.package/RadioButtonModel.class/instance/api-valueHolder/labelHolder.st R Spec-Core.package/RadioButtonModel.class/instance/api/activationAction_.st R Spec-Core.package/RadioButtonModel.class/instance/api/click.st R Spec-Core.package/RadioButtonModel.class/instance/api/deactivationAction_.st R Spec-Core.package/RadioButtonModel.class/instance/api/label.st R Spec-Core.package/RadioButtonModel.class/instance/api/labelClickable.st R Spec-Core.package/RadioButtonModel.class/instance/api/labelClickable_.st R Spec-Core.package/RadioButtonModel.class/instance/api/label_.st R Spec-Core.package/RadioButtonModel.class/instance/api/state.st R Spec-Core.package/RadioButtonModel.class/instance/api/toggleState.st M Spec-Core.package/RadioButtonModel.class/instance/initialization/initialize.st A Spec-Debugger.package/ManifestSpecDebugger.class/README.md A Spec-Debugger.package/ManifestSpecDebugger.class/definition.st A Spec-Examples.package/ManifestSpecExamples.class/README.md A Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleClassNotReferencedRuleV1FalsePositive.st A Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleCollectionMessagesToExternalObjectRuleV1FalsePositive.st A Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleLongMethodsRuleV1FalsePositive.st A Spec-Examples.package/ManifestSpecExamples.class/class/code-critics/ruleSentNotImplementedRuleV1FalsePositive.st A Spec-Examples.package/ManifestSpecExamples.class/definition.st A Spec-Help.package/ManifestSpecHelp.class/README.md A Spec-Help.package/ManifestSpecHelp.class/definition.st A Spec-Inspector.package/ManifestSpecInspector.class/README.md A Spec-Inspector.package/ManifestSpecInspector.class/definition.st A Spec-Layout.package/ManifestSpecLayout.class/README.md A Spec-Layout.package/ManifestSpecLayout.class/class/code-critics/ruleExcessiveArgumentsRuleV1FalsePositive.st A Spec-Layout.package/ManifestSpecLayout.class/definition.st A Spec-MorphicAdapters.package/ManifestSpecMorphicAdapters.class/README.md A Spec-MorphicAdapters.package/ManifestSpecMorphicAdapters.class/class/code-critics/ruleGTExampleNotDefinedRuleV1FalsePositive.st A Spec-MorphicAdapters.package/ManifestSpecMorphicAdapters.class/class/code-critics/ruleRBOverridesDeprecatedMethodRuleV1FalsePositive.st A Spec-MorphicAdapters.package/ManifestSpecMorphicAdapters.class/definition.st M Spec-PolyWidgets.package/DateModel.class/definition.st M Spec-PolyWidgets.package/EditableList.class/class/example/example.st M Spec-PolyWidgets.package/EditableList.class/definition.st M Spec-PolyWidgets.package/EditableList.class/instance/initialization/initializeWidgets.st M Spec-PolyWidgets.package/InputWidget.class/class/example/example2.st A Spec-PolyWidgets.package/ManifestSpecPolyWidgets.class/README.md A Spec-PolyWidgets.package/ManifestSpecPolyWidgets.class/definition.st M Spec-PolyWidgets.package/PickListModel.class/definition.st M Spec-PolyWidgets.package/SearchableList.class/class/example/example.st M Spec-PolyWidgets.package/SearchableList.class/definition.st M Spec-PolyWidgets.package/SearchableTree.class/definition.st M Spec-PolyWidgets.package/SearchableTree.class/instance/initialization/initializeWidgets.st A Spec-SelectEntity.package/ManifestSpecSelectEntity.class/README.md A Spec-SelectEntity.package/ManifestSpecSelectEntity.class/definition.st A Spec-Tests.package/ManifestSpecTests.class/README.md A Spec-Tests.package/ManifestSpecTests.class/definition.st A Spec-Tools.package/ManifestSpecTools.class/README.md A Spec-Tools.package/ManifestSpecTools.class/definition.st Log Message: ----------- 60156 18822 RBScanner>>#scanPatternVariable shouldnt continue parsing on error https://pharo.fogbugz.com/f/cases/18822 18771 Add a manifest for critics https://pharo.fogbugz.com/f/cases/18771 18743 Create an abstract class to remove code duplication between CheckboxModel and RadioButtonModel https://pharo.fogbugz.com/f/cases/18743 18803 Cleanup of Spec-Polywidget https://pharo.fogbugz.com/f/cases/18803 http://files.pharo.org/image/60/60156.zip

1 0

Why nil needs class hierarchy protocol?
by Denis Kudriashov July 27, 2016

July 27, 2016

Hi. Look at UndefinedObject instance side methods. You will see class hierarchy protocol. For example nil understands #subclasses message: nil subclasses "==> {ProtoObject}" It implemented like this: UndefinedObject >>subclassesDo: aBlock "Evaluate aBlock with all subclasses of nil. Others are not direct subclasses of Class." ^ Class subclassesDo: [:cl | cl isMeta ifTrue: [aBlock value: cl soleInstance]]. So my question is: why it needs to be like that? And does it really needed? I removed all this methods and not saw any problem.

4 7

magritte extras
by Sean Glazier July 27, 2016

July 27, 2016

I am looking at creating a tool that works like the magritte example. It uses Magritte-XMLBinding. I ran the tests and had a small number of failures in Magritte-Tests-XMLBinding. The example class MADescriptionEditor is in the examples tag of the Magritte-Seaside package. It came from Repository: http://smalltalkhub.com/mc/Magritte/Magritte3/main/ and the XML binding for the examples comes from Repository: http://smalltalkhub.com/mc/Magritte/Magritte3Addons/main/ So if someone has these working and playing together that would be great. If it is outdated and we are to use something else I would like to know what the preferred way is so I can build the example building the descriptions using I guess json. Many thanks :-) Kind Regards, Sean Glazier

2 1

http://source.squeakfoundation.org down
by Dale Henrichs July 26, 2016

July 26, 2016

It's not just me: http://downforeveryoneorjustme.com/source.squeakfoundation.org I'm getting a '502 Bad Gateway' error ... I seems to have broken in the last hour or so ... It also appears that the squeak mailing list is down --- which is why I've sent the mail here --- The FFI code is hosted on http://source.squeakfoundation.org so this will likely impact others as well ... Dale

2 2

pragma syntax
by Nicolai Hess July 26, 2016

July 26, 2016

Hi, is this valid pragma syntax: foo <func: #operation arg: #+> ^ self (note the closing angle and the +-symbol) The above code is what the pretty printer creates if you pretty-print this code foo <func: #operation arg: #+ > ^ self (note the space between #+ and > Or a bug in the parser ? this pragma definition <func: #operation arg: #a> seems to work.

4 4

Doubled setting for now showing catalog projects in Spotter
by Torsten Bergmann July 26, 2016

July 26, 2016

Hi, I today wondered as in latest image it was not possible to download projects from Spotter anymore. The setting for downloading projects from Catalog was enabled. In latest Pharo 6 there is a new (second and redundant) setting to exclude catalog projects from Spotter (now provided by the GT tools). Also it is not implemented very nice: - it uses reflection and is therefore hard to find (implemented in #catalogSettingsOn:) - it shows ugly symbols in the settings browser without any description - while the method is called #catalogSettingsOn: the way it is implemented it allows to disable ANY GT Spotter extension in the settings browser as it uses "GTSpotter spotterExtendingMethods". Not very intention revealing. To me this really looks like a BIG AND QUICK HACK and a solution to a problem that was already solved before. Please remove it/roll back this unnecessary addition. Side note: ========== There ALREADY WAS A SETTING FOR THAT (since Pharo 5 or 4) to not query the catalog (because a few people lamented before that it slows down when connected with low bandwidth network). It is implemented in CatalogSettings and you can find it in the settings browser under "Tools" -> "Catalog" -> "Display catalog projects in Spotter" and is used in the spotter extension #spotterCatalogProjectsFor: Second side note: ================= If the intention was to generally provide an ability to disable any spotter extension (via reflection) then use #spotterExtensionSettingsOn: instead of the name #catalogSettingsOn: and set the default to true for the catalog extension. If you want to disable projects showing up by default in spotter via network connection than use the one that was already there and set it to false by default. (which I would not do as network should be fast enough these days for catalog in most places also catalog is already cached and the call implemented asynchronously, so Spotter opens right away). Thanks Torsten

2 1

Recover *every lost change ever* in Pharo 5.0
by Sean P. DeNigris July 26, 2016

July 26, 2016

It seems the initial dialog has been removed. What is the rationale here? How often are integrator DoIts relevant to end users?! ----- Cheers, Sean -- View this message in context: http://forum.world.st/Recover-every-lost-change-ever-in-Pharo-5-0-tp4908073… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

1 0

magritte extras
by Sean Glazier July 26, 2016

July 26, 2016

I am looking at creating a tool that works like the magritte example. It uses Magritte-XMLBinding. I ran the tests and had a small number of failures in Magritte-Tests-XMLBinding. The example class MADescriptionEditor is in the examples tag of the Magritte-Seaside package. It came from Repository: http://smalltalkhub.com/mc/Magritte/Magritte3/main/ and the XML binding for the examples comes from Repository: http://smalltalkhub.com/mc/Magritte/Magritte3Addons/main/ So if someone has these working and playing together that would be great. If it is outdated and we are to use something else I would like to know what the preferred way is so I can build the example building the descriptions using I guess json. Many thanks :-) Kind Regards, Sean Glazier

1 0

Nautilus... switching from hierarchy to package
by stepharo July 26, 2016

July 26, 2016

Hi I would like to know what you think. I found annoying that when I'm browsing an hierarchy I cannot switch to the package view when I click on a class outside of the current package. Stef

3 2

FileException only when opening image in certain way...
by Mariano Martinez Peck July 26, 2016

July 26, 2016

Hi guys, Davide Varvello reported me an issue with Fuel, failing to do: FLSerializer serialize: 'whatever' toFileNamed: 'demo.fuel'. Such a thing would bring an error like this: File>>openForWrite: File>>openForWrite File>>writeStream File>>writeStreamDo: FLPharo5Platform>>fileNamed:writeStreamDo: FLSerializer>>serialize:toFileNamed: FLSerializer class>>serialize:toFileNamed: The code is: FLPharo5Platform >> fileNamed: aFilename writeStreamDo: aBlock ^ ((Smalltalk at: #File) named: aFilename) writeStreamDo: [ :stream | stream binary. aBlock value: stream ] Now..I have tried to reproduce it but it happens only depending on how the vm/image was started!!! And I only tested on OSX. Download the oneclick from here: http://files.pharo.org/platform/Pharo5.0-mac.zip and see my results: 1) Executing VM from command line and passing the image as argument: WORKS. 2) Double clicking on the internal Pharo binary (which auto-starts the image): WORKS 3) Double clicking the internal Pharo image and then "Open With" and I select the Pharo VM: DOES NOT WORK. 4) Double clicking the Pharo one click: DOES NOT WORK. Has anyone experienced something like this? Looks like different file / directory permissions when starting in different ways? Thanks in advance, -- Mariano http://marianopeck.wordpress.com

3 3