- Pharo-dev - lists.pharo.org

P3Converter and DateAndTime>>#readFrom: performance
by Esteban Maringolo Oct. 13, 2020

Oct. 13, 2020

Hi, I recently stumbled into some performance issue I had, so I profiled it and got it fixed, but by doing that I also noticed a huge time spent when reading DateAndTimes and Dates (which also uses the former) and the culprit seems to be `Date class>>#readFrom:`. Digging into this, I noticed that this was called from `DateAndTime>>#readFrom:`, but in particular 90% of the time spent was when instantiating the Date part of it, because it does unnecessary lookup of the index of Month when input stream only have a month index. What I did then was to change the default behavior of DateAndTime class>>#readFrom: readFrom: aStream defaultOffset: defaultOffset "Parse and return a new DateAndTime instance from stream, as a Date, an optional Time and an optional TimeZone offset. The time defaults to midnight, the timezone to defaultOffset" "self readFrom: '2013-03-04T23:47:52.876+01:00' readStream" "From this" date := Date readFrom: aStream. "To this" date := Date readFrom: (aStream next: 10) pattern: 'yyyy-mm-dd'. And also in P3Converter to specify the pattern directly. P3Converter>>#convertDateFrom: bytes length: length description: description ^Date readFrom: (self asciiStreamFor: bytes length: length) pattern: 'yyyy-mm-dd' With these two changes I got a 8x-10x speedup when reading Date/DateAndTime from the database. Then I dig a little further and in P3Converter added a little check to avoid translating the offset of a DateAndTime when it is not needed. P3Converter>>#convertDateAndTimeWithoutTimezoneFrom: bytes length: length description: description "TIMESTAMP WITHOUT TIME ZONE (TIMESTAMP) is stored internally in Postgres the way it was inserted, its representation remains constant, with no offset added. We use the timezone of the connection to do the necessary shifting. This assumes that the timezones used during insert/update and query are the same." | timestamp offset | timestamp := DateAndTime readFrom: (self asciiStreamFor: bytes length: length) defaultOffset: Duration zero. offset := self timezone offsetForTimestamp: timestamp. ^offset isZero "<-- added this check to avoid translation" ifTrue: [ timestamp ] ifFalse: [ timestamp translateTo: offset ] And the speedup went even higher. But I don't know whether this last part is correct. Of course this seems as a quick and dirty fix, but I don't know whether DateAndTime>>readFrom: should read any format or just ISO 8601 formats nor whether the Date/DateAndTime coming from PostgreSQL are always formatted that way. I ran my app's small test suite and haven't had any issues, neither during development with these changes applied. I think there is a significant slowdown involved in the instantiation of Dates that should be fixed, whether this fix is definitive or not is why I'm asking here. Regards! Esteban A. Maringolo

2 2

This week (41/2020) on the Issue Tracker
by Marcus Denker Oct. 13, 2020

Oct. 13, 2020

This week (41/2020) on the Issue Tracker ================================ Hi, We had the idea to try to do a summary of all the things that got merged during the week. I tried for a while an automatic tool (a Probot bot), but that only works for some weeks and then stops (I think they have some rate limiting problem for the bot). And it was not really usefulâ¦ as it just listed all PRs and Issues. This one puts a focus on *merged* PRs to Pharo itself only and sorts them by category with a little bit of context. Parser/Syntax Highlighting ======================= Improvement to make the prior huge improvement on parsing of syntactically wrong code much more usable: Several fixes to the parser and syntax feedback #7411 https://github.com/pharo-project/pharo/pull/7411 First class Variables / Compiler cleanup ==================== Lots of work has been done to unify all meta objects describing Variables into one hierarchy (see Variable and subclasses). This in turn enables many cleanups and simplification on the level of the name analysis of the Compiler and the API that the debugger uses to read Variables. Nearly finished, but some smaller steps remain: Variable-scope-addTests #7435 (all Variable objects should know the scope where they are from) https://github.com/pharo-project/pharo/pull/7435 Name Analysis: Lookup Slots In Class #7403 https://github.com/pharo-project/pharo/pull/7403 reduce-sends-doSemanticAnalysis #7402 https://github.com/pharo-project/pharo/pull/7402 7405-Debug-It-is-broken #7406 (this was a bad side effect of a refactoring needed to be able to move the call of #doSemanticAnalysis into the Compiler) https://github.com/pharo-project/pharo/pull/7406 Fluid Class Definions ====================== This is ongoing work to have a better class definiton for what is now called "slot enabeled class defintion" (the one where one can use First class Variables and where the Layout class is shown explicitly) 7444-Prepare-fluid-class-integration-part-4 #7445 https://github.com/pharo-project/pharo/pull/7445 7437-prepare-fluid-class-integration-part-3 #7438 https://github.com/pharo-project/pharo/pull/7438 7412-preparing-the-integration-of-fluid-class-part-2 #7434 https://github.com/pharo-project/pharo/pull/7434 7431-preparing-fluid-class-Part-1 #7433 https://github.com/pharo-project/pharo/pull/7433 Debugger ======= Debugger-should-show-Workspace-bindings #7408 A try to simplify how the workspace binding is found when debugging. Leads to many problems, will be reverted. https://github.com/pharo-project/pharo/pull/7408 7362-Package-Debugger-Filters-is-not-used-and-can-be-removed #7430 https://github.com/pharo-project/pharo/pull/7430 Added a closeAllDebugger method to trait TDebugger class, that users â¦ #7328 (just a first step, not yet solved) https://github.com/pharo-project/pharo/pull/7328 Exposing signalContext in Exception #7417 https://github.com/pharo-project/pharo/pull/7417 ReadOnly Literals ================= The compiler and the VM has support to make literals read-only. As the ability to change literals without the code reflecting it has lead to ugly bugs in the past, turning this on looks like a good idea: SourceFileBufferedReadWriteStreamTest-readOnlyLiteral #7418 https://github.com/pharo-project/pharo/pull/7418 betterName-isSharedLiteral #7432 https://github.com/pharo-project/pharo/pull/7432 Enable-ReadOnly-Literals #7393 https://github.com/pharo-project/pharo/pull/7393 Bug Fixes ========== Background failures log in CI #7337 https://github.com/pharo-project/pharo/pull/7337 5956-Wrong-format-of-DoubleWordArray #7404 Ongoing work. All code is merged, but now we need to still see that we can create classes like that with the bootrap https://github.com/pharo-project/pharo/pull/7404 Fix_for_PluggableSliderMorph #7415 https://github.com/pharo-project/pharo/pull/7415 7414-division-of-number-by-array-fails-with-doesNotUnderstand-isZero #7425 https://github.com/pharo-project/pharo/pull/7425 Cleaning integer division #7436 https://github.com/pharo-project/pharo/pull/7436 Comments ======== 7042-Better-comment-for-CompiledBlock-and-FullBlock https://github.com/pharo-project/pharo/pull/7447 Cleanups ======== 7367-pragmas-not-needed-textEditorShiftedMenu-fileListContentMenu #7426 https://github.com/pharo-project/pharo/pull/7426 Fixed #7420. Added transformation rules to some non-transforming deprecations that were identified as automatable in the Deprewriter paper #7427 https://github.com/pharo-project/pharo/pull/7427 7364-RBSelectorNode-has-unclassified-methods #7424 https://github.com/pharo-project/pharo/pull/7424 7416-Fileout-a-protocol-raises-a-DNU #7441 https://github.com/pharo-project/pharo/pull/7441 7365-DictionaryValueHold-removeKey-calls-a-non-existing-method #7407 https://github.com/pharo-project/pharo/pull/7407 For a complete list of all issues and PRs, see: https://github.com/pharo-project/pharo/pulse

2 1

[ANN] Pharo Consortium New Gold Member: InfOil
by Marcus Denker Oct. 11, 2020

Oct. 11, 2020

The Pharo Consortium is very happy to announce that InfOil has joined the Consortium as a Gold Member. InfOil is an Argentinian company focused on software development for the Oil and Gas industry with clients in Latin America, Cuba, and Canada. About - InfOil: http://www.infoil.com.ar - Pharo Consortium: http://consortium.pharo.org The goal of the Pharo Consortium is to allow companies and institutions to support the ongoing development and future of Pharo. Individuals can support Pharo via the Pharo Association: - http://association.pharo.org

3 2

Super nice parser improvements soon available
by StÃ©phane Ducasse Oct. 3, 2020

Oct. 3, 2020

> In the last week Iâve worked on doing several enhances to the parser > > https://github.com/pharo-project/pharo/pull/7411 <https://github.com/pharo-project/pharo/pull/7411> > > Besides several refactorings and cleanups, major changes include: > > - we are able to correctly detect unfinished statements (missing dots) > - we are able to correctly detect unreachable statements (like a statement after a return statement) > > And we still continue parsing. This makes that the faulty parser used for syntax highlighting and other much more precise, and several of my touches also fix some of the exceptions found while typing (that were due to wrong behaviours on the parser). > > Also I did a small iteration on top of the âsyntax feedbackâ so itâs less noisy. We can remove it at any time (thatâs just removing a configuration). But Iâd like more feedback before :) > > To see the improvements > > Pharo 8 > > > > Pharo9 previous to these changes > > > > Pharo9 with these changes > > > > > Now, Iâll not deny this is still perfectible, as everything, but we can do another iteration on top :) > > Guille > _______________________________________________ > Lse-consortium mailing list > Lse-consortium(a)lists.gforge.inria.fr > https://lists.gforge.inria.fr/mailman/listinfo/lse-consortium -------------------------------------------- StÃ©phane Ducasse http://stephane.ducasse.free.fr / http://www.pharo.org 03 59 35 87 52 Assistant: Aurore Dalle FAX 03 59 57 78 50 TEL 03 59 35 86 16 S. Ducasse - Inria 40, avenue Halley, Parc Scientifique de la Haute Borne, BÃ¢t.A, Park Plaza Villeneuve d'Ascq 59650 France

2 1

[ANN] Next Pharo Sprint: Sept 25
by Marcus Denker Sept. 22, 2020

Sept. 22, 2020

We will organize a Pharo sprint / Moose dojo Sept 25 (this Friday) Goals of this sprint: - Fix issues from tracker https://github.com/pharo-project/pharo/issues This is a Remote Sprint, it happens on Discord. http://pharo.org/contribute-events We have added a Board to coordinate the work: https://github.com/orgs/pharo-project/projects/9 A list of all Pharo Event of the year an be found here: https://association.pharo.org/events

1 0

Automatic build mails now go to another list
by Marcus Denker Sept. 21, 2020

Sept. 21, 2020

Hi, We changed the setup of the CI to send automatic mails now to another list âlog-ciâ. If you want to get these messages in the future directly by email, you have to subscribe to this new list via https://lists.pharo.org <https://lists.pharo.org/> Or you can check the archive in the case you need to: https://lists.pharo.org/empathy/list/log-ci.lists.pharo.org <https://lists.pharo.org/empathy/list/log-ci.lists.pharo.org> Marcus

1 1

Updating lists.pharo.org: New server, Mailman3 and more
by Marcus Denker Sept. 21, 2020

Sept. 21, 2020

Hi, We are updating the mailinglists (everything https://lists.pharo.org/ <https://lists.pharo.org/>) -> New server, thus: new IPâ¦ -> the server will run Mailman3 (we used Mailman2) -> There will be a better Archive I will do the change of the IP address today. The only thing that could happen is that mails send still via the old server will not be in the new archive, everything else should be transparent. I will send another mail when it is done. Marcus

5 10

[Pharo 9.0] Build #678: 7331-Fixing-comments-breaking-MD
by ci-pharo-ci-jenkins2＠inria.fr Sept. 20, 2020

Sept. 20, 2020

There is a new Pharo build available! The status of the build #678 was: SUCCESS. The Pull Request #7332 was integrated: "7331-Fixing-comments-breaking-MD" Pull request url: https://github.com/pharo-project/pharo/pull/7332 Issue Url: https://github.com/pharo-project/pharo/issues/7331 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 9.0] Build #677: Use the SDL renderer output size in the OSAthensRenderer for creating the Athens surface
by ci-pharo-ci-jenkins2＠inria.fr Sept. 18, 2020

Sept. 18, 2020

There is a new Pharo build available! The status of the build #677 was: SUCCESS. The Pull Request #7333 was integrated: "Use the SDL renderer output size in the OSAthensRenderer for creating the Athens surface" Pull request url: https://github.com/pharo-project/pharo/pull/7333 Issue Url: https://github.com/pharo-project/pharo/issues/bug Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 9.0] Build #676: cleanup-semanticNodeClass
by ci-pharo-ci-jenkins2＠inria.fr Sept. 18, 2020

Sept. 18, 2020

There is a new Pharo build available! The status of the build #676 was: FAILURE. The Pull Request #7327 was integrated: "cleanup-semanticNodeClass" Pull request url: https://github.com/pharo-project/pharo/pull/7327 Issue Url: https://github.com/pharo-project/pharo/issues/cleanup Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0