- Pharo-dev - lists.pharo.org

[Pharo-project] Some problems with Shout Parser
by Igor Stasenko May 2, 2009

May 2, 2009

Note, this error is very hard to reproduce. It happened only few times when i typing in an OB code pane and method source is considerably big. I suspect that this bug is triggered because i'm using a new scheduler, and uncovers a concurrency issue in SHParserST80>>styleInBackgroundProcess:. ---------------- Error: attempt to index non-existent element in an ordered collection 2 May 2009 1:39:33 pm VM: Win32 - a SmalltalkImage Image: Pharo0.1 [Latest update: #10292] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir F:\projects\pharo-freetype\Squeak-new-scheduling Trusted Dir F:\projects\pharo-freetype\Squeak-new-scheduling\sig Untrusted Dir G:\usr\sig\docs\My Squeak OrderedCollection(Object)>>error: Receiver: an OrderedCollection(a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange...etc... Arguments and temporary variables: aString: 'attempt to index non-existent element in an ordered collection' Receiver's instance variables: array: an Array(a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange a S...etc... firstIndex: 66 lastIndex: 77 OrderedCollection>>errorNoSuchElement Receiver: an OrderedCollection(a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange...etc... Arguments and temporary variables: Receiver's instance variables: array: an Array(a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange a S...etc... firstIndex: 66 lastIndex: 77 OrderedCollection>>at: Receiver: an OrderedCollection(a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange...etc... Arguments and temporary variables: anInteger: 130 Receiver's instance variables: array: an Array(a SHRange a SHRange a SHRange a SHRange a SHRange a SHRange a S...etc... firstIndex: 66 lastIndex: 77 [] in [] in SHParserST80>>parseKeyword Receiver: a SHParserST80 Arguments and temporary variables: <<error during printing> Receiver's instance variables: classOrMetaClass: AdvancedDelay source: 'performCommonChecksAt: nowTick "Perform various checks, each time we...etc... workspace: nil arguments: a Dictionary(0->an OrderedCollection('nowTick') ) sourcePosition: 452 currentToken: 'ScheduledDelay' currentTokenFirst: $S temporaries: a Dictionary(0->an OrderedCollection('nowTick' 'nextTick') ) instanceVariables: #('delayDuration' 'resumptionTime' 'waitingProcess' 'beingWa...etc... errorBlock: [closure] in SHParserST80>>parse: currentTokenSourcePosition: 438 blockDepth: 0 bracketDepth: 0 ranges: an OrderedCollection(a SHRange a SHRange a SHRange a SHRange a SHRange ...etc... environment: Smalltalk --- The full stack --- OrderedCollection(Object)>>error: OrderedCollection>>errorNoSuchElement OrderedCollection>>at: [] in [] in SHParserST80>>parseKeyword - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Array(SequenceableCollection)>>do: [] in SHParserST80>>parseKeyword MethodContext(ContextPart)>>unwindTo: TerminateProcess>>signal TerminateProcess class>>signalForProcess:abandonedSemaphore: SystemDictionary(Set)>>do: SystemDictionary(Dictionary)>>associationsDo: SystemDictionary(Dictionary)>>keysDo: SystemDictionary(Dictionary)>>hasBindingThatBeginsWith: [] in SHParserST80>>resolvePartial: OrderedCollection>>do: SHParserST80>>resolvePartial: SHParserST80>>resolve: SHParserST80>>parseTerm [] in SHParserST80>>parseKeyword BlockClosure>>ensure: SHParserST80>>parseKeyword SHParserST80>>parseCascade SHParserST80>>parseExpression SHParserST80>>parseStatement SHParserST80>>parseStatementList [] in SHParserST80>>parse: BlockClosure>>ensure: SHParserST80>>parse: SHParserST80>>parse SHParserST80>>rangesIn:classOrMetaClass:workspace:environment: SHTextStylerST80>>rangesIn:setWorkspace: SHTextStylerST80>>privateStyle: [] in [] in SHTextStylerST80(SHTextStyler)>>styleInBackgroundProcess: [] in BlockClosure>>newProcess -- Best regards, Igor Stasenko AKA sig.

1 0

[Pharo-project] I will integrate and push some fixes before noon
by StÃ©phane Ducasse May 2, 2009

May 2, 2009

- not working sensor fixes - http://code.google.com/p/pharo/issues/detail?id=789 (PseudoContext initialize) -http://code.google.com/p/pharo/issues/detail?id=788 (MC pool sorting) - http://code.google.com/p/pharo/issues/detail?id=788 (compact classes - http://code.google.com/p/pharo/issues/detail?id=783 Issue 783: Better ContextPart>>errorReportOn: - http://code.google.com/p/pharo/issues/detail?id=774 network rollover - http://code.google.com/p/pharo/issues/detail?id=784 TestCollections - http://code.google.com/p/pharo/issues/detail?id=769 Fix for (StringTest new testUnescapePercentsWithTextEncoding) - http://code.google.com/p/pharo/issues/detail?id=758 Little font rendering speedup Stef

1 0

[Pharo-project] Fwd: Closure update from eliot
by StÃ©phane Ducasse May 1, 2009

May 1, 2009

Begin forwarded message: > From: John M McIntosh <johnmci(a)smalltalkconsulting.com> > Date: May 1, 2009 7:41:58 PM CEDT > To: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Cc: Eliot Miranda <eliot.miranda(a)gmail.com> > Subject: Re: [Pharo-project] Closure update from eliot > Reply-To: johnmci(a)smalltalkconsulting.com > > Ok to answer the question, when we need to find the class of an > object, we invoke either fetchClassOf: or fetchClassOfNonInt: > now if the class is compact as per the oops header bits we use more > bits in the oops header to pull the class oops from the compact array > using the compact class index value. Otherwise the oops of the class > is in the header, which requires more storage for the oops header > > When we make the class as compact then it's stuff into the compact > array and allInstances of the old class converted. > > > Lastly, well I'm wondering about the impact on image segments. > > The comment in becomeCompact: says... > > "Here are the restrictions on compact classes in order for export > segments to work: A compact class index may not be reused. If a > class was compact in a release of Squeak, no other class may use > that index. The class might not be compact later, and there should > be nil in its place in the array." > > But I wonder if > remapCompactClasses:refStrm: > > ensures accidents don't happen, however let's see if Eliot has cross- > checked this issue, no doubt the the comment is dated... > > > Also > PseudoContext(class)>>initialize > seems rather obsolete then? > > > On 1-May-09, at 3:10 AM, StÃ©phane Ducasse wrote: > >> I have a stupid question about this one. >> Does it mean that we should fix that at the level of the vm since >> compactClassesArray is a primitive >> and recreateSpecialObjectsArray used it. >> >> stef >> >> Begin forwarded message: >> >>> From: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> >>> Date: May 1, 2009 11:55:45 AM CEDT >>> To: Pharo Development <Pharo-project(a)lists.gforge.inria.fr> >>> Subject: [Pharo-project] Closure update from eliot >>> Reply-To: Pharo-project(a)lists.gforge.inria.fr >>> >>> > > -- > = > = > = > = > = > ====================================================================== > John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: > squeaker68882 > Corporate Smalltalk Consulting Ltd. http:// > www.smalltalkconsulting.com > = > = > = > = > = > ====================================================================== > > > > >

1 1

[Pharo-project] Fwd: latest Pharo image?
by StÃ©phane Ducasse May 1, 2009

May 1, 2009

Begin forwarded message: > From: Eliot Miranda <eliot.miranda(a)gmail.com> > Date: May 1, 2009 1:50:55 AM CEDT > To: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Cc: nicolas cellier <ncellier(a)ifrance.com>, Lukas Renggli <renggli(a)iam.unibe.ch > > > Subject: Re: latest Pharo image? > > the attached sorts class variables and shared pools in Monticello > class defs and results in fewer conflicts being reported. > > On Thu, Apr 30, 2009 at 12:42 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > > wrote: > You can find it at > > http://gforge.inria.fr/frs/?group_id=1299 > then you should take the pharo and not pharo-dev > then you should do update (in system -> software update) > > Stef > > > On Apr 30, 2009, at 12:21 AM, Eliot Miranda wrote: > > This reminds me to ask you for a location from which to download the > latest Pharo image ith closures so I can check the compiler changes > I've made against the image and send you them. This will be easier > and less error-prone than my e.g. extracting the packages we use > here and you having to work out the changes. > > > mmm latest pharo image > > [1 == 0] forkAt: 999. > > oops.. > > >

1 1

[Pharo-project] Fwd: Closure update from eliot
by StÃ©phane Ducasse May 1, 2009

May 1, 2009

Begin forwarded message: > From: Eliot Miranda <eliot.miranda(a)gmail.com> > Date: May 1, 2009 7:31:05 PM CEDT > To: johnmci(a)smalltalkconsulting.com > Cc: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Subject: Re: [Pharo-project] Closure update from eliot > > I just used this in an updated Pharo0.1Core-10281cl.image > > PseudoContext becomeUncompact. > LargeNegativeInteger becomeCompact. > Smalltalk compactClassesArray at: 12 put: nil. "Stomp on the > obsolete Translated whatsit" > BlockClosure becomeCompact > > On Fri, May 1, 2009 at 9:29 AM, John M McIntosh <johnmci(a)smalltalkconsulting.com > > wrote: > Also see > http://code.google.com/p/pharo/issues/detail?id=467 > > > Eliot wants > #(CompiledMethod MethodProperties Array LargeNegativeInteger > LargePositiveInteger Float MethodDictionary Association Point > Rectangle ByteString BlockClosure BlockContext MethodContext nil > Bitmap nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil) > > so do > > (Smalltalk compactClassesArray select: [:e | e notNil and: [e > isObsolete]]) > do: [:i | i becomeUncompact]. > PseudoContext becomeUncompact. > Smalltalk garbageCollect. > LargeNegativeInteger becomeCompact. > BlockClosure becomeCompact. > > gives then > > Smalltalk compactClassesArray inspect > > {CompiledMethod . MethodProperties . Array . LargeNegativeInteger . > LargePositiveInteger . Float . MethodDictionary . Association . > Point . Rectangle . ByteString . BlockClosure . BlockContext . > MethodContext . nil . Bitmap . nil . nil . nil . nil . nil . nil . > nil . nil . nil . nil . nil . nil . nil . nil . nil} > > Which my squinting eyeballs this morning seem to say it's the same... > > A post check is > > Smalltalk compactClassesArray doWithIndex: > [:c :i | c == nil ifFalse: > [c indexIfCompact = i ifFalse: [self halt]]] > > > > > On 1-May-09, at 3:10 AM, StÃ©phane Ducasse wrote: > > Smalltalk compactClassesArray > > -- > = > = > = > = > = > ====================================================================== > John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: > squeaker68882 > Corporate Smalltalk Consulting Ltd. http:// > www.smalltalkconsulting.com > = > = > = > = > = > ====================================================================== > > > > >

1 1

[Pharo-project] Fwd: Closure update from eliot
by StÃ©phane Ducasse May 1, 2009

May 1, 2009

Begin forwarded message: > From: John M McIntosh <johnmci(a)smalltalkconsulting.com> > Date: May 1, 2009 7:43:44 PM CEDT > To: Eliot Miranda <eliot.miranda(a)gmail.com> > Cc: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Subject: Re: [Pharo-project] Closure update from eliot > Reply-To: johnmci(a)smalltalkconsulting.com > > Boo hiss, well that would work, but '12' is a magic number in this > case the iteration over the collection was to *avoid* one-off > useages of a magic number > Well humpft. > > Of course one off usages of a magic number is allowed... Since it's > less typing.. > > > On 1-May-09, at 10:31 AM, Eliot Miranda wrote: > >> I just used this in an updated Pharo0.1Core-10281cl.image >> >> PseudoContext becomeUncompact. >> LargeNegativeInteger becomeCompact. >> Smalltalk compactClassesArray at: 12 put: nil. "Stomp on the >> obsolete Translated whatsit" >> BlockClosure becomeCompact > > -- > = > = > = > = > = > ====================================================================== > John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: > squeaker68882 > Corporate Smalltalk Consulting Ltd. http:// > www.smalltalkconsulting.com > = > = > = > = > = > ====================================================================== > > > >

1 0

[Pharo-project] Fwd: Closure update from eliot
by StÃ©phane Ducasse May 1, 2009

May 1, 2009

Begin forwarded message: > From: John M McIntosh <johnmci(a)smalltalkconsulting.com> > Date: May 1, 2009 6:29:33 PM CEDT > To: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Cc: Eliot Miranda <eliot.miranda(a)gmail.com> > Subject: Re: [Pharo-project] Closure update from eliot > Reply-To: johnmci(a)smalltalkconsulting.com > > Also see > http://code.google.com/p/pharo/issues/detail?id=467 > > > Eliot wants > #(CompiledMethod MethodProperties Array LargeNegativeInteger > LargePositiveInteger Float MethodDictionary Association Point > Rectangle ByteString BlockClosure BlockContext MethodContext nil > Bitmap nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil) > > so do > > (Smalltalk compactClassesArray select: [:e | e notNil and: [e > isObsolete]]) > do: [:i | i becomeUncompact]. > PseudoContext becomeUncompact. > Smalltalk garbageCollect. > LargeNegativeInteger becomeCompact. > BlockClosure becomeCompact. > > gives then > > Smalltalk compactClassesArray inspect > > {CompiledMethod . MethodProperties . Array . LargeNegativeInteger . > LargePositiveInteger . Float . MethodDictionary . Association . > Point . Rectangle . ByteString . BlockClosure . BlockContext . > MethodContext . nil . Bitmap . nil . nil . nil . nil . nil . nil . > nil . nil . nil . nil . nil . nil . nil . nil . nil} > > Which my squinting eyeballs this morning seem to say it's the same... > > A post check is > > Smalltalk compactClassesArray doWithIndex: > [:c :i | c == nil ifFalse: > [c indexIfCompact = i ifFalse: [self halt]]] > > > > > On 1-May-09, at 3:10 AM, StÃ©phane Ducasse wrote: > >>>> Smalltalk compactClassesArray > > -- > = > = > = > = > = > ====================================================================== > John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: > squeaker68882 > Corporate Smalltalk Consulting Ltd. http:// > www.smalltalkconsulting.com > = > = > = > = > = > ====================================================================== > > > > >

1 0

[Pharo-project] run all tests from superClass
by Cyrille Delaunay May 1, 2009

May 1, 2009

A change have been saved in 'PharoInBox' for class TestCase in package SUnit so that suite are now built from allSelectors. This makes sense when you have testcase classes which inherits from each other and have parametrized (hook-based) setup.

7 13

[Pharo-project] fixing linux loadOBAlpha problem by strace-ing an image (was Monticello/ftp stopped working for me)
by Nicolas Cellier May 1, 2009

May 1, 2009

After ScriptLoader loadOBAlpha problems, I'm now playing a bit with strace. very instructive. strace build/squeak *.image `pwd`/loadOBAlpha.st > tmp.trace 2>&1 Notice a (SourceFiles at: 2) truncate: SmalltalkImage current lastQuitLogPosition. This is because repeated ScriptLoader loadOBAlpha are quickly spoiling the change log. Tracing is really slow, especially with these unbuffered writes write(6, "^", 1) = 1 write(6, "s", 1) = 1 write(6, "e", 1) = 1 write(6, "l", 1) = 1 write(6, "f", 1) = 1 I remember Eliot noticed this easy potential speed-up already. I noticed a bunch of try...catch style of open file at startup. grep ENOENT ../pharo0.1-10268dev09.04.1/tmp.trace | wc -l 4012 Most are plugin/library search and Freetype related. But a few search concern icons and wonderland... Some room for more etoys clean-up here? On my linux box, I can now confirm the socket problem encountered by loadOBAlpha is really a (Too many open files) problem. Some @!*^# code is trying to open more than 1018 change log files which is a bit too much. Some file closing happens from time to time but very sparsely. This happens while loading Installer wiresong project: 'ob'; install: 'OB-Refactory'. Consequently, the following instruction fails. Installer lukas project: 'ob'; install: 'OB-Regex'; You can find tmp.trace at http://ncellier.ifrance.com/Squeak/tmp.trace.gz 26MB gzipped. ------------------------------------------------------------------------------------------------------- Now it's easier to debug the change log opener in image. But it's not obvious whether we can reproduce in debugger because of UI, debugger, GC interactions... So we gonna use the MessageTally/Notification tricks: build/squeak *.image `pwd`/TraceOpenFile.st & Tally results are copied in OpenFileTally.txt. Highly suspect is #readOnlyCopy... RemoteString is guilty for not closing the file and relying on some finalization actions... And OBDynamicProtocols is abusing of this stuff... So fixing RemoteString by gently closing the file does fix the linux problem... build/squeak *.image `pwd`/loadOBAlpha.st & Now this is a good workaround, but what change introduced the problem ? there are two solutions: - either recent versions of OB are creating the problem - or recent changes in Polling UI/or Process changed finalization order This should be tested in a 3.10.2 image

2 2

[Pharo-project] Fwd: Improving a Process termination procedure
by Igor Stasenko May 1, 2009

May 1, 2009

FYI ---------- Forwarded message ---------- From: Igor Stasenko <siguctua(a)gmail.com> Date: 2009/5/1 Subject: Re: Improving a Process termination procedure To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org> Another improvement would be to marry the process termination with exception handling, and nicely signal ProcessTerminatedException. This offers many practical benefits, since then we could write: [ ... ] on: ProcessTerminatedException do: [:ex | Â "oh man we're been terminated" ]. But i'm not expert in exception handling. Can someone give me a sample, how to signal such exception in potential #terminateFromContext: method? 2009/5/1 Igor Stasenko <siguctua(a)gmail.com>: > There are a potential of having incorrect behavior , when terminating > a preempted or waiting process: > > with introduction of ProcessLocalVariable, it is essential that > context unwinding procedure should be performed only > for currently active process. > > Here the proposal how to ensure this: > > if terminating process is not active process we should do the following: > > suspendedContext := proc suspendedContext. > currentProces := Processor activeProcess. > proc suspendedContext: Â [ Â Processor activeProcess > terminateFromContext: suspendedContext. Processor switchToProcess: > currentProcess ] asContext. > Processor switchToProcess: proc. > > here #switchToProcess: is explicit switch (bypassing scheduling logic). > > If we don't care about immediate termination of process and getting > back to process who initiated termination as soon as possible, then > simply do: > process terminateSoon. > > which can be implemented as: > > Process>>terminateSoon > | termContext | > termContext := suspendedContext. > suspendedContext := [ Â self terminateFromContext: termContext. self > suspend ] asContext. > Processor yield. > > > > -- > Best regards, > Igor Stasenko AKA sig. > -- Best regards, Igor Stasenko AKA sig. -- Best regards, Igor Stasenko AKA sig.

1 0