- Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3964 in pharo: Enabling double click on PluggableListMorphOfMany
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: FixProposed Owner: Benjamin...(a)gmail.com Labels: Nautilus New issue 3964 by Benjamin...(a)gmail.com: Enabling double click on PluggableListMorphOfMany http://code.google.com/p/pharo/issues/detail?id=3964 Just copy and paste 2 lines ... Attachments: EnableDoubleClickOnPluggableListMorphOfMany.1.cs 1.9 KB

1 1

[Pharo-project] [update 1.3] #13133
by Marcus Denker April 5, 2011

April 5, 2011

13133 ----- Issue 3955: Better implementation of the MorphTreeMorph auto select Issue 3956: Better implementation of the PluggableListMorphs auto select Issue 3964: Enabling double click on PluggableListMorphOfMany Issue 3105: DeepCopier warnIverNotCopiedIn:sel: dependent on ToolSet -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

1 0

[Pharo-project] Issue 3956 in pharo: Better implementation of the PluggableListMorphs auto select
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: FixProposed Owner: Benjamin...(a)gmail.com Labels: Nautilus New issue 3956 by Benjamin...(a)gmail.com: Better implementation of the PluggableListMorphs auto select http://code.google.com/p/pharo/issues/detail?id=3956 - Refactor - Multi selection fixed when using arrows - When auto search is done, result is printed using secondSelectionColor Attachments: BetterColorForListMorphsSearch.1.cs 9.7 KB

1 1

[Pharo-project] Issue 3955 in pharo: Better implementation of the MorphTreeMorph auto select
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: FixProposed Owner: Benjamin...(a)gmail.com CC: aplan...(a)gmail.com Labels: Nautilus Milestone-1.3 New issue 3955 by Benjamin...(a)gmail.com: Better implementation of the MorphTreeMorph auto select http://code.google.com/p/pharo/issues/detail?id=3955 Now use secondarySelectionColor defined by the current theme and the display is done like the selection Attachments: BetterColorForMorphTreeMorphSearch.3.cs 9.5 KB

1 1

[Pharo-project] Issue 3950 in pharo: SequenceableCollection>>#findBinary and friends (wrong exceptionBlock, delegation)
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: New Owner: ---- New issue 3950 by sven.van...(a)gmail.com: SequenceableCollection>>#findBinary and friends (wrong exceptionBlock, delegation) http://code.google.com/p/pharo/issues/detail?id=3950 Pharo 1.2 #12333 There is something wrong with how some of the exceptionBlocks of SequenceableCollection>>#findBinary and friends work. Some of them expect no arguments (as most #ifNone: exception blocks do), while others expect 2 arguments here (a low & a high bounds). Delegation among them is also strange as there seem to be two implementations. Some refactoring could be done. Unit tests are also missing. Some users are also vulnerable. As an example, try these: #(1 3 5 7 11 15 23) findBinary: [ :arg | 11 - arg ] #(1 3 5 7 11 15 23) findBinary: [ :arg | 8 - arg ] #(1 3 5 7 11 15 23) findBinary: [ :arg | 11 - arg ] ifNone: [ nil ] #(1 3 5 7 11 15 23) findBinary: [ :arg | 8 - arg ] ifNone: [ nil ] I could propose a fix, but I don't understand the reason behind the strange exception block: how could passing the low/high bounds be useful here ? Sven

1 3

[Pharo-project] Issue 3345 in pharo: findBinary: from Cuis as integrated in Squeak
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 Difficulty-Easy New issue 3345 by stephane.ducasse: findBinary: from Cuis as integrated in Squeak http://code.google.com/p/pharo/issues/detail?id=3345 It would be nice to have a look at that and write some tests Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.408.mcz ==================== Summary ==================== Name: Collections-ul.408 Author: ul Time: 17 November 2010, 12:25:59.364 pm UUID: 1520a654-9c34-734d-ae16-a600d1a2b948 Ancestors: Collections-ul.407 - findBinary* enhancements from Cuis. =============== Diff against Collections-ul.407 =============== Item was changed: ----- Method: SequenceableCollection>>findBinary: (in category 'enumerating') ----- findBinary: aBlock "Search for an element in the receiver using binary search. The argument aBlock is a one-element block returning 0 - if the element is the one searched for <0 - if the search should continue in the first half >0 - if the search should continue in the second half If no matching element is found, raise an error. Examples: + #(1 3 5 7 11 15 23) findBinary: [ :arg | 11 - arg ] - #(1 3 5 7 11 15 23) findBinary:[:arg| 11 - arg] " + ^self findBinary: aBlock do: [ :found | found ] ifNone: [ self errorNotFound: aBlock ]! - ^self findBinary: aBlock ifNone: [self errorNotFound: aBlock]! Item was added: + ----- Method: SequenceableCollection>>findBinary:do:ifNone: (in category 'enumerating') ----- + findBinary: aBlock do: actionBlock ifNone: exceptionBlock + "Search for an element in the receiver using binary search. + The argument aBlock is a one-element block returning + 0 - if the element is the one searched for + <0 - if the search should continue in the first half + >0 - if the search should continue in the second half + If found, evaluate actionBlock with the found element as argument + If no matching element is found, evaluate exceptionBlock, + with the 'bounding' elements (or nil) as optional arguments. + Examples: + #(1 3 5 7 11 15 23) + findBinary: [ :arg | 11 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ', {a. b} printString) ] + #(1 3 5 7 11 15 23) + findBinary: [ :arg | 12 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ', {a. b} printString) ] + #(1 3 5 7 11 15 23) + findBinary: [ :arg | 0.5 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ', {a. b} printString) ] + #(1 3 5 7 11 15 23) + findBinary: [ :arg | 25 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ',{a. b} printString) ] + " + ^self + findBinaryIndex: aBlock + do: [ :foundIndex | actionBlock value: (self at: foundIndex) ] + ifNone: [ :prevIndex :nextIndex | + exceptionBlock + cull: (prevIndex > 0 ifTrue: [ self at: prevIndex ]) + cull: (nextIndex <= self size ifTrue: [ self at: nextIndex ]) ]! Item was changed: ----- Method: SequenceableCollection>>findBinary:ifNone: (in category 'enumerating') ----- findBinary: aBlock ifNone: exceptionBlock "Search for an element in the receiver using binary search. The argument aBlock is a one-element block returning 0 - if the element is the one searched for <0 - if the search should continue in the first half >0 - if the search should continue in the second half + If no matching element is found, evaluate exceptionBlock, + with the 'bounding' elements (or nil) as optional arguments." + + ^self findBinary: aBlock do: [ :found | found ] ifNone: exceptionBlock! - If no matching element is found, evaluate exceptionBlock." - | index low high test item | - low := 1. - high := self size. - [index := high + low // 2. - low > high] whileFalse:[ - test := aBlock value: (item := self at: index). - test = 0 - ifTrue:[^item] - ifFalse:[test > 0 - ifTrue: [low := index + 1] - ifFalse: [high := index - 1]]]. - ^exceptionBlock value! Item was changed: ----- Method: SequenceableCollection>>findBinaryIndex: (in category 'enumerating') ----- findBinaryIndex: aBlock "Search for an element in the receiver using binary search. The argument aBlock is a one-element block returning 0 - if the element is the one searched for <0 - if the search should continue in the first half >0 - if the search should continue in the second half If no matching element is found, raise an error. Examples: + #(1 3 5 7 11 15 23) findBinaryIndex: [ :arg | 11 - arg ] - #(1 3 5 7 11 15 23) findBinaryIndex:[:arg| 11 - arg] " + ^self findBinaryIndex: aBlock do: [ :found | found ] ifNone: [ self errorNotFound: aBlock]! - ^self findBinaryIndex: aBlock ifNone: [self errorNotFound: aBlock]! Item was added: + ----- Method: SequenceableCollection>>findBinaryIndex:do:ifNone: (in category 'enumerating') ----- + findBinaryIndex: aBlock do: actionBlock ifNone: exceptionBlock + "Search for an element in the receiver using binary search. + The argument aBlock is a one-element block returning + 0 - if the element is the one searched for + <0 - if the search should continue in the first half + >0 - if the search should continue in the second half + If found, evaluate actionBlock with the index as argument + If no matching element is found, evaluate exceptionBlock, + with the indexes of the 'bounding' elements as optional + arguments. Warning: Might give invalid indexes, see + examples below. + Examples: + #(1 3 5 7 11 15 23) + findBinaryIndex: [ :arg | 11 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ', {a. b} printString)] + #(1 3 5 7 11 15 23) + findBinaryIndex: [ :arg | 12 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ', {a. b} printString) ] + #(1 3 5 7 11 15 23) d + findBinaryIndex: [ :arg | 0.5 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ', {a. b} printString) ] + #(1 3 5 7 11 15 23) + findBinaryIndex: [ :arg | 25 - arg ] + do: [ :found | found ] + ifNone: [ :a :b | ('between: ',{a. b} printString) ] + " + | index low high | + low := 1. + high := self size. + [ + index := high + low // 2. + low > high ] whileFalse: [ + | test | + test := aBlock value: (self at: index). + test = 0 + ifTrue: [ ^actionBlock value: index ] + ifFalse: [ test > 0 + ifTrue: [ low := index + 1 ] + ifFalse: [ high := index - 1 ] ] ]. + ^exceptionBlock cull: high cull: low! Item was changed: ----- Method: SequenceableCollection>>findBinaryIndex:ifNone: (in category 'enumerating') ----- findBinaryIndex: aBlock ifNone: exceptionBlock "Search for an element in the receiver using binary search. The argument aBlock is a one-element block returning 0 - if the element is the one searched for <0 - if the search should continue in the first half >0 - if the search should continue in the second half + If no matching element is found, evaluate exceptionBlock, + with the indexes of the 'bounding' elements as optional + arguments. Warning: Might give invalid indexes." + + ^self findBinaryIndex: aBlock do: [ :found | found ] ifNone: exceptionBlock! - If no matching element is found, evaluate exceptionBlock." - | index low high test | - low := 1. - high := self size. - [index := high + low // 2. - low > high] whileFalse:[ - test := aBlock value: (self at: index). - test = 0 - ifTrue:[^index] - ifFalse:[test > 0 - ifTrue: [low := index + 1] - ifFalse: [high := index - 1]]]. - ^exceptionBlock value!

1 1

[Pharo-project] Issue 3942 in pharo: Transcript missing compatibility method ensureCr
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: Accepted Owner: marcus.d...(a)gmail.com Labels: Milestone-1.3 New issue 3942 by marcus.d...(a)gmail.com: Transcript missing compatibility method ensureCr http://code.google.com/p/pharo/issues/detail?id=3942 Transcript missing compatibility method ensureCr

1 2

[Pharo-project] Issue 3961 in pharo: Fix order of worlmenu
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: FixToInclude Owner: marcus.d...(a)gmail.com Labels: Milestone-1.3 New issue 3961 by marcus.d...(a)gmail.com: Fix order of worlmenu http://code.google.com/p/pharo/issues/detail?id=3961 ... System was wrong Attachments: fixMenu.1.cs 3.1 KB

1 1

[Pharo-project] Issue 3953 in pharo: add #ensureCr to new transcript
by pharo＠googlecode.com April 5, 2011

April 5, 2011

Status: Accepted Owner: siguc...(a)gmail.com New issue 3953 by siguc...(a)gmail.com: add #ensureCr to new transcript http://code.google.com/p/pharo/issues/detail?id=3953 in order to make VMMaker happy... Attachments: new-transcript-fixes.1.cs 435 bytes

1 2

April 5, 2011

13132 ----- - Issue 3953: add #ensureCr to new transcript - fix world menu

1 0