- Pharo-dev - lists.pharo.org

[Pharo-project] Bug in FileSystem
by Mariano Martinez Peck Jan. 10, 2012

Jan. 10, 2012

FSReadStream >> next: count | result | result := ByteArray new: count. handle at: position read: result startingAt: 1 count: count. position := position + 1. ^ result shouldn't be FSReadStream >> next: count | result | result := ByteArray new: count. handle at: position read: result startingAt: 1 count: count. position := position + count. ^ result At least with that (among some extensions) Fuel tests pass with FS :) Cheers -- Mariano http://marianopeck.wordpress.com

4 4

[Pharo-project] Bug in #pointsTo: ?
by Mariano Martinez Peck Jan. 9, 2012

Jan. 9, 2012

Hi guys. Levente recommended us to integrate the new version of #pointsTo:, and I did it. But not I think I found a bug. The method is: pointsTo: anObject "Answers true if I hold a reference to anObject, or false otherwise. Or stated another way: Answers true if the garbage collector would fail to collect anObject because I hold a reference to it, or false otherwise" ^ (self instVarsInclude: anObject) or: [self class == anObject] The problem is that if the receiver is an instance of a compact class, this method answers true to: 'aaa' pointsTo: ByteString and I think that's incorrect. Moreoever, you can read the comment of the method "Or stated another way: Answers true if the garbage collector would fail to collect anObject because I hold a reference to it, or false otherwise" That's not true for compact classes. With this change: pointsTo: anObject "Answers true if I hold a reference to anObject, or false otherwise. Or stated another way: Answers true if the garbage collector would fail to collect anObject because I hold a reference to it, or false otherwise" ^ (self instVarsInclude: anObject) or: [(self class indexIfCompact = 0) and: [self class == anObject] ] it works fine. Do you agree with the change? cheers -- Mariano http://marianopeck.wordpress.com

6 32

[Pharo-project] Small improvement for WriteStream >> nextPutAll:
by Mariano Martinez Peck Jan. 9, 2012

Jan. 9, 2012

Hi guys. Some time ago Henry spot to us a small improvement for WriteStream >> nextPutAll: that we are using in Fuel, but I think it can be general. Henry comment was exactly: *Also: For variableBytes classes, if you rewrite: WriteStream nextPutAll: aCollection | newEnd | collection class instSpec == aCollection class instSpec ifFalse: [^ super nextPutAll: aCollection ]. newEnd := position + aCollection size. newEnd > writeLimit ifTrue: [self growTo: newEnd + 10]. collection replaceFrom: position+1 to: newEnd with: aCollectionstartingAt: 1. position := newEnd. ^ aCollection You can now pass all variableByte classes (Like ByteString) directly to a stream with a ByteArray collection, and the replaceFrom:to:with:* *startingAt: primitive will work correctly, just like the file primitive does This means you don't need special Serializers for these either, using f.ex. clunky nextStringPutAll: methods with manual asByteArray conversions.* So...if you agree, I can commit the patch. Let me know. -- Mariano http://marianopeck.wordpress.com

4 4

[Pharo-project] [update 1.4] #14283
by StÃ©phane Ducasse Jan. 9, 2012

Jan. 9, 2012

14283 ----- - Issue 2560: Convenient methods from Grease for Strings. Part Five. http://code.google.com/p/pharo/issues/detail?id=2560 Now no excuse anymore: webpage CV to look smart and project proposalsâ¦ :(

1 0

[Pharo-project] [update 1.4] #14282
by StÃ©phane Ducasse Jan. 9, 2012

Jan. 9, 2012

14282 ----- - Issue 2560: Convenient methods from Grease for Strings. Part 4. http://code.google.com/p/pharo/issues/detail?id=2560 - Issue 5161: Small fixes to FSReadStream http://code.google.com/p/pharo/issues/detail?id=5161 - Issue 5162: Little fix about Tabs http://code.google.com/p/pharo/issues/detail?id=5162 - Issue 3692: Default line-end convention fix. Thanks Javier pinas, Igor and henrik. http://code.google.com/p/pharo/issues/detail?id=3692. Stef

2 2

[Pharo-project] [update 1.4] #14281
by stephane ducasse Jan. 9, 2012

Jan. 9, 2012

14281 ----- - Issue 2560: Convenient methods from Grease for Strings. Thanks Sven van Caekenberghe. Part Two. http://code.google.com/p/pharo/issues/detail?id=2560

1 0

Re: [Pharo-project] Bug in FileSystem
by Henrik Sperre Johansen Jan. 9, 2012

Jan. 9, 2012

On 07.01.2012 14:05, Henrik Sperre Johansen wrote: > On 07.01.2012 13:20, StÃ©phane Ducasse wrote: >> sounds like :) >> >> Stef >> >> On Jan 7, 2012, at 1:10 PM, Mariano Martinez Peck wrote: >> >>> FSReadStream>> next: count >>> | result | >>> result := ByteArray new: count. >>> handle at: position read: result startingAt: 1 count: count. >>> position := position + 1. >>> ^ result >>> >>> >>> shouldn't be >>> >>> FSReadStream>> next: count >>> | result | >>> result := ByteArray new: count. >>> handle at: position read: result startingAt: 1 count: count. >>> position := position + count. >>> ^ result >>> >>> At least with that (among some extensions) Fuel tests pass with FS :) >>> >>> Cheers >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com >>> >> > Still wrong though, I think... > It doesn't handle the case where you try to read past end of stream. > > next: count > ^self nextInto: (ByteArray new: count) > > would probably be better. > > Cheers, > Henry > > As for the API: 1) There's no next: into: (which returns the amount read). It's really the only way to do buffers without garbage allocations. 2) FSHandle >>at: offset read: buffer startingAt: start count: count is a weirdly named selector for what it does imho... Doesn't #at: offset read: count into: buffer startingAt: start make more sense? Cheers, Henry

5 6

Jan. 9, 2012

14280 ----- - Issue 5149: add line in comment of VirtualMachine class>>parameterAt:. ThanksLuc Fabresse and Mariano Martinez-Peck. http://code.google.com/p/pharo/issues/detail?id=5149 - Issue 5132: CommentReference SourcedMethodReference MethodReference are now deprecated http://code.google.com/p/pharo/issues/detail?id=5132 - Issue 2560: Convenient methods from Grease for Strings. Thanks Sven van Caekenberghe. Part one. http://code.google.com/p/pharo/issues/detail?id=2560 Stef

1 0

[Pharo-project] How can I get account on Jenkins?
by Dimitry Golubovsky Jan. 9, 2012

Jan. 9, 2012

Hi, How can I get an account on Jenkins so I could set up build jobs for CogDroid? Such way, everybody interested could easily get access to the latest builds. Also, people who wish to experiment with derived versions (built on top of the core VM Java+native libraries) would be able to do it without messing with building the VM itself, just referencing the proper .jar and .so files. Thanks. -- Dimitry Golubovsky Anywhere on the Web

2 1

Re: [Pharo-project] How can I get account on Jenkins?
by Marcus Denker Jan. 9, 2012

Jan. 9, 2012

On Jan 9, 2012, at 3:41 AM, Dimitry Golubovsky wrote: > Hi, > > How can I get an account on Jenkins so I could set up build jobs for > CogDroid? Yes, let's see how we set this up. (we can do this off-list) > Such way, everybody interested could easily get access to > the latest builds. Also, people who wish to experiment with derived > versions (built on top of the core VM Java+native libraries) would be > able to do it without messing with building the VM itself, just > referencing the proper .jar and .so files. > > Thanks. > > -- > Dimitry Golubovsky > > Anywhere on the Web > -- Marcus Denker -- http://marcusdenker.de

1 0