- Pharo-dev - lists.pharo.org

Monkey Validation
by Camillo Bruni May 16, 2013

May 16, 2013

I spent some time yesterday evening with ben to compile a set of nice validation rules for the monkey, this is what we came up with ;) : CIRunTestsRule & "Only after the tests succeeded validate anything else" ( "Hard rules that lead to immediate WorkNeeded state:" RBUnclassifiedMethodsRule harden, RBUndeclaredReferenceRule harden, RBNoClassCommentRule harden, RBDefinesEqualNotHashRule harden, RBEquivalentSuperclassMethodsRule harden, RBJustSendsSuperRule harden, RBSubclassResponsibilityNotDefinedRule harden, RBTempVarOverridesInstVarRule harden, RBUndeclaredReferenceRule harden, RBVariableNotDefinedRule harden, RBEqualNotUsedRule harden, RBOnlyReadOrWrittenTemporaryRule harden, RBPrecedenceRule harden, RBSendsDeprecatedMethodToGlobalRule harden, RBSizeCheckRule harden, RBUnconditionalRecursionRule harden, RBUnoptimizedToDoRule harden, RBBetweenAndRule harden, RBCodeCruftLeftInMethodsRule harden, "Soft rules that only lead to warnings:" RBInstanceVariableCapitalizationRule, RBClassVariableCapitalizationRule, RBMissingSubclassResponsibilityRule, RBOverridesSpecialMessageRule, RBRefersToClassRule, RBBadMessageRule, RBUsesTrueRule, RBSendsDifferentSuperRule, RBInconsistentMethodClassificationRule, RBInstVarInSubclassesRule, RBSentNotImplementedRule, RBLongMethodsRule, RBCollectionProtocolRule, RBConsistencyCheckRule, RBContainsRule, RBDetectContainsRule, RBEmptyExceptionHandlerRule, RBEndTrueFalseRule, RBEqualsTrueRule, RBExtraBlockRule, RBFileBlocksRule, RBFloatEqualityComparisonRule, RBLiteralArrayCharactersRule, RBMissingYourselfRule, RBModifiesCollectionRule, RBReturnsIfTrueRule, RBSearchingLiteralRule, RBUnnecessaryAssignmentRule, RBNotEliminationRule, RBAtIfAbsentRule, RBAllAnyNoneSatisfyRule, RBClassNameInSelectorRule ); Don't be scared nor offended if your issue submission will get a lot of feedback in the near future. We're tweaking the rules to get decent feedback and not just blind noise.

5 6

Re: [Pharo-dev] dual screen
by Ralph Boland May 16, 2013

May 16, 2013

A different topic here although a dual screen issue. I recently got a second screen and use it to run Squeak but I assume the same issues occur with Pharo. I want to run one image across both screens. For some windows (e.g. Browsers) I have modified the code so that when the window is initially opened, if necessary, it moves to the left so as to avoid showing up across both screens. Other windows (e.g. Save and Quit Window) can still open split between the two screens. I will fix these someday and then release my code to Squeak. Feel free to then port it to Pharo. One problem though is vm related. If I save and quit and then reopen my image all the windows on the right screen only are lost. This is a major pain. Also, what happens with three screens? I am willing to look into this if someone sends me the money for a third screen. ;-) Ralph Boland -- It is impossible for a man to learn what he thinks he already knows. -- Epictetus

2 1

vm fixes
by Esteban Lorenzano May 16, 2013

May 16, 2013

Hi, I just pushed fix for a weird bug in cocoa cog vm. It was crashing image when resizing using DisplayScreen>>#hostWindowSize: but even worst, some times was crashing also when dragging a window outside the world screen... The fix is there, but you will need to wait until tomorrow to have it in zeroconf (because of weird mac jenkins slave permissions). This increases a bit more the VM stability, still not perfect, but we are getting closer :) Esteban

8 20

Making ASTInterpreter work with opal bindings
by Guillermo Polito May 16, 2013

May 16, 2013

Right now, in the image there exist two ways to annotate an AST: - the Opal way - the RB Way We should simplify that by having only one. So far, the only user of the RB bindings is the ASTInterpreter + the RB tests. So, I prepared a slice and issue [1], with the following details - annotate ast using opal annotator - extended OCBindings to read and write from an AST interpreter - not yet made a difference between arg nodes with a different class (just put an if) - i didnt add inst vars into the opal bindings for the binding->node relation as in RB, I send the node as a parameter - I had to adapt the #compile: into ASTInterpreter because - opal does not annotate other than method nodes - undeclared variables raised warnings, not errors There is one problem yet, I have only one failing test: #testEnsureTricky. I don't understand yet why it is failing and debugging it is pretty complex :). So any help is welcome in reviewing the changes. Guille [1] https://pharo.fogbugz.com/f/cases/10610/Make-ASTInterpreter-use-OC-Opal-bin…

5 13

[update 3.0] #30137
by Marcus Denker May 16, 2013

May 16, 2013

30137 ----- 10547 Do not run CommandLineHandlers on the existing stack https://pharo.fogbugz.com/f/cases/10547 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Support-MarcusDenker.8… http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-CommandLine-MarcusDenk… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1453.diff

1 0

[regression reporter]regression occurred
by no-reply＠ci.inria.fr May 16, 2013

May 16, 2013

https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2-Validation/./label=wi… 2 regressions found. CollectionsTests.Strings.ByteSymbolTest.testReadFromString CollectionsTests.Strings.SymbolTest.testReadFrom

1 0

[regression reporter]regression occurred
by no-reply＠ci.inria.fr May 16, 2013

May 16, 2013

https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2-Validation/./label=ma… 2 regressions found. CollectionsTests.Strings.ByteSymbolTest.testReadFromString CollectionsTests.Strings.SymbolTest.testReadFrom

1 0

[regression reporter]regression occurred
by no-reply＠ci.inria.fr May 16, 2013

May 16, 2013

https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2-Validation/./label=li… 2 regressions found. CollectionsTests.Strings.ByteSymbolTest.testReadFromString CollectionsTests.Strings.SymbolTest.testReadFrom

1 0

[update 3.0] #30136
by Marcus Denker May 16, 2013

May 16, 2013

1 0

[update 3.0] #30135
by Marcus Denker May 16, 2013

May 16, 2013

30135 ----- 10634 Simplify CompiledMethod>>#methodClass https://pharo.fogbugz.com/f/cases/10634 10645 clean up pc mapping methods of ASTInterpreter https://pharo.fogbugz.com/f/cases/10645 10642 remove unused low level scanning methods in CompiledMethod (scanLongLoad...) https://pharo.fogbugz.com/f/cases/10642 10632 OutOfScopeNotification not needed https://pharo.fogbugz.com/f/cases/10632 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1122.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Text-MarcusDenker.72.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1450.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Compiler-MarcusDenker.460.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/AST-Interpreter-Extension-Mar…

1 0