I spent some time yesterday evening with ben to compile a set of nice validation rules for the monkey, this is what we came up with ;) : CIRunTestsRule & "Only after the tests succeeded validate anything else" ( "Hard rules that lead to immediate WorkNeeded state:" RBUnclassifiedMethodsRule harden, RBUndeclaredReferenceRule harden, RBNoClassCommentRule harden, RBDefinesEqualNotHashRule harden, RBEquivalentSuperclassMethodsRule harden, RBJustSendsSuperRule harden, RBSubclassResponsibilityNotDefinedRule harden, RBTempVarOverridesInstVarRule harden, RBUndeclaredReferenceRule harden, RBVariableNotDefinedRule harden, RBEqualNotUsedRule harden, RBOnlyReadOrWrittenTemporaryRule harden, RBPrecedenceRule harden, RBSendsDeprecatedMethodToGlobalRule harden, RBSizeCheckRule harden, RBUnconditionalRecursionRule harden, RBUnoptimizedToDoRule harden, RBBetweenAndRule harden, RBCodeCruftLeftInMethodsRule harden, "Soft rules that only lead to warnings:" RBInstanceVariableCapitalizationRule, RBClassVariableCapitalizationRule, RBMissingSubclassResponsibilityRule, RBOverridesSpecialMessageRule, RBRefersToClassRule, RBBadMessageRule, RBUsesTrueRule, RBSendsDifferentSuperRule, RBInconsistentMethodClassificationRule, RBInstVarInSubclassesRule, RBSentNotImplementedRule, RBLongMethodsRule, RBCollectionProtocolRule, RBConsistencyCheckRule, RBContainsRule, RBDetectContainsRule, RBEmptyExceptionHandlerRule, RBEndTrueFalseRule, RBEqualsTrueRule, RBExtraBlockRule, RBFileBlocksRule, RBFloatEqualityComparisonRule, RBLiteralArrayCharactersRule, RBMissingYourselfRule, RBModifiesCollectionRule, RBReturnsIfTrueRule, RBSearchingLiteralRule, RBUnnecessaryAssignmentRule, RBNotEliminationRule, RBAtIfAbsentRule, RBAllAnyNoneSatisfyRule, RBClassNameInSelectorRule ); Don't be scared nor offended if your issue submission will get a lot of feedback in the near future. We're tweaking the rules to get decent feedback and not just blind noise.
Camillo we should really spend some time updating the plots in the jenkins job : https://ci.inria.fr/pharo/job/Pharo-3.0-CodeCritics-Beta/ . Because then for Pharo 3.0 release we could advertse saying look at the plots it is the code quality improvements for this release. 2013/5/16 Camillo Bruni <camillobruni@gmail.com>
I spent some time yesterday evening with ben to compile a set of nice validation rules for the monkey, this is what we came up with ;) :
CIRunTestsRule & "Only after the tests succeeded validate anything else" ( "Hard rules that lead to immediate WorkNeeded state:" RBUnclassifiedMethodsRule harden, RBUndeclaredReferenceRule harden, RBNoClassCommentRule harden, RBDefinesEqualNotHashRule harden, RBEquivalentSuperclassMethodsRule harden, RBJustSendsSuperRule harden, RBSubclassResponsibilityNotDefinedRule harden, RBTempVarOverridesInstVarRule harden, RBUndeclaredReferenceRule harden, RBVariableNotDefinedRule harden, RBEqualNotUsedRule harden, RBOnlyReadOrWrittenTemporaryRule harden, RBPrecedenceRule harden, RBSendsDeprecatedMethodToGlobalRule harden, RBSizeCheckRule harden, RBUnconditionalRecursionRule harden, RBUnoptimizedToDoRule harden, RBBetweenAndRule harden, RBCodeCruftLeftInMethodsRule harden,
"Soft rules that only lead to warnings:" RBInstanceVariableCapitalizationRule, RBClassVariableCapitalizationRule, RBMissingSubclassResponsibilityRule, RBOverridesSpecialMessageRule, RBRefersToClassRule, RBBadMessageRule, RBUsesTrueRule, RBSendsDifferentSuperRule, RBInconsistentMethodClassificationRule, RBInstVarInSubclassesRule, RBSentNotImplementedRule, RBLongMethodsRule, RBCollectionProtocolRule, RBConsistencyCheckRule, RBContainsRule, RBDetectContainsRule, RBEmptyExceptionHandlerRule, RBEndTrueFalseRule, RBEqualsTrueRule, RBExtraBlockRule, RBFileBlocksRule, RBFloatEqualityComparisonRule, RBLiteralArrayCharactersRule, RBMissingYourselfRule, RBModifiesCollectionRule, RBReturnsIfTrueRule, RBSearchingLiteralRule, RBUnnecessaryAssignmentRule, RBNotEliminationRule, RBAtIfAbsentRule, RBAllAnyNoneSatisfyRule, RBClassNameInSelectorRule );
Don't be scared nor offended if your issue submission will get a lot of feedback in the near future. We're tweaking the rules to get decent feedback and not just blind noise.
-- Clément Béra Mate Virtual Machine Engineer Bâtiment B 40, avenue Halley 59650 *Villeneuve d'Ascq*
On 16 May 2013 09:33, Clément Bera <bera.clement@gmail.com> wrote:
Camillo we should really spend some time updating the plots in the jenkins job : https://ci.inria.fr/pharo/job/Pharo-3.0-CodeCritics-Beta/ .
Because then for Pharo 3.0 release we could advertse saying look at the plots it is the code quality improvements for this release.
What does "unpackaged code" mean in the Pharo (Kernel only) analysis? (Otherwise, that's a really nice thing to see, those graphs!) frank
2013/5/16 Frank Shearar <frank.shearar@gmail.com>
On 16 May 2013 09:33, Clément Bera <bera.clement@gmail.com> wrote:
Camillo we should really spend some time updating the plots in the jenkins job : https://ci.inria.fr/pharo/job/Pharo-3.0-CodeCritics-Beta/ .
Because then for Pharo 3.0 release we could advertse saying look at the plots it is the code quality improvements for this release.
What does "unpackaged code" mean in the Pharo (Kernel only) analysis?
It supposed to be code that has no Monticello package I think. But it cannot happen in Pharo, so this graph was useless. But you cannot remove easily old graph data with the current jenkins plot plugin.
(Otherwise, that's a really nice thing to see, those graphs!)
Yeah it is nice, but it should be improved :).
frank
-- Clément Béra Mate Virtual Machine Engineer Bâtiment B 40, avenue Halley 59650 *Villeneuve d'Ascq*
On 16 May 2013 10:22, Clément Bera <bera.clement@gmail.com> wrote:
2013/5/16 Frank Shearar <frank.shearar@gmail.com>
On 16 May 2013 09:33, Clément Bera <bera.clement@gmail.com> wrote:
Camillo we should really spend some time updating the plots in the jenkins job : https://ci.inria.fr/pharo/job/Pharo-3.0-CodeCritics-Beta/ .
Because then for Pharo 3.0 release we could advertse saying look at the plots it is the code quality improvements for this release.
What does "unpackaged code" mean in the Pharo (Kernel only) analysis?
It supposed to be code that has no Monticello package I think. But it cannot happen in Pharo, so this graph was useless. But you cannot remove easily old graph data with the current jenkins plot plugin.
Ah, OK. I'd suspected that's what it meant. Just wanted to make sure.
(Otherwise, that's a really nice thing to see, those graphs!)
Yeah it is nice, but it should be improved :).
Everything always does :) frank
Clément Bera wrote:
Camillo we should really spend some time updating the plots in the jenkins job : https://ci.inria.fr/pharo/job/Pharo-3.0-CodeCritics-Beta/ .
What is "JSHint Trend" on the graph heading? Are you advertising something to do with Javascript? :) (Sorry, its just the first thing that popped into my head looking at it.)
On 16 May 2013 20:03, <btc@openinworld.com> wrote:
Clément Bera wrote:
Camillo we should really spend some time updating the plots in the jenkins job : https://ci.inria.fr/pharo/job/Pharo-3.0-CodeCritics-Beta/ .
What is "JSHint Trend" on the graph heading? Are you advertising something to do with Javascript? :) (Sorry, its just the first thing that popped into my head looking at it.)
Yes, this is related to javascript.. looks like guys forced it to work with smalltalk :) https://wiki.jenkins-ci.org/display/JENKINS/JSHint+Checkstyle+Plugin -- Best regards, Igor Stasenko.
participants (5)
-
btc＠openinworld.com -
Camillo Bruni -
Clément Bera -
Frank Shearar -
Igor Stasenko