- Pharo-dev - lists.pharo.org

Penelope Doesn't Skip "Wrong" Lint Rules
by Sean P. DeNigris May 7, 2015

May 7, 2015

I marked them wrong in the Critic Browser, which now skips them, but the validation report still shows them as Warnings. Anyone know why? I see the versions in the inbox references by the slice have their manifest classes... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Penelope-Doesn-t-Skip-Wrong-Lint-Rules-tp4825134.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

2 3

[Review]: Issue 15507: SliceMaker Overhaul
by Sean P. DeNigris May 7, 2015

May 7, 2015

Issue 15507: SliceMaker Overhaul https://pharo.fogbugz.com/default.asp?15507 It all started simply enough: I wanted to extract the issue title downloading - which is generally useful - from slice maker. One full day later, I ended up with a pretty extensive rewrite. Now, I feel like it would've been better to start from scratch, but IMHO it's better, and good enough to move on to more pressing things. Fix in inbox: SLICE-Issue-15507-SliceMaker-Overhaul-SeanDeNigris.1 ###[FEATURE]: PharoIssue class. Here is it's class comment: I represent a Pharo development issue. Responsibilities: - create text templates (e.g. for the mailing list or issue tracker comments) for common events like issue creation and slice submission - communicate with the issue tracker Collaborators: - ZnClient - my link to the issue tracker - MCSliceInfo - I can get you one if you need it Public API and Key Messages: Most of my behavior is illustrated in my tests. The noticable exception are my text template creation messages, the testing of which seemed to hurt as much in duplication as it added in QA. ###[Cleanup]: Komitter - Remove Duplication Caused By MCSliceInfo - For some reason, Komitter seems to deal with MCPackages, while MCSliceInfo deals with MCWorkingCopy instances. This causes a tiny difference when making a slice (one sends #package to the wc, the other already has the package). The previous solution was to copy/paste a long method, changing one statement. This one trades that method in for "MCPackage>>#package ^ self" with a careful explanation in the comment of why we are doing this ugly thing! ###[ENH]: MC Slice Making - This is the most significant change - Extract issue-related behavior to PharoIssue - Extract slice-related behavior to MCSliceInfo. This class is still pretty confusing. It's a cross between a model of an actual slice, and an Application Model for MCSliceMaker. But since slices are supposed to go away soon... - Many small cleanups - fix misspellings, improve comments, simplify code - Remove the "Grab" button. The issue title is automatically downloaded when the issue number field loses focus ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-15507-SliceMaker-Overhaul-tp4825070.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

1 1

Debugger hangs vm on step into
by Alain Rastoul May 7, 2015

May 7, 2015

Hi I wanted to step into SharedQueue code, but got a hanged vm on simple test code below. It works fine in Pharo 3 but hangs in Pharo4-40611 and Pharo5-50029, it does not hang in squeak 4.5 but the Monitor code is not the same. In a playgound, execute the first two lines of code then select the third line and 'Debug it' (right click menu option) to step into it. q := SharedQueue new . q nextPut: 1 . q next. Everything goes fine until stepping into 'aBlock value' in Monitor>>critical: critical: aBlock ^[ self enter. Hangs here >>>>aBlock value<<<<<< ] ensure: [self exit]. The vm get hanged and can be interrupted only once, then it is completely hanged. I once got an error message Error: Monitor access violation message and a stack trace in debug log before hanging but was unable to reproduce it (something related to effectiveProcess?) --- The full stack --- Monitor(Object)>>error: Monitor>>checkOwnerProcess Monitor>>waitWhile:for:maxMilliseconds: Monitor>>waitWhile:for: Monitor>>waitWhile: [ monitor waitWhile: [ items isEmpty ]. items removeFirst ] in SharedQueue>>next [ self enter. aBlock value ] in Monitor>>critical: BlockClosure>>ensure: Monitor>>critical: SharedQueue>>next UndefinedObject>>DoIt CompiledMethod>>valueWithReceiver:arguments: [ aCompiledMethod valueWithReceiver: anObject arguments: (evalContext ifNil: [ #() ] ifNotNil: [ {evalContext} ]) ] in RubSmalltalkEditor>>debug:receiver:in: [ self value. Processor terminateActive ] in BlockClosure>>newProcess ------------------------------------------------------------------------------- Can someone have a look and confirm it is a bug before I open a bug entry ? And/or give me hints on how to debug this ? I tried to modify Monitor>>waitWhile: and put a delay, put traces but still hanging. DebugSession someInstance stepInto does not hang, but I'm not sure that the execution flow is the same ... TIA -- Regards, Alain

2 9

RewriteTool
by Sean P. DeNigris May 7, 2015

May 7, 2015

There are two repos: http://smalltalkhub.com/#!/~PharoExtras/RewriteTool , which seems to have been forked some time ago and http://smalltalkhub.com/#!/~MarkRizun/RewriteTool/ , which is now about 70 commits ahead of the first! What should be done? ----- Cheers, Sean -- View this message in context: http://forum.world.st/RewriteTool-tp4824877.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

4 11

[pharo-project/pharo-core] f22176: 50039
by GitHub May 7, 2015

May 7, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: f22176c65834be28372208e6add9f57a39f1b644 https://github.com/pharo-project/pharo-core/commit/f22176c65834be28372208e6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-05-07 (Thu, 07 May 2015) Changed paths: M Kernel.package/Character.class/instance/printing/hex.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script647.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script648.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50038.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50039.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/extension/Behavior/instance/layout.st Log Message: ----------- 50039 15286 `Class new` doesnt result in a properly initialized class object. https://pharo.fogbugz.com/f/cases/15286 15506 Hexadecimal is misspelled in Character>>#hex https://pharo.fogbugz.com/f/cases/15506 http://files.pharo.org/image/50/50039.zip

1 0

[pharo-project/pharo-core]
by GitHub May 7, 2015

May 7, 2015

Branch: refs/tags/50039 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core]
by GitHub May 7, 2015

May 7, 2015

Branch: refs/tags/50038 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 55a69b: 50038
by GitHub May 7, 2015

May 7, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 55a69b0645f398bb4d99610db20a900d1d56d864 https://github.com/pharo-project/pharo-core/commit/55a69b0645f398bb4d99610d… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-05-07 (Thu, 07 May 2015) Changed paths: M Nautilus.package/AbstractNautilusUI.class/class/menu/sourceCodeMenu_.st M Nautilus.package/AbstractNautilusUI.class/definition.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/showGroups_.st M Nautilus.package/AbstractNautilusUI.class/instance/build ui text/buildCodePane.st M Nautilus.package/AbstractNautilusUI.class/instance/code panel/buildCodePanelWithComment.st R Nautilus.package/AbstractNautilusUI.class/instance/code panel/buildCodePanelWithCommentOnBottom.st R Nautilus.package/AbstractNautilusUI.class/instance/code panel/buildCodePanelWithCommentOnLeft.st M Nautilus.package/AbstractNautilusUI.class/instance/code panel/buildCodePanelWithCommentOnRight.st R Nautilus.package/AbstractNautilusUI.class/instance/code panel/buildCodePanelWithCommentOnTop.st M Nautilus.package/AbstractNautilusUI.class/instance/code panel/buildCodePanelWithoutComment.st R Nautilus.package/AbstractNautilusUI.class/instance/source code area/lockTextArea.st R Nautilus.package/AbstractNautilusUI.class/instance/source code area/lockTextArea_from_.st R Nautilus.package/AbstractNautilusUI.class/instance/source code area/unlockTextArea_.st R Nautilus.package/MultipleMethodsEditor.class/README.md R Nautilus.package/MultipleMethodsEditor.class/definition.st R Nautilus.package/MultipleMethodsEditor.class/instance/initialization/initialize.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/addHFill.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/addSplitterBetween_and_to_at_.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/layoutFor_startingAt_finishingAt_.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/newButtonFor_label_.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/newButtonFor_value_label_.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/newProportionalPanelMorph.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/newScrollPaneWithScroller_target_.st R Nautilus.package/MultipleMethodsEditor.class/instance/private/scrollFromEditor_.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/addEditor_.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/giveFocusToDefault.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/hasMultipleElements.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/hasSingleElement.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/removeEditor_.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/rgiveFocusToCurrent.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/setCurrent_.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/setDefault.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/updateButtonsStateFrom_.st R Nautilus.package/MultipleMethodsEditor.class/instance/protocol/updateScroller.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/addAllButton.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/addButtons.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/newAllButton.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/updateEditorsWith_over_into_.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/updateLayoutForMultiple.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/updateLayoutForSingle.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/updateLayoutForSingleWithButtons.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/updateScrollerWithMultipleElements.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/updateScrollerWithMultipleElementsWithoutButtons.st R Nautilus.package/MultipleMethodsEditor.class/instance/updating/updateScrollerWithOneElement.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/README.md R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/class/instance creation/on_.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/definition.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/instance/accessing/model.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/instance/accessing/model_.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/instance/initialization/initialize.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/instance/protocol/action.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/instance/protocol/label.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/instance/protocol/setState_.st R Nautilus.package/MultipleMethodsEditorAllButtonModel.class/instance/protocol/state.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/README.md R Nautilus.package/MultipleMethodsEditorButtonModel.class/class/instance creation/on_label_target_.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/class/instance creation/on_value_label_target_.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/definition.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/accessing/label_.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/accessing/model.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/accessing/model_.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/accessing/target.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/accessing/target_.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/initialization/initialize.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/protocol/action.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/protocol/label.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/protocol/setState_.st R Nautilus.package/MultipleMethodsEditorButtonModel.class/instance/protocol/state.st M Nautilus.package/Nautilus.class/class/settings/nautilusSettingsOn_.st M Nautilus.package/NautilusUI.class/instance/widget method/selectedMethod_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script646.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script647.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50037.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50038.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50038 15499 post removal of multiwindow https://pharo.fogbugz.com/f/cases/15499 http://files.pharo.org/image/50/50038.zip

1 0

[Review]: Issue 15503 Add RPackage>>#mcWorkingCopy for MCSliceInfo>>#makeSlice
by Sean P. DeNigris May 7, 2015

May 7, 2015

It's really quick - 3 tiny methods changed and two tests added. The monkey passed it and it's holding up two more fixes I want to do... Thanks :) ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Issue-15503-Add-RPackage-mcWorkingCopy-for-MCS… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

2 1

NativeBoost and memory management
by Holger Freyther May 7, 2015

May 7, 2015

Good Morning, I used NB to access openlog, closelog and syslog of libc and I am not sure if I got it right but didnât really get further by browsing testcases/reading the examples. openlog(3) takes an âchar *identâ as first parameter and the caller needs to make sure that the string passed remains valid until closelog is called. My binding looks like this: c_openlog: ident opt: aOpt facility: aFac "openlog(const char *ident, int logopt, int facility);" <primitive: #primitiveNativeCall module: #NativeBoostPlugin error: errorCode> ^self nbCall: #(void openlog(char *ident, int aOpt, int aFac)) And I call it like this: Identity := anIdentity asNBExternalString. self c_openlog: Identity opt: anOption facility: aFacility. The things I am not sure with: 1.) is it right to use âchar *identâ instead of âString identâ? âStringâ will copy the string by value but the pointer passed to openlog would be a pointer from the C callstack? 2.) Am I right with the call to asNBExternalString? 3.) How does this integrate with GC and image quit/image resume? E.g. I could use >>#freeAfterUse and if I do âIdentity := nilâ at some point free should be called on the old string. Is there anything in the system that sets the address to 0x0 after the image is starting? thanks holger

4 3