March 2018 - Pharo-dev - lists.pharo.org

Adapt ImageReadWriter hierarchy to need only pure binary streams
by Sven Van Caekenberghe March 17, 2018

March 17, 2018

https://pharo.manuscript.com/f/cases/21611 With the new File/Stream changes in Pharo 7, ImageReadWriter and subclasses broke because these classes are not yet capable of working with simple binary streams. I created a new test case (attached) to catch the functional degradation. For each image type (class) there are 2 tests, IO in memory and IO to file. For example: testJpegWriteReadInMemory | form bytes result | form := self pharoLogoFormNonTransparent. bytes := ByteArray streamContents: [ :out | PluginBasedJPEGReadWriter putForm: form onStream: out ]. "Without format detection" result := (JPEGReadWriter on: bytes readStream) nextImage. self assert: form bits size equals: result bits size. "With format detection" result := ImageReadWriter formFromStream: bytes readStream. self assert: form bits size equals: result bits size testJpegWriteReadUsingFiles | form file result | form := self pharoLogoFormNonTransparent. file := (self class name asString , '-pharo-logo.jpeg') asFileReference. file ensureDelete. (PluginBasedJPEGReadWriter on: file binaryWriteStream) nextPutImage: form. "gets closed ?!" "Without format detection" result := file binaryReadStreamDo: [ :in | (JPEGReadWriter on: in) nextImage ]. self assert: form bits size equals: result bits size. "With format detection" result := file binaryReadStreamDo: [ :in | ImageReadWriter formFromStream: in ]. self assert: form bits size equals: result bits size. file delete I have a bunch of changes that make all tests pass. They clean up some strange coding as well. I will make a proper PR later. Sven

3 2

Executive Summary of the recent FileStream Changes
by Sven Van Caekenberghe March 17, 2018

March 17, 2018

Executive Summary of the recent FileStream Changes In Pharo 7 Guille Polito recently committed a heroic set of changes that we were planning to do for a long time but were afraid to take on. The idea is to replace a couple of fat, overly complex, multi-functional, do-all classes with a set of simpler single purpose classes that can be combined as needed. The classes that we want to get rid of can be found in the package DeprecatedFileSystem, in particular FileStream, StandardFileStream, MultiByteFileStream, MultiByteBinaryOrTextStream and RWBinaryOrTextStream. The replacements are can be found in packages Files and Zinc-Character-Encoding-Core. Encoding and decoding characters to and from bytes is done using classes that you wrap around a more primitive binary stream. The same goes for buffering or translating line endings. For example, '/Users/sven/Desktop/foo.txt' asFileReference binaryReadStream. gives you a ZnBufferedWriteStream wrapping a BinaryWriteStream. While, '/Users/sven/Desktop/foo.txt' asFileReference readStream. gives a ZnCharacterReadStream wrapping a ZnBufferedWriteStream wrapping a BinaryWriteStream. To translate line endings, we would wrap a ZnCharacterWriteStream using a ZnCrPortableWriteStream. There are a couple of more specialised streams to cover special cases (like read and writing at the same time). SocketStream remains another fat, overly complex, multi-functional, do-all class, for which usable replacements exist in the form of ZdcSocketStream and ZdcSecureSocketStream, which are simpler, cleaner and binary only. Of course, switching is more than replacing one class with a 100% compatible alternative, that would give us the same complex result. The challenge is to use a simpler API as well, to rethink how the streams are used. You know, KISS. Of course, we are far from done and need more testing, debugging and help from as many people as possible. Sven -- Sven Van Caekenberghe Proudly supporting Pharo http://pharo.org http://association.pharo.org http://consortium.pharo.org

5 9

[Pharo 7.0-dev] Build #702: Remove extra buffered read stream
by ci-pharo-ci-jenkins2＠inria.fr March 17, 2018

March 17, 2018

There is a new Pharo build available! The status of the build #702 was: SUCCESS. The Pull Request #1118 was integrated: "Remove extra buffered read stream" Pull request url: https://github.com/pharo-project/pharo/pull/1118 Issue Url: https://pharo.fogbugz.com/f/cases/21604 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #701: 21487 Lint clean #testAtWrapPut
by ci-pharo-ci-jenkins2＠inria.fr March 16, 2018

March 16, 2018

There is a new Pharo build available! The status of the build #701 was: SUCCESS. The Pull Request #1125 was integrated: "21487 Lint clean #testAtWrapPut" Pull request url: https://github.com/pharo-project/pharo/pull/1125 Issue Url: https://pharo.fogbugz.com/f/cases/21487 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Base64MimeConverter class>>mimeDecodeToBytes: change breaks image load
by Alistair Grant March 16, 2018

March 16, 2018

Hi Guille & Pavel, On 6 Feb Guille changed Base64MimeConverter class>>mimeDecodeToBytes: so that it doesn't reset the dataStream position back to the start of the stream. This breaks Pavel's PlayingCard, part of FreeCell (you can see that I only load important stuff :-)). PlayingCard class>>initialize "PlayingCard initialize" | forms f | "Read the stored forms from mime-encoded data in imageData." f := Base64MimeConverter mimeDecodeToBytes: (ReadStream on: self imageData). forms := OrderedCollection new. f next = 2 ifFalse: [self error: 'corrupted imageData']. [f atEnd] whileFalse: [forms add: (Form new readFrom: f)]. ... Previously, f would be at the start of the stream (which makes sense given this usage), but now it is at the end of the stream, so returns nil and "f next = 2" fails. Guille, can you explain the change. The commit log just says "make tests run". Note that a lot of users of this won't fail as they just call #contents of the stream after #mimeDecodeToBytes:, which works regardless of the current position. Thanks, Alistair

3 8

FileHandle creates a buffered stream on a buffered stream
by Sven Van Caekenberghe March 16, 2018

March 16, 2018

Hi (Guille), FileHandle creates a buffered stream on a buffered stream when sent #readStream. Note how #binaryReadStream adds a bufferer stream as well as #readStreamEncoded: Probably the latter should not do this Sven

3 3

Something is happening...
by Marcus Denker March 16, 2018

March 16, 2018

Hi, There is something odd happeningâ¦ or better: There is *a lot* happening. Just one example: for the Newsletter, the original idea was to send out once a month a post with 3 things, some of them recycled (e.g. pointers to existing projects, re-use âsuccess storiesâ, things like that. Now already some months ago I had to add âand here are some other interesting announcements, blog posts, videosâ. But this month, the list of things for the newsletter TODO list contains over 60 entries. With the exception of maybe 5, these are just things that happened between sending the February newsletter and today. Newsletter March should be ready till this thursday, I hope, subscribe or read the oder ones here: http://newsletter.pharo.org <http://newsletter.pharo.org/> Marcus

6 10

[Pharo 7.0-dev] Build #700: 21600 Use "instance creation" protocol in Monticello
by ci-pharo-ci-jenkins2＠inria.fr March 16, 2018

March 16, 2018

There is a new Pharo build available! The status of the build #700 was: SUCCESS. The Pull Request #1114 was integrated: "21600 Use "instance creation" protocol in Monticello" Pull request url: https://github.com/pharo-project/pharo/pull/1114 Issue Url: https://pharo.fogbugz.com/f/cases/21600 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #699: 21601 Use "instance creation" in FT classes
by ci-pharo-ci-jenkins2＠inria.fr March 16, 2018

March 16, 2018

There is a new Pharo build available! The status of the build #699 was: SUCCESS. The Pull Request #1115 was integrated: "21601 Use "instance creation" in FT classes" Pull request url: https://github.com/pharo-project/pharo/pull/1115 Issue Url: https://pharo.fogbugz.com/f/cases/21601 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #698: 21595 Use "instance creation" protocol in OSVMWindowHandle
by ci-pharo-ci-jenkins2＠inria.fr March 16, 2018

March 16, 2018

There is a new Pharo build available! The status of the build #698 was: FAILURE. The Pull Request #1110 was integrated: "21595 Use "instance creation" protocol in OSVMWindowHandle" Pull request url: https://github.com/pharo-project/pharo/pull/1110 Issue Url: https://pharo.fogbugz.com/f/cases/21595 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0