FileHandle creates a buffered stream on a buffered stream
Hi (Guille), FileHandle creates a buffered stream on a buffered stream when sent #readStream. Note how #binaryReadStream adds a bufferer stream as well as #readStreamEncoded: Probably the latter should not do this Sven
Nice catch. The write stream is well defined in comparison. https://pharo.fogbugz.com/f/cases/21604/FileHandle-creates-a-buffered-stream... https://github.com/pharo-project/pharo/pull/1118 Can somebody review please? Tx, Guille On Thu, Mar 15, 2018 at 4:00 PM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Hi (Guille),
FileHandle creates a buffered stream on a buffered stream when sent #readStream.
Note how #binaryReadStream adds a bufferer stream as well as #readStreamEncoded:
Probably the latter should not do this
Sven
-- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13
On 16 Mar 2018, at 11:46, Guillermo Polito <guillermopolito@gmail.com> wrote:
Nice catch. The write stream is well defined in comparison.
https://pharo.fogbugz.com/f/cases/21604/FileHandle-creates-a-buffered-stream...
https://github.com/pharo-project/pharo/pull/1118
Can somebody review please?
OK by me
Tx, Guille
On Thu, Mar 15, 2018 at 4:00 PM, Sven Van Caekenberghe <sven@stfx.eu> wrote: Hi (Guille),
FileHandle creates a buffered stream on a buffered stream when sent #readStream.
Note how #binaryReadStream adds a bufferer stream as well as #readStreamEncoded:
Probably the latter should not do this
Sven
--
Guille Polito Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - http://www.cnrs.fr
Web: http://guillep.github.io Phone: +33 06 52 70 66 13
Guille is a machine :) I'm amazed and love to see all this energy pushed into Pharo. Tx guille. On Fri, Mar 16, 2018 at 1:37 PM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 16 Mar 2018, at 11:46, Guillermo Polito <guillermopolito@gmail.com> wrote:
Nice catch. The write stream is well defined in comparison.
https://pharo.fogbugz.com/f/cases/21604/FileHandle-creates-a-buffered-stream...
https://github.com/pharo-project/pharo/pull/1118
Can somebody review please?
OK by me
Tx, Guille
On Thu, Mar 15, 2018 at 4:00 PM, Sven Van Caekenberghe <sven@stfx.eu> wrote: Hi (Guille),
FileHandle creates a buffered stream on a buffered stream when sent #readStream.
Note how #binaryReadStream adds a bufferer stream as well as #readStreamEncoded:
Probably the latter should not do this
Sven
--
Guille Polito Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - http://www.cnrs.fr
Web: http://guillep.github.io Phone: +33 06 52 70 66 13
participants (3)
-
Guillermo Polito -
Stephane Ducasse -
Sven Van Caekenberghe