September 2015 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]
by GitHub Sept. 6, 2015

Sept. 6, 2015

Branch: refs/tags/50307 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 96f3ce: 50307
by GitHub Sept. 6, 2015

Sept. 6, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 96f3ceffe16fa3c72e2ba9e7c7590e00118c4d2f https://github.com/pharo-project/pharo-core/commit/96f3ceffe16fa3c72e2ba9e7… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-06 (Sun, 06 Sep 2015) Changed paths: M AST-Core.package/RBParser.class/instance/accessing/parseExpression_.st M AST-Core.package/RBParser.class/instance/accessing/parseMethod_.st M AST-Core.package/RBParser.class/instance/private-parsing/parseBlock.st A AST-Core.package/RBParser.class/instance/private-parsing/parseIncompleteExpression_.st M AST-Core.package/RBParser.class/instance/private-parsing/parseVariableNode.st M AST-Core.package/RBScanner.class/instance/accessing/scanToken.st M AST-Core.package/RBScanner.class/instance/private-scanning/scanLiteral.st M AST-Core.package/RBScanner.class/instance/private-scanning/scanLiteralString.st M AST-Core.package/RBScanner.class/instance/private-scanning/stripComment.st M Morphic-Base.package/EmbeddedMenuMorph.class/instance/keyboard control/moveSelectionDown_event_.st M Morphic-Base.package/MenuItemMorph.class/instance/accessing/hasIconOrMarker.st M Morphic-Base.package/MenuItemMorph.class/instance/accessing/hasMarker.st M Morphic-Base.package/MenuItemMorph.class/instance/events/themeChanged.st M Morphic-Base.package/MenuItemMorph.class/instance/grabbing/aboutToBeGrabbedBy_.st M Morphic-Base.package/MenuItemMorph.class/instance/meta actions/wantsHaloFromClick.st M Morphic-Base.package/MenuItemMorph.class/instance/nil/deselectItem.st A Morphic-Base.package/MenuItemMorph.class/instance/testing/isMenuItemMorph.st A Morphic-Base.package/MenuLineMorph.class/instance/testing/isMenuLineMorph.st R Morphic-Base.package/MenuMorph.class/instance/accessing/hasItems.st R Morphic-Base.package/MenuMorph.class/instance/accessing/hasSubMenu_.st M Morphic-Base.package/MenuMorph.class/instance/accessing/items.st M Morphic-Base.package/MenuMorph.class/instance/accessing/lastItem.st M Morphic-Base.package/MenuMorph.class/instance/accessing/menuItems.st M Morphic-Base.package/MenuMorph.class/instance/accessing/popUpOwner.st M Morphic-Base.package/MenuMorph.class/instance/actions/deleteIfPopUp.st A Morphic-Base.package/MenuMorph.class/instance/construction-UIManager/addItem.st A Morphic-Base.package/MenuMorph.class/instance/construction-UIManager/addTitle.st M Morphic-Base.package/MenuMorph.class/instance/construction-title/addStayUpIcons.st R Morphic-Base.package/MenuMorph.class/instance/construction-title/newTitleIconCalling_form_ballonText_.st A Morphic-Base.package/MenuMorph.class/instance/construction-title/newTitleIconCalling_form_helpText_.st M Morphic-Base.package/MenuMorph.class/instance/construction/addAllFrom_.st M Morphic-Base.package/MenuMorph.class/instance/construction/addLine.st M Morphic-Base.package/MenuMorph.class/instance/construction/addMenuItem_.st M Morphic-Base.package/MenuMorph.class/instance/construction/addToggle_target_selector_getStateSelector_enablementSelector_argumentList_.st M Morphic-Base.package/MenuMorph.class/instance/initialization/initialize.st M Morphic-Base.package/MenuMorph.class/instance/invoking/informUserAt_during_.st M Morphic-Base.package/MenuMorph.class/instance/keyboard control/displayFiltered_.st M Morphic-Base.package/MenuMorph.class/instance/keyboard control/moveSelectionDown_event_.st M Morphic-Base.package/MenuMorph.class/instance/menu/addCustomMenuItems_hand_.st R Morphic-Base.package/MenuMorph.class/instance/menu/addItem.st R Morphic-Base.package/MenuMorph.class/instance/menu/addTitle.st M Morphic-Base.package/MenuMorph.class/instance/menu/detachSubMenu_.st M Morphic-Base.package/MenuMorph.class/instance/menu/doButtonAction.st M Morphic-Base.package/MenuMorph.class/instance/menu/removeStayUpItems.st M Morphic-Base.package/MenuMorph.class/instance/menu/setTarget_.st M Morphic-Base.package/MenuMorph.class/instance/menu/target_.st A Morphic-Base.package/MenuMorph.class/instance/submorphs-add%2Fremove/addMorphBack_.st A Morphic-Base.package/MenuMorph.class/instance/testing/hasItems.st A Morphic-Base.package/MenuMorph.class/instance/testing/hasSubMenu_.st A Morphic-Base.package/MenuMorph.class/instance/testing/isMenuMorph.st A Morphic-Base.package/extension/Morph/instance/isMenuItemMorph.st A Morphic-Base.package/extension/Morph/instance/isMenuLineMorph.st A Morphic-Base.package/extension/Morph/instance/isMenuMorph.st M Morphic-Base.package/extension/WorldState/class/windowsOn_.st M Polymorph-Widgets.package/IdentifierChooserMorph.class/instance/event handling/selectNextItem.st M Polymorph-Widgets.package/IdentifierChooserMorph.class/instance/event handling/selectPreviousItem.st M Polymorph-Widgets.package/IdentifierChooserMorph.class/instance/event handling/switchToOtherColumn_.st M Polymorph-Widgets.package/IdentifierChooserMorph.class/instance/ui-building/newChoicesMorph.st M Polymorph-Widgets.package/IdentifierChooserMorph.class/instance/ui-building/newMenuWith_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50306.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50307.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50306.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50307.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-MorphicAdapters.package/MorphicMenuAdapter.class/instance/private/buildWidgetPopup.st M Tool-FileList.package/extension/MenuMorph/instance/addServices_for_extraLines_.st Log Message: ----------- 50307 16483 AST-Core should not depend on System-Localization https://pharo.fogbugz.com/f/cases/16483 16472 Minor improvements to MenuMorph (2) https://pharo.fogbugz.com/f/cases/16472 16492 no syntax highlighting if last expression is invalid code https://pharo.fogbugz.com/f/cases/16492 http://files.pharo.org/image/50/50307.zip

1 0

GroupAnnouncer?
by stepharo Sept. 5, 2015

Sept. 5, 2015

Hi A final thought from my reading of Nautilus and related. I'm thinking that we could merge GroupAnnouncer into class side Group. Because I do not see the point to have a singleton and a subclass of Announcer. Stef

1 0

Nautilus cleaning ideas.
by stepharo Sept. 5, 2015

Sept. 5, 2015

Hi I was reading code and I was wondering if we could have a simple NullPlugin to avoid bottom := self model plugins select: [:each | each position = #bottom ]. bottom ifEmpty: [ ^ nil ]. and bottomMorph := self buildBottomPlugins. bottomMorph ifNotNil: [ bottomHeight := bottomMorph height + 8 ]. aWindow addMorph: sourceCodeContainer fullFrame: ((0 @ self navigationAreaProportion corner: 1 @ 1) asLayoutFrame topOffset: middleHeight; bottomOffset: bottomHeight negated). bottomMorph ifNotNil: [ aWindow addMorph: bottomMorph fullFrame: ((0 @ 1 corner: 1 @ 1) asLayoutFrame topOffset: bottomHeight negated). bottomMorph color: Color transparent ] But I do not think that this is the solution. Just brainstorming.... I imagine that we should change the computation to go from bottomMorph := self buildBottomPlugins. bottomMorph ifNotNil: [ bottomHeight := bottomMorph height + 8 ]. aWindow addMorph: sourceCodeContainer fullFrame: ((0 @ self navigationAreaProportion corner: 1 @ 1) asLayoutFrame topOffset: middleHeight; bottomOffset: bottomHeight negated). bottomMorph ifNotNil: [ aWindow addMorph: bottomMorph fullFrame: ((0 @ 1 corner: 1 @ 1) asLayoutFrame topOffset: bottomHeight negated). bottomMorph color: Color transparent ] into bottomMorph := self buildBottomPlugins. bottomHeight := bottomMorph height + 8. aWindow addMorph: sourceCodeContainer fullFrame: ((0 @ self navigationAreaProportion corner: 1 @ 1) asLayoutFrame topOffset: middleHeight; bottomOffset: bottomHeight negated). bottomMorph addYourselfInto: aWindow. and for the Null version height returns 0 addYourselfInto: does nothing. What do you think? Stef

1 0

how do I push fixed upstream?
by Peter UhnÃ¡k Sept. 5, 2015

Sept. 5, 2015

How do I push "fixed upstream"? Since it doesn't have "Fix Review Needed" nobody will see it, review it and merge it. How should I mark it? Do I need to make another step? https://pharo.fogbugz.com/f/cases/15920/Cannot-inspect-a-SpecTreeNodeModel-… Peter

3 2

rb highlighting is not up to the task yet
by Tudor Girba Sept. 5, 2015

Sept. 5, 2015

Hi, I think it's nice that we are going towards consolidating our tools around RB. However, the highlighting logic is not quite enough because if I have an error anywhere in the code, the whole highlighting disappears. In contrast, Shout manages to limit the problem only to the surrounding code. Is anyone working on this part of the highlighting? Cheers, Doru -- www.tudorgirba.com "Every thing has its own flow"

4 7

[pharo-project/pharo-core] 948180: 50306
by GitHub Sept. 5, 2015

Sept. 5, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 9481809ccc4c7874fce2997bb202a34f35dc480f https://github.com/pharo-project/pharo-core/commit/9481809ccc4c7874fce2997b… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-05 (Sat, 05 Sep 2015) Changed paths: M Nautilus.package/Nautilus.class/instance/accessing/selectedPackage_.st M Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/registerSelectionPackage_.st A Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - after/testAfterReturn.st M Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - instead/testInsteadBlock.st M Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - instead/testInsteadReturn.st M Reflectivity.package/RFASTTranslator.class/instance/visitor-double dispatching/visitBlockNode_.st M Reflectivity.package/RFASTTranslator.class/instance/visitor-double dispatching/visitReturnNode_.st A Reflectivity.package/extension/RBReturnNode/instance/link_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50305.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50306.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50305.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50306.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot-Tests.package/SlotEnvironmentTest.class/instance/tests/testBasicEnvironment.st M Slot.package/PharoClassInstaller.class/instance/notifications/classAdded_inCategory_.st M System-Support.package/SystemDictionary.class/instance/accessing/organization.st Log Message: ----------- 50306 16485 Class panes not refreshed when changing package https://pharo.fogbugz.com/f/cases/16485 16479 Creating a class in an empty environment https://pharo.fogbugz.com/f/cases/16479 16481 #instead for Block https://pharo.fogbugz.com/f/cases/16481 http://files.pharo.org/image/50/50306.zip

1 0

[pharo-project/pharo-core]
by GitHub Sept. 5, 2015

Sept. 5, 2015

Branch: refs/tags/50306 Home: https://github.com/pharo-project/pharo-core

1 0

now that we have a pragma for fileService
by stepharo Sept. 5, 2015

Sept. 5, 2015

Hi now that we have a pragma for fileService description I imagine that the following method is not necessary anymore. Object class>>fileReaderServicesForFile: fullName suffix: suffix <fileService> "Backstop" ^#()

1 0

Voyage Mongo and Serialization anomalies?
by Holger Freyther Sept. 5, 2015

Sept. 5, 2015

Hi all, it is the first time I notice this and I am not sure that this has been written down somewhere and if it is known to others (and then what to do about it). I had an Object with a ByteArray and then tried to find this object using the ByteArray and it wasnât found. It looks like the ByteArray will be converted to an âarrayâ. When searching the ByteArray would not match it, an Array matches it. When using anArray to find the object and using a âgetterâ to get the value and comparing it will not lead to equality. I understand that Mongo doesnât have same types (Array, OrderedCollection, ByteArray) as Smalltalk but I wonder if there can be done something to improve the situation? Is this known? Can we improve it? I can of course workaround it by converting it to an array/orderedcollection before comparing it. holger Example: | data repository test res | repository := VOMongoRepository database: 'dbtest'. data := #[1 2 3 4]. test := ZEByteArrayVoyage new. test byteArray: data. repository save: test. res := repository selectOne: ZEByteArrayVoyage where: [:each | each byteArray = data ]. res. "---> UndefinedObject" res := repository selectOne: ZEByteArrayVoyage where: [:each | each byteArray = data asArray]. res. "---> ZEByteArrayVoyage" res byteArray = data. âfalse.. OrderedCollection = ByteArray" res byteArray = data asArray. âOrderedCollection = Array" res byteArray = data asOrderedCollection. "true"

2 1