August 2015 - Pharo-dev - lists.pharo.org

Cleaning up Locale, LanguageEnvironment and EncodedCharSet
by Guillermo Polito Aug. 25, 2015

Aug. 25, 2015

Hi guys, I was having a deep look today at Locale, LanguageEnvironment and EncodedCharset with the objective of understanding it and see how we can organize it better. As I saw, in almost all cases, it happened that the locale and language environment are only used to get the current system's encoding. Even, it is not that the system's encoding is obtained from the system's configuration but guessed. Also, I saw that the usage of leadingCharacter is very limited in the image and I'd say that most of the time we would not be using it: we will be using unicode. I proposed in the issue tracker a change in three steps that cleans up this: - Cleaning Locale's API ( https://pharo.fogbugz.com/f/cases/16379/Cleanup-Locale-API) - Fix users to make use of this new API ( https://pharo.fogbugz.com/f/cases/16380/Make-use-of-new-Locale-API) - Remove old unused code ( https://pharo.fogbugz.com/f/cases/16381/Removed-unused-Locale-code) I know that with this change we lose temporarily the ability to use other language environments (like greek or japanese), and thus, change to other system encodings that are not UTF8/16/32. However, I believe that we should not 'guess' the system converter from the system language but to ask the system the encoding it is using. And this should maybe be added as a primitive (as the others already existing in the Locale class for example). If somebody could review these issues or has some comment on something that I should not be aware of, I'd be grateful :). Guille

2 4

[pharo-project/pharo-core]
by GitHub Aug. 25, 2015

Aug. 25, 2015

Branch: refs/tags/50269 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] c65815: 50269
by GitHub Aug. 25, 2015

Aug. 25, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: c65815c1b891362831d8c1c36f08e35f7c6d8e12 https://github.com/pharo-project/pharo-core/commit/c65815c1b891362831d8c1c3… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-25 (Tue, 25 Aug 2015) Changed paths: M RecentSubmissions.package/RecentMessageList.class/instance/userinterface/open.st M Refactoring-Critics.package/RBModifiesCollectionRule.class/instance/private/modifiesTree_in_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50268.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50269.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50268.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50269.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/TemporaryVariable.class/instance/comparing/hash.st M Slot.package/TemporaryVariable.class/instance/properties/ensureProperties.st M Slot.package/TemporaryVariable.class/instance/properties/removePropertiesIfEmpty.st M Spec-Tools.package/MessageBrowser.class/instance/accessing/selectedMethod.st Log Message: ----------- 50269 16131 RBModifiesCollectionRule breaks methods AST when checking https://pharo.fogbugz.com/f/cases/16131 16363 Context menu in Recent Messages broken when empty https://pharo.fogbugz.com/f/cases/16363 16365 Make properties on TemporaryVariable persistent https://pharo.fogbugz.com/f/cases/16365 16364 Typo in Recent message browser title https://pharo.fogbugz.com/f/cases/16364 http://files.pharo.org/image/50/50269.zip

1 0

[Issue Tracker] reviews needed
by Marcus Denker Aug. 25, 2015

Aug. 25, 2015

Hi, There are 9 fixed issues that need to be reviewed: https://pharo.fogbugz.com/f/filters/36/Fixed-to-Review Marcus

1 0

[pharo-project/pharo-core] 0fcec8: 50268
by GitHub Aug. 25, 2015

Aug. 25, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 0fcec817446e17a206d940cb67ae2d138df16bb4 https://github.com/pharo-project/pharo-core/commit/0fcec817446e17a206d940cb… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-25 (Tue, 25 Aug 2015) Changed paths: M Ring-Monticello.package/extension/RGMethodDefinition/instance/sameAsMCDefinition_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50267.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50268.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50267.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50268.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50268 16358 Can not commit three changed method to class TemporaryVariable https://pharo.fogbugz.com/f/cases/16358 http://files.pharo.org/image/50/50268.zip

2 1

Strange Monticello bug: methods are not saved
by Marcus Denker Aug. 25, 2015

Aug. 25, 2015

Hi, I have a *very* strange bug. I am trying to add change these three methods in class âTemporaryVariableâ: (I copy the new version): ensureProperties method saveTemp: self. ^ Properties at: self ifAbsentPut: WeakKeyDictionary new removePropertiesIfEmpty ^ Properties at: self ifPresent: [ :dict | dict ifEmpty: [ method removeSavedTemp: self. Properties removeKey: self ] ] hash ^ (name hash bitXor: method hash) bitXor: (startpc ifNil: 0) Now when I save the MC package, these changes are *not* saved, even though when I diff against the repository of Pharo5, they are shown as different. The only special things I did is to move TemporaryVariable to a new tag some updates ago. And I had extension methods in *slot where the same thing happened, but that was fixed by putting them into *Slot. This looks like some wired RPackage problem. But the RPackage seems to correctly know TemporaryVariable and these three selectors as local from the package Slot. I really have no idea what the problem could be. Marcus

7 27

[pharo-project/pharo-core]
by GitHub Aug. 25, 2015

Aug. 25, 2015

Branch: refs/tags/50268 Home: https://github.com/pharo-project/pharo-core

1 0

Stability of configurations
by HernÃ¡n Morales Durand Aug. 25, 2015

Aug. 25, 2015

I would like to know your opinion on the following issue: Some supposedly stable published configurations are not loading properly. I read once Stef or someone else commented about validating configurations. I agree completely with such idea because guarantees quality. For example I tried to load Chalten stable (.13) in Pharo 4 and a modal window display this message: This package depends on the following classes: MinusInfinityClassTest ArithmeticObjectIntervalTest InfinityClassTest You must resolve these dependencies before you will be able to load these definitions: testAsTimeSpan testDaysMeasure testDaysMeasure So, the package is stable but not its configuration? Is this issue on the table for Pharo 5? HernÃ¡n

1 0

[pharo-project/pharo-core] 6e5dad: 50267
by GitHub Aug. 24, 2015

Aug. 24, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 6e5dad7eb6771d49eabe5009bb2725f5add6e959 https://github.com/pharo-project/pharo-core/commit/6e5dad7eb6771d49eabe5009… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-24 (Mon, 24 Aug 2015) Changed paths: R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50266.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50267.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50266.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50267.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50267 16358 Can not commit three changed method to class TemporaryVariable https://pharo.fogbugz.com/f/cases/16358 http://files.pharo.org/image/50/50267.zip

2 1

[pharo-project/pharo-core]
by GitHub Aug. 24, 2015

Aug. 24, 2015

Branch: refs/tags/50267 Home: https://github.com/pharo-project/pharo-core

1 0