January 2014 - Pharo-dev - lists.pharo.org

fun with update:
by Pharo4Stef Jan. 25, 2014

Jan. 25, 2014

During my analysis of update: methods (I started to extract conditional leaves : simple refactoring no change) and I found the following We are lucky because this is SimpleHierarchicalListMorph and I prefer not to think about ComplexHierarchicalListâ¦ update: aSymbol aSymbol == getSelectionSelector ifTrue: [self selection: self getCurrentSelectionItem. ^self]. aSymbol == getListSelector ifTrue: [self list: self getList. ^self]. ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == getListSelector and: [ aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" ifTrue: [^(scroller submorphs at: 1 ifAbsent: [^self]) openPath: (aSymbol allButFirst: 2)]. ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == getListSelector and: [ aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" ifTrue: [^(scroller submorphs at: 1 ifAbsent: [^self]) openItemPath: (aSymbol allButFirst: 2)]. ((aSymbol isKindOf: Array) and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) ifTrue: [^(scroller submorphs at: 1 ifAbsent: [^self]) openPath: aSymbol allButFirst]. ((aSymbol isKindOf: Array) and: [aSymbol size = 2 and: [aSymbol first = getListSelector and: [ aSymbol second == #expandRoots]]]) ifTrue: [^self expandRoots]. ((aSymbol isKindOf: Array) and: [aSymbol notEmpty and: [aSymbol first = getListSelector and: [ aSymbol second == #expandAll]]]) ifTrue: [^self expandAll]

1 0

HandMorph ShowEvents
by Sean DeNigris Jan. 25, 2014

Jan. 25, 2014

Is there a reason that the HandMorph class>>showEvents: feature draws directly on the screen instead of opening a Morph? Am I missing a use case, or would it be okay to turn this into a proper Morph?

3 2

more code reviews :)
by Pharo4Stef Jan. 25, 2014

Jan. 25, 2014

Hi marcus I agree with you. Sometimes I look at the code and I cannot help deciding if I would integrate it or not. :) For example the opal or compiler parser changes. Marcus may be we should just go slower. It takes times to have energy to have a look at a change. I would like that we take more time to do code review. May be in the future we should change the way we work: integrate only changes that have got more than two ok? I do not know, what I know is that I want to read the code of the changes I push because I want to slowly learn just by reading (without understanding much) the parts of the system I do not know. This is a gigantic task but I do not see how else we can do to learn. Stef

1 0

TraitComposition equality
by Martin Dias Jan. 25, 2014

Jan. 25, 2014

Hi, I want to determine if a trait composition is different than other, for example: newClass traitComposition = oldClass traitComposition But I didn't find an implementation. I imagine the simple implementation that checks that all of its components are equal recursively. The components are instances of either Trait, TraitAlias or TraitExclusion, and it should be simple to define = on each of them. Do experts on traits agree? I can open an issue and propose a slice. This arose when looking into issue 12157, where the problem is that ClassModifiedClassDefinition is always announced because the trait composition *may* have changed. This way, ClassModifiedClassDefinition is announced even when it was a class creation. We could also workaround the lack of trait composition equality by comparing their 'asString's... Bests, MartÃn

6 10

Re: [Pharo-dev] problems with RPackage and cie...
by Stephan Eggermont Jan. 25, 2014

Jan. 25, 2014

Esteban wrote: >I would really like a reproducible caseâ¦ in the form of an image, if no else. > >btwâ¦ moose 5.0 images are severely broken in that area, so if you are using one of them you *will* have problems. I can deny that it is a Moose problem, I can reproduce it in Pharo 30716 on mac Open the image, open a Nautilus browser Add new package AZ Select AST-Core, Nodes Select RBProgramNode Copy the class with right-click menu Rename to AZProgramNode Enter your name (should have happened when creating the new package!) Drag AZProgramNode to AZ Category is not updated. Stephan

2 1

Font chooser broken (12704)
by Nicolai Hess Jan. 25, 2014

Jan. 25, 2014

Sean, can you look at my latest submission for 12704. There were some types in your slice := instead of = or each value: aBlock instead of aBlock value:each And an error with Announcements for FontChooser that were sent to the PluggableListMorph too. nicolai

3 3

Re: [Pharo-dev] execute external command?
by Torsten Bergmann Jan. 25, 2014

Jan. 25, 2014

3 2

Re: [Pharo-dev] issue 12506 Vm crashes vm when testing updates [A-L]
by Nicolai Hess Jan. 25, 2014

Jan. 25, 2014

2014/1/6 Marcus Denker <marcus.denker(a)inria.fr> > > On 06 Jan 2014, at 00:58, Nicolai Hess <nicolaihess(a)web.de> wrote: > > These are the minimal steps I can use to reproduce the crash > take the 30663 image > running tests A-L -> no crash > open the image and execute: > > ScriptLoader new unloadPackage: 'Athens-Tutorial'. "<-- one part of 30664 > update" > HashedCollection cleanUp:true. "<-- one part of Smalltalk cleanUp:true" > > running tests A-L -> CRASH > > > Hmm... > > > 2014/1/5 Nicolai Hess <nicolaihess(a)web.de> > >> How about this: >> Take a 30663 image, apply all updates, recompile and cleanup. >> >> btw what exactly does a "Do Image Cleanup" (from system menu)? >> Is it the same as "Smalltalk cleanup"? >> >> > It is âSmalltalk cleanUp: trueâ > (so it does a bit more, e.g. resetting change sets) > > Marcus > I don't know if it is since the lates NB changes, but running all A-L tests works again. Tested on Linux: pharo --nodisplay Pharo-30719.image test --junit-xml-output '^[A-L].*' -> no crash

1 0

execute external command?
by Johan Brichau Jan. 25, 2014

Jan. 25, 2014

Hi list, In another thread, Sven pointed me to the environment variables access from within Pharo3 (using Smalltalk os environment). This already eliminates one use case we have for OSProcess, but I fail to find a replacement for the other one: invoking external commands. So, my question: is OSProcess the only way to perform an external command from within Pharo3 ? thanks for the info Johan

1 0

asReactiveVariable ????
by Pharo4Stef Jan. 24, 2014

Jan. 24, 2014

Hi guys, I think that we will rename all the asReactiveVariable that got introduced into their old name asValueHolder. And we will rename the class too to its old name. Why? I think that we should not change at the last moment ValueHolder into ReactiveVariable even if the name could be better: - First there are books around (and not only mine) that use this vocabulary for decades. - Second all the Spec tools developed by people right now do not work in latest 3.0. - I think that this change does not worth the noise it introduced: all the future changes of Spec-based tools that will be using asReactive will not work in Pharo3.0. We are in beta and now we should not change that. Then I would appreciate that we discuss it before. Because I would not change that even between versions of Pharo. Stef

3 2