Font chooser broken (12704)
Sean, can you look at my latest submission for 12704. There were some types in your slice := instead of = or each value: aBlock instead of aBlock value:each And an error with Announcements for FontChooser that were sent to the PluggableListMorph too. nicolai
Nicolai Hess wrote
Sean, can you look at my latest submission for 12704.
It looks good. I made a few more small changes. Check my new slice⦠in the future I think we make a new issue with fixes to previously integrated fixes to keep things clear... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Font-chooser-broken-12704-tp4739230p4739234.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
2014/1/25 Sean P. DeNigris <sean@clipperadams.com>
Nicolai Hess wrote
Sean, can you look at my latest submission for 12704.
It looks good. I made a few more small changes. Check my new slice⦠in the future I think we make a new issue with fixes to previously integrated fixes to keep things clear...
----- Cheers, Sean -- View this message in context: http://forum.world.st/Font-chooser-broken-12704-tp4739230p4739234.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Ok.
Thanks. Doing is accepting that we can make mistakes. I really like that you looked at my changes. I spent some times with Alain trying to spot my mistakes (because I had a broken version of my changes). So thank you guys. This is cool to know that they are people that have a look at what we are doing. It is not easy to work on code that we do not write and something fully understand. Stef On 25 Jan 2014, at 09:14, Nicolai Hess <nicolaihess@web.de> wrote:
2014/1/25 Sean P. DeNigris <sean@clipperadams.com> Nicolai Hess wrote
Sean, can you look at my latest submission for 12704.
It looks good. I made a few more small changes. Check my new slice⦠in the future I think we make a new issue with fixes to previously integrated fixes to keep things clear...
----- Cheers, Sean -- View this message in context: http://forum.world.st/Font-chooser-broken-12704-tp4739230p4739234.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Ok.
participants (3)
-
Nicolai Hess -
Pharo4Stef -
Sean P. DeNigris