July 2013 - Pharo-dev - lists.pharo.org

About abuse of inheritance
by Igor Stasenko July 22, 2013

July 22, 2013

I just stumbled upon this: Announcer subclass: #TxEditor .... This is just plain wrong, as wrong as: Shampoo subclass: #Shower because every time you treat inheritance as something else as _specialization_ you doing it wrong. Inheritance is not about importing needed functionality, it should be about specialization and only about it: - a superclass provides generic functionality, while subclasses providing more and more specialized forms of it. Because if we don't follow that, then it is really hard to see and follow a structure in design.. it is just random. And here's why: so since shower uses shampoo, as we concluded, then why not including it via inheritance: Shampoo subclass: #Shower but then, Shower also uses Soap, so maybe it should be like that: Soap subclass: #Shower so, which superclass you prefer most? And how do you pick/prioritize which element should be a superclass of Shower? To solve this dilemma, i think we will need multiple inheritance: (Shampoo, Soap) subclass: #Shower but thankfully, we don't have it in classic smalltalk model :) So, then maybe it should be something like that: Object subclass: #Shower instanceVariableNames: 'soap shampoo' ... Anyways, despite the obvious abuses, i'd like to ask community, in what cases , you think (ab)using inheritance in a way like above is justified? Because maybe it is i, who doing it wrong? -- Best regards, Igor Stasenko.

10 38

[regression reporter]regression occurred
by no-reply＠ci.inria.fr July 22, 2013

July 22, 2013

https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2-Validation/label=win/… 1 regressions found. KernelTests.Classes.ClassHierarchyTest.testSubclasses

1 0

[regression reporter]regression occurred
by no-reply＠ci.inria.fr July 22, 2013

July 22, 2013

https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2-Validation/label=mac/… 1 regressions found. KernelTests.Classes.ClassHierarchyTest.testSubclasses

1 0

[regression reporter]regression occurred
by no-reply＠ci.inria.fr July 22, 2013

July 22, 2013

https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2-Validation/label=linu… 1 regressions found. KernelTests.Classes.ClassHierarchyTest.testSubclasses

1 0

[update 3.0] #30292
by Marcus Denker July 22, 2013

July 22, 2013

30292 ----- 11211 clean up Watery2 theme https://pharo.fogbugz.com/f/cases/11211 11206 clean up externalInterrupt in old Debugger https://pharo.fogbugz.com/f/cases/11206 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1190.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Polymorph-Widgets-MarcusDenke…

1 0

opal bug with the old debugger
by Andrei Vasile Chis July 22, 2013

July 22, 2013

Hi, Executing '1 haba' in a workspace and then choosing create method from the pre debug window leads to this exception: UndefinedObject(Object)>>doesNotUnderstand: #methodOrBlockNode If instead I choose to debug, select the top context of the stack and the press the 'Creare method' button a different exception is thrown: UndefinedObject(Object)>>doesNotUnderstand: #debugHighlightRange In both cases the method is created. So known or unknown issue? Also it doesn't seem to happen with the new debugger. Not sure why :) Andrei

3 5

[update 3.0] #30290
by Marcus Denker July 22, 2013

July 22, 2013

30290 ----- 10393 Add RPackageSet cache https://pharo.fogbugz.com/f/cases/10393 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/RPackage-Core-MarcusDenker.24… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Monticello-MarcusDenker.839.d… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Metacello-Platform.pharo20-Ma…

4 3

[update 3.0] #30291
by Marcus Denker July 22, 2013

July 22, 2013

30291 ----- 4533 UIThemeWatery and UIThemeWatery2 should be merged... https://pharo.fogbugz.com/f/cases/4533 11207 clean up some dead code in FileContentsBrowser https://pharo.fogbugz.com/f/cases/11207 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1189.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Polymorph-Widgets-MarcusDenke…

1 0

[NB]: Review & fixes & ideas
by Igor Stasenko July 22, 2013

July 22, 2013

Hi, there , i've been working last two weeks on reviewing the code in NB, and update configuration & making tests green etc.. So, here the summary: 0. New stuff: external structures (NBExternalStructure) now is normal objects (not var-byte ones), and using 'data' ivar indirection like in NBExternalArray, so you can allocate external struct on both external heap and object memory, e.g.: struct := MyStructClass externalNew. or: struct := MyStructClass new. (so, it is similar to NBExternalArray). - a function with signature MyStruct * foo () which returns a pointer to struct, now will return an instance of MyStruct with the address, so you can use it directly , e.g.: struct := self callFoo. value := struct field1. struct field2: 10 etc.. Thanks to Ciprian for introducing the change. I just polished a bit and fixed some mistakes. 1. NBExternalTypeValue>>address should not exist. You simply cannot use freely an address to object's internal field because object can move in memory. (the tests in NBFFIExternalValueTests testOutIntArg testOutValueArg testOutVoidArg is changed accordingly) 2. In NBExternalEnumerationType: pushing a pointer to this type is not allowed, since it makes no sense. But the mistake there was to generate a code which fails primitive with an error message, instead of failing much much sooner - at code generation stage, since it is already known that user specified wrong type. 3. I reverting generic pushAsPointer: to accept varbyte objects instead of just ByteArray object. - removing #specialPush:asPointer:endLabel: because it will be not used (btw, in NBExternalStructureType>>specialPush:asPointer:endLabel: , there was same mistake that it generates code to checking a pointer arity at runtime, while it is already known during code generation time: asm decorateWith: 'arity checking' during: [ |pointerArityOk| pointerArityOk := asm uniqueLabelName: 'pointerArityOk'. asm mov: pointerArity asImm32 to: asm EAX; cmp: asm EAX with: 1 asImm32; je: pointerArityOk. gen failWithMessage: 'Arity ', pointerArity printString,' not allowed for ', objectClass name, 'objects'. asm label: pointerArityOk]. since pointerArity is known, the produced code will be something like: mov: 1 to: EAX; cmp: EAX with: 1; je: pointerArityOk and makes no sense, because again it can just throw the error at code generation time. 4. Added code to capture argument names (CompiledMethod>>nbArgumentNames) and 'NativeBoost prepareForProduction', to ensure NB can work without source code accessible. 5. But the general expression, like in (1): object address gave me an interesting idea: what if we introduce a special type, say NBObjectFieldAddress. Consider the following problem: imagine that you have a big array in object memory (byte array), and you want to pass a pointer to n-th element of that array to some function. Right now, there is no way how you can do it, and you can pass only a pointer to array itself (which means it will always point to its first element). So, the idea is to introduce a special type, and special object which represents the address-of-object's-field, so you can tell: array := ByteArray new: 1000. address := array nbAddressAt: 500. "create an address object which points to 500th element of given array" (and expression 'array nbAddress' is synonym to 'array nbAddressAt: 1'). self callSomeFunctionWith: address. The signature of C function which takes a pointer like: void foo (void * ptr) then should be changed to: void foo (NBObjectFieldAddress ptr) the only question, which remains , shall it use strict type checking (so you have to change the signature), or allow to use such objects with any signatures which takes a pointer to something, e.g. extend generic NBExternalType>>pushAsPointer: to additionally check if incoming argument is instance of NBObjectFieldAddress class. P.S. to try new config , load it: Gofer new smalltalkhubUser: 'Pharo' project: 'NativeBoost'; configuration; load. ConfigurationOfNativeBoost loadDevelopment. "which should load 2.2 version of it" -- Best regards, Igor Stasenko.

4 7

Nautilus running tests and expected failures
by Holger Hans Peter Freyther July 22, 2013

July 22, 2013

Hi, I used Nautilus to browse some code and make myself familiar with a foriegn codebase. I inserted some code and pressed the button in the browser to execute the test. The button turned green, I got the test finished notification but my code was not executed. It took me a bit to figure out that this test is in the expected failure list and only by stepping through the exception handling and looking at the 'TestResult' returned from TestResult>>#runTest. Is there any color (not equal to green) that could be used to indicate expected failures? kind regards holger

1 0