December 2009 - Pharo-dev - lists.pharo.org

[Pharo-project] [update 1.1] #11113
by StÃ©phane Ducasse Dec. 25, 2009

Dec. 25, 2009

11113 ----- - Issue 1681: change default font -- Issue 1550: Make Bitmap DejaVu as default fonts in 1.1 - Issue 1660: SortBlock and sort L. Uzonyi . S. Ducasse - Issue 1647: Fix FixAndTesstForAdditionalMethodStateAtPut - A. Raab - Issue 1675: Change FixedIdentitySet behaviour wrt silently ignoring collisions and fullness - Issue 1676: change QuickIntegerDictionary superclass Stef

1 0

[Pharo-project] Preferences left over..... a Question
by StÃ©phane Ducasse Dec. 25, 2009

Dec. 25, 2009

Alain stan proposed in http://code.google.com/p/pharo/issues/detail?can=2&q=1679 to change (Smalltalk at: #Preferences ifAbsent: []) ifNotNil: [:oldPrefClass | (oldPrefClass allPreferenceObjects select: [:pref | pref changeInformee = Sensor class]) do: [:pref | pref changeInformee: newSensor class]]. into (Preferences allPreferenceObjects select: [:pref | pref changeInformee = Sensor class]) do: [:pref | pref changeInformee: newSensor class]. in installEventSensorFramework: fetcherClass But it seems to me that there is probably a better solution. installEventSensorFramework: fetcherClass "Installs the new sensor framework." "InputEventSensor installEventSensorFramework: InputEventPollingFetcher" | newSensor | "Do some extra cleanup" {InputEventFetcher. InputEventPollingFetcher. } do: [:oldSensorClass | Smalltalk removeFromShutDownList: oldSensorClass. Smalltalk removeFromStartUpList: oldSensorClass]. InputEventFetcher deinstall. newSensor := self new. fetcherClass install. newSensor registerIn: InputEventPollingFetcher default. "Shut down old sensor" Sensor shutDown. Smalltalk removeFromShutDownList: Sensor class. Smalltalk removeFromStartUpList: Sensor class. (Smalltalk at: #Preferences ifAbsent: []) ifNotNil: [:oldPrefClass | (oldPrefClass allPreferenceObjects select: [:pref | pref changeInformee = Sensor class]) do: [:pref | pref changeInformee: newSensor class]]. "Note: We must use #become: here to replace all references to the old sensor with the new one, since Sensor is referenced from all the existing controllers." Sensor becomeForward: newSensor. "done" "Register the interrupt handler" UserInterruptHandler new registerIn: InputEventFetcher default. Smalltalk addToStartUpList: Sensor class after: fetcherClass. Smalltalk addToShutDownList: Sensor class after: Form. "Project spawnNewProcessAndTerminateOld: true"

1 0

[Pharo-project] From The Trunk: SLICE-MethodDictionaryTest
by Alexandre Bergel Dec. 25, 2009

Dec. 25, 2009

Name: SLICE-MethodDictionaryTest-AlexandreBergel.1 Author: TestRunner Time: 25 December 2009, 9:29:13 am UUID: 2170f234-8a10-49e6-9c0a-6ce0ad27f70f Ancestors: Dependencies: Kernel-TestRunner.521, KernelTests-TestRunner.180 ISSUE #1683 Pharo image: Pharo-core Pharo core version: 11112 SLICE-MethodDictionaryTest-Alexandre_Bergel.1 in the inbox fixes what is proposed by Nicolas. It also defines a class MethodDictionaryTest in the class category: KernelTests-Methods. MethodDictionaryTest uses some traits defined by Cyrille. This is really cool! It permitted to find a bug in MethodDictionary (removes removeKey:ifAbsent: should return the value that has been removed). MethodDictionaryTest has 21 green tests. Before loading the SLICE: 7320 run, 7272 passes, 20 expected failures, 12 failures, 16 errors, 0 unexpected passes After loading the SLICE: 7341 run, 7293 passes, 19 expected failures, 12 failures, 16 errors, 1 unexpected passes Unfortunately, I was not able to find the unexpected pass. Apparently, running twice the unit tests have different results. The description of the issue in Trunk follows: Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.343.mcz ==================== Summary ==================== Name: Kernel-nice.343 Author: nice Time: 24 December 2009, 10:22:02 am UUID: 155bf515-f41c-bc40-9dad-f98c01dfce8d Ancestors: Kernel-nice.342 Smalltalk commandments #7: 'Thu shalt not invoke super when self could do the job' =============== Diff against Kernel-nice.342 =============== Item was changed: ----- Method: MethodDictionary>>includesKey: (in category 'accessing') ----- includesKey: aSymbol "This override assumes that pointsTo is a fast primitive" aSymbol ifNil: [^ false]. + ^ self pointsTo: aSymbol! - ^ super pointsTo: aSymbol! -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

2 1

[Pharo-project] Fonts
by Schwab,Wilhelm K Dec. 25, 2009

Dec. 25, 2009

Hello all, I just looked at the 12.2 web image, and noted that the Fonts directory is gone, but the anti-aliased fonts appear to be working. Is there simple summary of the relevant changes and what they imply for the end user? It looks like good things have happened, but what? Lukas, are your build scripts on the Wiki updated for the changes? Bill

2 4

[Pharo-project] about displayString
by StÃ©phane Ducasse Dec. 24, 2009

Dec. 24, 2009

Hi I would really like that we introduce displayString to keep printOn: for internal purpose. Igor I remember that you got a proposal about that. Do you remember? Stef

2 1

[Pharo-project] Search squeaksource for all senders of a method?
by Adrian Kuhn Dec. 24, 2009

Dec. 24, 2009

I would like search squeaksource for all senders of a method. How could this be done? How would I approach doing this? --AA

4 6

Re: [Pharo-project] Search squeaksource for all senders of a method?
by Dale Henrichs Dec. 24, 2009

Dec. 24, 2009

It has been on the todo list for quite awhile ... I'm just getting around to getting the most recent SqueakSource running in GemStone ... the GemSource instance is still running the Seaside2.6 version:) For GemStone, the mcz files are stored in a Dictionary in the repository. Something to look forward to in the new year? Dale ----- "Lukas Renggli" <renggli(a)gmail.com> wrote: | It is on the nice-to-have list since the beginning (5 years). | Unfortunately there is currently no index and searching 7 GB of | compressed versions is not practically feasible either. | | Maybe the GemStone version has a solution to that? AFAIK they keep | the | versions all in the stone and could easily index the internal data. | | Lukas | | -- | Lukas Renggli | http://www.lukas-renggli.ch | | _______________________________________________ | Pharo-project mailing list | Pharo-project(a)lists.gforge.inria.fr | http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

1 0

[Pharo-project] Fwd: [squeak-dev] The Trunk: Traits-nice.248.mcz
by Nicolas Cellier Dec. 24, 2009

Dec. 24, 2009

For Trait experts only. ---------- Forwarded message ---------- From: <commits(a)source.squeak.org> Date: 2009/12/24 Subject: [squeak-dev] The Trunk: Traits-nice.248.mcz To: squeak-dev(a)lists.squeakfoundation.org, packages(a)lists.squeakfoundation.org Nicolas Cellier uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-nice.248.mcz ==================== Summary ==================== Name: Traits-nice.248 Author: nice Time: 24 December 2009, 11:49:10 am UUID: 557593d7-1db7-2347-bf40-2d40e3b91f55 Ancestors: Traits-nice.247 Move FixedIdentitySet off the Array hierarchy. Provide a fast implementation using MethodDictionary tricks - handles collisions (instead of blindly ignoring the entry) - eventually grow. I did not understand previous design decision... The conflict just did happen (I put a halt: and caught one in Object...) According to my own scale, make it work > make it fast. Rationale about the new design: #grow costs, but I think it is user responsibility to fix a reasonnable capacity. collisions handling should not cost much (except above 4096 entries) If any expert knowing the reasons for this class and knowing how to fire the profiling tests could have a look, thanks... =============== Diff against Traits-nice.247 =============== Item was changed: + Collection variableSubclass: #FixedIdentitySet + Â Â Â instanceVariableNames: 'tally capacity hashShift' - Array variableSubclass: #FixedIdentitySet - Â Â Â instanceVariableNames: 'tally capacity' Â Â Â Â classVariableNames: '' Â Â Â Â poolDictionaries: '' Â Â Â Â category: 'Traits-Requires'! + !FixedIdentitySet commentStamp: 'nice 12/24/2009 11:46' prior: 0! + This is a fast implementation of fixed size identity sets. + Same algorithm as MethodDictionary are used, and thus FixedIdentitySet is to IdentitySet what MethodDictionary is to IdentityDictionary. + The main features are: + 1) do not use an array instance variable so as to fast-up creation and every access + 2) due to the fixed allocated size, growing costs an expensive #become: operation. Preallocate me with care. + 3) my size is a power of two so the the hashing algorithm be most efficient. + 4) for maximum random access efficiency, at least half the storage area is always kept empty - !FixedIdentitySet commentStamp: 'NS 5/26/2005 13:00' prior: 0! - This is a fast but lazy implementation of fixed size identity sets. The two main difference to regular identity sets are: - - 1) These identity sets have a fixed size. If they are full, adding another element doesn't have any effect. - 2) No rehashing. If two elements were to be stored on the same position in the underlying array, one of them is simply discarded. + Unlike MethodDictionary, this class will scale a bit better over the 4096 basicSize limit inherent to identityHash, thanks to a proper bitShift.! - As a consequence of (1) and (2), these identity sets are very fast!! Note that this class inherits form Array. This is not clean but reduces memory overhead when instances are created.! Item was added: + ----- Method: FixedIdentitySet>>removeAll (in category 'removing') ----- + removeAll + Â Â Â tally = 0 ifTrue: [^self]. + Â Â Â 1 to: self basicSize do: [:i | self basicAt: i put: nil]. + Â Â Â tally := 0! Item was changed: + ----- Method: FixedIdentitySet>>add: (in category 'adding') ----- - ----- Method: FixedIdentitySet>>add: (in category 'accessing') ----- Â add: anObject + Â Â Â | index | + Â Â Â index := self scanFor: anObject. + Â Â Â (self basicAt: index) + Â Â Â Â Â Â Â ifNil: [ + Â Â Â Â Â Â Â Â Â Â Â self basicAt: index put: anObject. + Â Â Â Â Â Â Â Â Â Â Â tally := tally + 1. + Â Â Â Â Â Â Â Â Â Â Â self isFull ifTrue: [ self grow ]] + Â Â Â Â Â Â Â "ifNotNil: [] already inside". + Â Â Â ^anObject! - Â Â Â | index old | - Â Â Â self isFull ifTrue: [^ false]. - Â Â Â index := self indexOf: anObject. - Â Â Â old := self basicAt: index. - Â Â Â old == anObject ifTrue: [^ true]. - Â Â Â old ifNotNil: [^ false]. - Â Â Â self basicAt: index put: anObject. - Â Â Â tally := tally + 1. - Â Â Â ^ true! Item was changed: + ----- Method: FixedIdentitySet>>addAll:notIn: (in category 'adding') ----- - ----- Method: FixedIdentitySet>>addAll:notIn: (in category 'accessing') ----- Â addAll: aCollection notIn: notCollection Â Â Â Â aCollection do: [:each | - Â Â Â Â Â Â Â self isFull ifTrue: [^ self]. Â Â Â Â Â Â Â Â (notCollection includes: each) ifFalse: [self add: each]. Â Â Â Â ].! Item was changed: Â ----- Method: FixedIdentitySet class>>with:with:with:with:with: (in category 'instance creation') ----- Â with: firstObject with: secondObject with: thirdObject with: fourthObject with: fifthObject Â Â Â Â "Answer an instance of me, containing the five arguments as the elements." + Â Â Â ^ (self new: 5) - Â Â Â ^ self new Â Â Â Â Â Â Â Â add: firstObject; Â Â Â Â Â Â Â Â add: secondObject; Â Â Â Â Â Â Â Â add: thirdObject; Â Â Â Â Â Â Â Â add: fourthObject; Â Â Â Â Â Â Â Â add: fifthObject; Â Â Â Â Â Â Â Â yourself! Item was changed: Â ----- Method: FixedIdentitySet class>>with:with:with:with:with:with: (in category 'instance creation') ----- Â with: firstObject with: secondObject with: thirdObject with: fourthObject with: fifthObject with: sixthObject Â Â Â Â "Answer an instance of me, containing the six arguments as the elements." + Â Â Â ^ (self new: 6) - Â Â Â ^ self new Â Â Â Â Â Â Â Â add: firstObject; Â Â Â Â Â Â Â Â add: secondObject; Â Â Â Â Â Â Â Â add: thirdObject; Â Â Â Â Â Â Â Â add: fourthObject; Â Â Â Â Â Â Â Â add: fifthObject; Â Â Â Â Â Â Â Â add: sixthObject; Â Â Â Â Â Â Â Â yourself! Item was changed: + ----- Method: FixedIdentitySet class>>new (in category 'instance creation') ----- - ----- Method: FixedIdentitySet class>>new (in category 'constants') ----- Â new Â Â Â Â ^ self new: self defaultSize! Item was added: + ----- Method: FixedIdentitySet>>grow (in category 'private') ----- + grow + Â Â Â | newSelf | + Â Â Â newSelf := self species new: capacity * 2. Â "This will double the capacity" + Â Â Â self do: [ :anObject | newSelf add: anObject ]. + Â Â Â self become: newSelf! Item was changed: + ----- Method: FixedIdentitySet>>includes: (in category 'testing') ----- + includes: aSymbol + Â Â Â "This override assumes that pointsTo is a fast primitive" + + Â Â Â aSymbol ifNil: [^ false]. + Â Â Â ^ self pointsTo: aSymbol! - ----- Method: FixedIdentitySet>>includes: (in category 'accessing') ----- - includes: anObject - Â Â Â ^ (self basicAt: (self indexOf: anObject)) == anObject! Item was added: + ----- Method: FixedIdentitySet>>fixCollisionsFrom: (in category 'private') ----- + fixCollisionsFrom: start + Â Â Â "The element at start has been removed and replaced by nil. + Â Â Â This method moves forward from there, relocating any entries + Â Â Â that had been placed below due to collisions with this one." + + Â Â Â | key index mask | + Â Â Â index := start. + Â Â Â mask := self basicSize - 1. + Â Â Â [ (key := self basicAt: (index := (index bitAnd: mask) + 1)) == nil ] whileFalse: [ + Â Â Â Â Â Â Â | newIndex | + Â Â Â Â Â Â Â (newIndex := self scanFor: key) = index ifFalse: [ + Â Â Â Â Â Â Â Â Â Â Â | element | + Â Â Â Â Â Â Â Â Â Â Â element := self basicAt: index. + Â Â Â Â Â Â Â Â Â Â Â self basicAt: index put: (self basicAt: newIndex). + Â Â Â Â Â Â Â Â Â Â Â self basicAt: newIndex put: element.] ]! Item was changed: + ----- Method: FixedIdentitySet class>>new: (in category 'instance creation') ----- - ----- Method: FixedIdentitySet class>>new: (in category 'constants') ----- Â new: anInteger + Â Â Â ^ (self basicNew: (self arraySizeForCapacity: anInteger)) initializeCapacity: anInteger! - Â Â Â ^ (super new: (self arraySizeForCapacity: anInteger)) initializeCapacity: anInteger! Item was changed: + ----- Method: FixedIdentitySet>>remove:ifAbsent: (in category 'removing') ----- - ----- Method: FixedIdentitySet>>remove:ifAbsent: (in category 'accessing') ----- Â remove: anObject ifAbsent: aBlock + Â Â Â | index element | + Â Â Â index := self scanFor: anObject. + Â Â Â (element := self basicAt: index) ifNil: [ ^aBlock value ]. + Â Â Â self basicAt: index put: nil. + Â Â Â tally := tally - 1. + Â Â Â self fixCollisionsFrom: index. + Â Â Â ^element! - Â Â Â | index | - Â Â Â index := self indexOf: anObject. - Â Â Â ^ (self basicAt: index) == anObject - Â Â Â Â Â Â Â ifTrue: [self basicAt: index put: nil. tally := tally - 1. anObject] - Â Â Â Â Â Â Â ifFalse: [aBlock value].! Item was added: + ----- Method: FixedIdentitySet>>rehash (in category 'private') ----- + rehash + Â Â Â | newSelf | + Â Â Â newSelf := self species new: self size. + Â Â Â self do: [ :anObject | newSelf add: anObject ]. + Â Â Â ^newSelf! Item was changed: Â ----- Method: FixedIdentitySet>>initializeCapacity: (in category 'initialize-release') ----- Â initializeCapacity: anInteger Â Â Â Â tally := 0. + Â Â Â capacity := anInteger. + Â Â Â hashShift := self basicSize highBit - 4096 highBit max: 0! - Â Â Â capacity := anInteger.! Item was changed: + ----- Method: FixedIdentitySet class>>arraySizeForCapacity: (in category 'private') ----- - ----- Method: FixedIdentitySet class>>arraySizeForCapacity: (in category 'constants') ----- Â arraySizeForCapacity: anInteger Â Â Â Â "Because of the hash performance, the array size is always a power of 2 Â Â Â Â and at least twice as big as the capacity anInteger" Â Â Â Â ^ anInteger <= 0 Â Â Â Â Â Â Â Â ifTrue: [0] Â Â Â Â Â Â Â Â ifFalse: [1 << (anInteger << 1 - 1) highBit].! Item was added: + ----- Method: FixedIdentitySet>>scanFor: (in category 'private') ----- + scanFor: anObject + Â Â Â "Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements." + + Â Â Â | index start mask | + Â Â Â anObject ifNil: [self error: 'This class collection cannot handle nil as an element']. + Â Â Â mask := self basicSize - 1. + Â Â Â index := start := ((anObject identityHash bitShift: hashShift) bitAnd: mask) + 1. + Â Â Â [ + Â Â Â Â Â Â Â | element | + Â Â Â Â Â Â Â ((element := self basicAt: index) == nil or: [ element == anObject ]) + Â Â Â Â Â Â Â Â Â Â Â ifTrue: [ ^index ]. + Â Â Â Â Â Â Â (index := (index bitAnd: mask) + 1) = start ] whileFalse. + Â Â Â self errorNoFreeSpace! Item was removed: - ----- Method: FixedIdentitySet>>destructiveAdd: (in category 'accessing') ----- - destructiveAdd: anObject - Â Â Â | index old | - Â Â Â self isFull ifTrue: [^ false]. - Â Â Â index := self indexOf: anObject. - Â Â Â old := self basicAt: index. - Â Â Â self basicAt: index put: anObject. - Â Â Â old ifNil: [tally := tally + 1]. - Â Â Â ^ true! Item was removed: - ----- Method: FixedIdentitySet>>notFull (in category 'testing') ----- - notFull - Â Â Â ^ tally < capacity! Item was removed: - ----- Method: FixedIdentitySet>>addAll: (in category 'accessing') ----- - addAll: aCollection - Â Â Â aCollection do: [:each | - Â Â Â Â Â Â Â self isFull ifTrue: [^ self]. - Â Â Â Â Â Â Â self add: each. - Â Â Â ].! Item was removed: - ----- Method: FixedIdentitySet>>indexOf: (in category 'private') ----- - indexOf: anObject - Â Â Â anObject isNil ifTrue: [self error: 'This class collection cannot handle nil as an element']. - Â Â Â ^ (anObject identityHash bitAnd: self basicSize - 1) + 1!

3 8

[Pharo-project] What are MethodDictionary faults?
by Mariano Martinez Peck Dec. 24, 2009

Dec. 24, 2009

Hi folks: I am trying to understand ImageSegment methods like activeClasses, swapOutInactiveClasses, discoverActiveClasses among others. One of the comments of those methods says: "NOTE: discoverActiveClasses uses Squeak's ability to detect and recover from faults due to a nil method dictionary. It staches the method dict in with the organization during the time when discovery is in progress (Gag me with a spoon). This is why the faults need to be cleared promptly before resuming normal work with the system. It is also important that classes *do not* refer directly to their method dictionary, but only via the accessor message." So, it seems to HACK (it forces a fault) this MD fault recover to discover inactive classes and other things. Ok, forget that hack for a moment. What questions is, what are these faults? Why a method dictionary can be in nil ? How is this produced ? And how is it fixed? I saw for example this: Behaviour>>methodDict methodDict == nil ifTrue: [self recoverFromMDFaultWithTrace]. ^ methodDict But again...how can that be nil ??? Thank you very much. Marian

4 16

[Pharo-project] Vote for Kernel test: (Array allSubclasses size) = 0 [ Was: Re: FixedIdentitySet ... ]
by Igor Stasenko Dec. 24, 2009

Dec. 24, 2009

2009/12/24 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: > 2009/12/23 Martin McClure <martin(a)hand2mouse.com>: >> Nicolas Cellier wrote: >>> >>> While looking at it, FixedIdentitySet asArray ^ self, is this really expected ? >> >> FixedIdentitySet is a very odd beast. I'm afraid I don't see the value >> of it at all, but I haven't looked at the code that uses it. >> >> Regards, >> >> -Martin >> > > Yes, very bad example, only used in traits implementation and should > be considered as private, so who ever use it should learn to not send > asArray, nor any other inherited message but a few. > I suspect inheriting basicAt: basicAt:put: and basicSize: should be > enough, which completely disqualify the choice of superclass, but I > won't bother more. > Anyway, I'm impressed by (Array allSubclasses size), I would expect > zero as a good number. > +1 why its subclassing Array, why not Collection? I propose to vote for putting SUnit test, in Kernel tests: self assert: [ Array allSubclasses size = 0 ]. -- Best regards, Igor Stasenko AKA sig.

2 1