[Pharo-project] From The Trunk: SLICE-MethodDictionaryTest
Name: SLICE-MethodDictionaryTest-AlexandreBergel.1 Author: TestRunner Time: 25 December 2009, 9:29:13 am UUID: 2170f234-8a10-49e6-9c0a-6ce0ad27f70f Ancestors: Dependencies: Kernel-TestRunner.521, KernelTests-TestRunner.180 ISSUE #1683 Pharo image: Pharo-core Pharo core version: 11112 SLICE-MethodDictionaryTest-Alexandre_Bergel.1 in the inbox fixes what is proposed by Nicolas. It also defines a class MethodDictionaryTest in the class category: KernelTests-Methods. MethodDictionaryTest uses some traits defined by Cyrille. This is really cool! It permitted to find a bug in MethodDictionary (removes removeKey:ifAbsent: should return the value that has been removed). MethodDictionaryTest has 21 green tests. Before loading the SLICE: 7320 run, 7272 passes, 20 expected failures, 12 failures, 16 errors, 0 unexpected passes After loading the SLICE: 7341 run, 7293 passes, 19 expected failures, 12 failures, 16 errors, 1 unexpected passes Unfortunately, I was not able to find the unexpected pass. Apparently, running twice the unit tests have different results. The description of the issue in Trunk follows: Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.343.mcz ==================== Summary ==================== Name: Kernel-nice.343 Author: nice Time: 24 December 2009, 10:22:02 am UUID: 155bf515-f41c-bc40-9dad-f98c01dfce8d Ancestors: Kernel-nice.342 Smalltalk commandments #7: 'Thu shalt not invoke super when self could do the job' =============== Diff against Kernel-nice.342 =============== Item was changed: ----- Method: MethodDictionary>>includesKey: (in category 'accessing') ----- includesKey: aSymbol "This override assumes that pointsTo is a fast primitive" aSymbol ifNil: [^ false]. + ^ self pointsTo: aSymbol! - ^ super pointsTo: aSymbol! -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
thanks alex if christmas day let me approach a computer without considering that I'm a bad father I will do that list of updates: Issue 1680: Update Gofer Issue 1681: change default font -- Issue 1550: Make Bitmap DejaVu as default fonts in 1.1 Issue 1679: InputEventSensor refers to defunct class InputSensor Issue 1660: SortBlock Issue 1677: Change QuickStack superclass Issue 1676: change QuickIntegerDictionary superclass Issue 1675: Change FixedIdentitySet behaviour wrt silently ignoring collisions and fullness Issue 1664: Long method can not be compiled using #compile: aString ISSUE #1683 Issue 1214: [Squeak] Collection possible improvements (not sure) first publish the slice Issue 1113: [squeak trunk] Tools-bf.106.mcz - Fix Message Finder problem - bug #7380 -> Issue 1158: System Browser vs Class Browser To close: Issue 1632: Don't accept script files as VM parameter Issue 1607: ProjectLauncher readDocumentAtStartup a setting Issue 1379: Sometimes my author names ends up being "TestRunner" Issue 1624: 1.1#alpha should be renamed to 1.1#unstable On Dec 25, 2009, at 9:40 AM, Alexandre Bergel wrote:
Name: SLICE-MethodDictionaryTest-AlexandreBergel.1 Author: TestRunner Time: 25 December 2009, 9:29:13 am UUID: 2170f234-8a10-49e6-9c0a-6ce0ad27f70f Ancestors: Dependencies: Kernel-TestRunner.521, KernelTests-TestRunner.180
ISSUE #1683
Pharo image: Pharo-core Pharo core version: 11112
SLICE-MethodDictionaryTest-Alexandre_Bergel.1 in the inbox fixes what is proposed by Nicolas. It also defines a class MethodDictionaryTest in the class category: KernelTests-Methods. MethodDictionaryTest uses some traits defined by Cyrille. This is really cool! It permitted to find a bug in MethodDictionary (removes removeKey:ifAbsent: should return the value that has been removed). MethodDictionaryTest has 21 green tests.
Before loading the SLICE: 7320 run, 7272 passes, 20 expected failures, 12 failures, 16 errors, 0 unexpected passes
After loading the SLICE: 7341 run, 7293 passes, 19 expected failures, 12 failures, 16 errors, 1 unexpected passes
Unfortunately, I was not able to find the unexpected pass. Apparently, running twice the unit tests have different results.
The description of the issue in Trunk follows:
Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.343.mcz
==================== Summary ====================
Name: Kernel-nice.343 Author: nice Time: 24 December 2009, 10:22:02 am UUID: 155bf515-f41c-bc40-9dad-f98c01dfce8d Ancestors: Kernel-nice.342
Smalltalk commandments #7: 'Thu shalt not invoke super when self could do the job'
=============== Diff against Kernel-nice.342 ===============
Item was changed: ----- Method: MethodDictionary>>includesKey: (in category 'accessing') ----- includesKey: aSymbol "This override assumes that pointsTo is a fast primitive"
aSymbol ifNil: [^ false]. + ^ self pointsTo: aSymbol! - ^ super pointsTo: aSymbol!
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Alexandre Bergel -
Stéphane Ducasse