- Pharo-dev - lists.pharo.org

Refactoring and traitsâ¦
by Yuriy Tymchuk Nov. 23, 2015

Nov. 23, 2015

Hi guys, is it a known issue that if you are refactoring something (eg. doing a class rename) and some changes should happen in a method which comes from trait, then new methods are compiled in concrete classes instead of changing the trait method? Cheers. Uko

5 5

A plea for responsive coding
by Thierry Goubier Nov. 22, 2015

Nov. 22, 2015

Hi all, I would like to ask you, all of you, something significant when doing GUI coding: Pay attention to performance! With the current state of our technology (Morphic, Bloc, whatever comes next) your target should be one hundred milliseconds (100 ms), for opening / redisplaying the widget. Why? - Because, in 10ms, Morphic can open and layout dozens of Morphs on a low-end machine (1.4GHz Celeron). - Because most of you work on 3GHz+ i7 Macbook Pro (so, at 10x the cpu performance of that said Celeron). - Because you are not to reproduce the past: that your current tools are slow is no excuse. - Because you now have well designed core widgets (FT) that behaves in O(1) and opens fully loaded in 10's of milliseconds So, profile and clean your code! Eliminate unneeded caches! Clean your architectures! Avoid or mark slow code and bottlenecks! And bring numbers when you want to criticize the performance of a subsystem... Thierry

5 15

recompiling all classes and traits is slow (at least on windows)
by Nicolai Hess Nov. 22, 2015

Nov. 22, 2015

recompiling all classes -> ~ 2 minutes recompiling all traits -> ~ 13 minutes is there any way to recompile all without removing and adding all trait methods for trait users ? Because this touches the changes file (although recompiling shouldn't change the source) and touching the changes file for many methods is pretty slow on windows. nicolai

4 4

[pharo-project/pharo-core] b27de6: 50458
by GitHub Nov. 22, 2015

Nov. 22, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: b27de6aabe954041aca71fc9aeadba1fddcdde66 https://github.com/pharo-project/pharo-core/commit/b27de6aabe954041aca71fc9… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-11-22 (Sun, 22 Nov 2015) Changed paths: M Collections-Sequenceable.package/OrderedDictionary.class/instance/comparing/=.st A Collections-Tests.package/DictionaryTest.class/instance/requirements/otherDictionaryClasses.st A Collections-Tests.package/DictionaryTest.class/instance/test - comparing/testOtherDictionaryEquality.st A Collections-Tests.package/OrderedDictionaryTest.class/instance/accessing/otherOrderedDictionaryClasses.st M Collections-Tests.package/OrderedDictionaryTest.class/instance/tests/testEqualsDictionary.st A Collections-Tests.package/OrderedDictionaryTest.class/instance/tests/testEqualsOtherOrderedDictionaries.st M Collections-Unordered.package/Dictionary.class/instance/comparing/=.st M Collections-Unordered.package/SmallDictionary.class/instance/comparing/=.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50457.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50458.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50457.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50458.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50458 16760 Dictionary>>= breaks when comparing identity and non-identity dictionaries https://pharo.fogbugz.com/f/cases/16760 http://files.pharo.org/image/50/50458.zip

1 0

[pharo-project/pharo-core]
by GitHub Nov. 22, 2015

Nov. 22, 2015

Branch: refs/tags/50458 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core]
by GitHub Nov. 22, 2015

Nov. 22, 2015

Branch: refs/tags/50457 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] a4ba46: 50457
by GitHub Nov. 22, 2015

Nov. 22, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: a4ba46aa059cc15f4892e91086abcdec33c4c677 https://github.com/pharo-project/pharo-core/commit/a4ba46aa059cc15f4892e910… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-11-22 (Sun, 22 Nov 2015) Changed paths: M Nautilus-GroupManagerUI.package/DialogGroupManagerUI.class/instance/item creation/buildAddSelectedPackageInSelectedGroupButton.st M Nautilus-GroupManagerUI.package/DialogGroupManagerUI.class/instance/item creation/buildRemoveSelectedPackageFromSelectedGroupButton.st M Nautilus-Tests.package/PackageTreeNautilusTest.class/instance/tests/setUp.st R Nautilus.package/AbstractNautilusUI.class/instance/accessing/selectedGroup_.st R Nautilus.package/AbstractNautilusUI.class/instance/accessing/showHierarchySilently_.st R Nautilus.package/AbstractNautilusUI.class/instance/build ui/buildSeparator.st R Nautilus.package/AbstractNautilusUI.class/instance/private/popUpTestsResult_.st R Nautilus.package/AbstractNautilusUI.class/instance/private/renamePackage_.st R Nautilus.package/AbstractNautilusUI.class/instance/private/updatePackageView.st R Nautilus.package/AbstractNautilusUI.class/instance/system announcements/classAdded_.st R Nautilus.package/NautilusUI.class/class/initialize/initializeCache.st A Nautilus.package/NautilusUI.class/class/menu/packagesFixMenu_.st M Nautilus.package/NautilusUI.class/definition.st A Nautilus.package/NautilusUI.class/instance/accessing/basicSelectPackage_.st A Nautilus.package/NautilusUI.class/instance/accessing/groups.st A Nautilus.package/NautilusUI.class/instance/accessing/packages.st A Nautilus.package/NautilusUI.class/instance/accessing/selectedFromPackageGroupView_.st A Nautilus.package/NautilusUI.class/instance/accessing/selectedGroup_.st A Nautilus.package/NautilusUI.class/instance/accessing/selectedPackageWithoutChangingSelection_.st A Nautilus.package/NautilusUI.class/instance/accessing/selectedPackage_.st A Nautilus.package/NautilusUI.class/instance/accessing/selectedProtocol.st A Nautilus.package/NautilusUI.class/instance/accessing/showHierarchy_.st A Nautilus.package/NautilusUI.class/instance/build ui lists/buildFirstColumn_.st R Nautilus.package/NautilusUI.class/instance/category-method methods/selectedMethodWithoutAsking_.st A Nautilus.package/NautilusUI.class/instance/class/addClassIn_.st A Nautilus.package/NautilusUI.class/instance/class/addTraitIn_.st A Nautilus.package/NautilusUI.class/instance/events handling/keyPressedOnList_shifted_.st A Nautilus.package/NautilusUI.class/instance/events handling/keyPressedOnTree_target_.st M Nautilus.package/NautilusUI.class/instance/initialization/initialize.st A Nautilus.package/NautilusUI.class/instance/menu pragmas/packageFixPragma.st A Nautilus.package/NautilusUI.class/instance/menus behavior/addClassCategory.st R Nautilus.package/NautilusUI.class/instance/menus behavior/findAllMethod.st M Nautilus.package/NautilusUI.class/instance/menus behavior/fullBrowse.st A Nautilus.package/NautilusUI.class/instance/menus behavior/removeGroups.st A Nautilus.package/NautilusUI.class/instance/menus behavior/removePackages.st M Nautilus.package/NautilusUI.class/instance/menus behavior/renameCategory.st A Nautilus.package/NautilusUI.class/instance/menus behavior/restrictedBrowsePackages_.st A Nautilus.package/NautilusUI.class/instance/menus/menu_shifted_.st A Nautilus.package/NautilusUI.class/instance/package filter/buildPackageSearch.st A Nautilus.package/NautilusUI.class/instance/package filter/class_matchPackagePatternString_.st A Nautilus.package/NautilusUI.class/instance/package filter/createPackagePattern_.st A Nautilus.package/NautilusUI.class/instance/package filter/ensureSafePackagePattern_.st A Nautilus.package/NautilusUI.class/instance/package filter/fixPackagePattern_ex_.st A Nautilus.package/NautilusUI.class/instance/package filter/packageMatchPattern_.st A Nautilus.package/NautilusUI.class/instance/package filter/packagePattern.st A Nautilus.package/NautilusUI.class/instance/package filter/packagePatternString.st A Nautilus.package/NautilusUI.class/instance/package filter/packagePatternString_.st A Nautilus.package/NautilusUI.class/instance/package filter/packageSearchUpdate_.st A Nautilus.package/NautilusUI.class/instance/package filter/package_matchPackagePattern_.st A Nautilus.package/NautilusUI.class/instance/package filter/updatePackages.st A Nautilus.package/NautilusUI.class/instance/package filter/useLastPackagePatternString.st A Nautilus.package/NautilusUI.class/instance/package filter/useLastPackagePatternStringForClass_.st A Nautilus.package/NautilusUI.class/instance/package/addPackageBasedOn_.st A Nautilus.package/NautilusUI.class/instance/package/addPackagesAsGroup_.st A Nautilus.package/NautilusUI.class/instance/package/alertCategoryName_exitstsAlreadyIn_.st A Nautilus.package/NautilusUI.class/instance/package/category_existsIn_.st A Nautilus.package/NautilusUI.class/instance/package/fileOutPackages_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/fullBrowseFromPackage_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/fullBrowseFromTag_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/registerSelectionGroup_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/registerSelectionPackage_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/removeClassCategory_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/removePackageCategory_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/renameClassCategory_.st A Nautilus.package/NautilusUI.class/instance/private dispatch/renamePackageCategory_.st A Nautilus.package/NautilusUI.class/instance/private/addClassCategoryBasedOn_.st A Nautilus.package/NautilusUI.class/instance/private/basicRemoveClasses_.st A Nautilus.package/NautilusUI.class/instance/private/basicRenamePackage_.st A Nautilus.package/NautilusUI.class/instance/private/basicShowHierarchy.st A Nautilus.package/NautilusUI.class/instance/private/clearPackageSelections.st M Nautilus.package/NautilusUI.class/instance/private/isSelectedPackage_.st A Nautilus.package/NautilusUI.class/instance/private/listClearSelection.st A Nautilus.package/NautilusUI.class/instance/private/listSelectItem_.st R Nautilus.package/NautilusUI.class/instance/private/nextButtonState.st R Nautilus.package/NautilusUI.class/instance/private/previousButtonState.st A Nautilus.package/NautilusUI.class/instance/private/renamePackage_.st A Nautilus.package/NautilusUI.class/instance/private/runPackagesTestsNotifying_.st A Nautilus.package/NautilusUI.class/instance/private/selectPackageFor_.st A Nautilus.package/NautilusUI.class/instance/private/updateGroupView.st A Nautilus.package/NautilusUI.class/instance/private/updatePackageGroupAndClassList.st A Nautilus.package/NautilusUI.class/instance/private/updatePackageView.st A Nautilus.package/NautilusUI.class/instance/source code area/defaultClassDescriptor.st A Nautilus.package/NautilusUI.class/instance/system announcements/classAdded_.st A Nautilus.package/NautilusUI.class/instance/test creation/buildTestPackageNameFrom_.st R Nautilus.package/NautilusUI.class/instance/widget method/methodsForCategoriesInGroup_.st R Nautilus.package/NautilusUI.class/instance/widget method/methodsForCategoryInGroup_.st R Nautilus.package/PackageTreeNautilusUI.class/class/menu/packagesFixMenu_.st M Nautilus.package/PackageTreeNautilusUI.class/definition.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/basicSelectPackage_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/groups.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/packages.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/selectedFromPackageGroupView_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/selectedGroup_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/selectedPackageWithoutChangingSelection_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/selectedPackage_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/selectedProtocol.st R Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/showHierarchy_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/build ui lists/buildFirstColumn_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/class/addClassIn_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/class/addTraitIn_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/events handling/keyPressedOnList_shifted_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/events handling/keyPressedOnTree_target_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/initialization/initialize.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menu pragmas/packageFixPragma.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menus behavior/addClassCategory.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menus behavior/fullBrowse.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menus behavior/removeGroups.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menus behavior/removePackages.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menus behavior/renameCategory.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menus behavior/restrictedBrowsePackages_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/menus/menu_shifted_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/buildPackageSearch.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/class_matchPackagePatternString_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/createPackagePattern_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/ensureSafePackagePattern_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/fixPackagePattern_ex_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/packageMatchPattern_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/packagePattern.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/packagePatternString.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/packagePatternString_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/packageSearchUpdate_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/package_matchPackagePattern_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/updatePackages.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/useLastPackagePatternString.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/useLastPackagePatternStringForClass_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package/addPackageBasedOn_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package/addPackagesAsGroup_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package/alertCategoryName_exitstsAlreadyIn_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package/category_existsIn_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/package/fileOutPackages_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/fullBrowseFromPackage_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/fullBrowseFromTag_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/registerSelectionGroup_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/registerSelectionPackage_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/removeClassCategory_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/removePackageCategory_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/renameClassCategory_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/renamePackageCategory_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/addClassCategoryBasedOn_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/basicRemoveClasses_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/basicRenamePackage_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/basicShowHierarchy.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/clearPackageSelections.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/isSelectedPackage_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/listClearSelection.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/listSelectItem_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/renamePackage_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/runPackagesTestsNotifying_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/selectPackageFor_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/updateGroupView.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/updatePackageGroupAndClassList.st R Nautilus.package/PackageTreeNautilusUI.class/instance/private/updatePackageView.st R Nautilus.package/PackageTreeNautilusUI.class/instance/source code area/defaultClassDescriptor.st R Nautilus.package/PackageTreeNautilusUI.class/instance/system announcements/classAdded_.st R Nautilus.package/PackageTreeNautilusUI.class/instance/test creation/buildTestPackageNameFrom_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50456.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50457.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50456.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50457.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A System-Announcements.package/ClassParentRenamed.class/README.md A System-Announcements.package/ClassParentRenamed.class/class/instance creation/classParentOf_renamedFrom_to_.st A System-Announcements.package/ClassParentRenamed.class/definition.st A System-Announcements.package/ClassParentRenamed.class/instance/accessing/classAffected.st A System-Announcements.package/ClassParentRenamed.class/instance/accessing/classAffected_.st A System-Announcements.package/ClassParentRenamed.class/instance/accessing/parentNewName.st A System-Announcements.package/ClassParentRenamed.class/instance/accessing/parentNewName_.st A System-Announcements.package/ClassParentRenamed.class/instance/accessing/parentOldName.st A System-Announcements.package/ClassParentRenamed.class/instance/accessing/parentOldName_.st A System-Announcements.package/SystemAnnouncer.class/instance/triggering/classParentOf_renamedFrom_to_.st M System-Support.package/SystemDictionary.class/instance/renaming/renameClass_from_to_.st Log Message: ----------- 50457 17071 merge all methods of PackageTreeNautilusUI into NautilusUI https://pharo.fogbugz.com/f/cases/17071 17064 Add new SystemAnnouncement for "parent class name changed" https://pharo.fogbugz.com/f/cases/17064 17073 wrong arrow icon in Group Manager https://pharo.fogbugz.com/f/cases/17073 http://files.pharo.org/image/50/50457.zip

1 0

opal optimize to do limits
by Nicolai Hess Nov. 22, 2015

Nov. 22, 2015

What is the purpose of replacing expressions, used as limits in a to:do: call with by a new temporary variable? For example: OCOpalExamples>>#exampleToDoArgumentLimitIsExpression the code is exampleToDoArgumentLimitIsExpression | count sum | count := 10. sum := 0. 1 to: count - 1 do: [ :each | sum := sum + each]. ^sum the decompiled bytecode : exampleToDoArgumentLimitIsExpression | tmp1 tmp2 tmp3 | tmp1 := 10. tmp2 := 0. tmp3 := tmp1 - 1. 1 to: tmp3 do: [ :tmp4 | tmp2 := tmp2 + tmp4 ]. ^ tmp2 So, the expression (count - 1) in the to:do: loop is replaced by a new temporay (tmp3). Ok, but why ?

5 9

Recovering _lost_ changes
by Yuriy Tymchuk Nov. 21, 2015

Nov. 21, 2015

Hi, is Epicea integrated already? If so, is it possible to apply all the changes to code (without doits) since the last image save? I think that it should be really helpful because searching for changes and cherry-picking them is a pain. Later this can be improved, so before the changes are applied you see the condensed diff. Cheers. Uko

4 7

SystemAnnouncer class>>#uniqueInstance
by Juraj Kubelka Nov. 21, 2015

Nov. 21, 2015

Hi, The class SystemAnnouncer has #restoreAllNotifications method that is called only by RPackageRenameTest>>setUp. This is pretty strange. I have an impression that tests should not affect global information (singleton). And there are some objects that depends on calling #restoreAllNotifications. I guess that all this staff works thanks to this particular test case. I think this is a bug and correct solution should be: -=-=-=- uniqueInstance "Answer a system annoncer." ^ announcer ifNil: [ announcer := self new. self restoreAllNotifications. announcer ]. -=-=-=- And it should be removed from RPackageRenameTest>>setUp. What do you think? Should I open an issue? Cheers, Juraj

2 1