- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] a6d83d: 50477
by GitHub Nov. 30, 2015

Nov. 30, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: a6d83d28de549e5e0bfb948f07fa983453d0b5dd https://github.com/pharo-project/pharo-core/commit/a6d83d28de549e5e0bfb948f… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: A FontInfrastructure.package/LogicalFont.class/instance/accessing/lineGrid.st A FreeType.package/FreeTypeFont.class/instance/accessing/familyName.st M NECompletion.package/NECPreferences.class/class/accessing/overrideModel_.st R Reflectivity-Tools.package/BreakpointIconStyler.class/instance/defaults/iconLabel.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50476.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50477.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50476.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50477.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Examples.package/DynamicWidgetChange.class/instance/private/change.st A Spec-Examples.package/TabsExample.class/instance/accessing/title.st R Spec-Examples.package/TabsExample.class/instance/as yet unclassified/title.st M Spec-Examples.package/TabsExample.class/instance/initialization/populateManager.st A Spec-Examples.package/TabsExample.class/instance/private/dynamicTab.st Log Message: ----------- 50477 16555 Correct and Improve Spec example DynamicWidgetChange https://pharo.fogbugz.com/f/cases/16555 17161 Missing subclass responsibility implementation in some Font subclasses https://pharo.fogbugz.com/f/cases/17161 17157 preference for completing whole methods can not be enabled https://pharo.fogbugz.com/f/cases/17157 17153 BreakpointIconStyler>>#iconLabel is dead code https://pharo.fogbugz.com/f/cases/17153 http://files.pharo.org/image/50/50477.zip

1 0

About the announcements model for SUnit
by NicolÃ¡s Papagna Maldonado Nov. 30, 2015

Nov. 30, 2015

Hi everyone! Lately I've been playing with/digging into the announcements model for SUnit, and have a couple of questions about it. I'm trying to understand the model and I am by no means an expert to it. Any pointers/references/feedback is appreciated. 1) As expected TestCaseEnded is notified after a test case is run in TestResult>>#runCase:, but after some tests I've noticed that the announcement (which is created with the TestResult instance as collaborator) is sent before the passing test case is added to the TestResult instance. That means that one gets notified that a test case has been run successfully, but when inspecting the result, that test case won't be there: runCase: aTestCase [ aTestCase announce: TestCaseStarted withResult: self. aTestCase runCase. *aTestCase announce: TestCaseEnded withResult: self. self addPass: aTestCase*] on: self class failure , self class skip, self class warning, self class error do: [:ex | ex sunitAnnounce: aTestCase toResult: self] Is this the expected behavior? 2) When a test case does not pass (for whatever reason), the failure is handled and the TestResult instance is updated, but a TestCaseEnded announcement is not sent. So there's a chance that you'd get a TestCaseStarted announcement, but never receive a TestCaseEnded announcement if it didn't pass: runCase: aTestCase [ *aTestCase announce: TestCaseStarted withResult: self.* aTestCase runCase. aTestCase announce: TestCaseEnded withResult: self. self addPass: aTestCase] on: self class failure , self class skip, self class warning, self class error do: [:ex | *ex sunitAnnounce: aTestCase toResult: self*] Is this the expected behavior? 3) When a TestSuiteEnded is announced (TestResult>>#updateResultsInHistory), the announcement instance is created passing in the TestCase subclass as result. So, when sending #testResult to the annoucement, one does not get a TestResult instance (as expected) but the TestCase subclass. updateResultsInHistory |classesToNotify| classesToNotify:= Set new. #(#passed #failures #errors) do: [ :status | (self perform: status) do: [ :testCase | classesToNotify add:testCase class. self class updateTestHistoryFor: testCase status: status ] ]. *classesToNotify do:[:cl | * cl historyAnnouncer announce: (*TestSuiteEnded result: cl*)] 4) I've read an old post about using a Dictionary instead of storing the TestResult instance as history, and it seemed like that was the intended design. The only issue I see there is that there could be potentially duplicated code in writing the interpretation of that dictionary (ie. #passed, #failures, #defects, etc..). Has anyone worked with TestCase results history before? if So, which was your approach to do it? Cheers, Nico PM -- View this message in context: http://forum.world.st/About-the-announcements-model-for-SUnit-tp4863569.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

3 3

is it me or we cannot use shortcut in debugger inspector?
by stepharo Nov. 29, 2015

Nov. 29, 2015

Hi I authorised myself a littel coding session today and is it me or we cannot use shortcut in debugger inspector? stef

2 2

learning from errors....
by stepharo Nov. 29, 2015

Nov. 29, 2015

I was looking at the LoadingMorph BTW: it would be good that QA does not refer to Komitter. And package it as a separate project. QA should not dependent on Komitter because we can remove Komitter. And it makes no sense! And it uses a state pattern, which is ok but there is not needed to create a new state all time. SmallCogInitialState >> nextState ^ SmallCogState2 new nextState ^ SmallCogState3 new We can have a state pattern without creating garbage all the time. Now I wonder who is using this LoadingMorph? Stef

3 8

Autoscrolling (in FastTable)
by Stephan Eggermont Nov. 29, 2015

Nov. 29, 2015

Today we've had a design discussion on slack on autoscrolling with Morphic. The idea is to start scrolling up or down when drag-holding over a table. A similar approach should hold for scrolling panes. It started with me describing a working but not so nice approach starting stepping on #mouseEnterDragging:, checking the global hand position and button state in each #step:, stopping the stepping on #mouseLeaveDragging: or #mouseUp:. Thierry noticed the #newMouseFocus: taking of FastTable on #mouseEnterDragging: causes problems when dragging from one table to itself without leaving the table bounds. Henrik then wrote the code for FastTable, removing the mouse focus taking by adapting #handleMouseMove: The first results are in the latest version of FastTable on estebanlm/FastTable. The top and bottom parts of the table will now start scrolling the table rows when drag-holding over them. Further possible improvements: - expand/contract tree triangles when holding over them, taking priority over the start of autoscrolling; - adapt scrolling speed depending on distance from border - check starting delay, repeat rate and smoothness of the scrolling Stephan

3 6

[Pharo5] Semantic Warnings as icons in the editor
by Marcus Denker Nov. 29, 2015

Nov. 29, 2015

Hi, One result of Fridayâs Pharo Sprint in Chile: Use the nice icons of the new text editor to display some of the semantic errors nicely (instead of breaking flow with a intrusive dialog): This was done by Johan based on the prototype Miguel did in September: 1) unused temps: (the âdrag the crosshairâr is an artefact of the snapshot tool) 2) temps used that are not initialised: In a next step, we need to integrate that with the QA toolâ¦ no need to have this reported twice. What is nice is that this simplified the Compiler: instead of having an Exception and raising it, we now just annotate the AST: unusedVariable: variableNode variableNode propertyAt: #semanticWarning put: 'unused variableâ (this is very simple for now, with a node just being able to have one kind of semanticWarning). SemanticWarningIconStyler is what adds the icon. It has 4 methods with one line each. Marcus

6 7

Delay>>waitOtherwise:
by Ben Coman Nov. 28, 2015

Nov. 28, 2015

I think I made a mistake introducing Delay>>waitOtherwise: to be used by World>>interCyclePause: . Its requirement that #schedule: return a boolean complicates all those methods. In review now, I was being too conservative while letting the refactored delay scheduler code settle in. Would anyone mind if I revert that? cheers -ben

2 1

Occasional random validation failures
by Ben Coman Nov. 28, 2015

Nov. 28, 2015

In case 16962 [1] the question was raised why after a successful CI validation you later get a failed validation. I experience this sometimes and guess others might interested in this too. If multi-threads are involved, sometimes the failure indicates a real problem due to a race condition that only occurs sometimes. Here you will see lots of tests passing and then a problem on a particular one. In this case I find running the suspect test or class from playground wrapped in a 1000 loop can expose the problem for debugging. In the case of 16962 [1], looking at a report for success [2] you can see "CIChangeCaseValidationRule" is followed by "Loading CASE 16962" and then a long listing of tests run, and only at the end the validation report. However the report for failure [3] shows CIChangeCaseValidationRule immediately followed by the validation report. So I wonder if that means the slice did not load - maybe due to some network error or smalltalkhub error. Now thats idle speculation, but maybe useful to consider if you encounter such a scenario. cheers -ben 2015-11-28 3:56 AM SUCCESS [2] [...] Starting validation of CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… Notice: Running a CIAndRule Notice: Running a CIChangeCaseValidationRule Notice: Loading CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… [...cut many,many lines of test cases...] ========================================================== Validation Report: CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… ========================================================== Validation Success: CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… [...] 2015-11-26 10:29 PM FAILURE [3] [...] Starting validation of CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… Notice: Running a CIAndRule Notice: Running a CIChangeCaseValidationRule ========================================================== Validation Report: CASE 16962 http://smalltalkhub.com/mc/Pharo/Pharo50Inbox/main/SLICE-Issue-16962-Code-p… ========================================================== Validation Errors: a CIChangeCaseValidationRule: Timeout (after 0:01:40:00) [...] [1] https://pharo.fogbugz.com/default.asp?16962 [2] https://ci.inria.fr/pharo/job/Pharo-5.0-Issue-Validator/20704//artifact/val… [3] https://ci.inria.fr/pharo/job/Pharo-5.0-Issue-Validator/20587//artifact/val…

1 0

Improving API of Date, Month....
by stepharo Nov. 28, 2015

Nov. 28, 2015

Hi I was reading the code of Date and I was expecting to get some methods such as monthNames dayNames daysInMonths Ok they are stored in ChronologyConstants but they are not accessible. There is no monthNames nor Do I imply something strange or silly? I think that it would make sense to add them. Stef

6 10

Analyzing Tweets
by Alexandre Bergel Nov. 28, 2015

Nov. 28, 2015

Hi! Some students from Arizona State University are analyzing some tweets. This is pretty cool. Here are some short video and url full of pictures: https://sites.google.com/a/asu.edu/project-geeko/ https://drive.google.com/file/d/0BxQoWoSofKvaTkN5bk9hN0NyQ28/view https://www.youtube.com/watch?v=cnuc_crnWB0&feature=youtu.be Impressive! Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

3 4