- Pharo-dev - lists.pharo.org

Fixed Glamour wrong users of LayoutFrame fractions: (0@0 corner: 1@1) fixes
by stepharo Jan. 9, 2016

Jan. 9, 2016

Hi I commited Glamour fixes for LayoutFrame fractions: (0@0 corner: 1@1)) -> LayoutFrame identity It is faster, produces less garbage and easier to read. Now it would be good that Glamourers do the same cleans that I did with Igor on complete Pharo. Check all the uses of fractions: and fractions:offsets: and only use those if you do not create by yourself a rectangle. In addition using rectangles for passing four digits is doomed to create wrong and incorrect rectangles so if you still need to use rectangle better use Margin. A margin is a holder of 1,2 or 4 digits and it is not a rectangle. Tell me if you need more precision. Stef

2 1

Fixed Glamour wrong users of LayoutFrame fractions: (0@0 corner: 1@1) fixes
by stepharo Jan. 9, 2016

Jan. 9, 2016

Hi I commited Glamour fixes for LayoutFrame fractions: (0@0 corner: 1@1)) -> LayoutFrame identity It is faster, produces less garbage and easier to read. Now it would be good that Glamourers do the same cleans that I did with Igor on complete Pharo. Check all the uses of fractions: and fractions:offsets: and only use those if you do not create by yourself a rectangle. In addition using rectangles for passing four digits is doomed to create wrong and incorrect rectangles so if you still need to use rectangle better use Margin. A margin is a holder of 1,2 or 4 digits and it is not a rectangle. Tell me if you need more precision. Stef

1 0

problem with become:?
by Tudor Girba Jan. 9, 2016

Jan. 9, 2016

Hi, If I execute the following code in the latest Pharo image: Object subclass: #A instanceVariableNames: '' classVariableNames: '' package: 'AA'. Object subclass: #B instanceVariableNames: '' classVariableNames: '' package: 'AA'. a := A new. b := B new. a become: b. a class ==> âA". In a pre-Spur image, I used to get âBâ. Is this a bug, or is there a change I am not aware of? Cheers, Doru -- www.tudorgirba.com www.feenk.com "Things happen when they happen, not when you talk about them happening."

4 7

Crash editing class method...with Pharo5.0, Latest update: #50519
by stepharo Jan. 9, 2016

Jan. 9, 2016

DNU RubShoutStylerDecorator>>characterBlockForIndex: I just started to edit fractions:offsets: characterBlockForIndex: index "Answer a CharacterBlock for the character in text at index." | line | line := self lines at: (self lineIndexOfCharacterIndex: index). ^ (RubCharacterBlockScanner new text: self text textStyle: self textStyle) characterBlockAtPoint: nil index: ((index max: line first) min: self text size+1) in: line self lines is empty... Now I could not recover or close my window. No idea how to reproduce it. Stef

1 0

[ANN] I created a web page so you can stalk me :)
by Esteban Lorenzano Jan. 8, 2016

Jan. 8, 2016

Hi, Stef told me I need to make a bit more visibility my work, and while being in Togo I sketched an application I tested last few days and seems to be working fina. Of course, easiest way would be to use twitter as a work log, but I was not satisfied with the idea. Why? wellâ¦ some reasons are explained in the source page: - You can add formatting using pillar - You do not have 140 characters max (probably you will not need much more, but anyway, the limitation is annoying :P) - You can disqus (http://disqus.com) posts. - Posts are interpreted and links are detected and listed (so is easy to find them) - Since is made for my own work, it understand links like *case:12345* as a link to pharo fogbugz case 12345. - It has a command line! but another reason was because I wanted to try it (and I was bored in Togo waiting for the planes) I donât know how this experiment will work, but letâs give it a try :) http://log.smallworks.eu <http://log.smallworks.eu/> http://log.smallworks.eu/rss <http://log.smallworks.eu/rss> (you can suscribe with your reader, so you do not need to go to the page) https://github.com/estebanlm/worklog <https://github.com/estebanlm/worklog> Enjoy stalking me :) Esteban

5 9

Syntax Highlighting error (RBParseErrorNode(Object)>>doesNotUnderstand: #isInstance)
by Sven Van Caekenberghe Jan. 8, 2016

Jan. 8, 2016

I am seeing the following very annoying error in 50511 spur. Open a Playground, type [ (both open en close are inserted, with the cursor in-between), type : (to start a block arg), boom: RBParseErrorNode(Object)>>doesNotUnderstand: #isInstance OCASTClosureAnalyzer>>changeVariableClass: OCASTClosureAnalyzer>>visitArgumentNode: [ :each | self visitArgumentNode: each ] in OCASTClosureAnalyzer(RBProgramNodeVisitor)>>visitArgumentNodes: OrderedCollection>>do: OCASTClosureAnalyzer(RBProgramNodeVisitor)>>visitArgumentNodes: OCASTClosureAnalyzer>>visitBlockNode: RBBlockNode>>acceptVisitor: OCASTClosureAnalyzer(RBProgramNodeVisitor)>>visitNode: [ :each | self visitNode: each ] in OCASTClosureAnalyzer(RBProgramNodeVisitor)>>visitSequenceNode: OrderedCollection>>do: OCASTClosureAnalyzer(RBProgramNodeVisitor)>>visitSequenceNode: RBSequenceNode>>acceptVisitor: OCASTClosureAnalyzer(RBProgramNodeVisitor)>>visitNode: OCASTClosureAnalyzer>>visitMethodNode: RBMethodNode>>acceptVisitor: OCASTClosureAnalyzer(RBProgramNodeVisitor)>>visitNode: OCASTSemanticAnalyzer>>analyze: RBMethodNode>>doSemanticAnalysis RBBlockNode(RBProgramNode)>>doSemanticAnalysis RubSHTextStylerST80(SHRBTextStyler)>>privateStyle: [ self privateStyle: text. view ifNotNil: [ view stylerStyledInBackground: text ] ] in [ backgroundProcess := [ self privateStyle: text. view ifNotNil: [ view stylerStyledInBackground: text ] ] forkAt: Processor userBackgroundPriority ] in RubSHTextStylerST80(SHTextStyler)>>styleInBackgroundProcess: [ self value. Processor terminateActive ] in BlockClosure>>newProcess Has this already been reported ? It makes the image almost unusable... Sven

3 4

Re: [Pharo-dev] [Vm-dev] Where to get Monitor implementation based on primitives?
by Eliot Miranda Jan. 8, 2016

Jan. 8, 2016

Hi Ben, On Thu, Jan 7, 2016 at 10:39 AM, Ben Coman <btc(a)openinworld.com> wrote: > > On Fri, Jan 8, 2016 at 1:20 AM, Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > > > > and here's a version with a better class comment > > > > On Thu, Jan 7, 2016 at 9:12 AM, Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > >> > >> Hi Denis, Hi ClÃ©ment, Hi Frank, > >> > >> On Thu, Jan 7, 2016 at 5:34 AM, ClÃ©ment Bera <bera.clement(a)gmail.com> > wrote: > >>> > >>> Hello, > >>> > >>> Eliot, please, you told me you had the code and Denis is interested. > >>> > >>> It uses 3 primitives for performance. > >> > >> > >> Forgive the delay. I thought it proper to ask permission since the > code was written while I was at Qwaq. I'm attaching the code in a fairly > raw state, see the attached. The code is MIT, but copyright 3DICC. > >> > >> It is a plugin replacement for Squeak's Mutex, and with a little > ingenuity could be a replacement for Squeak's Monitor. It is quicker > because it uses three new primitives to manage entering a critical section > and setting the owner, exiting the critical section and releasing the > owner, and testing if a critical section, entering if the section is > unowned. The use of the primitives means fewer block activations and > ensure: blocks in entering and exiting the critical section, and that's the > actual cause of the speed-up. > >> > >> You can benchmark the code as is. Here are some results on 32-bit > Spur, on my 2.2GHz Core i7 > >> > >> {Mutex new. Monitor new. CriticalSection new} collect: > >> [:cs| | n | > >> n := 0. > >> [cs critical: [n := n + 1]. cs critical: [n := n + 1]. cs critical: [n > := n + 1]. cs critical: [n := n + 1]. cs critical: [n := n + 1]. > >> cs critical: [n := n - 1]. cs critical: [n := n - 1]. cs critical: [n > := n - 1]. cs critical: [n := n - 1]. cs critical: [n := n - 1]. > >> n ] bench] > >> > >> {Mutex new. Monitor new. CriticalSection new} collect: > >> [:cs| | n | > >> n := 0. > >> cs class name, ' -> ', > >> [cs critical: [n := n + 1]. cs critical: [n := n + 1]. cs critical: [n > := n + 1]. cs critical: [n := n + 1]. cs critical: [n := n + 1]. > >> cs critical: [n := n - 1]. cs critical: [n := n - 1]. cs critical: [n > := n - 1]. cs critical: [n := n - 1]. cs critical: [n := n - 1]. > >> n ] bench] > >> > >> #( 'Mutex -> 440,000 per second. 2.27 microseconds per run.' > >> 'Monitor -> 688,000 per second. 1.45 microseconds per run.' > >> 'CriticalSection -> 1,110,000 per second. 900 nanoseconds per run.') > >> > > This is great Eliot. Thank you and 3DICC. After loading the changeset > into Pharo-50515 (32 bit Spur) I get the following results on my > laptop i5-2520M @ 2.50GHz > > #('Mutex -> 254,047 per second' > 'Monitor -> 450,442 per second' > 'CriticalSection -> 683,393 per second') > > In a fresh Image "Mutex allInstances basicInspect" lists just two > mutexes... > 1. NetNameResolver-->ResolverMutex > 2. ThreadSafeTranscript-->accessSemaphore > I hate myself for getting distracted but I'm finding this is un. One can migrate to the new representation using normal Monticello loads by In the first version redefine Mutex and Monitor to subclass LinkedList and have their owner/ownerProcess inst var first (actually third after firstLink & lastLink), and add the primitives. In the next version check that all Mutex and Monitor instanes are unowned and then redefine to discard excess inst vars Let me test this before committing, and see that all tests are ok. > cheers -ben > > >> Replacement is probably trivial; rename Mutex to OldMutex, rename > CriticalSection to Mutex, recompile. But there are lots of mutexes in the > system and these are potentially owned. Transforming unowned ones is > trivial, but transforming owned ones is, I think, impossible. But at least > in my system there are no owned mutexes or monitors. > >> > >> Frank (or anyone else), would you be interested in creating a > replacement for Squeak's Monitor based on CriticalSection? > >> > >> > >> Here are the two business methods: > >> CriticalSection methods for mutual exclusion > >> critical: aBlock > >> "Evaluate aBlock protected by the receiver." > >> ^self primitiveEnterCriticalSection > >> ifTrue: [aBlock value] > >> ifFalse: [aBlock ensure: [self primitiveExitCriticalSection]] > >> > >> critical: aBlock ifLocked: lockedBlock > >> "Answer the evaluation of aBlock protected by the receiver. If it is > already in a critical > >> section on behalf of some other process answer the evaluation of > lockedBlock." > >> ^self primitiveTestAndSetOwnershipOfCriticalSection > >> ifNil: [lockedBlock value] > >> ifNotNil:[:alreadyOwner| > >> alreadyOwner > >> ifTrue: [aBlock value] > >> ifFalse: [aBlock ensure: [self primitiveExitCriticalSection]]] > >> > >> and the primitives: > >> CriticalSection methods for private-primitives > >> primitiveEnterCriticalSection > >> "Primitive. The receiver must be unowned or owned by the current > process to proceed. > >> Answer if the process is owned by the current process." > >> <primitive: 186> > >> self primitiveFailed > >> "In the spirit of the following" > >> "[owner ifNil: > >> [owner := Processor activeProcess. > >> ^false]. > >> owner = Processor activeProcess ifTrue: > >> [^true]. > >> self addLast: Processor activeProcess. > >> Processor activeProcess suspend] valueUnpreemptively" > >> > >> primitiveExitCriticalSection > >> "Primitive. Set te receiver to unowned and if any processes are waiting > on > >> the receiver then proceed the first one, indicating that the receiver > is unowned." > >> <primitive: 185> > >> self primitiveFailed > >> "In the spirit of the following" > >> "[owner := nil. > >> self isEmpty ifFalse: > >> [process := self removeFirst. > >> process resume]] valueUnpreemptively" > >> > >> primitiveTestAndSetOwnershipOfCriticalSection > >> "Primitive. Attempt to set the ownership of the receiver. > >> If the receiver is unowned set its owningProcess to the > >> activeProcess and answer false. If the receiver is owned > >> by the activeProcess answer true. If the receiver is owned > >> by some other process answer nil." > >> <primitive: 187> > >> self primitiveFail > >> "In the spirit of the following" > >> "[owner ifNil: > >> [owningProcess := Processor activeProcess. > >> ^false]. > >> owner = Processor activeProcess ifTrue: [^true]. > >> ^nil] valueUnpreemptively" > >> > >>> 2016-01-07 13:24 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > >>>> > >>>> > >>>> Hello. > >>>> > >>>> I hear about new Monitor implementation based on new primitives. > >>>> Where to get it? > >> > >> > >> _,,,^..^,,,_ > >> best, Eliot > > > > > > > > > > -- > > _,,,^..^,,,_ > > best, Eliot > > > -- _,,,^..^,,,_ best, Eliot

3 3

[pharo-project/pharo-core]
by GitHub Jan. 8, 2016

Jan. 8, 2016

Branch: refs/tags/50519 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 2354ee: 50519
by GitHub Jan. 8, 2016

Jan. 8, 2016

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 2354ee435aa2ae08cbc362bd26432a25d56150c2 https://github.com/pharo-project/pharo-core/commit/2354ee435aa2ae08cbc362bd… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-01-08 (Fri, 08 Jan 2016) Changed paths: A Deprecated50.package/extension/Object/instance/haltIfShiftPressed.st M Kernel.package/CompiledMethod.class/instance/testing/containsHalt.st R Kernel.package/Object.class/instance/halting/haltIfShiftPressed.st M Nautilus.package/MethodContainsHaltAction.class/instance/order/isActionHandled.st R NautilusCommon.package/extension/RGMethodDefinition/instance/containsHalt.st M OpalCompiler-Core.package/IRBytecodeGenerator.class/definition.st M OpalCompiler-Core.package/IRBytecodeGenerator.class/instance/private/nextPut_.st M OpalCompiler-Core.package/IRBytecodeGenerator.class/instance/results/bytecodes.st M OpalCompiler-Core.package/IRBytecodeGenerator.class/instance/results/compiledMethodWith_.st M OpalCompiler-Core.package/IRBytecodeGenerator.class/instance/results/endPrimNumber.st M OpalCompiler-Core.package/IRBytecodeGenerator.class/instance/results/hasPrimitive.st A Ring-Core-Kernel.package/RGMethodDefinition.class/instance/testing/containsHalt.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50518.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50519.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50518.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50519.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50519 17251 Quick method primitive not set correctly for #spurVMHeader: https://pharo.fogbugz.com/f/cases/17251 17346 move #haltIfShiftPressed to Deprecated50 https://pharo.fogbugz.com/f/cases/17346 http://files.pharo.org/image/50/50519.zip

1 0

Adapting the launcher to Spur VM
by Damien Cassou Jan. 8, 2016

Jan. 8, 2016

Hi, from a Pharo image, can I detect if another image needs the Spur VM or not? Best -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill

10 17