- Pharo-dev - lists.pharo.org

Fix To Include
by Ben Coman Jan. 25, 2016

Jan. 25, 2016

Is something stuck with integration by the CI monkey. I thought this automatically picked and integrated any Fix To Include status slices. But these two cases were marked Fix To include a fews days ago, and have not yet been integrated. Case 17296 --> Fix To Include 2016-01-21 22:29 Case 17435 --> Fix To Include 2016-01-22 16:34 But I see several cases integrated since then didn't pass through Fix To Include, so I'm curious what the process is. Is it still a manual pick of items to integrate? In that case why are the above passed over? There is no indication on the tracker. Case 17429 --> Fix To include 2016-01-22 16:52 --> Integrated 2016-01-22 21:05 Build 50539 Case 17446 --> Fix To Include 2016-01-22 21:40 --> Integrated 2016-01-22 23:40 Build 50540 Case 17404 --> Fix Reviewed By Monkey 2016-01-24 03:42 Case 17443 --> Fix Reviewed By Monkey 2016-01-24 04:57 Case 17457 --> Fix Reviewed By Monkey 2016-01-24 05:03 --> Integrated 2016-01-24 17:55 Build 50541 Case 17450 --> Fix Review Needed 2016-01-24 19:37 --> Integrated 2016-01-24 17:37 Build 50542 Case 17301 --> Fix Reviewed by the Monkey 2016-01-24 20:39 Case 17384 --> Fix To Include 2016-01-24 16:50 --> Integrated 2016-01-24 20:39

3 5

4th Chapter of Updated Pharo by Example ready for review.
by stepharo Jan. 24, 2016

Jan. 24, 2016

4th Chapter of Updated Pharo by Example ready for review. https://ci.inria.fr/pharo-contribution/view/Books/job/UpdatedPharoByExample… This one was way simpler than the PharoTour and FirstAplication, so I imagine that the review will be easier too. Stef Not thinking too much, just doing.

1 0

Why pharo is going over squeaksource when saving code?
by stepharo Jan. 24, 2016

Jan. 24, 2016

may be I'm dreaming this morning but when I saved code in the inbox I saw a query to www.squeaksource.com? Stef

5 10

Better class comment version2
by stepharo Jan. 24, 2016

Jan. 24, 2016

I define a transformation frame relative to some rectangle. I'm basic data structure used for graphics. I represent two groups of distances: - The fractional distance (between 0 and 1) to place the morph in its owner's bounds - Fixed pixel offset to apply after fractional positioning (e.g., "10 pixel right of the center of the owner") !! API usage It is important to understand that it is better to use the fine grained API using elementary distances (bottomFraction:, bottomOffset:, leftFraction: ....) than the ones (historical) using points and rectangles (fractions:offsets:) The reason is that the old API (fractions:offsets:) is only interesting if you already have a rectangle and point at hand. If you need to create new ones, then they are created for nothing because they will be destructured to extract their information to be feed into the layoutFrame. So please do not blindly copy and paste code! Example: Favor (LayoutFrame identity leftFraction: 0; yourself); (LayoutFrame identity leftFraction: 0.5; rightFraction: 0.95; (LayoutFrame identity topOffset: topHeight; bottomFraction: 0; bottomOffset: self buttonsBarHeight; leftOffset: -1; rightOffset: 1) over (LayoutFrame fractions: (0 @ 0 corner: 1 @ 1)) For this one in particular it is better to use LayoutFrame identity It is faster and more readable because you are creating for nothing a new rectangle and some points. !! Final point: Do not use Rectangles for specifying layoutFrames If you happen to need to create a rectangle and use the fractions:offsets: class methods, refrain from creating a rectangle. The reason is that a rectangle is not 4 numbers, it represents a space area and when you use a rectangle to represent random numbers you end up creating rectangles with negative extents and this is not good. In this case use Margin, Margin is a nice class holding either one number (the same "margin" on the four sides of a rectangle), or two number (top/bottom, left/right margins) or 4 numbers. !! Implementation Instance variables: The fractional distance (between 0 and 1) to place the morph in its owner's bounds is represented by the following instance variables: leftFraction topFraction rightFraction bottomFraction <Float> Fixed pixel offset to apply after fractional positioning (e.g., "10 pixel right of the center of the owner") is represented by the following instance variables: leftOffset topOffset rightOffset bottomOffset <Integer>

6 9

Moving large classes in Pharo5 between packages makes me sad
by Aliaksei Syrel Jan. 24, 2016

Jan. 24, 2016

[image: Inline image 1] Cheers, Alex

2 1

3rd Chapter of Updated Pharo by Example ready for review.
by stepharo Jan. 24, 2016

Jan. 24, 2016

3rd Chapter of Updated Pharo by Example ready for review. https://ci.inria.fr/pharo-contribution/view/Books/job/UpdatedPharoByExample… Stef Not thinking too much, just doing.

1 0

[pharo-project/pharo-core] e29965: 50545
by GitHub Jan. 24, 2016

Jan. 24, 2016

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: e29965eecb03b444a689c55aeb098e9f0fbe09ad https://github.com/pharo-project/pharo-core/commit/e29965eecb03b444a689c55a… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-01-24 (Sun, 24 Jan 2016) Changed paths: A Deprecated50.package/extension/Delay/instance/waitOtherwise_.st R Kernel.package/Delay.class/instance/delaying/waitOtherwise_.st M Kernel.package/Delay.class/instance/private/schedule.st M Kernel.package/DelayExperimentalCourageousScheduler.class/instance/low priority processes/schedule_.st M Kernel.package/DelayExperimentalSemaphoreScheduler.class/instance/low priority processes/schedule_.st M Kernel.package/DelayExperimentalSpinScheduler.class/instance/low priority processes/schedule_.st M Kernel.package/DelayMicrosecondScheduler.class/instance/low priority processes/schedule_.st M Kernel.package/DelayMillisecondScheduler.class/instance/low priority processes/schedule_.st M Kernel.package/DelayNullScheduler.class/instance/low priority processes/schedule_.st A Reflectivity.package/RFReification.class/instance/generate/genForRBArgumentNode.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50544.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50545.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50544.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50545.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50545 17296 Remove Delay>>otherwise: https://pharo.fogbugz.com/f/cases/17296 17453 add #genForRBArgumentNode https://pharo.fogbugz.com/f/cases/17453 http://files.pharo.org/image/50/50545.zip

1 0

[pharo-project/pharo-core]
by GitHub Jan. 24, 2016

Jan. 24, 2016

Branch: refs/tags/50545 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 5d8e29: 50544
by GitHub Jan. 24, 2016

Jan. 24, 2016

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 5d8e29106a266ef2cff7f53ec5f793e172a82b5d https://github.com/pharo-project/pharo-core/commit/5d8e29106a266ef2cff7f53e… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-01-24 (Sun, 24 Jan 2016) Changed paths: M Kernel.package/ProtocolOrganizer.class/instance/initialization/initialize.st A Kernel.package/ProtocolOrganizer.class/instance/initialization/reset.st M Morphic-Base.package/MenuMorph.class/definition.st M Morphic-Base.package/MenuMorph.class/instance/accessing/items.st M Morphic-Base.package/MenuMorph.class/instance/accessing/lastItem.st M Morphic-Base.package/MenuMorph.class/instance/accessing/menuItems.st M Morphic-Base.package/MenuMorph.class/instance/construction/addMenuItem_.st M Morphic-Base.package/MenuMorph.class/instance/construction/addToggle_target_selector_getStateSelector_enablementSelector_argumentList_.st M Morphic-Base.package/MenuMorph.class/instance/copying/veryDeepInner_.st M Morphic-Base.package/MenuMorph.class/instance/initialization/initialize.st M Morphic-Base.package/MenuMorph.class/instance/menu/addCustomMenuItems_hand_.st M Morphic-Base.package/MenuMorph.class/instance/menu/removeStayUpItems.st R Morphic-Base.package/MenuMorph.class/instance/submorphs-add%2Fremove/addMorphBack_.st M Morphic-Base.package/MenuMorph.class/instance/testing/hasItems.st M Morphic-Base.package/MenuMorph.class/instance/testing/hasSubMenu_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50543.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50544.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50543.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50544.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50544 17423 PopupChoiceDialogWindow keyboard navigation https://pharo.fogbugz.com/f/cases/17423 17435 ClassOrganisation>>#changeFromString: MNU for empty change https://pharo.fogbugz.com/f/cases/17435 http://files.pharo.org/image/50/50544.zip

1 0

[pharo-project/pharo-core]
by GitHub Jan. 24, 2016

Jan. 24, 2016

Branch: refs/tags/50544 Home: https://github.com/pharo-project/pharo-core

1 0