- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] 08a1a0: 50659
by GitHub March 24, 2016

March 24, 2016

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 08a1a07549088f5591d225a8574900f57761d9f9 https://github.com/pharo-project/pharo-core/commit/08a1a07549088f5591d225a8… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-03-24 (Thu, 24 Mar 2016) Changed paths: M Collections-Tests.package/StringTest.class/instance/requirements/sortedInAscendingOrderCollection.st A Collections-Tests.package/StringTest.class/instance/testing/testFindStringStartingAtCaseSensitive.st A Collections-Tests.package/StringTest.class/instance/testing/testFindTokens.st A Collections-Tests.package/StringTest.class/instance/testing/testFindTokensEscapedBy.st A Collections-Tests.package/StringTest.class/instance/testing/testFindTokensIncludes.st A Collections-Tests.package/StringTest.class/instance/testing/testFindWordStartStartingAt.st A Collections-Tests.package/StringTest.class/instance/testing/testHasWideCharacterFromTo.st A Collections-Tests.package/StringTest.class/instance/testing/testIncludesSubstring.st A Collections-Tests.package/StringTest.class/instance/testing/testIncludesSubstringCaseSensitive.st A Collections-Tests.package/StringTest.class/instance/testing/testIndexOf.st A Collections-Tests.package/StringTest.class/instance/testing/testIndexOfFirstUppercaseCharacter.st A Collections-Tests.package/StringTest.class/instance/testing/testIndexOfWideCharacterFromTo.st A Collections-Tests.package/StringTest.class/instance/testing/testInitialIntegerOrNil.st A Collections-Tests.package/StringTest.class/instance/testing/testIsAllAlphaNumerics.st A Collections-Tests.package/StringTest.class/instance/testing/testIsWideString.st A Collections-Tests.package/StringTest.class/instance/testing/testLastSpacePosition.st A Collections-Tests.package/StringTest.class/instance/testing/testLeadingCharRunLengthAt.st A Collections-Tests.package/StringTest.class/instance/testing/testNumericSuffix.st A Collections-Tests.package/StringTest.class/instance/testing/testOccursInWithEmptyCaseSensitive.st A Collections-Tests.package/StringTest.class/instance/testing/testOnlyLetters.st A Collections-Tests.package/StringTest.class/instance/testing/testTranslateToLowercase.st A Collections-Tests.package/StringTest.class/instance/testing/testTranslateToUppercase.st R Collections-Tests.package/StringTest.class/instance/tests - indexof/testIndexOf.st M Kernel.package/Context.class/instance/private/doPrimitive_method_receiver_args_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50658.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50659.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50658.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50659.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50659 17872 simulation mirror primitive100 for perform with superclass is not working https://pharo.fogbugz.com/f/cases/17872 17873 Simple Test Cases for String (continued) https://pharo.fogbugz.com/f/cases/17873 http://files.pharo.org/image/50/50659.zip

1 0

modifying copied context vars
by Nicolai Hess March 24, 2016

March 24, 2016

Hello, we have a failing test (OCClosureCompilerTest>>#testDebuggerTempAccess) (fails since spur, but not related - I think). A simple example to reproduce the behavior: | local1 remote1| remote1:=4. local1 :=3.[:i | |c| c := local1. remote1 := i. i halt. "local1:=25. <-- evaluate during debugging" ] value:1. Transcript show:local1;cr. Transcript show:remote1;cr. (Executing this code and evaluating "local:=25" after the debugger halts for "i halt" will modify the var "remote1" instead of "local1", as this is a vector tempvar , proceeding the execution will crash at accessing the remote1 value). The purpose of the testDebuggerTempAccess test case is, evaluating code that changes the value of a copied temp var *does not* change the value of this var in the outer context. (see comment in the test case: "this is not 25 as the var is a local, non escaping variable that was copied into the block, If the compiler would have known about the write, it would have made the var escaping". ) But the implementation (OCCopyingTempVariable>>#writeFromContext: aContext scope: contextScope value: aValue) explicitly iterates through all outer context(s) and changes the vars as well. 1. Question: Who is right? But the reason why the test actually fails is different. It is because evaluating the code that modifies the var "local1:=25" ends up to a call aContext tempAt: self indexFromIR put: aValue but the index (indexFromIR) can be different for every context (method context / inner block context(s)). 2. Question: should the index be always the same? thanks inadvance Nicolai ps: since spur (resp. compiler changes that were done for new spur images), the index of tempvars can be different. In pre-spur, this testcase modifies an outer context var, but one that isn't checked (the argument "two"), therefore the test succeed. In spur, this testcase modifes a different outer context var "remote1", and the test fails.

2 1

Discussing FileSystem >> #workingDirectory and VM process getcwd(3)
by Mariano Martinez Peck March 24, 2016

March 24, 2016

Hi guys, In a couple of recent threads, there were discussions about FileSystem >> #workingDirectory VS VM process getcwd(3) and the fact that they do not match. The current state is as follows: 1) *If Pharo was launched from double click* then we do not care about its location and I think it's correct to default to image location: 1.1) FileSystem >> #workingDirectory refers to the directory containing the .image file 1.2) The VM process getcmd() is the default one of the particular OS ($HOME in my OSX). So...there is a mismatch between #workingDirectory and VM's process cmd. *I think (as Damien said), that we should do a chdir() for the VM process to match the .image location. * 2) *If Pharo was launched from command line* then we likely are interested in the current CMD from where we launched the VM process (imagine using Pharo for scripting). The current status is: 2.1) FileSystem >> #workingDirectory still refers to the directory containing the .image file which I think it is incorrect. 2.2) The CMD of the VM process is correct. But again, there is a mismatch with #workingDirectory. *For this case, I think we should set FileSystem >> #workingDirectory to CMD. * Before start discussing how to implement this, do you agree with the idea? Thanks in advance, -- Mariano http://marianopeck.wordpress.com

5 12

Naming question for new version of Mocketry
by Denis Kudriashov March 23, 2016

March 23, 2016

Hello. I prepare new version of Mocketry with many new functions. And I have little question about some naming. It will be possible to verify (at the end of test) that particular message was happened. My first suggestion was: mock should receive someMessage But from English it not sounds like it should be occurred in past. So what correct and not long sentence can be used here? maybe: mock had received someMessage And same question for verification group of message sends (at the end of test): [mock someMessage. mock2 someMessage2] should occur [mock someMessage. mock2 someMessage2] should occurInSameOrder Does it sounds correct? What suggestions? Best regards, Denis

4 11

Re: [Pharo-dev] [squeak-dev] Re: [Vm-dev] I would be extremely grateful for a reproducible case for the following Socket issue
by Eliot Miranda March 23, 2016

March 23, 2016

Hi Levente, On Wed, Mar 23, 2016 at 11:31 AM, Levente Uzonyi <leves(a)caesar.elte.hu> wrote: > Hi Eliot, > > What sort of reproducibility are you looking for? Is it enough if it > happens once every few hours or do you need something that you can trigger > on demand? I'll take every few hours, but I'd prefer "in under 30 minutes". Getting warm and fuzzy feelings when trying to prove a negative with something that takes hours to run is very difficult. Let's say you have a case which reproduces in 8 hours 50% of the time. To reach 99% confidence level in a fix I'd have to run it for 8 * (50 log: 2) hours without seeing it reproduce, right? That's nearly 2 days; it could take weeks to fix :-( Levente > _,,,^..^,,,_ best, Eliot

1 0

I would be extremely grateful for a reproducible case for the following Socket issue
by Eliot Miranda March 23, 2016

March 23, 2016

http://forum.world.st/Socket-s-readSemaphore-is-losing-signals-with-Cog-on-… On 8/13/2011 13:42, Levente Uzonyi wrote: > Socket's readSemaphore is losing signals with CogVMs on linux. We > found several cases (RFB, PostgreSQL) when processes are stuck in the > following method: > > Socket >> waitForDataIfClosed: closedBlock > "Wait indefinitely for data to arrive. This method will block until > data is available or the socket is closed." > > [ > (self primSocketReceiveDataAvailable: socketHandle) > ifTrue: [^self]. > self isConnected > ifFalse: [^closedBlock value]. > self readSemaphore wait ] repeat > > When we inspect the contexts, the process is waiting for the > readSemaphore, but evaluating (self primSocketReceiveDataAvailable: > socketHandle) yields true. Signaling the readSemaphore makes the > process running again. As a workaround we replaced #wait with > #waitTimeoutMSecs: and all our problems disappeared. > > The interpreter VM doesn't seem to have this bug, so I guess the bug > was introduced with the changes of aio.c. Â« [hide part of quote] Oh, interesting. We know this problem fairly well and have always worked around by changing the wait in the above to a "waitTimeoutMSecs: 500" which turns it into a soft busy loop. It would be interesting to see if there's a bug in Cog which causes this. FWIW, here is the relevant portion: "Soft 500ms busy loop - to protect against AIO probs; occasionally, VM-level AIO fails to trip the semaphore" self readSemaphore waitTimeoutMSecs: 500. Cheers, - Andreas _,,,^..^,,,_ best, Eliot

1 0

[Ann] New version of StateSpecs 2.0
by Denis Kudriashov March 23, 2016

March 23, 2016

Hello. I glad to present new version of StateSpecs: - should expressions based on normal message sends instead of pragma magic Pragma based approach allows to write very natural expressions like 1 should be an instance of: Number But it is completely not practical because it is impossible to work with such code as with any other. No easy way to find senders or implementors of expressions. It is difficult to understand how it works. It's hidden magic. So now this approach is extracted to separate package as nice experiment on what can be done with smalltalk. And legal approach now is to use normal keywords like: 1 should beInstanceOf: SmallInteger 1 should beKindOf: Number With this you can easily find implementors and get full list of defined expressions. (look at class SpecOfShouldExpression) - new functionality: - boolean properties validation. You can send any messages to "should be" which will be executed by subject of "should" and then validated for truth: 1 should be between: 10 and: 50 #(1 2) should be isEmpty - properties chain validation. You can send any series of messages to "object where" to write should expression for internal property: (1@3) where x should be: 1 (0@1 corner: 10@20) where origin x should be: 0 - unordered equality for collections and explicit order sentence: #(1 2) should equal: #(2 1) "not fail" (1 2) should beOrderedEqualTo: #(2 1) "fail" Idea that in tests you usually put as less details as possible. And only if you really need specific behaviour you write it requirement explicitly. - better failures descriptions similar to existed assertions: 1 should be: 2 => Got "1" but it should be "2" 1 should beInstanceOf: String => Got "1" but it should be instance of String #(1 2) should be isEmpty => #(1 2) should be isEmpty (1@3) where x should be: 10 => Got "1" from (1@3) x but it should be 10 - improved existing should expressions: - collection item specification is based on expected item spec #(10 20) should include: 10 at: 1 #(10 20) should include: (Kind of: Number) at: 1 - block failure spec is based on expected failure spec: [1/0] should raise: ZeroDivide "not fail" [1/0] should raise: Error "fail because explicit exception class is specified" [1/0] should raise: (Kind of: Error) "not fail" [self error: 'test'] should raise: errorInstance "fail because raised exception is not the same instance as errorInstance" [1/0] should raiseError "not fail when any kind of errors was signalled" - repackaged to separate specs from DSL code - cleaned classes - comments - no dependency from SMock anymore You can load StateSpecs by Gofer it smalltalkhubUser: 'dionisiy' project: 'StateSpecs'; configurationOf: 'StateSpecs'; loadStable. . Loo at details and examples here http://www.smalltalkhub.com/#!/~dionisiy/StateSpecs I hope StateSpecs can become legal alternative for classic assertions. It models requirements and failures as first class objects which make them good target for object specific tools which will be difficult to achieve with assertion methods. Best regards, Denis

1 0

[pharo-project/pharo-core]
by GitHub March 23, 2016

March 23, 2016

Branch: refs/tags/50658 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 5153ef: 50658
by GitHub March 23, 2016

March 23, 2016

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 5153ef622fc2e172d61a9e8163d712ccb0098308 https://github.com/pharo-project/pharo-core/commit/5153ef622fc2e172d61a9e81… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-03-23 (Wed, 23 Mar 2016) Changed paths: M Collections-Tests.package/ArrayTest.class/instance/initialization/setUp.st M ConfigurationOfUnifiedFFI.package/ConfigurationOfUnifiedFFI.class/instance/symbolic versions/stable_.st A ConfigurationOfUnifiedFFI.package/ConfigurationOfUnifiedFFI.class/instance/versions/v0%5F17_.st M OpalCompiler-Tests.package/OCNewCompilerWithChangesFunctionalTests.class/instance/other-tests/testModulePrimitive.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50657.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50658.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50657.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50658.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st R UnifiedFFI-Legacy.package/extension/FFIExternalObject/instance/handle.st R UnifiedFFI-Legacy.package/extension/FFIExternalObject/instance/handle_.st A UnifiedFFI-Legacy.package/extension/FFIExternalReference/instance/handle.st A UnifiedFFI-Legacy.package/extension/FFIExternalReference/instance/handle_.st A UnifiedFFI-Tests.package/FFIConstantHandleTests.class/README.md A UnifiedFFI-Tests.package/FFIConstantHandleTests.class/definition.st A UnifiedFFI-Tests.package/FFIConstantHandleTests.class/instance/primitives/getTimeReturnConstantHandle_.st A UnifiedFFI-Tests.package/FFIConstantHandleTests.class/instance/primitives/getTime_.st A UnifiedFFI-Tests.package/FFIConstantHandleTests.class/instance/tests/testCall.st A UnifiedFFI-Tests.package/FFIConstantHandleTests.class/instance/tests/testReturn.st A UnifiedFFI.package/FFICharacterType.class/instance/testing/needsArityPacking.st R UnifiedFFI.package/FFICharacterType.class/instance/testing/needsArityRolling.st A UnifiedFFI.package/FFICharacterType.class/instance/testing/needsArityUnpacking.st R UnifiedFFI.package/FFICharacterType.class/instance/testing/needsArityUnrolling.st A UnifiedFFI.package/FFIConstantHandle.class/README.md A UnifiedFFI.package/FFIConstantHandle.class/class/converting/asExternalTypeOn_.st A UnifiedFFI.package/FFIConstantHandle.class/class/instance creation/fromInteger_.st A UnifiedFFI.package/FFIConstantHandle.class/definition.st A UnifiedFFI.package/FFIConstantHandle.class/instance/initialization/createDefaultHandle.st A UnifiedFFI.package/FFIConstantHandleType.class/README.md A UnifiedFFI.package/FFIConstantHandleType.class/class/private/naturalPointerArity.st A UnifiedFFI.package/FFIConstantHandleType.class/definition.st A UnifiedFFI.package/FFIConstantHandleType.class/instance/accessing/externalType.st A UnifiedFFI.package/FFIConstantHandleType.class/instance/accessing/externalTypeSize.st A UnifiedFFI.package/FFIConstantHandleType.class/instance/accessing/instanceVariableName.st A UnifiedFFI.package/FFIConstantHandleType.class/instance/emitting code/emitReturnArgument_context_.st A UnifiedFFI.package/FFIConstantHandleType.class/instance/emitting code/readFieldAt_.st A UnifiedFFI.package/FFIConstantHandleType.class/instance/emitting code/readHandleAt_.st A UnifiedFFI.package/FFIConstantHandleType.class/instance/emitting code/writeFieldAt_with_.st M UnifiedFFI.package/FFIDereferencedOpaqueObjectError.class/README.md A UnifiedFFI.package/FFIExternalReference.class/instance/initialization/createDefaultHandle.st M UnifiedFFI.package/FFIExternalReference.class/instance/initialization/initialize.st M UnifiedFFI.package/FFIExternalReferenceType.class/instance/emitting code/emitReturnArgument_context_.st A UnifiedFFI.package/FFIExternalReferenceType.class/instance/testing/needsArityUnpacking.st R UnifiedFFI.package/FFIExternalReferenceType.class/instance/testing/needsArityUnrolling.st M UnifiedFFI.package/FFIExternalType.class/instance/emitting code/emitArgument_context_.st M UnifiedFFI.package/FFIExternalType.class/instance/emitting code/emitPointerArityRoll_context_.st M UnifiedFFI.package/FFIExternalType.class/instance/emitting code/emitReturnArgument_context_.st A UnifiedFFI.package/FFIExternalType.class/instance/testing/needsArityPacking.st R UnifiedFFI.package/FFIExternalType.class/instance/testing/needsArityRolling.st A UnifiedFFI.package/FFIExternalType.class/instance/testing/needsArityUnpacking.st R UnifiedFFI.package/FFIExternalType.class/instance/testing/needsArityUnrolling.st M UnifiedFFI.package/FFIFloat32.class/instance/emitting code/emitPointerArityRoll_context_.st M UnifiedFFI.package/FFIFloat64.class/instance/emitting code/emitPointerArityRoll_context_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitHandleArityUnpack_type_context_objectClass_instVarName_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityPack_context_arity_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityPack_context_arity_selector_.st R UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityRoll_context_arity_.st R UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityRoll_context_arity_selector_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityUnpack_type_context_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityUnpack_type_context_objectClass_instVarName_.st R UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityUnroll_type_context_.st R UnifiedFFI.package/FFIFunctionArgument.class/instance/emitting code/emitPointerArityUnroll_type_context_objectClass_instVarName_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/private emitting code/addUnpack_fromArity_.st R UnifiedFFI.package/FFIFunctionArgument.class/instance/private emitting code/addUnroll_fromArity_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/private emitting code/emitArgumentVariableAccesingPart_context_objectClass_instVarName_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/private emitting code/emitPointerArityUnpack_context_arity_.st A UnifiedFFI.package/FFIFunctionArgument.class/instance/private emitting code/emitPointerArityUnpack_context_objectClass_instVarName_arity_.st R UnifiedFFI.package/FFIFunctionArgument.class/instance/private emitting code/emitPointerArityUnroll_context_arity_.st R UnifiedFFI.package/FFIFunctionArgument.class/instance/private emitting code/emitPointerArityUnroll_context_objectClass_instVarName_arity_.st A UnifiedFFI.package/FFIInstVarArgument.class/instance/private emitting code/emitArgumentVariableAccesingPart_context_objectClass_instVarName_.st A UnifiedFFI.package/FFIMethodArgument.class/instance/private emitting code/emitArgumentVariableAccesingPart_context_objectClass_instVarName_.st A UnifiedFFI.package/FFIOop.class/instance/testing/needsArityUnpacking.st R UnifiedFFI.package/FFIOop.class/instance/testing/needsArityUnrolling.st A UnifiedFFI.package/FFIOpaqueObjectType.class/instance/testing/needsArityPacking.st R UnifiedFFI.package/FFIOpaqueObjectType.class/instance/testing/needsArityRolling.st A UnifiedFFI.package/FFISelfArgument.class/instance/private emitting code/emitArgumentVariableAccesingPart_context_objectClass_instVarName_.st A UnifiedFFI.package/FFIVoid.class/instance/testing/needsArityPacking.st R UnifiedFFI.package/FFIVoid.class/instance/testing/needsArityRolling.st A UnifiedFFI.package/FFIVoid.class/instance/testing/needsArityUnpacking.st R UnifiedFFI.package/FFIVoid.class/instance/testing/needsArityUnrolling.st A UnifiedFFI.package/extension/ByteArray/instance/packAsDoubleToArity_.st A UnifiedFFI.package/extension/ByteArray/instance/packAsFloatToArity_.st A UnifiedFFI.package/extension/ByteArray/instance/packToArity_.st R UnifiedFFI.package/extension/ByteArray/instance/rollAsDoubleToArity_.st R UnifiedFFI.package/extension/ByteArray/instance/rollAsFloatToArity_.st R UnifiedFFI.package/extension/ByteArray/instance/rollToArity_.st A UnifiedFFI.package/extension/ByteArray/instance/unpackHandleFromArity_.st A UnifiedFFI.package/extension/ExternalAddress/instance/packToArity_.st R UnifiedFFI.package/extension/ExternalAddress/instance/rollToArity_.st A UnifiedFFI.package/extension/ExternalAddress/instance/unpackFromArity_.st A UnifiedFFI.package/extension/ExternalAddress/instance/unpackHandleFromArity_.st R UnifiedFFI.package/extension/ExternalAddress/instance/unrollFromArity_.st A UnifiedFFI.package/extension/Float/instance/packAsDoubleToArity_.st A UnifiedFFI.package/extension/Float/instance/packAsFloatToArity_.st A UnifiedFFI.package/extension/Float/instance/packToArity_.st R UnifiedFFI.package/extension/Float/instance/rollAsDoubleToArity_.st R UnifiedFFI.package/extension/Float/instance/rollAsFloatToArity_.st R UnifiedFFI.package/extension/Float/instance/rollToArity_.st A UnifiedFFI.package/extension/Object/instance/packToArity_.st R UnifiedFFI.package/extension/Object/instance/rollToArity_.st A UnifiedFFI.package/extension/SmallInteger/instance/unpackFromArity_.st R UnifiedFFI.package/extension/SmallInteger/instance/unrollFromArity_.st A UnifiedFFI.package/extension/String/instance/packToArity_.st R UnifiedFFI.package/extension/String/instance/rollToArity_.st A UnifiedFFI.package/extension/UndefinedObject/instance/packToArity_.st R UnifiedFFI.package/extension/UndefinedObject/instance/rollToArity_.st Log Message: ----------- 50658 17859 testModulePrimitive should use mock instead of real class https://pharo.fogbugz.com/f/cases/17859 17866 add support for HANDLE types (windows) https://pharo.fogbugz.com/f/cases/17866 17861 ArrayTest should not use Color https://pharo.fogbugz.com/f/cases/17861 http://files.pharo.org/image/50/50658.zip

1 0

Re: [Pharo-dev] Call a WebService with authentication
by Paul DeBruicker March 22, 2016

March 22, 2016

ZnClient new url: 'https://www.example.com'; username: 'myuser' password: 'mypwd'; get angelo.favero wrote > Hi, all. > > I'm calling a web service with java using this java code to authenticate. > > --------------------------------------------------------------------------------------------------------------------- > Authenticator authenticator = new Authenticator() { > protected PasswordAuthentication getPasswordAuthentication() { > String user = "myuser"; > String password = "mypwd"; > System.out.println("Feeding username and password"); > PasswordAuthentication auth = new PasswordAuthentication(user, > password.toCharArray()); > return auth; > }}; > Authenticator.setDefault(authenticator); > -------------------------------------------------------------------------------------------------------------------- > > I'm looking for an example of smalltak code that does the same thing. -- View this message in context: http://forum.world.st/Call-a-WebService-with-authentication-tp4885984p48860… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

1 0