- Pharo-dev - lists.pharo.org

17240 Spur, when saving an image, it never shrinks
by Ben Coman Feb. 24, 2017

Feb. 24, 2017

@Marcus, I was reviewing this issue before I noticed you flipped the milestone from Pharo 6.0 to Later. But is it solved already? In a fresh image 47.7MB in size I did the following a bunch of times to grow the image file to 400MB o ifNil: [o := OrderedCollection new]. 100 timesRepeat: [ o add: (Array new: 100000) ]. Smalltalk saveSession then I did this o := nil. Smalltalk saveSession. and the image file returned to 47.7MB. Version info... Linux Debian 8 Jessie 32-bit Latest update: #60391 CoInterpreter VMMaker.oscog-eem.1855 uuid: d8e4a3c2-a3bf-4adc-b224-8012903a1ef4 May 4 2016 StackToRegisterMappingCogit VMMaker.oscog-eem.1855 uuid: d8e4a3c2-a3bf-4adc-b224-8012903a1ef4 May 4 2016 https://github.com/pharo-project/pharo-vm.git Commit: b8ec25a570d7539653e1d793e97609adb509aaed Date: 2016-05-04 11:14:22 +0200 By: Esteban Lorenzano <estebanlm(a)gmail.com> Jenkins build #589 https://pharo.fogbugz.com/f/cases/17240/Spur-When-saving-an-image-it-never-… cheers -ben

5 14

Problem with OSSubprocess / signals / heartbeat ?
by Mariano Martinez Peck Feb. 24, 2017

Feb. 24, 2017

Hi guys, There is a bug happening in OSSubprocess since quite some time which we were never able to fix. What happens is that at certain point (after having used OSSubprocess for a while), a simple command like the following would "hang" Pharo: OSSUnixSubprocess new command: 'ls'; arguments: #(); redirectStdout; runAndWaitOnExitDo: [ :process :outString | outString ] Once the image does that, it keeps doing it in a 80% of the cases (so it is easy enough to debug). Guille Polito kept one of these images if someone can give us a hand. He also proposed the great idea of using `strace` to see what was going on. He (together with Pable Tesone) suspected that the heartbeat could be interrupting the `clone()` function which is (I think) called internally by the 'posix_spawn()' which is the one used by OSSubprocess. When these images are "hung" they found at a infinitive loop like this: [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 593498}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 600126}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 606282}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 612528}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 618689}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 624922}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 631145}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 637241}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 643578}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 17477] gettimeofday({1482152630, 649974}, NULL) = 0 [pid 17477] sigreturn() (mask []) = 120 [pid 17477] clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0xf7578768) = ? ERESTARTNOINTR (To be restarted) [pid 17477] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- As you can see, there is a SIGALARM involved. It also looks like the `gettimeofday` is used by the heartbeat ? Could it be that someone the heartbeat is interrupting the `clone()` ? Guille also showed me the `strace` output with a regular / working image: [pid 18647] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- [pid 18647] gettimeofday({1482152829, 481014}, NULL) = 0 [pid 18647] sigreturn() (mask []) = -1 EINTR (Interrupted system call) [pid 18647] getitimer(ITIMER_REAL, {it_interval={0, 2000}, it_value={0, 1917}}) = 0 [pid 18647] recvmsg(3, 0xff7b0734, 0) = -1 EAGAIN (Resource temporarily unavailable) [pid 18647] select(4, [3], [], [3], {0, 1000}) = 0 (Timeout) [pid 18647] getitimer(ITIMER_REAL, {it_interval={0, 2000}, it_value={0, 797}}) = 0 [pid 18647] recvmsg(3, 0xff7b0734, 0) = -1 EAGAIN (Resource temporarily unavailable) [pid 18647] select(4, [3], [], [3], {0, 1000}) = ? ERESTARTNOHAND (To be restarted if no handler) [pid 18647] --- SIGALRM {si_signo=SIGALRM, si_code=SI_KERNEL} --- Does anyone have any hint here? Thanks in advance, -- Mariano http://marianopeck.wordpress.com

4 5

UnixOSProcessPlugin and accessing C array out of bounds
by Holger Freyther Feb. 23, 2017

Feb. 23, 2017

Hi Esteban, while building packages for OBS and going the compile warnings (one of the nice things of newer compilers is the increased diagnostic) I noticed this: [ 196s] /usr/src/packages/BUILD/src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c:4525:20: warning: iteration 64u invokes undefined behavior [-Waggressive-loop-optimizations] [ 196s] if ((semaIndices[sigNum]) > 0) { [ 196s] ^ [ 196s] /usr/src/packages/BUILD/src/plugins/UnixOSProcessPlugin/UnixOSProcessPlugin.c:4524:9: note: containing loop [ 196s] while (sigNum <= (signalArraySize())) { while (sigNum <= (signalArraySize())) { if ((semaIndices[sigNum]) > 0) { setSignalNumberhandler(sigNum, (originalSignalHandlers())[sigNum]); } sigNum += 1; } semaIndices has signalArraySize()/NSIG number of entries and is zero based, it is being accessed with sigNum==NSIG which means one entry beyond the memory of the array? Can you confirm this? restoreDefaultSignalHandlers "Restore signal handlers to their original behaviors." | sigNum | <returnTypeC: 'void'> semaIndices = nil "nil if in interpreter simulation" ifFalse: [sigNum := 1. [sigNum <= self signalArraySize] whileTrue: [((semaIndices at: sigNum) > 0) ifTrue: [self setSignalNumber: sigNum handler: (self originalSignalHandlers at: sigNum).]. sigNum := sigNum + 1]] So it is one based but the array doesn't have an extra element to make it work? How is this normally handled in slang code? holger

3 2

[pharo-project/pharo-core]
by GitHub Feb. 23, 2017

Feb. 23, 2017

Branch: refs/tags/60410 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] e65cbe: 60410
by GitHub Feb. 23, 2017

Feb. 23, 2017

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: e65cbe9d4fdb5c5e7d5d9557e1232a5e625c5de2 https://github.com/pharo-project/pharo-core/commit/e65cbe9d4fdb5c5e7d5d9557… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60409.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60410.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60409.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60410.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M UnifiedFFI-Tests.package/FFICallbackTests.class/instance/tests/testCqsort.st M UnifiedFFI-Tests.package/FFICallbackTests.class/instance/tests/testCqsortWithByteArray.st Log Message: ----------- 60410 19749 FFICallbackTests needs to be skipped for now https://pharo.fogbugz.com/f/cases/19749 http://files.pharo.org/image/60/60410.zip

1 0

[pharo-project/pharo-core] f6558d: 60409
by GitHub Feb. 23, 2017

Feb. 23, 2017

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: f6558da26d4c7f3f14392533dc65b60a5c71f6ae https://github.com/pharo-project/pharo-core/commit/f6558da26d4c7f3f14392533… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-02-23 (Thu, 23 Feb 2017) Changed paths: R Kernel-Tests.package/ContextTest.class/instance/private/expectedFailures.st M ReflectionMirrors-Primitives-Tests.package/MirrorPrimitivesTests.class/instance/tests-write barrier/testMakingObjectReadOnly.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60408.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60409.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60408.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60409.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st R WriteBarrierTests.package/WriteBarrierTest.class/instance/setup/expectedFailures.st Log Message: ----------- 60409 19748 new VMs allow enabling of WriteBarrierTests https://pharo.fogbugz.com/f/cases/19748 http://files.pharo.org/image/60/60409.zip

1 0

[pharo-project/pharo-core]
by GitHub Feb. 23, 2017

Feb. 23, 2017

Branch: refs/tags/60409 Home: https://github.com/pharo-project/pharo-core

1 0

WeakValueDictionary: shouldn't be "absent" after GC?
by Martin Dias Feb. 23, 2017

Feb. 23, 2017

Hi. The answer of: | dictionary | dictionary := WeakValueDictionary with: 'hello' -> 'world' copy. Smalltalk garbageCollect. { dictionary values includes: nil. dictionary at: 'hello'. dictionary at: 'hello' ifAbsent: [ 'absent' ]. dictionary at: 'hello' ifAbsentPut: [ 'put' ]. } is: #(true nil nil nil) Bug or feature? shouldn't the value be considered as absent instead of present (and nil). cheers, MartÃn

5 14

[pharo-project/pharo-core]
by GitHub Feb. 22, 2017

Feb. 22, 2017

Branch: refs/tags/60408 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 1cdbba: 60408
by GitHub Feb. 22, 2017

Feb. 22, 2017

Branch: refs/heads/6.0 Home: https://github.com/pharo-project/pharo-core Commit: 1cdbbada9ba7c8879e9bd2b67d83d2b6fa8e2021 https://github.com/pharo-project/pharo-core/commit/1cdbbada9ba7c8879e9bd2b6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2017-02-22 (Wed, 22 Feb 2017) Changed paths: M BaselineOfIDE.package/BaselineOfIDE.class/instance/baseline/baseline_.st M BaselineOfIDE.package/BaselineOfIDE.class/instance/baseline/groups_.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/README.md A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/class/as yet unclassified/ignoredDependencies.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/class/meta-data - dependency analyser/packageName.st A PharoBootstrap-Initialization.package/ManifestPharoBootstrapInitialization.class/definition.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/README.md A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/classesToInitializeWithDependencies.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/classesToInitializeWithNoDependency.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/initializeClasses.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/class-initialization/runInitializeOnClasses_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/loadPackage_from_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/loadSUnitPackage.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/loadTestPackages.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/reloadBootstrapPackages.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/loading/repository.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/public api/initializeCommandLineHandlerAndErrorHandling.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/public api/run.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/public api/runStartup.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/ignoredTests.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/runTests.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/runTestsOn_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/testClassesFrom_.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/running - tests/testPackages.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/applyPatches.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/fixPharoClassInstallerMethodCopying.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/fixSetInitialCodeFormatter.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/class/temporary-patch/fixUpdateInstancesOfSpecialClasses.st A PharoBootstrap-Initialization.package/PharoBootstrapInitialization.class/definition.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/README.md A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/class/accessing/caseFolding.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/class/accessing/data.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/class/initializing/initializeUnicodeClass.st A PharoBootstrap-Initialization.package/UnicodeDefinitions.class/definition.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60407.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - scripts/script60408.st R ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60407.st A ScriptLoader60.package/ScriptLoader.class/instance/pharo - updates/update60408.st M ScriptLoader60.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 60408 19743 Fix Refactoring-Tests-Group in BaselineOfIDE https://pharo.fogbugz.com/f/cases/19743 19744 integrate PharoBootstrap-Initialization https://pharo.fogbugz.com/f/cases/19744 http://files.pharo.org/image/60/60408.zip

1 0