- Pharo-dev - lists.pharo.org

[ANN] Next Pharo Sprint: April 30
by Marcus Denker April 27, 2021

April 27, 2021

Next Pharo Sprint: April 30 We will organize a Pharo sprint / Moose dojo April 30 Goals of this sprint: - Fix issues from tracker https://github.com/pharo-project/pharo/issues - Especially checking older issues This is a Remote Sprint, it happens on Discord. http://pharo.org/contribute-events We have added a Board to coordinate the work: https://github.com/orgs/pharo-project/projects/9 A list of all Pharo Event of the year an be found here: https://association.pharo.org/events

1 0

Progress Report -> Refactoring Project - ( April 19 - April 23)
by Evelyn Cusi Lopez April 26, 2021

April 26, 2021

Hi everyone, Last week I did these tasks: -* Introduce class deprecation refactoring*, Fix issue: Introduce class Deprecation as Refactoring #9033 <https://github.com/pharo-project/pharo/issues/9033> Check PR <https://github.com/pharo-project/pharo/pull/9103> to know the changes. You can see the new behavior in this video: https://youtu.be/sVq6cyyvf7s . -* Introduce **Migrate References From Class to Another*. Fix issue: MigrateReferencesFromClass: A to: NewClass #9101 <https://github.com/pharo-project/pharo/issues/9101>. Check PR <https://github.com/pharo-project/pharo/pull/9103> to know the changes. - *Add support to alias in RBNamespace *. Fix issue: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> . You can see the changes here: PR <https://github.com/pharo-project/pharo/pull/9141> . - *Improve inline all senders refactoring.* Fix issues: RB - Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042>, Inline senders refactoring does not correctly manage errors #6218 <https://github.com/pharo-project/pharo/issues/6218> . Check PR <https://github.com/pharo-project/pharo/pull/9141> to know the changes. You can watch the new behavior in: https://youtu.be/H9S3nmEHL9s . -* Improve preconditions of Realize Class Refactoring and add tests for it*. Check PR <https://github.com/pharo-project/pharo/pull/9146> to know the changes. You can watch the new behavior in this video: https://youtu.be/UAoiiEK1Xy4 . - *Add preview for refactorings.* Check PR <https://github.com/pharo-project/pharo/pull/9146> to know the changes. Tasks for this week: - Finish to add the new preview to select a default scope. - Fix issue: RB - Inline all senders of class methods (instance creation) doesn't work, need improve pattern to search #9142 <https://github.com/pharo-project/pharo/issues/9142> - Fix issues: Enhance Refactoring Preview Widget #9060 <https://github.com/pharo-project/pharo/issues/9060> and Refactoring dialogs should not be modal #5894 . <https://github.com/pharo-project/pharo/issues/5894> <https://github.com/pharo-project/pharo/issues/6218> - Fix issue: When I rename a method I cannot rename its parameter #9139 <https://github.com/pharo-project/pharo/issues/9139> - Fix issue: Inline temp refactoring can create code with different behavior. #6056 <https://github.com/pharo-project/pharo/issues/6056> (using create cascade refactoring) - Fix issue: RB - Improve instance variable refactoring #8665 <https://github.com/pharo-project/pharo/issues/8665> Regards, Evelyn C.

1 0

This week (16/2021) on the Pharo Issue Tracker
by Marcus Denker April 23, 2021

April 23, 2021

We merged 32 PRs and fixed 23 issue tracker entries this week. https://github.com/pharo-project/pharo/pulse Spec v0.8.10 ============ - added a trait SpTModel to add "model" behavior to presenters. - SpPanedLayout: deprecating position/position: using positionOfSlider: now - Fixed error when entering an empty text on the field of SpRGBSliders (Thanks @jordanmontt) - small fixes NewTools v0.6.3 ================ - Raw inspection should show always first fixed slots then variable slots (thanks @guillep) - do not use gtDisplay things (thanks @Ducasse) - applying deprecations - small fixes Refactoring Tools ================= - RB - Update deprecate method refactoring and add command #9085 https://github.com/pharo-project/pharo/pull/9085 - RB - Fix command extract set up #9109 https://github.com/pharo-project/pharo/pull/9109 Compiler ======== - Refactor semantics analyzer to not rely on #isLocalVariable message #9113 https://github.com/pharo-project/pharo/pull/9113 - Cleanup DoItVariable from locals related methods (markRead and etc.) #9122 https://github.com/pharo-project/pharo/pull/9122 - Compiler-Improve-lookupVar #9118 https://github.com/pharo-project/pharo/pull/9118 Features ======= - adding-variadic-TF-functions #9102 https://github.com/pharo-project/pharo/pull/9102 - Added a setting configuration for ClyTextLineNumberSwitchMorph #9104 https://github.com/pharo-project/pharo/pull/9104 - Pr new help #9090 https://github.com/pharo-project/pharo/pull/9090 - 4443-We-should-have-a-code-critic-rule-checking-for-dot-at-the-end-of-method-signature #9088 https://github.com/pharo-project/pharo/pull/9088 Fixes ===== - remove hidden character #9082 https://github.com/pharo-project/pharo/pull/9082 - Fix #8654 - Process>>#terminate should answer self consistently #8712 https://github.com/pharo-project/pharo/pull/8712 - 9069-Typing-in-Transcript-gives-a-DNU-doItContext-CompletionEngine #9084 https://github.com/pharo-project/pharo/pull/9084 - 5818-SHRBTextStyler-doesnt-format-comments-on-root-AST-node #9083 https://github.com/pharo-project/pharo/pull/9083 - Fix/9056: The 'meta' keyboard shortcut modifier should not be used in the UI #9078 https://github.com/pharo-project/pharo/pull/9078 - Order in Calypso menu order for test handling #9124 https://github.com/pharo-project/pharo/pull/9124 - Continue improving DrTests Doc comments plugin #9081 https://github.com/pharo-project/pharo/pull/9081 - Simplify-CommentTestCase #9116 https://github.com/pharo-project/pharo/pull/9116 Improve Tests ============= - Fixes: #9091: ading some tests to the Mock SUnit extensions #9092 https://github.com/pharo-project/pharo/pull/9092 - ReleaseTest-Dot-end-of-Signature #9097 https://github.com/pharo-project/pharo/pull/9097 - improve-taskit-tests-for-waitingGC #9106 https://github.com/pharo-project/pharo/pull/9106 - testNoUnusedInstanceVariablesLeft-down-to-12 #9126 https://github.com/pharo-project/pharo/pull/9126 - 6337-Ensure-test-classes-are-named-in-singular #9089 https://github.com/pharo-project/pharo/pull/9089 Cleanups ======== - 6319-SmallInteger-as31BitInteger-wrong-on-64-bit-systems #9100 https://github.com/pharo-project/pharo/pull/9100 - Editor-Cleanup-Unused-Rubric-Subclasses #9120 https://github.com/pharo-project/pharo/pull/9120 - Remove GTPlaygroundHelp #9079 https://github.com/pharo-project/pharo/pull/9079

1 0

Progress Report -> Refactoring Project - ( April 12 - April 16)
by Evelyn Cusi Lopez April 19, 2021

April 19, 2021

Hi everyone, Last week I did these tasks: - *Improve and add command to deprecate a method. *Check PR <https://github.com/pharo-project/pharo/pull/9085> to know the changes. - *Improve "Set up score command" *Check PR <https://github.com/pharo-project/pharo/pull/9039> to know the changes. I'm not sure if this issue is still relevant, but you can see the new behavior here: https://youtu.be/ejL_RTLPOMo . -* Fix move method with suggestion of protocol* (Move to package of defining class enh #8929 <https://github.com/pharo-project/pharo/issues/8929>) Check PR <https://github.com/pharo-project/pharo/pull/9095> to know the changes. You can see the new behavior in this video: https://youtu.be/r22E1BUZxrE . - *Add preview rename class refactoring*, now show changes one by one, not all in one. Check PR <https://github.com/pharo-project/pharo/pull/9043> to know the changes. -* Introduce class deprecation refactoring*, It was based mainly on Stef's suggestions, however before doing the PR I hope to resolve some doubts to see if any of the behaviors from the previous refactoring should be preserved. You can see the changes here: https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:ClassDepre… . - I start to do the *new preview to set the default scope*. Still in progress. - I continue fixing the issue: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> and Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042> . Still in progress. Tasks for this week: - Add command to class deprecation refactoring. - Finish to add the new preview to select a default scope. - Finish to fix: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> - Finish to fix issues: Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042> and Inline senders refactoring does not correctly manage errors #6218 <https://github.com/pharo-project/pharo/issues/6218> - Fix issues: Enhance Refactoring Preview Widget #9060 <https://github.com/pharo-project/pharo/issues/9060> and Refactoring dialogs should not be modal #5894 . <https://github.com/pharo-project/pharo/issues/5894> <https://github.com/pharo-project/pharo/issues/6218> Regards, Evelyn C.

2 2

This week (15/2021) on the Pharo Issue Tracker
by Marcus Denker April 16, 2021

April 16, 2021

We merged 35 PRs and closed 14 issues. https://github.com/pharo-project/pharo/pulse merge spec 0.8.9 #9049 ================ - https://github.com/pharo-spec/Spec/releases/tag/v0.8.9 - removed some unused methods (starting to clean up before release a final version) - code presenter: Fix implementors and senders to work as in Pharo 8 (thanks @guillep) - toolbar: fixing moving buttons (thanks @tesonep) - small fixes Fixes ===== - 8966-hidden-Undeclared-instance-variables-after-renaming #8997 https://github.com/pharo-project/pharo/pull/8997 - added a comparisson to KeyboardKey #8436 https://github.com/pharo-project/pharo/pull/8436 - fix-dependency-test-error-with-SUnit-Mock #9054 https://github.com/pharo-project/pharo/pull/9054 - Answer the new instance in OSWindowGestureHandler #9058 https://github.com/pharo-project/pharo/pull/9058 - Parse comments at the end of methods without statements #9066 https://github.com/pharo-project/pharo/pull/9066 Tool Fixes =========== - Links in class comments crash instead of opening a browser #9068 https://github.com/pharo-project/pharo/pull/9068 - 9000-MethodFinder-class-works-as-expected-but-not-in-the-Finder-tool--error-in-Finder-documentation #9017 https://github.com/pharo-project/pharo/pull/9017 - 8978-Selector-extraction-for-browsing-sendersimplementors-does-not-work-for-for-multi-line-calls #9053 https://github.com/pharo-project/pharo/pull/9053 - 8974-Adding-a-breakpoint-using-the-context-menu-does-not-work-in-the-latest-build #9045 https://github.com/pharo-project/pharo/pull/9045 Tool Improvements ================= - 2586 deleting a class with references gives extra do you want to delete anyway msg #8901 https://github.com/pharo-project/pharo/pull/8901 - Allow the user to delete a class even if the class has references. #9055 https://github.com/pharo-project/pharo/pull/9055 - Add simple mock objects implementation to SUnit #8489 https://github.com/pharo-project/pharo/pull/8489 Cleanups ======== - 8941-Cleanup-shadowing-class-Variables #9001 https://github.com/pharo-project/pharo/pull/9001 - 7305-HiExampleCommit-classiceberg-v1-5-6-contains-huuuuge-String #9061 https://github.com/pharo-project/pharo/pull/9061 - IRBuilderTest-testLiteralVariableClassVariable-cleanup #9059 https://github.com/pharo-project/pharo/pull/9059 - DrTest-Simplify-Docomment-detection #9062 https://github.com/pharo-project/pharo/pull/9062 - Cleanup-GLMHighlighterTextParserStyler #9065 https://github.com/pharo-project/pharo/pull/9065 - copyOldValuesToNewVariable-no-offset #9051 https://github.com/pharo-project/pharo/pull/9051 - Remove GTDebuggerHelp and subclasses #9071 https://github.com/pharo-project/pharo/pull/9071 - Remove GTInspectorHelp #9073 https://github.com/pharo-project/pharo/pull/9073 - remove hidden character #9082 https://github.com/pharo-project/pharo/pull/9082 Cleanup: unify class names ======= - Rename WidgetExamples to WidgetExample #9005 https://github.com/pharo-project/pharo/pull/9005 - Rename TabSelected to TabSelectedState. #9008 https://github.com/pharo-project/pharo/pull/9008 - Rename TabDisabled to TabDisabledState #9009 https://github.com/pharo-project/pharo/pull/9009 - Rename Pharo3TabPanelBorder to Pharo3TabPanelBorderStyle. #9028 https://github.com/pharo-project/pharo/pull/9028 - Rename ToggleMenuItemShortcutWithSymbol to ToggleWithSymbolMenuItemShâ¦ #9006 https://github.com/pharo-project/pharo/pull/9006 - Rename ExampleRadioButtonModel to RadioButtonModelExample #9007 https://github.com/pharo-project/pharo/pull/9007 - Rename IconicListItem to IconicListItemMorph. #9031 https://github.com/pharo-project/pharo/pull/9031 - Rename FTMultipleSelection to FTMultipleSelectionStrategy. #9003 https://github.com/pharo-project/pharo/pull/9003 - Rename FTSimpleSelection to FTSimpleSelectionStrategy. #9004 https://github.com/pharo-project/pharo/pull/9004 - Rename IconicButton to IconicButtonMorph and TabLabelItem to TabLabelâ¦ #9037 https://github.com/pharo-project/pharo/pull/9037 - Renaming the TabState hierarchy. #9036 https://github.com/pharo-project/pharo/pull/9036

1 0

Improving Variable Shadow model
by Marcus Denker April 14, 2021

April 14, 2021

The issue tracker entry "Rule required for shadowed variables" [#8009](https://github.com/pharo-project/pharo/issues/8009) It reads: ___ In the CI output log for PRs on Pharo 9 issues I see the following warnings on Roassal classes: SystemNotification: RSCanvas>>numberOfEdges(edges is shadowed) SystemNotification: RSCanvas>>numberOfEdges(edges is shadowed) SystemNotification: RSCanvas>>numberOfNodes(nodes is shadowed) SystemNotification: RSCanvas>>numberOfNodes(nodes is shadowed) SystemNotification: RSComposite>>numberOfEdges(edges is shadowed) SystemNotification: RSComposite>>numberOfEdges(edges is shadowed) SystemNotification: RSComposite>>numberOfNodes(nodes is shadowed) SystemNotification: RSComposite>>numberOfNodes(nodes is shadowed) SystemNotification: RSShape>>printOn:(model is shadowed) SystemNotification: RSShape>>printOn:(model is shadowed) which means we have local variables (or block variable) in a method with the same name as an existing ivar in the class. These cases should be cleaned in Rossal3 for the Pharo 9 image - for that I opened https://github.com/ObjectProfile/Roassal3/issues/321 on Roassal3 issue tracker. But it would be good if we could have a Lint rule that shows that problem so one can avoid it: **Side note:** Yes - there already is a rule called ReTempVarOverridesInstVarRuleTest - but this is only for temps and does not cover variables in blocks like in ```Smalltalk numberOfEdges "Return the number of edges contained in the container" ^ self privateEdges ifNil: [ 0 ] ifNotNil: [ :edges | edges size ] ``` when "edges" is already an instance variable ___ So how is ReTempVarOverridesInstVarRuleTest implemented? ```Smalltalk check: aMethod forCritiquesDo: aCriticBlock | ivarNames problemTemps| ivarNames := aMethod methodClass instVarNames. ivarNames ifEmpty: [ ^ self ]. problemTemps := ((aMethod ast arguments, aMethod ast temporaries) select: [ :node |ivarNames includes: node name]). problemTemps do: [ :node | aCriticBlock cull: (self critiqueFor: aMethod about: node) ] ``` So, this test is done purely on the results of the compilation, it just checks if temps are overriding the instance vars. It just does not care about blocks, nor class variables or globals. We could now, for this issue, recurse into the compiled block closures, but that would make the code quite complex. To see a better solution, let's check who actually prints out the log message in the build. Just searching for a substring will lead us to OCShadowVariableWarning>>#variable:shadows: ```Smalltalk variable: varNode shadows: semVar compilationContext interactive ifTrue: [ OCSemanticError new node: node; compilationContext: compilationContext; messageText: self stringMessage; signal ] ifFalse: [ self showWarningOnTranscript ]. ``` This is an exception raised by the AST visitor that does name analysis, OCASTSemanticAnalyzer: ```Smalltalk variable: variableNode shadows: semVar compilationContext optionSkipSemanticWarnings ifTrue: [ ^semVar ]. ^ OCShadowVariableWarning new node: variableNode; shadowedVar: semVar; compilationContext: compilationContext; signal ``` This method is called whever we lookup a Variable name to create a Variable object describing it: ```Smalltalk declareVariableNode: aVariableNode as: anOCTempVariable | name var | name := aVariableNode name. var := scope lookupVarForDeclaration: name. var ifNotNil: [ "Another variable with same name is visible from current scope. Warn about the name clash and if proceed add new temp to shadow existing var" self variable: aVariableNode shadows: var ]. var := scope addTemp: anOCTempVariable. aVariableNode binding: var. ^ var ``` This means: in non-interactive mode, we just log the error and compile while allowing shadowing. In interactive mode we forbid it (we raise a OCSemanticError exception that will be displayed in the code editor). What could we now do to improve the model of shadowing variables? The best thing would be if we could add the fact that a variable shadows another to the semantic information. That is, it should be modeled as part of the variable. We do not need much: just add this information as a property would be perfectly enough. This way we can add a test method (that check if the property exists). On the level of the Code Critique rule it will be very simple: just get all variables that are defined (args, temps, args of blocks) and check if they are shadowing. That's easy! So what is needed to implement it? We first need to make sure we hand over one more parameter to #variable:shadows: and call it later: right now, in interactive mode, we never create a Variable at all. There is no problem to delay that and tag the variable correctly: ```Smalltalk variable: aVariable shadows: shadowedVariable inNode: variableNode aVariable shadowing: shadowedVariable. compilationContext optionSkipSemanticWarnings ifTrue: [ ^aVariable ]. ^ OCShadowVariableWarning new node: variableNode; shadowedVar: aVariable; compilationContext: compilationContext; signal ``` with: ```Smalltalk declareVariableNode: aVariableNode as: anOCTempVariable | name var shadowed | name := aVariableNode name. var := scope lookupVarForDeclaration: name. var ifNotNil: [ "Another variable with same name is visible from current scope" shadowed := var. ]. var := scope addTemp: anOCTempVariable. aVariableNode binding: var. shadowed ifNotNil: [self variable: var shadows: shadowed inNode: aVariableNode]. ^ var ``` To be able to tag Variables, we implement ```Smalltalk shadowing: anotherVariable self propertyAt: #shadows put: anotherVariable ``` and ```Smalltalk "testing" isShadowing ^self hasProperty: #shadows ``` We do this on Variables, which means that we can later introduce Variable shadow tagging even for instance variables and Class Variables How do we now test this? One idea is to rewrite ReTempVarOverridesInstVarRule>>#check:forCritiquesDo: to use #isShadowing. ReTempVarOverridesInstVarRuleTest is green, we have something that is reado to commit. Let's try ```Smalltalk check: aMethod forCritiquesDo: aCriticBlock | problemTemps | problemTemps := aMethod temporaryVariables select: [ :var | var isShadowing ]. problemTemps do: [ :var | aCriticBlock cull: (self critiqueFor: aMethod about: var definingNode) ] ``` And: Success! This is now a first PR to be done [see here](https://github.com/pharo-project/pharo/pull/8909). This does not yet provide the Rule and the Release Test for shadowing vars in general, but it is a very nice first step that we can build upon next.

3 8

Progress Report -> Refactoring Project - ( April 5 - April 9 )
by Evelyn Cusi Lopez April 12, 2021

April 12, 2021

Hi everyone, Last week I did these tasks: - *Add a default refactoring scope. *Now you can define a default environment through Refactorings Settings, this is useful when you are doing refactoring changes in Global environment. You can see the new behavior in this video: https://www.youtube.com/watch?v=NkxGP0P9klA . Check PR <https://github.com/pharo-project/pharo/pull/8999> to know the changes. - *Improve "Set up score command" *Check PR <https://github.com/pharo-project/pharo/pull/9039> to know the changes. -* Fix move method with empty protocol* (Move to package of defining class enh #8929 <https://github.com/pharo-project/pharo/issues/8929>) Check PR <https://github.com/pharo-project/pharo/pull/9040> to know the changes. - *Add preview rename class refactoring* Check PR <https://github.com/pharo-project/pharo/pull/9043> to know the changes. - I was fixing the issue: https://github.com/pharo-project/pharo/issues/6218 but I found two issues more, these are: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> , Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042> Still in progress. - I was improving the creation of cascades to fix: Inline temp refactoring can create code with different behavior. #6056 <https://github.com/pharo-project/pharo/issues/6056>Still in progress. Tasks for this week: - Fix issue: RBNamespace doesn't support alias #9041 <https://github.com/pharo-project/pharo/issues/9041> - Fix issue: Inline method refactoring doesn't handle well, handling calls to super or overrides #9042 <https://github.com/pharo-project/pharo/issues/9042> - Fix issue: Inline senders refactoring does not correctly manage errors #6218 <https://github.com/pharo-project/pharo/issues/6218> - Finish to fix: Create cascade issue <https://github.com/pharo-project/pharo/issues/6056>. (Fix when the object is referenced after cascade block, fix the assignation when we have returns in called methods) - Fix issue: Introduce class Deprecation as Refactoring #9033 <https://github.com/pharo-project/pharo/issues/9033> <https://github.com/pharo-project/pharo/issues/8871> - Fix issue: move to component refactoring issue. <https://github.com/pharo-project/pharo/issues/8499> <https://github.com/pharo-project/pharo/issues/6218> Regards, Evelyn C.

1 0

Pharo 8.0 crash on resizing with Moom
by Bernhard Pieber April 11, 2021

April 11, 2021

Hi everyone, Is this the right place to report a Pharo 8.0 crash? I am on a MacBookPro16,4 on macOS Big Sur Version 11.2.3 (20D91) with an external 30" Apple Cinema Display (2500 x 1600). Here is what I did: I downloaded PharoLauncher. I created a new image using the official distribution Pharo 8.0 - 64bit (stable). I launched the new image. I clicked on light theme. I resized to full screen using Moom. => It crashed. I could reproduce it three out of five times I tried those steps. Let me add that Moom works very reliably with all other applications. Resizing like that is in my muscular memory. Cheers, Bernhard I dow

2 1

This week (14/2021) on the Pharo Issue Tracker
by Marcus Denker April 9, 2021

April 9, 2021

We merged 36 Pull Requests and closed 29 issues. https://github.com/pharo-project/pharo/pulse Merge newtools 0.6.2 #8951 ========================== - https://github.com/pharo-spec/NewTools/releases/tag/v0.6.2 - enhance control of spotter queries in a presenter (it should present "old" results to appear in new queries) - fixes pharo-spec/NewTools#209 - fixes pharo-spec/NewTools#196 - using a worker pool instead a regular "schedule" - fix a problem of entries being duplicated on history Spec 0.8.8 =========== - https://github.com/pharo-spec/Spec/releases/tag/v0.8.8 - "labelled" presenters moved to deprecated and not loaded by default. - tweak how overlay stack (still can be wrong) - fix a problem when assigning box layout sizes : it was not stacking widget sizes. Refactoring Tools ================ - RB - Method's Refactoring using selected scope #8950 https://github.com/pharo-project/pharo/pull/8950 - RB - Correct selection scope #8960 https://github.com/pharo-project/pharo/pull/8960 - RB - Clean use of "Smalltalk globals" #8959 https://github.com/pharo-project/pharo/pull/8959 Shadowing Variables =================== https://blog.marcusdenker.de/modeling-variable-shadowing-part-ii https://blog.marcusdenker.de/modeling-variable-shadowing-part-iii - Shadowing-Better-Implementation #8931 https://github.com/pharo-project/pharo/pull/8931 - Simplify-OCShadowVariableWarning #8943 https://github.com/pharo-project/pharo/pull/8943 - ReClassVariablesShadowingRule #8940 https://github.com/pharo-project/pharo/pull/8940 - ReClassVariablesShadowingRule-Improve #8965 https://github.com/pharo-project/pharo/pull/8965 - further improve testUndeclared #8964 https://github.com/pharo-project/pharo/pull/8964 Cleanup Shadowing Vars ======================= With the model for shadowing vars merged, we can cleanup. - LocalTimeZone class variable is shadowing the class of the same name. #8979 https://github.com/pharo-project/pharo/pull/8979 - ReleaseTest: testNoShadowedVariablesInMethods #8927 https://github.com/pharo-project/pharo/pull/8927 - reset the ASTCache in #testNoShadowedVariablesInMethods #8986 https://github.com/pharo-project/pharo/pull/8986 - 8935-add-release-test-for-shadowed-ivar--class-vars #8939 https://github.com/pharo-project/pharo/pull/8939 - ClassVariable in RBBrowserEnvironmentTest is shadowing a class #8982 https://github.com/pharo-project/pharo/pull/8982 - ClassVariable in OCOpalExamples is shadowing a class #8980 https://github.com/pharo-project/pharo/pull/8980 - Author in PoolDefiner and PoolDefiner2 is shadowing class #8981 https://github.com/pharo-project/pharo/pull/8981 - Link in ReflectivityDemos is shadowing a class #8983 https://github.com/pharo-project/pharo/pull/8983 - 8988-Failing-tests-ClassTest-testUsesPoolVarNamed-and-testHasPoolVarNamed- #8989 https://github.com/pharo-project/pharo/pull/8989 Fixes ===== - allow system to react to a theme change #8937 https://github.com/pharo-project/pharo/pull/8937 - 8861-Code-Coverage-in-Dr-Tests-is-misreporting-methods-implemented-as-subclassResponsibility #8954 https://github.com/pharo-project/pharo/pull/8954 - 7655-Epicea-fileout-should-produce-Pharo-code-and-not-ombu-definition #8969 https://github.com/pharo-project/pharo/pull/8969 - Don't make SDL_Texture autoRelease from renderer #8962 https://github.com/pharo-project/pharo/pull/8962 - ZdcSecureSocketStreamTest>>#testPlain and ZnHTTPSTests>>#testRequestRâ¦ #8977 https://github.com/pharo-project/pharo/pull/8977 - 8972-Class-instance-variable-menu-error #8973 https://github.com/pharo-project/pharo/pull/8973 - Float numbers are only immediates if the VM/Image has SmallFloats. #8975 https://github.com/pharo-project/pharo/pull/8975 - Use a Mutex instead of a Semaphore to prevent trouble in concurrent sâ¦ #8990 https://github.com/pharo-project/pharo/pull/8990 - CairoLibrary in windows: don't look for cairo.dll #8994 https://github.com/pharo-project/pharo/pull/8994 - fixes: #7599 finally class side fluid does not show anymore the brokeâ¦ #8987 https://github.com/pharo-project/pharo/pull/8987 Cleanups ======== - AST-Tag-ErrorNodes #8936 https://github.com/pharo-project/pharo/pull/8936 - 8932-CI-failure-ArrayTestClassTestCasetestMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses https://github.com/pharo-project/pharo/pull/8938 - #8942 another try: Cleanup some class name in Drtests #8948 https://github.com/pharo-project/pharo/pull/8948 - 8955-failing-test-on-CI-ReleaseTesttestUndeclared #8958 https://github.com/pharo-project/pharo/pull/8958 - CI - Fix broken test ReleaseTest >> #testUndeclared #8971 https://github.com/pharo-project/pharo/pull/8971 - 5388-Improving-RBNode-API: add #hasArguments #8949 https://github.com/pharo-project/pharo/pull/8949 - RBSequenceNode-children-no-accessor #8963 https://github.com/pharo-project/pharo/pull/8963 - 7827-oldDefinition-should-use-the-associated-class-definition-printer #8970 https://github.com/pharo-project/pharo/pull/8970

1 0

Broken window alert
by Guillermo Polito April 7, 2021

April 7, 2021

Hi Guys, With Pablo we were discussing that it would be nice to stop with the integrations until we fix the broken tests. We have crossed the 20 broken tests for more than 20 builds. We should put some energy in fixing those, but we are afraid that if we continue this way, eventually it will become unmanageable. Cheers, Guille

3 6