- Pharo-dev - lists.pharo.org

[Pharo 7.0-dev] Build #278: 20667-Be-able-to-install-breakpoints-by-clicking-on-segment-icons-area
by ci-pharo-ci-jenkins2＠inria.fr Nov. 9, 2017

Nov. 9, 2017

There is a new Pharo build available! The status of the build #278 was: SUCCESS. The Pull Request #459 was integrated: "20667-Be-able-to-install-breakpoints-by-clicking-on-segment-icons-area" Pull request url: https://github.com/pharo-project/pharo/pull/459 Issue Url: https://pharo.fogbugz.com/f/cases/20667 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[IMPORTANT] Is there a bug in Tonel with category:
by Stephane Ducasse Nov. 9, 2017

Nov. 9, 2017

Hi I was working in cleaning the users of asLayoutFrame and when I commit I see - #category : 'Morphic-Base-Layouts' + #category : #Morphic-Base-Layouts but #category : #Morphic-Base-Layouts is not a valid symbol. So is it a bug? Stef

8 23

LayoutFrame bug
by Nicolas Cellier Nov. 9, 2017

Nov. 9, 2017

Hi, don't you get nice red-cross when opening a browser and selecting comment? (Pharo7.0-32bit-b5ec533.image) The problem is LayoutFrame having a Point instead of Number in fraction/offset inst. var. So I defined two horrible hacks in order to be able to work with Pharo Point>>@ n ^x @ n Point>>asInteger ^x asInteger then could instrument the LayoutFrame inst. var. setters with horrible checks like: aNumber isNumber ifFalse: [ self halt]. And after a few seconds of IDE usage: AbstractNautilusUI>>buildCodePanelWithCommentOnRight ...snip... sourceCodePanel addMorph: commentWidget fullFrame: (LayoutFrame identity leftFraction: 0.5@0 ; leftOffset: delta). Huh! it's as pleasant as not eating own dog food I think this comes from a recent refactoring. I can hardly use in image tools to trace it. Iceberg bugs, MC has lost ancestry and is just good at synchronizing disk working copy with image working copy, but there is github & git API: https://github.com/pharo-project/pharo/commit/042baad47fddb63db2dd0beefeec6… As it's nearly impossible to make giant refactorings like this without human error, and as it's as impossible to review pull request with many lines of code, I wonder if it is possible to automate those with rewrite rules... I let you finish the work (open issue, patch, commit, etc...)

4 5

[Pharo 7.0-dev] Build #273: 20661-Fixing-test-from-debugger-should-mark-test-as-green-when-proceed-
by ci-pharo-ci-jenkins2＠inria.fr Nov. 9, 2017

Nov. 9, 2017

There is a new Pharo build available! The status of the build #273 was: SUCCESS. The Pull Request #456 was integrated: "20661-Fixing-test-from-debugger-should-mark-test-as-green-when-proceed-" Pull request url: https://github.com/pharo-project/pharo/pull/456 Issue Url: https://pharo.fogbugz.com/f/cases/20661 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

2 1

You can cheat in FFI as long as you don't get caught...
by Nicolas Cellier Nov. 9, 2017

Nov. 9, 2017

I was trying to inquire about my latest vm crash in libgit2 https://pharo.fogbugz.com/f/cases/20655/vm-crash-in-libgit-git_tree_free-th… when I found this bizarre prototype: ^ self callUnchecked: #(LGitReturnCodeEnum git_diff_tree_to_tree #(LGitDiff * diff , LGitRepository repo , LGitTree old_tree , LGitTree new_tree , LGitDiffOptions * opts)) options: #() While the libgit2 signature differs in indirection levels: https://libgit2.github.com/libgit2/#v0.19.0/group/diff/git_diff_tree_to_tree int git_diff_tree_to_tree(git_diff_list **diff, git_repository *repo, git_tree *old_tree, git_tree *new_tree, const git_diff_options *opts); The fact that it does not differs for opts, made me think of a bug... But no. opts is allocated on external c heap with: callUnchecked: #(LGitReturnCodeEnum git_diff_init_options(LGitDiffOptions * self, LGitOptionsVersionsEnum version)) int git_diff_init_options(git_diff_options *opts, unsigned int version); What you see this time is that signatures match... So the LGitDiffOptions handle will be an ExternalAddress that will really point on a git_diff_options In other words, the handle is a git_diff_options *... IOW, our LGitDiffOptions object points to an external it_diff_options so it is what it promises to be. For the other structures not so. We are lying on the level of indirection, so our LGitTree handle are not really a git_tree *. They are a git_tree **. (an ExternalAddress on a pointer). As long as we lie consistently, it's OK, because it avoids too much packToArity: unpackToArity: dance. That's the "beauty" of C pointers. We can cast them to whatever or pretend they are handle_for_anything * in the intermediate level, as long as original producer and final consumer agree on what it really points to. But from code quality perspective, it really stinks. Anyone like me opening a page to get the exact signature of the function will be scratching head and loose precious time. Especially when tracking vm crash down. I'm not sure how well it's documented, I presume it's a well known conscious hack from the original developpers, but such practice really ought to be discussed here.

3 6

[Pharo 7.0-dev] Build #277: 20582-atat-messages-call-errorKeyNotFound
by ci-pharo-ci-jenkins2＠inria.fr Nov. 9, 2017

Nov. 9, 2017

There is a new Pharo build available! The status of the build #277 was: SUCCESS. The Pull Request #454 was integrated: "20582-atat-messages-call-errorKeyNotFound" Pull request url: https://github.com/pharo-project/pharo/pull/454 Issue Url: https://pharo.fogbugz.com/f/cases/20582 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #276: 20664-set-the-display-size-sooner
by ci-pharo-ci-jenkins2＠inria.fr Nov. 9, 2017

Nov. 9, 2017

There is a new Pharo build available! The status of the build #276 was: SUCCESS. The Pull Request #458 was integrated: "20664-set-the-display-size-sooner" Pull request url: https://github.com/pharo-project/pharo/pull/458 Issue Url: https://pharo.fogbugz.com/f/cases/20664 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #275: 20499-Examples-in-GlamourPresentationModel-should-have-no-gtExamplePragma
by ci-pharo-ci-jenkins2＠inria.fr Nov. 9, 2017

Nov. 9, 2017

There is a new Pharo build available! The status of the build #275 was: SUCCESS. The Pull Request #455 was integrated: "20499-Examples-in-GlamourPresentationModel-should-have-no-gtExamplePragma" Pull request url: https://github.com/pharo-project/pharo/pull/455 Issue Url: https://pharo.fogbugz.com/f/cases/20499 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Zinc and Zodiac - Synching/Contributing
by Torsten Bergmann Nov. 9, 2017

Nov. 9, 2017

Hi Sven, for Zinc there is a new issue: 1. Zinc is using #asBytesDescription. It should not be used as it is deprecated https://github.com/pharo-project/pharo/pull/401 there is also 2. https://pharo.fogbugz.com/f/cases/20557 which is not yet integrated. I also proposed some simple but necessary cleanups for Zodiac in Pharo 7: 3. Proper categorization in Zodiac-Tests package - to use "test" category instead of "testing" and better group the tests written https://github.com/pharo-project/pharo/pull/355/files Also it looks like the #setUp in Zodiac tests never send a "super setUp". Which should be fixed too. I've noticed that both Zinc/Zodiac are not hosted on STHub. You seem to use your own custom hosting server on http://mc.stfx.eu/Zodiac http://mc.stfx.eu/ZincHTTPComponents as well as github: https://github.com/svenvc/zinc https://github.com/svenvc/zodiac If we just merge the changes from 3. into Pharo 7 they may later be overwritten when synching also Zodiac again as in 2. So how can we contribute from community side to both projects? Should I fork https://github.com/svenvc/zodiac and send a PR to it so that you can integrate? Thanks Torsten

6 8

[Pharo 7.0-dev] Build #274: 20662-displaying-method-versions-in-Nautilus-causes-DNU
by ci-pharo-ci-jenkins2＠inria.fr Nov. 9, 2017

Nov. 9, 2017

There is a new Pharo build available! The status of the build #274 was: SUCCESS. The Pull Request #457 was integrated: "20662-displaying-method-versions-in-Nautilus-causes-DNU" Pull request url: https://github.com/pharo-project/pharo/pull/457 Issue Url: https://pharo.fogbugz.com/f/cases/20662 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0