- Pharo-dev - lists.pharo.org

Monticello file out bug during bootstrap
by Alistair Grant Feb. 27, 2018

Feb. 27, 2018

Hi Everyone, I'm working on integrating the file attribute primitives in to the main code during bootstrap. Class methods for FileAttributesPluginPrims are written out as: !FileAttributesPluginPrims classSide methodsFor: 'initialize' stamp: 'nil'! reset "Reload the masks" Default := nil.! ! As you can see, the class name is written with "classSide" instead of "class", resulting in the method quietly being ignored during file in. This comes about in: MCStWriter>>writeMethodPreamble: definition self chunkContents: [:str | stream bang. str nextPutAll: definition fullClassName; nextPutAll: ' methodsFor: '; nextPutAll: definition category asString printString; nextPutAll: ' stamp: '; nextPutAll: definition timeStamp asString printString ] which calls: MCMethodDefinition>>fullClassName "Using #class selector for classes for backwards compatibility" ^ self classIsMeta ifFalse: [self className] ifTrue: [ (self actualClass isNil or: [ self actualClass isTrait ]) ifFalse: [self className, ' class'] ifTrue: [self className, ' classSide']] Because FileAttributesPluginPrims doesn't exist in the image (the code is read in from the git repository and being written out to a .st file), #actualClass returns nil, resulting in "classSide" being used instead of "class". I've never seen "classSide" used in chunk format. Is there any time "classSide" is valid, and any suggestions on how this should be fixed? (My first thought is to just change MCStWriter>>writeMethodPreamble: to only write "class"). Thanks, Alistair

3 8

[Pharo 7.0-dev] Build #619: 21419-Integrate-Calypso
by ci-pharo-ci-jenkins2＠inria.fr Feb. 27, 2018

Feb. 27, 2018

There is a new Pharo build available! The status of the build #619 was: SUCCESS. The Pull Request #966 was integrated: "21419-Integrate-Calypso" Pull request url: https://github.com/pharo-project/pharo/pull/966 Issue Url: https://pharo.fogbugz.com/f/cases/21419 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #617: 21425-remove-some-dead-code-referencing-SmalltalkEditor
by ci-pharo-ci-jenkins2＠inria.fr Feb. 27, 2018

Feb. 27, 2018

There is a new Pharo build available! The status of the build #617 was: SUCCESS. The Pull Request #969 was integrated: "21425-remove-some-dead-code-referencing-SmalltalkEditor" Pull request url: https://github.com/pharo-project/pharo/pull/969 Issue Url: https://pharo.fogbugz.com/f/cases/21425 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #616: 21269 Provide tags in package Announcements-Core for better structure
by ci-pharo-ci-jenkins2＠inria.fr Feb. 27, 2018

Feb. 27, 2018

There is a new Pharo build available! The status of the build #616 was: SUCCESS. The Pull Request #823 was integrated: "21269 Provide tags in package Announcements-Core for better structure" Pull request url: https://github.com/pharo-project/pharo/pull/823 Issue Url: https://pharo.fogbugz.com/f/cases/21269 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #615: 21423-Improve-even-more-the-Test-reports
by ci-pharo-ci-jenkins2＠inria.fr Feb. 27, 2018

Feb. 27, 2018

There is a new Pharo build available! The status of the build #615 was: SUCCESS. The Pull Request #968 was integrated: "21423-Improve-even-more-the-Test-reports" Pull request url: https://github.com/pharo-project/pharo/pull/968 Issue Url: https://pharo.fogbugz.com/f/cases/21423 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Simplified AST "Suggestions" menu definitions
by Marcus Denker Feb. 27, 2018

Feb. 27, 2018

Hi, I started to simplidy the âSmartSuggestionsâ code. What does it do? It adds the âsuggestionsâ menu to the editor context menu, this shows operations that make sense for the AST node a the cursor position. -> removed lots of state from SugsSuggestion (label, position, â¦). Instead uses methods. -> simplified how to define new suggestions. Here is a small example: a menu to browse the defintion of variables. First we need to make a suclass of SugsSuggestion. 1) add a subclass of SugsSuggestion SugsSuggestion subclass: #SugsBrowseVariableDefintion instanceVariableNames: '' classVariableNames: '' package: 'SmartSuggestions-Suggestion' 2) define on the class side a method that defines for which AST nodes you want the menu to be shown. Here is is all Variable Nodes: nodes ^{RBVariableNode} 3) On the instance side, we just need to define a label label ^ 'Browse Variable definition' translated 4) and we need to define #execute which just implements what is supposed to happen: execute | semanticVariable | semanticVariable := context selectedNode binding. semanticVariable isInstance ifTrue: [ ^semanticVariable slot definingClass browse ]. semanticVariable isTemp ifTrue: [ ^semanticVariable scope node method browse ]. semanticVariable isClassVariable ifTrue: [ ^semanticVariable scope getClass browse ]. semanticVariable isGlobal ifTrue: [ Smalltalk globals inspect ]. DONE. The simplified SmartSuggestions are in the latest Pharo7, so you can play with the code there, the SugsBrowseVariableDefintion is not (yet?) in Pharo7. (maybe someone wants to submit it?) Next steps: - get rid of the âContextâ and instead embed the AST in the editor. This will be nice for *many* other clients (AST Node navigation, code completion, syntax highlightingâ¦) - liberate the AST menu entries from the âsuggestionsâ submenu: they should just appear in the standard editor context menu. Marcus

5 7

[Pharo 7.0-dev] Build #614: 21415 Move primitive failure methods from Object to ProtoObject
by ci-pharo-ci-jenkins2＠inria.fr Feb. 26, 2018

Feb. 26, 2018

There is a new Pharo build available! The status of the build #614 was: SUCCESS. The Pull Request #964 was integrated: "21415 Move primitive failure methods from Object to ProtoObject" Pull request url: https://github.com/pharo-project/pharo/pull/964 Issue Url: https://pharo.fogbugz.com/f/cases/21415 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array
by ci-pharo-ci-jenkins2＠inria.fr Feb. 26, 2018

Feb. 26, 2018

There is a new Pharo build available! The status of the build #593 was: SUCCESS. The Pull Request #932 was integrated: "21390-Do-not-store-any-non-literals-in-the-literal-array" Pull request url: https://github.com/pharo-project/pharo/pull/932 Issue Url: https://pharo.fogbugz.com/f/cases/21390 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

4 3

[Pharo 7.0-dev] Build #613: 21413 Cleanup JobTest
by ci-pharo-ci-jenkins2＠inria.fr Feb. 26, 2018

Feb. 26, 2018

There is a new Pharo build available! The status of the build #613 was: SUCCESS. The Pull Request #962 was integrated: "21413 Cleanup JobTest" Pull request url: https://github.com/pharo-project/pharo/pull/962 Issue Url: https://pharo.fogbugz.com/f/cases/21413 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #612: 21420-The-XML-Test-reports-should-have-independent-filenames-for-each-CI-Node
by ci-pharo-ci-jenkins2＠inria.fr Feb. 26, 2018

Feb. 26, 2018

There is a new Pharo build available! The status of the build #612 was: SUCCESS. The Pull Request #967 was integrated: "21420-The-XML-Test-reports-should-have-independent-filenames-for-each-CI-Node" Pull request url: https://github.com/pharo-project/pharo/pull/967 Issue Url: https://pharo.fogbugz.com/f/cases/21420 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0