- Pharo-dev - lists.pharo.org

Esteban's ChangeLog week of 26 February 2018
by estebanlm＠gmail.com March 7, 2018

March 7, 2018

Hello! This is my weekly ChangeLog, from 26 February 2018 to 4 March 2018. You can see it in a better format by going here: http://log.smallworks.eu/web/search?from=26/2/2018&to=4/3/2018 ChangeLog ========= 2 March 2018: ------------- * I've been working on Iceberg UI. I have first versions of: * repositories browser * individual repository browser * individual repository management browser * commit window * push window * pull windows I'm not woking on fix a couple of problems on refreshing windows and defining how the pull will work (by default, it will trigger a merge of the changes your are pulling into your image). 1 March 2018: ------------- * I made a new backport for 6.1, [case: 21344](https://pharo.fogbugz.com/f/cases/21344) enjoy 28 February 2018: ----------------- * Well... I spent an stupid amount of time to figure out why the latest VM for macOS was not including libgit2. Turns out, there was a "deploy filter" problem (two problems, in fact), that was making that all pharo flavours were being uploaded to the file server and with same name so in fact, one flavour was being copied on top of the other. And "lowcode VM", for example, does not includes libgi2. So, now that's fixed. You can start using latest VM again (which is the one that is signed) ;) cheers! Esteban

3 3

[ANN] 64 bits support preview
by Mariano Martinez Peck March 7, 2018

March 7, 2018

Hi guys, Thanks for Guillermo Polito we now have 64 bits support for OSSubprocess. You can see the required changes in this PR [1]. I made a branch called `support64bits` so that you can help us test it even if CI said it was good [2]. If you do test it and come back to us with the results, please tell us which OS you used. To install from the branch: Metacello new configuration: 'OSSubprocess'; repository: 'github://marianopeck/OSSubprocess:support64bits/repository'; version: #stable; load. Roadmap: Current release is v0.2.5. So I will let that release for Pharo <= 5.0. I will make a new release with the Pharo 64 bits and call it v0.3. That release should be used for Pharo 6.x. Once v0.3 is out, I will make a new release v0.4 with some changes I wanted to do since a loooong time and its a small refactor to minimize OSSubprocess dependency on OSProcesses primitives (at VM side). This is thanks to Holger Freyther and Alistair Grant [3]. As that requires a new VM, then v0.4 should be used in Pharo >= 7.0. Cheers, [1] https://github.com/marianopeck/OSSubprocess/pull/30 [2] https://travis-ci.org/guillep/OSSubprocess/builds/349280174 [3] https://github.com/pharo-project/pharo-vm/pull/142 -- Mariano http://marianopeck.wordpress.com

3 2

[Pharo 7.0-dev] Build #663: 21489 Cleanup TReplacementSequencedTest
by ci-pharo-ci-jenkins2＠inria.fr March 7, 2018

March 7, 2018

There is a new Pharo build available! The status of the build #663 was: SUCCESS. The Pull Request #1022 was integrated: "21489 Cleanup TReplacementSequencedTest" Pull request url: https://github.com/pharo-project/pharo/pull/1022 Issue Url: https://pharo.fogbugz.com/f/cases/21489 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #662: 21489 Cleanup TReplacementSequencedTest
by ci-pharo-ci-jenkins2＠inria.fr March 7, 2018

March 7, 2018

There is a new Pharo build available! The status of the build #662 was: FAILURE. The Pull Request #1022 was integrated: "21489 Cleanup TReplacementSequencedTest" Pull request url: https://github.com/pharo-project/pharo/pull/1022 Issue Url: https://pharo.fogbugz.com/f/cases/21489 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #661: 21327-Integrate-the-new-version-of-Modular-Stateful-Traits
by ci-pharo-ci-jenkins2＠inria.fr March 7, 2018

March 7, 2018

There is a new Pharo build available! The status of the build #661 was: SUCCESS. The Pull Request #871 was integrated: "21327-Integrate-the-new-version-of-Modular-Stateful-Traits" Pull request url: https://github.com/pharo-project/pharo/pull/871 Issue Url: https://pharo.fogbugz.com/f/cases/21327 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #660: 21508-Integrate-Calypso-0103
by ci-pharo-ci-jenkins2＠inria.fr March 6, 2018

March 6, 2018

There is a new Pharo build available! The status of the build #660 was: SUCCESS. The Pull Request #1037 was integrated: "21508-Integrate-Calypso-0103" Pull request url: https://github.com/pharo-project/pharo/pull/1037 Issue Url: https://pharo.fogbugz.com/f/cases/21508 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Ann] Commander shortcuts in Settings Browser
by Denis Kudriashov March 6, 2018

March 6, 2018

Hi. With latest version of Commander and Calypso we will have all shortcuts explorable and configurable in Settings Browser: â Currently it uses command class name and class comment for presentation. We can improve it in future if necessary. In addition you can add single shortcut to your own application settings. For example: MyApp class>>appSettingsOn: aBuilder <systemsettings> ann := ClySpawnFullBrowserCommand classAnnotationAt: #browserShortcutActivation. (ann buildSettingNodeOn: aBuilder) label: 'My app shortcut'; description: 'This command opens browser' Shortcut settings are persisted as all other settings. Only redefined shortcuts are stored into the file. This version also allows to add commands into the world menu and world shortcuts. Just use CmdWorldMenuContext for command annotations: CmdOpenFamilyBookCommand class>>worldMenuActivation <classAnnotation> ^CmdContextMenuCommandActivation byRootGroupItemFor: CmdWorldMenuContext CmdOpenFamilyBookCommand class>>globalShortcutActivation <classAnnotation> ^CmdShortcutCommandActivation by: $o meta, $f meta for: CmdWorldMenuContext (CmdOpenFamilyBookCommand is a command from Commander-Examples package). Nice detail: all shortcuts are updated immediately when you modify annotations either from settings or programmatically from browser. Now pull request for Pharo 7 <https://github.com/pharo-project/pharo/pull/1037> is waiting integration. Soon it will be inside. Best regards, Denis

3 2

FFI Struct Argument Pass By Value Fails on Mac 64 bit
by Todd Blanchard March 6, 2018

March 6, 2018

I've been trying to track this down for a couple weeks now. I have concluded that structs passed by value to functions on the 64 bit VM are not properly populated. The struct's memory is all zero'd. I found this while trying to work with LibClang and found that functions that fetched code locations from code ranges always returned invalid zero'd locations. After spending some time with lldb I have traced the problem into the native code and found that the argument is not correct. I've carved out the wee bit of clang to reproduce this in a tiny library. The gist of it is below and the entire file is included. Basically the struct passed to the function clang_getRangeStart is zero'd memory regardless of the data I send from the image side. The build command I used on sierra is clang -shared -undefined dynamic_lookup -o microclang.dylib microclang.c I'm stuck. The FFI64 plugin is way beyond my comprehension. // microclang.c typedef struct { const void *ptr_data[2]; unsigned int_data; } CXSourceLocation; /** * \brief Identifies a half-open character range in the source code. * * Use clang_getRangeStart() and clang_getRangeEnd() to retrieve the * starting and end locations from a source range, respectively. */ typedef struct { const void *ptr_data[2]; unsigned begin_int_data; unsigned end_int_data; } CXSourceRange; const char* first = "first_pointer"; const char* second = "second_pointer"; // return a fake range with non zero data CXSourceRange clang_getArbitraryRange() { CXSourceRange range = {0}; range.ptr_data[0] = (void*)first; range.ptr_data[1] = (void*)second; range.begin_int_data = 17; range.end_int_data = 24; return range; } // Actual clang function - range is always zero'd here despite having values in the image CXSourceLocation clang_getRangeStart(CXSourceRange range) { // Special decoding for CXSourceLocations for CXLoadedDiagnostics. if ((uintptr_t)range.ptr_data[0] & 0x1) { CXSourceLocation Result = { { range.ptr_data[0], nullptr }, 0 }; return Result; } CXSourceLocation Result = { { range.ptr_data[0], range.ptr_data[1] }, range.begin_int_data }; return Result; }

4 13

Buffer overriuns detected by fortify in the AioPlugin (was Re: Pharo6 with Ubuntu and OSSubprocess/threaded heartbeat crashes and problems
by Eliot Miranda March 6, 2018

March 6, 2018

Hi, aioEnable et al should really check the fd argument against FD_SETSIZE and answer error codes that get tested in clients. See two messages below: On Tue, Mar 6, 2018 at 2:49 AM, Sabine Manaa <manaa.sabine(a)gmail.com> wrote: > Hi, > > I can report the following: > > The problem with the Buffer overflow remains also with OSProcess. > Also with the normal vm (https://get.pharo.org ). > > Summary: I have buffer overflow crashes with my application on Linux. > The same code runs without problems on MacOS and on Windows. > I have the same test data/database and do exactly the same. > > The problem occurs only after calling several times OSProcess/OSSubprocess. > This is the reason why I first had a suspicion that OSSubprocess is > responsible for the crashes. > > Can anyone tell me how to proceed to find the reason for the buffer > overflow? > There is no PharoDebug.log > > Help is very appreciated! > > This is the message when terminating: > > root@Pharo_ubuntu_16:/spf/build# ./pharo Pharo-Productive-SPF.image > --no-quit > > SmalltalkImageInstanceID class>>startUp*** buffer overflow detected ***: > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/pharo terminated > > ======= Backtrace: ========= > > /lib/i386-linux-gnu/libc.so.6(+0x67377)[0xf75b9377] > > /lib/i386-linux-gnu/libc.so.6(__fortify_fail+0x68)[0xf7649708] > > /lib/i386-linux-gnu/libc.so.6(+0xf58f8)[0xf76478f8] > > /lib/i386-linux-gnu/libc.so.6(+0xf75fa)[0xf76495fa] > > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/pharo(aioEnab > le+0x31)[0x80c9811] > > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/pharo[0x81215ee] > > [0x90010e0] > > [0x90ad2d0] > > [0x90db8b4] > > [0x90ad24a] > > [0x900be6b] > > [0x900b04d] > > [0x9007a3e] > > [0x9004247] > > [0x9004572] > > [0x9001020] > > [0xa98c524] > > [0xb1755db] > > [0x9003efc] > > [0x9001020] > > [0xdcb558c] > > [0xb0d4d95] > > [0x9000ff0] > > ======= Memory map: ======== > > 08048000-08164000 r-xp 00000000 00:1b 1183256 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/pharo > > 08164000-08165000 r--p 0011b000 00:1b 1183256 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/pharo > > 08165000-08170000 rw-p 0011c000 00:1b 1183256 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/pharo > > 08170000-081a7000 rw-p 00000000 00:00 0 > > 08fdd000-08ffe000 rw-p 00000000 00:00 0 > [heap] > > 09000000-09100000 rwxp 00000000 00:00 0 > > 09100000-11200000 rw-p 00000000 00:00 0 > > f552e000-f554a000 r-xp 00000000 00:1b 8244 > /lib/i386-linux-gnu/libgcc_s.so.1 > > f554a000-f554b000 rw-p 0001b000 00:1b 8244 > /lib/i386-linux-gnu/libgcc_s.so.1 > > f554b000-f684c000 rw-p 00000000 00:00 0 > > f684c000-f684f000 r-xp 00000000 00:1b 1183242 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/JPEGReaderPlugin.so > > f684f000-f6850000 r--p 00002000 00:1b 1183242 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/JPEGReaderPlugin.so > > f6850000-f6851000 rw-p 00003000 00:1b 1183242 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/JPEGReaderPlugin.so > > f6851000-f68b2000 r-xp 00000000 00:1b 1183230 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libssl.so.1.0.0 > > f68b2000-f68b3000 ---p 00061000 00:1b 1183230 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libssl.so.1.0.0 > > f68b3000-f68b5000 r--p 00061000 00:1b 1183230 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libssl.so.1.0.0 > > f68b5000-f68b9000 rw-p 00063000 00:1b 1183230 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libssl.so.1.0.0 > > f68b9000-f6a7b000 r-xp 00000000 00:1b 1183239 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libcrypto.so.1.0.0 > > f6a7b000-f6a7c000 ---p 001c2000 00:1b 1183239 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libcrypto.so.1.0.0 > > f6a7c000-f6a8c000 r--p 001c2000 00:1b 1183239 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libcrypto.so.1.0.0 > > f6a8c000-f6a93000 rw-p 001d2000 00:1b 1183239 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/libcrypto.so.1.0.0 > > f6a93000-f6a96000 rw-p 00000000 00:00 0 > > f6a96000-f6a9b000 r-xp 00000000 00:1b 1183249 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/SqueakSSL.so > > f6a9b000-f6a9c000 r--p 00004000 00:1b 1183249 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/SqueakSSL.so > > f6a9c000-f6a9d000 rw-p 00005000 00:1b 1183249 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/SqueakSSL.so > > f6a9d000-f6ab1000 r-xp 00000000 00:1b 7925 > /lib/i386-linux-gnu/libresolv-2.23.so > > f6ab1000-f6ab2000 ---p 00014000 00:1b 7925 > /lib/i386-linux-gnu/libresolv-2.23.so > > f6ab2000-f6ab3000 r--p 00014000 00:1b 7925 > /lib/i386-linux-gnu/libresolv-2.23.so > > f6ab3000-f6ab4000 rw-p 00015000 00:1b 7925 > /lib/i386-linux-gnu/libresolv-2.23.so > > f6ab4000-f6ab6000 rw-p 00000000 00:00 0 > > f6ab6000-f6abb000 r-xp 00000000 00:1b 7931 > /lib/i386-linux-gnu/libnss_dns-2.23.so > > f6abb000-f6abc000 r--p 00004000 00:1b 7931 > /lib/i386-linux-gnu/libnss_dns-2.23.so > > f6abc000-f6abd000 rw-p 00005000 00:1b 7931 > /lib/i386-linux-gnu/libnss_dns-2.23.so > > f6abd000-f6c05000 rw-p 00000000 00:00 0 > > f6c05000-f6c2e000 r-xp 00000000 00:1b 8373 > /lib/i386-linux-gnu/libpng12.so.0.54.0 > > f6c2e000-f6c2f000 r--p 00028000 00:1b 8373 > /lib/i386-linux-gnu/libpng12.so.0.54.0 > > f6c2f000-f6c30000 rw-p 00029000 00:1b 8373 > /lib/i386-linux-gnu/libpng12.so.0.54.0 > > f6c30000-f6c49000 r-xp 00000000 00:1b 8362 > /lib/i386-linux-gnu/libz.so.1.2.8 > > f6c49000-f6c4a000 r--p 00018000 00:1b 8362 > /lib/i386-linux-gnu/libz.so.1.2.8 > > f6c4a000-f6c4b000 rw-p 00019000 00:1b 8362 > /lib/i386-linux-gnu/libz.so.1.2.8 > > f6c4b000-f6cf6000 r-xp 00000000 00:1b 8395 > /usr/lib/i386-linux-gnu/libfreetype.so.6.12.1 > > f6cf6000-f6cfa000 r--p 000aa000 00:1b 8395 > /usr/lib/i386-linux-gnu/libfreetype.so.6.12.1 > > f6cfa000-f6cfb000 rw-p 000ae000 00:1b 8395 > /usr/lib/i386-linux-gnu/libfreetype.so.6.12.1 > > f6cfb000-f6d02000 r-xp 00000000 00:1b 1183229 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/FT2Plugin.so > > f6d02000-f6d03000 r--p 00006000 00:1b 1183229 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/FT2Plugin.so > > f6d03000-f6d04000 rw-p 00007000 00:1b 1183229 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/FT2Plugin.so > > f6d04000-f6d0f000 r-xp 00000000 00:1b 7934 > /lib/i386-linux-gnu/libnss_files-2.23.so > > f6d0f000-f6d10000 r--p 0000a000 00:1b 7934 > /lib/i386-linux-gnu/libnss_files-2.23.so > > f6d10000-f6d11000 rw-p 0000b000 00:1b 7934 > /lib/i386-linux-gnu/libnss_files-2.23.so > > f6d11000-f6d38000 rw-p 00000000 00:00 0 > > f6d38000-f6d39000 ---p 00000000 00:00 0 > > f6d39000-f7539000 rw-p 00000000 00:00 0 > [stack:21188] > > f7539000-f753b000 r-xp 00000000 00:1b 7968 > /usr/lib/i386-linux-gnu/gconv/MACINTOSH.so > > f753b000-f753c000 r--p 00001000 00:1b 7968 > /usr/lib/i386-linux-gnu/gconv/MACINTOSH.so > > f753c000-f753d000 rw-p 00002000 00:1b 7968 > /usr/lib/i386-linux-gnu/gconv/MACINTOSH.so > > f753d000-f7544000 r--s 00000000 00:1b 7977 > /usr/lib/i386-linux-gnu/gconv/gconv-modules.cache > > f7544000-f754a000 r-xp 00000000 00:1b 1183240 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/vm-sound-OSS.so > > f754a000-f754b000 r--p 00005000 00:1b 1183240 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/vm-sound-OSS.so > > f754b000-f754c000 rw-p 00006000 00:1b 1183240 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/vm-sound-OSS.so > > f754c000-f754e000 r-xp 00000000 00:1b 1183257 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/vm-display-null.so > > f754e000-f754f000 r--p 00001000 00:1b 1183257 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/vm-display-null.so > > f754f000-f7550000 rw-p 00002000 00:1b 1183257 > /spf/build/pharo-vm/lib/pharo/5.0-201707201942/vm-display-null.so > > f7550000-f7552000 rw-p 00000000 00:00 0 > > f7552000-f7702000 r-xp 00000000 00:1b 7921 > /lib/i386-linux-gnu/libc-2.23.so > > f7702000-f7704000 r--p 001af000 00:1b 7921 > /lib/i386-linux-gnu/libc-2.23.so > > f7704000-f7705000 rw-p 001b1000 00:1b 7921 > /lib/i386-linux-gnu/libc-2.23.so > > f7705000-f7708000 rw-p 00000000 00:00 0 > > f7708000-f775b000 r-xp 00000000 00:1b 7917 > /lib/i386-linux-gnu/libm-2.23.so > > f775b000-f775c000 r--p 00052000 00:1b 7917 > /lib/i386-linux-gnu/libm-2.23.so > > f775c000-f775d000 rw-p 00053000 00:1b 7917 > /lib/i386-linux-gnu/libm-2.23.so > > f775d000-f7776000 r-xp 00000000 00:1b 7920 > /lib/i386-linux-gnu/libpthread-2.23.so > > f7776000-f7777000 r--p 00018000 00:1b 7920 > /lib/i386-linux-gnu/libpthread-2.23.so > > f7777000-f7778000 rw-p 00019000 00:1b 7920 > /lib/i386-linux-gnu/libpthread-2.23.so > > f7778000-f777a000 rw-p 00000000 00:00 0 > > f777a000-f777d000 r-xp 00000000 00:1b 7923 > /lib/i386-linux-gnu/libdl-2.23.so > > f777d000-f777e000 r--p 00002000 00:1b 7923 > /lib/i386-linux-gnu/libdl-2.23.so > > f777e000-f777f000 rw-p 00003000 00:1b 7923 > /lib/i386-linux-gnu/libdl-2.23.so > > f777f000-f7780000 rw-p 00000000 00:00 0 > > f7780000-f7781000 r-xp 00000000 00:00 0 > [vdso] > > f7781000-f77a4000 r-xp 00000000 00:1b 7919 > /lib/i386-linux-gnu/ld-2.23.so > > f77a4000-f77a5000 r--p 00022000 00:1b 7919 > /lib/i386-linux-gnu/ld-2.23.so > > f77a5000-f77a6000 rw-p 00023000 00:1b 7919 > /lib/i386-linux-gnu/ld-2.23.so > > ffc55000-ffcd1000 rw-p 00000000 00:00 0 > [stack] > > ./pharo: line 11: 14639 Aborted "$DIR"/"pharo-vm/pharo" > --nodisplay "$@" > > On Tue, Mar 6, 2018 at 5:26 AM, Henrik Sperre Johansen < henrik.s.johansen(a)veloxit.no> wrote: > Seems to me aioEnable somehow triggers this. > It maintains buffers of size FD_SETSIZE (1024 on Linux)*, so an fd > parameter** >= that, could probably trigger such an error. > Maybe you could put a halt in whichever method in OSSubprocess/OSProcess > calls the primitive triggered when condition occurs, to see if that is the > cause? > If so, identifying *why* you end up with fd's that high (which, afaik, > isn't > normal), will probably lead to a workaround/solution... > > Cheers, > Henry > > * > https://github.com/pharo-project/pharo-vm/blob/e0ce2d9d78c3c > 7b37bbc12cd8730c6a15f1f057c/opensmalltalk-vm/platforms/unix/vm/aio.c > ** > https://github.com/pharo-project/pharo-vm/blob/c50dec02d2875 > de56c84d11889c78484e2d5cda8/mc/VMConstruction-Plugins- > AioPlugin.package/UnixAioPlugin.class/instance/primitiveAioEnable.st > > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html > _,,,^..^,,,_ best, Eliot

1 0

[Pharo 7.0-dev] Build #659: 21507-remove-SugsSmalltalkEditorContext
by ci-pharo-ci-jenkins2＠inria.fr March 6, 2018

March 6, 2018

There is a new Pharo build available! The status of the build #659 was: SUCCESS. The Pull Request #1036 was integrated: "21507-remove-SugsSmalltalkEditorContext" Pull request url: https://github.com/pharo-project/pharo/pull/1036 Issue Url: https://pharo.fogbugz.com/f/cases/21507 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0