- Pharo-dev - lists.pharo.org

ANN: Introducing PhEPs (Pharo Enhancement Proposals)
by Esteban Lorenzano May 17, 2022

May 17, 2022

Hello, Some of you were present at PharoDays 2022 were we made a presentation explaining this new way of handling the evolution of Pharo. In that talk we explained that this is an attempt of having the community involved in more deep way, with a clear (and visible) decision process, taking the model the Python community has been using with success (so why not us? :P). In a nutshell, the idea is that everybody wanting to work on any kind of enhancement for Pharo can now send their proposal and start a discussion process (a discussion arbitrated by the Pharo Board), and if this discussion leads to an accepted enhancement, the work will be integrated as part of the Pharo Environment. How it works? - There is a repository: https://github.com/pharo-project/pheps - and a detailed description of the process: https://github.com/pharo-project/pheps/blob/main/phep-0001.md You will have all the information you need there, but here is a summary of the process (you can also find it in the guidelines PhEP): 0. (Optional, but recommended) the proposer discusses the idea in pharo-dev list or discord, with members of the team, and gather ideas. 1. The proposer will clone the PhEP repository (pharo-project/pheps) and adds a proposal draft following the required stucture: - the file will not have an ID, hence it needs to be called `phep-proposal.md` - the proposal will have the header and structure explained in the section **Submitting a PhEP** (header, abstract, motivation and description). - the proposal will also have a "champion" (which by default is the author itself), responsible for the implementation of the proposal in case is been accepted. 2. The proposal will be submitted as PR to the PhEP repository. 3. A mail will be send to `pharo-dev` mailing list, including the link and the abstract of the proposal. 4. There will be a discussion process and in case of acceptance of the proposal, an ID will be assigned by the reviewer. 5. As final stage, the author renames the `phep-proposal.md` file as `phep-ID.md` and includes the ID in the phep file header (this step can be performed by the reviewer if he decides so). 6. The reviewer will merge the PR In the next days I will be sending a couple fo PhEPs to add to those already there, to get the process started. Do not hesitate to participate! Cheers, Esteban ps: Yes, I am aware "pheps" sounds fun on english :)

1 0

[review needed] Better structure for CleanBlock Hierachy
by Marcus Denker May 17, 2022

May 17, 2022

Hi, For now, CleanBlockClosure was a subclass of FullBlockClosure, which is not nice (as CleanBlockClosure is not a FullBlockClosure) The PR https://github.com/pharo-project/pharo/pull/11225 improves that a bit: â¢ make CleanBlockClosure a subclass of BlockClosure â¢ BlockClosure is now tagged abstract â¢ override #receiver in CleanBlockClosure â¢ push down #sender â¢ Improve comments ( fixes Check BlockClosure comments for mention of startpc #11217 ) Both CleanBlockClosure and FullBlockClosure add the ivar âreceiverâ, as the vm needs it (it is nil for CleanBlockClosure). This we should look at that later. e.g. have it defined in BlockClosure once, but that has to be done as itâs own PR as it is not a change doable from the image. The change should be save to merge, as CleanBlockClosure is, for now, just used in the tests that turn it on explicitly. PR for review: https://github.com/pharo-project/pharo/pull/11225 Marcus

1 0

Consider watching the GitHub repo
by Marcus Denker May 16, 2022

May 16, 2022

Hi, GitHub creates a kind of âspontaneous mini mailinglistsâ for every issue and every PR. For one, this is nice as all the discussion is at one place and can be found easily, and it makes sure those who are involved in the issue get the messages (e.g. the one who created an issue tracker entry). But: you will only see those by default. If you want to get an impression of things happening, it might be interesting to âWatchâ the repository. You can do that by clicking on the âWatchâ button on https://github.com/pharo-project/pharo Marcus

1 0

[Review Needed] Resolves #11184: printStringLimitedTo:Using: will fail to actually respect limit
by Marcus Denker May 13, 2022

May 13, 2022

Review Needed: Resolves #11184: printStringLimitedTo:Using: will fail to actually respect limit https://github.com/pharo-project/pharo/pull/11185 "Changes Object >> printStringLimitedTo:Using so that it actually properly respects the limit, and that it doesn't add '...etc...' when exactly at the limit and thus not needed."

1 0

This week (19/2022) on the Pharo Issue Tracker
by Marcus Denker May 13, 2022

May 13, 2022

We merged 14 Pull Requests and fixed 17 Issues. There are always more issues ready to be reviewed https://github.com/pharo-project/pharo/pulls Feature ======= - 6720-Dictionary--newFrom-logic-can-be-improved- #11176 https://github.com/pharo-project/pharo/pull/11176 - Fixes #11165 begins with and ends with should return true on empty string #11173 https://github.com/pharo-project/pharo/pull/11173 Clean Blocks ============ - Fix-messagetally-tests-Cleanblocks #11209 https://github.com/pharo-project/pharo/pull/11209 Bugs ==== - 6323-RubSmalltalkEditor-meta-j-shortcut-not-working #11205 https://github.com/pharo-project/pharo/pull/11205 - FIX issue #10933: Scaled decimals comparison result depends on the number creation method #10951 https://github.com/pharo-project/pharo/pull/10951 - Implement EpInverseVisitor>>#visitTraitModification: #11208 https://github.com/pharo-project/pharo/pull/11208 - 11198-Pharo11-Reflectivity-do-not-add-temp-for-value-if-not-generating-the-primtive-Wrapper #11199 https://github.com/pharo-project/pharo/pull/11199 Cleanup ======= - 11216-categorize-ZnStaticFileDecoratorDelegate-classdecorateservingFilesFrom #11224 https://github.com/pharo-project/pharo/pull/11224 - 11162-Check-ReToDoRule #11164 https://github.com/pharo-project/pharo/pull/11164 - Fix for the issue #11115: Feature Envy clipRect on AthensCairoCanvas #11117 https://github.com/pharo-project/pharo/pull/11117 - 11144-LocaleAnnouncementTest-seems-to-be-unused #11189 https://github.com/pharo-project/pharo/pull/11189 Pharo10 ======= - Remembering scroll position when collapsing and expanding tree table items #11202 https://github.com/pharo-project/pharo/pull/11202 - Making completion support $_ in class and method names #11197 https://github.com/pharo-project/pharo/pull/11197 - 11198-Pharo10-Reflectivity-do-not-add-temp-for-value-if-not-generating-the-primtive-Wrapper #11200 https://github.com/pharo-project/pharo/pull/11200

1 0

About Pull Request Reviews: Multiple Reviews are best!
by Marcus Denker May 12, 2022

May 12, 2022

Hi, If you see that a PR that you wanted to review already has a positive review, do not think âah, nothing to be done for meâ. Because imagine if the PR would be bad: you would add a comment how to improve in addition to the one already positive review. You should do the same even if you just add another âYes, looks goodâ. The reason is that *you* know that you looked at the PR and did not find a problem, but nobody else has a way to see that. Second (or even third, 4thâ¦) positive reviews are very valuable, they validate the first review *and* they are vote for getting that PR merged fast. You can find the PRs in need of a review here: https://github.com/pharo-project/pharo/pulls Marcus

1 0

Pharo Launcher 3.0.1: no GUI
by Shaping May 12, 2022

May 12, 2022

From: Shaping <shaping(a)uurda.org> Sent: Wednesday, 4 May, 2022 02:46 To: 'Pharo Development List' <pharo-dev(a)lists.pharo.org> Cc: 'Pharo-users' <pharo-users(a)lists.pharo.org> Subject: [Pharo-dev] Re: [ANN] Pharo Launcher 3.0.1 released! On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. â¦ I do have SDL2.dll in â¦\AppData\Local\PharoLauncher. Still the GUI doesnât open Hi Christophe. Do we understand why the PL 3.0.1 GUI doesnât open sometimes even when SDL2.dll is present? I have in my PharoLauncher folder 74 items. One of those is the images folder. Is that as it should be? â¦ Should the PL 3.0.1 installer produce a \PharoLancher install folder containing 74 items, of which one is the \images folder? If there is a file/folder list discrepancy, we can start the debugging there. â¦ I rebooted the PC, uninstalled PL 3.0.1, and then reinstalled it. The GUI still doesnât appear, but I have 70 files/folders now (not 74), one of which is \images. The difference seems to be caused by the change in OS state after the reboot. Strange. Any ideas? I still have an SDL2.dll. So, although the absence of this file in Johnâs install explains his missing GUI, it doesnât explain mine. Is anyone besides John and me seeing no PL 3.0.1 GUI on Windows? Shaping

1 0

[ANN] Pharo Launcher 3.0.1 released!
by Christophe Demarey May 10, 2022

May 10, 2022

Hi all, Pharo Launcher 3.0.1 has just been released! It is available from http://pharo.org/download <http://pharo.org/download>. It fixes some issues reported on Pharo Launcher 3.0. Here is the changelog: Pharo Launcher v3.0.1 Bug fixes: #554 <https://github.com/pharo-project/pharo-launcher/issues/554> UI does not show up on Windows #551 <https://github.com/pharo-project/pharo-launcher/issues/551> Show folder button is broken in Windows 10 #550 <https://github.com/pharo-project/pharo-launcher/issues/550> About Box shows "untitled Window" #549 <https://github.com/pharo-project/pharo-launcher/issues/549> Better display of download error messages. #358 <https://github.com/pharo-project/pharo-launcher/issues/358> Restore proxy authentication settings. Regards, The Pharo team.

3 9

About ReToDoRule
by Marcus Denker May 10, 2022

May 10, 2022

I have never seen ReToDoRule to suggest a change that I wanted to do. I think it tries to detect if there is #at: send to the collection inside the block and suggests to use more high-level iterators. But the suggestions are odd and it seems to be too naive with just detecting the #at: message send to the iterated value. "Checks for use of to:do: when a do:, with:do: or timesRepeat: when should be used.â â¢ #timesRepeat: does not take an argument for the block with the running index, so it is not a replacement â¢ with:do: is not a replacement for to:do: ? it would mean creating first a collection and then iterating â¢ using do: on an interval is bad, we even have a rule against that: ReUnoptimizedToDoRule Maybe I am missing something? The rule ReToDoCollectRule seems to be working nicely, though. Issue tracker entry: https://github.com/pharo-project/pharo/issues/11162

1 1

Dictionary newFrom: and duplicated keys
by Marcus Denker May 10, 2022

May 10, 2022

Hi, Dictionary class>>#newFrom: right now raises an error if it sees duplicated keys. newFrom: aDictionaryOrCollectionOfAssociations "Answer an instance of me containing the same associations as the argument. Error if any key appears twice." | newDictionary | newDictionary := self new: aDictionaryOrCollectionOfAssociations size. aDictionaryOrCollectionOfAssociations associationsDo: [:x | (newDictionary includesKey: x key) ifTrue: [self error: 'Duplicate key: ', x key printString] ifFalse: [newDictionary add: x]]. ^ newDictionary this leads to an error for: {#a->1. #a->2} asDictionary While just creating it with new and putting the data of course has no problem with duplicated keys: Dictionary new at: #a put: 1; at: #a put: 2; yourself We have a suggestion to remove the error. PR is here: https://github.com/pharo-project/pharo/pull/11176 <https://github.com/pharo-project/pharo/pull/11176> (as a side-effect, this speed up asDictionary a little, too) Marcus

1 0