- Pharo-dev - lists.pharo.org

[Issue Tracker] issues with proposed fixes
by Marcus Denker June 2, 2022

June 2, 2022

Hi, Sometimes it happens that a *description* of a fix is added to the issue tracker entry. We try to tag them with âFix Proposed" https://github.com/pharo-project/pharo/labels/Fix%20proposed <https://github.com/pharo-project/pharo/labels/Fix%20proposed> In practice, it is either astonishingly hard to turn a description into a fix, or it is so trivial that it feels as if nothing has to be done. (It feels sometimes that finding the solution is the real contribution, while actually doing it feels like boring work). - add, if possible, the code of the whole changed method, too (I often wonder if it is all correct after doing the steps described by a textual description, especially if the method got changed in between) - Make it *really* clear in the issue tracker entry that a fix has been proposed. Sometimes it gets lost in the discussion. - Doing a PR from an issue that already has a description is very valuable This can a nice way to contribute for beginners. âIt donât understand if it is good, but I made a PR for the solution described in the issue" Marcus

1 0

[ Review needed] Some easy to review PRs
by Marcus Denker June 1, 2022

June 1, 2022

Some easy to review small improvements (which in turn makes them easier to review): 1) use #isSelectorSymbol instead of #findInternedSelector: https://github.com/pharo-project/pharo/pull/11313 2) Improve: Symbol class>>#internSelector: can just record the symbol https://github.com/pharo-project/pharo/pull/11315 3) optimize MorphExtension>>#valueOfProperty: a little https://github.com/pharo-project/pharo/pull/11314 Marcus

1 0

Question about MethodDictionary in TraitedClass (methodDict/localMethodDict)
by Andrei Chis May 30, 2022

May 30, 2022

Hi, We were profiling the loading of code that uses many Traits. We saw something like this (this is a tally for `TraitedMetaclass>>#addAndClassifySelector:withMethod:inProtocol:`): [image: Screenshot 2022-05-11 at 17.17.37.png] >From what we saw in `TraitedMetaclass>>#addAndClassifySelector:withMethod:inProtocol:` a method is first added to `localMethodDict` and then it calls the super method that adds the selector to the `methodDict` of the actual class in `Behaviour>>addSelectorSilently:withMethod: `. Because of this we basically get an overhead as a method is added to two method dictionaries and adding a method to a MethodDictionary is slower, as it does operations like `flushCache` and `cachePragmas`. Should the `localMethodDict` also be an instance of MethodDictionary or could it be a simple dictionary? Cheers, Andrei

2 2

[PR in need of Review] Redraw world on SDL_WINDOWEVENT_EXPOSED #11240
by Marcus Denker May 30, 2022

May 30, 2022

This PR needs a review: Redraw world on SDL_WINDOWEVENT_EXPOSED #11240 https://github.com/pharo-project/pharo/pull/11240

2 1

This week (21/2022) on the Pharo Issue Tracker
by Marcus Denker May 30, 2022

May 30, 2022

This week we merged 27 PRs and fixed 23 Issues. Symbol/SelectorTable Improvements ================================ - Symbol-simpler-findInternedSelector #11281 https://github.com/pharo-project/pharo/pull/11281 - 11243-Symbol-classrebuildSelectorTable-hould-not-use-allInstancesDo #11244 https://github.com/pharo-project/pharo/pull/11244 - remove OneCharacterSymbols from Symbol #11247 https://github.com/pharo-project/pharo/pull/11247 Features ======== - Add rules for simplification of isNotNil ifTrue:, notNil ifTrue:ifFalse #11261 https://github.com/pharo-project/pharo/pull/11261 Fixes ====== - Pharo11-UFT8-Monticello #11239 fixes: Commits with ... (introduced by GH) in summary cannot be loaded back in Pharo #11226 https://github.com/pharo-project/pharo/pull/11239 Debugger ======== - Adding debuggerLayout in TStDebuggerExtensionLayout` to be able to choose the layout the debugger extension should have #376 https://github.com/pharo-spec/NewTools/pull/376 - Fixing odd behaviour in debugger inspector filters #359 https://github.com/pharo-spec/NewTools/pull/359 - Fixes context menu commands of the StDebugger stack. #373 https://github.com/pharo-spec/NewTools/pull/373 - [cleanup] fix selector name: initalizeSelectedList #369 https://github.com/pharo-spec/NewTools/pull/369 Cleanups ======== - 11245-Trivial-FinderUI-classsearchedTextListMaxSize-can-be-removed #11249 https://github.com/pharo-project/pharo/pull/11249 - 11255-OrderedCollection-adding-methods-remove-a-poppushTemp #11256 https://github.com/pharo-project/pharo/pull/11256 - [clean up] isLiteral and TestRunner method never call #11257 https://github.com/pharo-project/pharo/pull/11257 - Fixed issue 11210: Do not skip NativeArrayTest>>#testDoubleArraysHaveCorrectLayout #11260 https://github.com/pharo-project/pharo/pull/11260 - 10185-merge-ReSmalllintChecker-into-SmalllintManifestChecker #11219 https://github.com/pharo-project/pharo/pull/11219 Trivial Cleanups ================ - Cleanup IdentityTransform class>>#initialize #11289 https://github.com/pharo-project/pharo/pull/11289 - Cleanup: categorize ProcessLocalSlotTest #11288 https://github.com/pharo-project/pharo/pull/11288 - Cleanup: align #isTransparent and other #isXXX methods #11280 https://github.com/pharo-project/pharo/pull/11280 - Cleanup: #isCharacter should be in same "testing" category (not "acceâ¦ #11278 https://github.com/pharo-project/pharo/pull/11278 - Cleanup: small improvements for Webbrowser package #11283 https://github.com/pharo-project/pharo/pull/11283 - Cleanup Delay>>#isExpired #11269 https://github.com/pharo-project/pharo/pull/11269 - Cleanup: lint for ComputedSlotTest>>#testReadComputedSlotCompiled #11285 https://github.com/pharo-project/pharo/pull/11285 - Cleanup: remove unnecessary class #initialize comment #11292 https://github.com/pharo-project/pharo/pull/11292 - Cleanup: #isBlock should be in same "testing" category (not "accessing") #11277 https://github.com/pharo-project/pharo/pull/11277 - Properly categorize "is..." methods #11267 https://github.com/pharo-project/pharo/pull/11267 - Cleanup: small category cleanup in Path #11274 https://github.com/pharo-project/pharo/pull/11274 - #isResumable shoud be in "testing" or "private - testing" #11271 https://github.com/pharo-project/pharo/pull/11271 - Cleanup-DeadCode-05-20 #11250 https://github.com/pharo-project/pharo/pull/11250

1 0

About Image Size Pharo9->Pharo11
by Marcus Denker May 20, 2022

May 20, 2022

Pharo9: 65,8 MB Pharo10: 57,4 MB Pharo11: 56,5 MB The space saving come from three things: 1) Code cleanup Pharo9-Pharo10 ========================= e.g. removal of support in Kernel and Compiler of old style blocks and bytecodes, to mention one smaller (in term of image size) but deep cleanup. Of course, we can do more here. There is still a lot of dead code (and duplicated things) in the image! 2) Global Literal Sharing =================== Literals are now, when the method is compiled, set to be read-only, recursively in the case of arrays. This allows us to unify (share one instance) not only in the same method, but globally over all methods. As the compiler can not do a global literal table when compiling a single method (too slow), this is implemented as an additional pass, called as part of the build process. If you load a lot of code, it might be an idea to do that as part of your build again: ImageCleaner shareLiterals 3) Improvement of code structure objects =============================== e.g, in Pharo10 we found two empty OrderedCollections per class that where not needed. Further work on this idea is where the improvement in Pharo11 comes from, we merged these three changes: - Class>>#classPool: empty dictionary for all classes, but not many define class vars #11172 https://github.com/pharo-project/pharo/issues/11172 - [Memory] sharedPools OrderedCollections waste memory #10957 https://github.com/pharo-project/pharo/issues/10957 - [Memory] AllProtocol uses a lot of memory #10963 https://github.com/pharo-project/pharo/issues/10963 The classPools/sharedPool improves the size of the bootstrapped image not to0 much as the boostrap creates classes with nil there, but for newly loaded code this will be more visible. This direction has some more fairly simple next steps: - [Memory] commentSourcePointer is not needed for MetaClasses https://github.com/pharo-project/pharo/issues/10958 - [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959 https://github.com/pharo-project/pharo/issues/10959 ... and of course there are many more things to find with just looking a bit. (And it is interesting starting point to think about better language support for making long living but rarely changed data structures more memory efficient) If you want to get an impression of which classes use image space, "SpaceTally printSpaceAnalysis" prints a per-class analysis. Marcus

3 3

This week (20/2022) on the Pharo Issue Tracker
by Marcus Denker May 20, 2022

May 20, 2022

We merged 10 PRs and closed 9 Issues: Image Size ========== - Reset SelectorTable on #cleanUp #11235 https://github.com/pharo-project/pharo/pull/11235 Clean Blocks ============ - CleanBlock-Hierachy-Cleanup #11225 https://github.com/pharo-project/pharo/pull/11225 - 11218-CleanBlocks-Compiler-should-not-change-the-outerCode-for-all-blocks-in-the-literals #11229 https://github.com/pharo-project/pharo/pull/11229 Fixes ===== - OneCharacterSymbols: Symbol allSymbols contains one-character symbols twice #11241 https://github.com/pharo-project/pharo/pull/11241 - Revert "FIX issue #10933: Scaled decimals comparison result depends on the number creation method" #11228 https://github.com/pharo-project/pharo/pull/11228 - Fix an issue where streaming client usage failed when the server set a connection close. #11214 https://github.com/pharo-project/pharo/pull/11214 - Porting fixes from Pharo 10 to Pharo 11 #11207 https://github.com/pharo-project/pharo/pull/11207 Forward port to Pharo11: Allow to serialize Memory File Systems #11116 #11122 Forward port Pharo11: Fix #isPrime when sent to 3. #11154 Cleanup ======= - 11230-ClassParser-Improve-Hierarchy-CDSharedVariableNodeCDSlotNode #11231 https://github.com/pharo-project/pharo/pull/11231 - Categorize-Uncategorized-IceTipSpPresenter #1585 https://github.com/pharo-vcs/iceberg/pull/1585

1 0

PhEP submitted: String interpolation for Pharo
by Esteban Lorenzano May 19, 2022

May 19, 2022

Hello, There is a new PhEP (Pharo Enhancement Proposal) submitted titled: "String interpolation for Pharo" that requires the attention of the community: https://github.com/pharo-project/pheps/pull/9 Cheers! Esteban

1 0

[Review needed] Symbol allSymbols contains one-character symbols twice #11242
by Marcus Denker May 19, 2022

May 19, 2022

Symbol allSymbols asBag occurrencesOf: #a allSymbols returns an array of all symbols. The reason it contains #a twice: There is OneCharacterSymbols. - it is initialized with: OneCharacterSymbols := (1 to: 256) collect: [ :i | (i - 1) asCharacter asSymbol]. the #asSymbol puts the OneCharacterSymbols in the main symbol table already. Then OneCharacterSymbols is just used by #allSymbols and #selectorsContaining:, with the latter having no users. https://github.com/pharo-project/pharo/pull/11241 Besides the bugfix, it removes some one Character symbols that never got used and speeds up #allSymbols a little. And it simplifies the code related to the symbol table a little, which will make it easier to improve it later. Marcus

1 0

Please check older Issue tracker entries!
by Marcus Denker May 18, 2022

May 18, 2022

Hi, One problem with a public issue tracker: it accumulates lots of issuesâ¦ This sadly means that issues will not be looked at one by oneâ¦ there are just too many. One thing that is interesting to do is to check the issue that *you* submitted. - Is the issue still relevant? - is the title good and in sync with the issue? - Has it been fixed already ? (it happens!) Then, for every issue there is a ânext stepâ. It can be a good thing to spell out very explicitly what the next step is âWe need to create a Pull Request for the suggested fixâ. Or maybe what is needed is a summary of the huge discussion in the issue tracker entry. Another idea: try to find others to help. E.g. - send a mail to the mailinglist. - ask on discord. Maybe you can find a small group that works on this issue together. Marcus

4 3