- Pharo-dev - lists.pharo.org

[Pharo 7.0-dev] Build #914: 21920-includesSubstring-should-be-in-testing-and-not-in-accessing
by ci-pharo-ci-jenkins2＠inria.fr May 18, 2018

May 18, 2018

There is a new Pharo build available! The status of the build #914 was: SUCCESS. The Pull Request #1377 was integrated: "21920-includesSubstring-should-be-in-testing-and-not-in-accessing" Pull request url: https://github.com/pharo-project/pharo/pull/1377 Issue Url: https://pharo.fogbugz.com/f/cases/21920 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #913: 21519-RemoveFromSystem-does-not-work-well-with-Undeclareds
by ci-pharo-ci-jenkins2＠inria.fr May 17, 2018

May 17, 2018

There is a new Pharo build available! The status of the build #913 was: FAILURE. The Pull Request #1374 was integrated: "21519-RemoveFromSystem-does-not-work-well-with-Undeclareds" Pull request url: https://github.com/pharo-project/pharo/pull/1374 Issue Url: https://pharo.fogbugz.com/f/cases/21519 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #912: 18180-whichSelectorsAccess-cannot-find-some-of-the-variables-using-slots
by ci-pharo-ci-jenkins2＠inria.fr May 17, 2018

May 17, 2018

There is a new Pharo build available! The status of the build #912 was: FAILURE. The Pull Request #1375 was integrated: "18180-whichSelectorsAccess-cannot-find-some-of-the-variables-using-slots" Pull request url: https://github.com/pharo-project/pharo/pull/1375 Issue Url: https://pharo.fogbugz.com/f/cases/18180 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Idea and proof of concept: Accept for Test
by Marcus Denker May 17, 2018

May 17, 2018

Hi, Some code is very âactiveâ, executed all the time, e.g. collections, graphicsâ¦ or imagine if you work on the compiler or debugger. It would really be nice if we could test a change before accepting it. Something like âAccept for Testâ where magically the original method does not change, yet, when running tests, the version of the code we accepted for testing is executed. So how do we implement that? 1) menu in the browser. I did a quick hack, a Suggestions AST menu shows for all nodes (to be replaced with the âcorrectâ way later). SugsSuggestion subclass: #SugsAcceptForTest instanceVariableNames: '' classVariableNames: '' package: 'SmartSuggestions-Suggestionâ label ^'Accept for testâ So, now we can do everything in the #execute method. What do we need? 1) How we know that we are in a test? â> CurrentExecutionEnvironment value isTest 2) can we compile the buffer even if there are syntax errors (kind of what I expect to happen in non-accepted code)? â> yes, remember, we use the same Parser for syntax highlighting and we extended code-generation for SyntaxError Nodes in the past (it raises a syntax error at runtime, isnât that kind off odd in a fun way?). newMethod := context selectedClass compiler source: context code; options: #(+ optionParseErrors); compile. 3) Now how to we âhook intoâ the execution of the original unchanged method? We use a MetaLink. We install it as a before link on the RBMethodNode, the meta-object is a block. This block gets as arguments the thisContext and the arguments of the original method and then just does what you want it do do: if we are in test, return the result of the execution of the method we just compiled. (Closures are fun, we can just reference the outer temp newMethod, no need to store it anywhere else explicitly): [ :aContext :args | CurrentExecutionEnvironment value isTest ifTrue: [ aContext return: (newMethod valueWithReceiver: aContext receiver arguments: args) ] ]; Thus, all the code is this: execute | newMethod metaLink | âwe compile a new method from the not-accepted text editor. Allow syntax errors" newMethod := context selectedClass compiler source: context code; options: #(+ optionParseErrors); compile. "the link executes the method we just created and returns" metaLink := MetaLink new metaObject: [ :aContext :args | CurrentExecutionEnvironment value isTest ifTrue: [ aContext return: (newMethod valueWithReceiver: aContext receiver arguments: args) ] ]; selector: #value:value:; arguments: #(context arguments). context selectedMethod ast link: metaLink Cleanup we do not care as everything will be GCed as soon as we accept the method for real. And it works! I did not test it too much, but it seems to do what it is supposed to do. (but more tests and testing are for sure needed) https://github.com/pharo-project/pharo/pull/1182 Next step: move it to a better place in the menu. Marcus

7 17

[Pharo 7.0-dev] Build #911: 21902-Deprecate-old-Compiler-API-with-transforming-deprecation
by ci-pharo-ci-jenkins2＠inria.fr May 17, 2018

May 17, 2018

There is a new Pharo build available! The status of the build #911 was: SUCCESS. The Pull Request #1371 was integrated: "21902-Deprecate-old-Compiler-API-with-transforming-deprecation" Pull request url: https://github.com/pharo-project/pharo/pull/1371 Issue Url: https://pharo.fogbugz.com/f/cases/21902 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #910: 21911-Slot-class-definition-should-use-package-like-normal-class-definition
by ci-pharo-ci-jenkins2＠inria.fr May 17, 2018

May 17, 2018

There is a new Pharo build available! The status of the build #910 was: SUCCESS. The Pull Request #1360 was integrated: "21911-Slot-class-definition-should-use-package-like-normal-class-definition" Pull request url: https://github.com/pharo-project/pharo/pull/1360 Issue Url: https://pharo.fogbugz.com/f/cases/21911 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #909: 21917 No abbreviation for combined utilities category (no utils)
by ci-pharo-ci-jenkins2＠inria.fr May 16, 2018

May 16, 2018

There is a new Pharo build available! The status of the build #909 was: FAILURE. The Pull Request #1370 was integrated: "21917 No abbreviation for combined utilities category (no utils)" Pull request url: https://github.com/pharo-project/pharo/pull/1370 Issue Url: https://pharo.fogbugz.com/f/cases/21917 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #908: 20066-Character-definition-returns-non-existent-method
by ci-pharo-ci-jenkins2＠inria.fr May 16, 2018

May 16, 2018

There is a new Pharo build available! The status of the build #908 was: FAILURE. The Pull Request #1367 was integrated: "20066-Character-definition-returns-non-existent-method" Pull request url: https://github.com/pharo-project/pharo/pull/1367 Issue Url: https://pharo.fogbugz.com/f/cases/20066 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Lint Rule Exception for Common Tools?
by Sean P. DeNigris May 16, 2018

May 16, 2018

Code like the following `Smalltalk tools webBrowser` falsely triggers the "Message sent but not implemented" lint rule. Would it make sense / is it possible to generically exclude this scenario from the rule? Or maybe even check the registered tools (or maybe that should be a different rule altogether)â¦ ----- Cheers, Sean -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

1 0

[Pharo 7.0-dev] Build #907: 20215-Undo-in-Rubric-laves-a-part-of-autocompleted-keyword-message
by ci-pharo-ci-jenkins2＠inria.fr May 16, 2018

May 16, 2018

There is a new Pharo build available! The status of the build #907 was: FAILURE. The Pull Request #1189 was integrated: "20215-Undo-in-Rubric-laves-a-part-of-autocompleted-keyword-message" Pull request url: https://github.com/pharo-project/pharo/pull/1189 Issue Url: https://pharo.fogbugz.com/f/cases/20215 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0