- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Underscores question
by Bill Schwab Jan. 6, 2009

Jan. 6, 2009

Gwenael, That is great, but I keep getting "Nothing more expected ->" in place of the uderscore any time I try it. Am I doing something wrong, or is it simply not yet integrated? Bill Wilhelm K. Schwab, Ph.D. University of Florida Department of Anesthesiology PO Box 100254 Gainesville, FL 32610-0254 Email: bschwab(a)anest.ufl.edu Tel: (352) 273-6785 FAX: (352) 392-7029 >>> mrgwen(a)gmail.com 1/5/2009 7:25:25 AM >>> On Sunday 04 January 2009 17:41:21 Bill Schwab wrote: > Gwenael, > > Stef mentioned that you are working on a parser, in part to address > problems with $_. At the risk of appearing impatient, do your goals > include allowing the use of $_ in selector and class names? If so, is > it something simple that could appear soon, or is it involved and likely > to take a while? I have some external interfacing requirements that > would be simplified if $_ were unconstrained. > Hi Bill, You can put _ in selector and class names. There is only a problem with _ when it is used instead of :=. Cheers, Gwenael > Bill > > > > > Wilhelm K. Schwab, Ph.D. > University of Florida > Department of Anesthesiology > PO Box 100254 > Gainesville, FL 32610-0254 > > Email: bschwab(a)anest.ufl.edu > Tel: (352) 273-6785 > FAX: (352) 392-7029 > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

3 3

[Pharo-project] Pharo Issues
by Brian Brown Jan. 6, 2009

Jan. 6, 2009

Greetings all, I download the latest image from the site (10196 dev), and selected "Software update" from the System Menu. There is an error with update: 10201-Pha-FlapTabViewerObjectPassOneOverScriptSyst While it is in the "Adding Versions" step, we get an exception trying to read a stream on this file: Sixx-stephane_ducasse.2.mcz Here is the traceback: UndefinedObject(Object)>>doesNotUnderstand: #readStream MCScanner class>>scanTokens: MCMczReader>>parseMember: MCMczReader>>loadPackage MCMczReader(MCVersionReader)>>package MCMczReader(MCVersionReader)>>basicVersion MCMczReader(MCVersionReader)>>version [] in MCHttpRepository(MCFileBasedRepository)>>loadVersionFromFileNamed: {[:r | r version]} BlockContext>>valueWithPossibleArgs: MCMczReader(ProtoObject)>>ifNotNil: MCHttpRepository>>versionReaderForFileNamed:do: MCHttpRepository(MCFileBasedRepository)>>loadVersionFromFileNamed: [] in ScriptLoader>>loadTogether:merge: {[:fn | loader addVersion: (self repository loadVersionFromFileNamed: fn)]} [] in OrderedCollection(SequenceableCollection)>>do:displayingProgress: {[:each :i | bar value: i. aBlock value: each]} OrderedCollection(SequenceableCollection)>>withIndexDo: [] in OrderedCollection(SequenceableCollection)>>do:displayingProgress: {[:bar | self withIndexDo: [:each :i | bar value: i. aBlock value: e...]} [] in ProgressInitiationException>>defaultAction {[result := workBlock value: progress]} BlockContext>>ensure: ProgressInitiationException>>defaultAction UndefinedObject>>handleSignal: MethodContext(ContextPart)>>handleSignal: MethodContext(ContextPart)>>handleSignal: ProgressInitiationException(Exception)>>signal ProgressInitiationException>>display:at:from:to:during: ProgressInitiationException class>>display:at:from:to:during: ByteString(String)>>displayProgressAt:from:to:during: OrderedCollection(SequenceableCollection)>>do:displayingProgress: ScriptLoader>>loadTogether:merge: ScriptLoader>>script280 ScriptLoader>>update10201 UndefinedObject>>DoIt Compiler>>evaluate:in:to:notifying:ifFail:logged: Compiler class>>evaluate:for:notifying:logged: Compiler class>>evaluate:for:logged: Compiler class>>evaluate:logged: [] in MultiByteBinaryOrTextStream(PositionableStream)>>fileInAnnouncing: {[val := (self peekFor: $!) ifTrue: [(Compiler evaluate: self nextChunk l...]} BlockContext>>on:do: [] in MultiByteBinaryOrTextStream(PositionableStream)>>fileInAnnouncing: {[:bar | [self atEnd] whileFalse: [bar value: self position. self skipS...]} [] in ProgressInitiationException>>defaultAction {[result := workBlock value: progress]} BlockContext>>ensure: ProgressInitiationException>>defaultAction UndefinedObject>>handleSignal: MethodContext(ContextPart)>>handleSignal: ProgressInitiationException(Exception)>>signal ProgressInitiationException>>display:at:from:to:during: ProgressInitiationException class>>display:at:from:to:during: ByteString(String)>>displayProgressAt:from:to:during: MultiByteBinaryOrTextStream(PositionableStream)>>fileInAnnouncing: [] in ChangeSet class>>newChangesFromStream:named: {[newSet ifNotNil: [(aStream respondsTo: #converter:) ifTrue: [newStrea...]} BlockContext>>ensure: ChangeSet class>>newChangesFromStream:named: [] in Utilities class>>readServer:special:updatesThrough:saveLocally:updateImage: {[:bar | [this := docQueue next. nextDoc := docQueue next. nextDoc = #fail...]} [] in ProgressInitiationException>>defaultAction {[result := workBlock value: progress]} BlockContext>>ensure: ProgressInitiationException>>defaultAction UndefinedObject>>handleSignal: MethodContext(ContextPart)>>handleSignal: ProgressInitiationException(Exception)>>signal ProgressInitiationException>>display:at:from:to:during: ProgressInitiationException class>>display:at:from:to:during: ByteString(String)>>displayProgressAt:from:to:during: [] in Utilities class>>readServer:special:updatesThrough:saveLocally:updateImage: {[urls := self newUpdatesOn: (serverList collect: [:url | url , 'up...]} BlockContext>>ensure: CursorWithMask(Cursor)>>showWhile: Utilities class>>readServer:special:updatesThrough:saveLocally:updateImage: Utilities class>>readServerUpdatesThrough:saveLocally:updateImage: Utilities class>>readServerUpdatesSaveLocally:updateImage: Utilities class>>updateFromServer TheWorldMenu>>doMenuItem:with: [] in ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent: {[(selArgCount := selector numArgs) = 0 ifTrue: [target perform: selector] ...]} BlockContext>>ensure: CursorWithMask(Cursor)>>showWhile: ToggleMenuItemMorph(MenuItemMorph)>>invokeWithEvent: ToggleMenuItemMorph(MenuItemMorph)>>mouseUp: ToggleMenuItemMorph(MenuItemMorph)>>handleMouseUp: MouseButtonEvent>>sentTo: ToggleMenuItemMorph(Morph)>>handleEvent: MorphicEventDispatcher>>dispatchDefault:with: MorphicEventDispatcher>>dispatchEvent:with: ToggleMenuItemMorph(Morph)>>processEvent:using: MorphicEventDispatcher>>dispatchDefault:with: MorphicEventDispatcher>>dispatchEvent:with: MenuMorph(Morph)>>processEvent:using: MenuMorph(Morph)>>processEvent: MenuMorph>>handleFocusEvent: [] in HandMorph>>sendFocusEvent:to:clear: {[ActiveHand := self. ActiveEvent := anEvent. result := focusHolder han...]} [] in PasteUpMorph>>becomeActiveDuring: {[aBlock value]} BlockContext>>on:do: PasteUpMorph>>becomeActiveDuring: HandMorph>>sendFocusEvent:to:clear: HandMorph>>sendEvent:focus:clear: HandMorph>>sendMouseEvent: HandMorph>>handleEvent: HandMorph>>processEvents [] in WorldState>>doOneCycleNowFor: {[:h | ActiveHand := h. h processEvents. ActiveHand := nil]} Array(SequenceableCollection)>>do: WorldState>>handsDo: WorldState>>doOneCycleNowFor: WorldState>>doOneCycleFor: PasteUpMorph>>doOneCycle [] in Project class>>spawnNewProcess {[[World doOneCycle. Processor yield. false] whileFalse. nil]} [] in BlockContext>>newProcess {[self value. Processor terminateActive]}

3 10

[Pharo-project] [ANN] releasing image 10201...
by StÃ©phane Ducasse Jan. 5, 2009

Jan. 5, 2009

Hi guys I updated from 10091 and produce 10201 and published it. Stef

1 0

[Pharo-project] Issue 434: New MC merge dialog merges even if it is closed without hitting "merge"
by Adrian Lienhard Jan. 5, 2009

Jan. 5, 2009

The new merge dialog is really nice. I filed the following issue. http://code.google.com/p/pharo/issues/detail?id=434 After closing the dialog with the top left red button, the merge is performed. Furthermore, the dialog is modal, which I think is quite annoying as I often use to have several merge dialogs open at the same time. Improvements are welcome :) Cheers, Adrian ___________________ http://www.adrian-lienhard.ch/

1 0

[Pharo-project] Underscores question
by Bill Schwab Jan. 5, 2009

Jan. 5, 2009

Gwenael, Stef mentioned that you are working on a parser, in part to address problems with $_. At the risk of appearing impatient, do your goals include allowing the use of $_ in selector and class names? If so, is it something simple that could appear soon, or is it involved and likely to take a while? I have some external interfacing requirements that would be simplified if $_ were unconstrained. Bill Wilhelm K. Schwab, Ph.D. University of Florida Department of Anesthesiology PO Box 100254 Gainesville, FL 32610-0254 Email: bschwab(a)anest.ufl.edu Tel: (352) 273-6785 FAX: (352) 392-7029

2 1

[Pharo-project] [Fwd: [ANN] Number comparison, hash, NaN, Point, and other partially ordered sets]
by nicolas cellier Jan. 5, 2009

Jan. 5, 2009

-------- Message original -------- From: - Mon Jan 05 00:49:18 2009 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00800000 X-Mozilla-Keys: Date: Mon, 05 Jan 2009 00:49:17 +0100 From: nicolas cellier <ncellier(a)ifrance.com> User-Agent: Thunderbird 2.0.0.12 (X11/20080306) MIME-Version: 1.0 Newsgroups: gmane.comp.lang.smalltalk.squeak.general Subject: [ANN] Number comparison, hash, NaN, Point, and other partially ordered sets Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Happy new year everyone. After VWNC recent discussion about comparing Point and Number, I tried to make a review of my previous work concerning all these minor (but annoying) comparison bugs. I think I now have an acceptable and consistent solution. This is spreaded across several mantis bug reports: http://bugs.squeak.org/view.php?id=3374 http://bugs.squeak.org/view.php?id=6719 http://bugs.squeak.org/view.php?id=7259 http://bugs.squeak.org/view.php?id=7260 It should also solve: http://bugs.squeak.org/view.php?id=3360 http://bugs.squeak.org/view.php?id=6601 (I took andrew solution from the last one) Comments, code critics, flames, etc... are welcome Nicolas

2 1

[Pharo-project] Fwd: OB SUnit
by StÃ©phane Ducasse Jan. 1, 2009

Jan. 1, 2009

Begin forwarded message: > From: pharo-project-owner(a)lists.gforge.inria.fr > Date: January 1, 2009 9:45:18 AM CEST > To: stephane.ducasse(a)gmail.com > Subject: OB SUnit > > You are not allowed to post to this mailing list, and your message has > been automatically rejected. If you think that your messages are > being rejected in error, contact the mailing list owner at > pharo-project-owner(a)lists.gforge.inria.fr. > > > From: StÃ©phane Ducasse <stephane.ducasse(a)gmail.com> > Date: January 1, 2009 9:45:09 AM CEST > To: Pharo Development <Pharo-project(a)lists.gforge.inria.fr> > Subject: OB SUnit > > > From google ob group. > > > Dale Henrichs > View profile > Hide options Dec 29 2008, 11:05 pm > From: Dale Henrichs <dale.henri...(a)gemstone.com> > Date: Mon, 29 Dec 2008 14:05:09 -0800 (PST) > Local: Mon, Dec 29 2008 11:05 pm > Subject: [ANN] OmniBrowser-based TestRunner > Reply | Reply to author | Forward | Print | Individual message | > Show original | Report this message | Find messages by this author > Hello all, > > I've just finished with an initial version of an OmniBrowser-based > TestRunner. It has an MIT license. > > I've pushed a package to the Universe (OmniBrowser-SUnit-GUI version > 0.41) in the Development category. > > The Universe package loads in Squeak, but Pharo users should just > load the package (http://seaside.gemstone.com/ss/obsunit/OB-SUnitGUI-dkh.41.mcz > , or later). I'll be working on getting it running in GLASS shortly. > > The Monticello project is on GemSource (http://seaside.gemstone.com/ss/obsunit.html > ). If anyone would like to contribute code, register on GemSource > and drop me a mail and I'll add you to the project. It depends upon > SUnit, OmniBrowser, and OB-Morphic. At the moment it isn't pure > OB:). I left in the progress notification (I don't think there is > one in OB yet). I'll work on making it pure OB during my GemStone > port. > > Finally I leveraged David's work on OBPluggableListMorphOfMany (read > copied), because I didn't want to be dependent upon OB-Enhancements > in it's entirety. I departed from David's work with > OSMultipleSelectionColumn, where I've got a multiple selection > column implementation that is compatible with the needs TestRunner > (i.e., multiple multi-select columns). > > There are a couple of differences in the UI, but I've tried to be as > faithful to the original as OmniBrowser would let me. > > To launch the test runner, evaluate 'OSTestRunner open'. > > Enjoy, > > Dale > >

1 0

[Pharo-project] Dictionary as a Set
by nicolas cellier Dec. 31, 2008

Dec. 31, 2008

I reported some important distinction between Dictionaries and Sets at http://bugs.squeak.org/view.php?id=7258. The problem has been introduced by the change of Association>>#=. Logically, Dictionary should have been detached from Set at this time, since it was no more a Set of associations as it used to. StÃ©phane Ducasse <stephane.ducasse@...> writes: > > This is interesting that you present that as a Bag. I'm too sick now > (my brain > is wandering across my room) to really reply something clever. > > I thought that a bag was more an counting elements container > For me the sole specification is that a Bag unlike a Set can hold several equal elements. The fact that it can count them fast rather than enumerating the whole collection is an implementation detail (an important detail of course). > > a) multiple values can be in the dictionary: > > (Dictionary new) at: 'one' put: 1; at: 'first' put: 1; yourself. > > For me to be bag would mean more > > > dc := (DictionaryBag new) at: 'one' put: 1; at: 'one' put: 2; > > yourself. > dc at: one > -> #(1 2) > > Stef > a DictionaryOfBags ? One thing Dictionary is not : a Bag of associations. Think of it as a Bag of values. As long as you don't override a key, a Dictionary behaves like a Bag: digits := 0 to: 9. b := Bag new. d := Dictionary new. digits do: [:i | b add: i//2]. digits do: [:i | d at: i printString put: i//2]. digits do: [:i | self assert: (b occurrencesOf: i) = (d occurrencesOf: i)]. Personnally, I would expect d values. to answer a Bag (unordered) rather than an Array (arbitrary order)... The only advantage of an Array is that it is faster than a Bag...

2 1

[Pharo-project] About SmallDIctionary
by nicolas cellier Dec. 31, 2008

Dec. 31, 2008

While inquiring generalization of #removeAll and #removeAll: related to Klaus fix http://bugs.squeak.org/view.php?id=6937 , I came across two SmallDictionary minor bugs http://bugs.squeak.org/view.php?id=7256 , http://bugs.squeak.org/view.php?id=7257 . The first one by reading code, the second one by this procedure : - a) fileOut DictionaryTest, - b) replaced Dictionary with SmallDictionary (ALT+j), - c) fileIn again. Of course, the tests should be factored better rather than just duplicated. But I don't know how to inherit tests from super... (super tests are not executed by the TestRunner) See attached .st -------------------------------- Oh, and i had to change this test: testKeyAtValue | dict | dict := Dictionary new. dict at: #a put: 1. dict at: #c put: 1. self assert: (dict keyAtValue: 1) = #c. "ugly may be a bug, why not having a set #a and #c" Should be : self assert: ((dict keyAtValue: 1) = #c) | (dict keyAtValue: 1) = #a). The result highly depends on: - 1) hash algorithm - 2) Dictionary capacity (the default capacity for this test) Asserting that it is #c : - 1) does not help the reader to guess the specification (i would understand it is always #c) - 2) is very fragile, not portable, and might change unexpectedly For the case of SmallDictionary, we could eventually assert: self assert: (dict keyAtValue: 1) = #a. Because keys are ordered and will retain addition order. -------------------------------- Another point: these two methods should be removed shouldn't they? SmallDictionary removeSelector: #keyForPatternVariableNode:. SmallDictionary removeSelector: #valueForPatternVariableNode:. 'From Pharo0.1 of 16 May 2008 [Latest update: #10201] on 30 December 2008 at 10:45:19 pm'! TestCase subclass: #SmallDictionaryTest uses: TIncludesTest + TCloneTest instanceVariableNames: 'emptyDict nonEmptyDict' classVariableNames: '' poolDictionaries: '' category: 'CollectionsTests-Unordered'! !SmallDictionaryTest methodsFor: 'testing' stamp: 'nice 12/30/2008 19:26'! testCapacity "this is a non regression test for http://bugs.squeak.org/view.php?id=7256" self shouldnt: [SmallDictionary new capacity] raise: Error! ! !SmallDictionaryTest methodsFor: 'testing' stamp: 'ar 6/13/2008 00:14'! testCollect "Ensure that SmallDictionary>>collect: answers a dictionary not something else" | dict expected result | dict := SmallDictionary newFromPairs:{ #first. 1. #second. 2. #third. 3. #fourth. 4. #fifth. 5. }. result := dict collect:[:each| each asWords]. expected := SmallDictionary newFromPairs:{ #first. 'one'. #second. 'two'. #third. 'three'. #fourth. 'four'. #fifth. 'five'. }. self assert: result = expected.! ! !SmallDictionaryTest methodsFor: 'testing' stamp: 'nice 12/30/2008 19:43'! testDictionaryConcatenation "self run: #testDictionaryConcatenation" | dict1 dict2 dict3 | dict1 := SmallDictionary new. dict1 at: #a put: 'Nicolas' ; at: #b put: 'Damien'. dict2 := SmallDictionary new. dict2 at: #a put: 'Christophe' ; at: #c put: 'Anthony'. dict3 := dict1, dict2. self assert: (dict3 at: #a) = 'Christophe'. self assert: (dict3 at: #b) = 'Damien'. self assert: (dict3 at: #c) = 'Anthony'. ! ! !SmallDictionaryTest methodsFor: 'testing' stamp: 'ar 6/13/2008 00:13'! testReject "Ensure that SmallDictionary>>reject: answers a dictionary not something else" | dict expected result | dict := SmallDictionary newFromPairs:{ #first. 1. #second. 2. #third. 3. #fourth. 4. #fifth. 5. }. result := dict reject:[:each| each odd]. expected := SmallDictionary newFromPairs:{ #second. 2. #fourth. 4. }. self assert: result = expected.! ! !SmallDictionaryTest methodsFor: 'testing' stamp: 'ar 6/13/2008 00:12'! testSelect "Ensure that SmallDictionary>>select: answers a dictionary not something else" | dict expected result | dict := SmallDictionary newFromPairs:{ #first. 1. #second. 2. #third. 3. #fourth. 4. #fifth. 5. }. result := dict select:[:each| each odd]. expected := SmallDictionary newFromPairs:{ #first. 1. #third. 3. #fifth. 5. }. self assert: result = expected.! ! !SmallDictionaryTest methodsFor: 'setup' stamp: 'stephane.ducasse 11/21/2008 15:03'! setUp emptyDict := SmallDictionary new. nonEmptyDict := SmallDictionary new. nonEmptyDict at: #a put: 20; at: #b put: 30; at: #c put: 40; at: #d put: 30.! ! !SmallDictionaryTest methodsFor: 'tests - includes' stamp: 'stephane.ducasse 11/21/2008 15:05'! anotherElementNotIn ^ 42! ! !SmallDictionaryTest methodsFor: 'tests - includes' stamp: 'stephane.ducasse 11/21/2008 15:04'! collection ^ #(1 2 3)! ! !SmallDictionaryTest methodsFor: 'tests - includes' stamp: 'stephane.ducasse 11/21/2008 15:04'! elementNotIn ^ 666! ! !SmallDictionaryTest methodsFor: 'tests - includes' stamp: 'stephane.ducasse 11/21/2008 15:04'! empty ^ emptyDict! ! !SmallDictionaryTest methodsFor: 'tests - includes' stamp: 'stephane.ducasse 11/21/2008 15:04'! nonEmpty ^ nonEmptyDict! ! !SmallDictionaryTest methodsFor: 'association tests' stamp: 'NDCC 3/8/2006 08:14'! testAddAssociation "self run:#testAddAssociation" "self debug:#testAddAssociation" | dict | dict := SmallDictionary new. dict at: #a put: 1. dict at: #b put: 2. self assert: (dict at: #a) = 1. self assert: (dict at: #b) = 2. dict at: #a put: 10. dict at: #c put: 2. self assert: (dict at: #a) = 10. self assert: (dict at: #b) = 2. self assert: (dict at: #c) = 2 ! ! !SmallDictionaryTest methodsFor: 'association tests' stamp: 'ndCollectionsTests-Unordered 3/16/2006 10:30'! testAssociationsSelect | answer d | d := SmallDictionary new. d at: (Array with: #hello with: #world) put: #fooBar. d at: Smalltalk put: #'Smalltalk is the key'. d at: #Smalltalk put: Smalltalk. answer := d associationsSelect: [:assoc | assoc key == #Smalltalk and: [assoc value == Smalltalk]]. self should: [answer isKindOf: SmallDictionary]. self should: [answer size == 1]. self should: [(answer at: #Smalltalk) == Smalltalk]. answer := d associationsSelect: [:assoc | assoc key == #NoSuchKey and: [assoc value == #NoSuchValue]]. self should: [answer isKindOf: SmallDictionary]. self should: [answer size == 0]! ! !SmallDictionaryTest methodsFor: 'association tests' stamp: 'stephane.ducasse 11/21/2008 15:00'! testIncludesAssociation "self run:#testIncludesAssociation" | dict | dict := SmallDictionary new. dict at: #a put: 1. dict at: #b put: 2. self assert: (dict includesAssociation: (#a -> 1)). self assert: (dict includesAssociation: (#b -> 2)). ! ! !SmallDictionaryTest methodsFor: 'association tests' stamp: 'ndCollectionsTests-Unordered 3/16/2006 10:25'! testIncludesAssociationNoValue "self run:#testIncludesAssociationNoValue" "self debug:#testIncludesAssociationNoValue" | dict a1 a3 | a1 := Association key: #Italie. a3 := Association key: #France value: 'Paris'. self assert: (a1 key = #Italie). self assert: (a1 value isNil). dict := SmallDictionary new. dict add: a1. dict add: a3. self assert: (dict includesKey: #France). self assert: (dict includesKey: #Italie). self assert: (dict at: #Italie) isNil. self assert: (dict at: #France) = 'Paris' ! ! !SmallDictionaryTest methodsFor: 'basic tests' stamp: 'ndCollectionsTests-Unordered 3/16/2006 10:26'! testAtError "self run: #testAtError" | dict | dict := SmallDictionary new. dict at: #a put: 666. self shouldnt: [ dict at: #a ] raise: Error. self should: [ dict at: #b ] raise: Error. ! ! !SmallDictionaryTest methodsFor: 'basic tests' stamp: 'NDCC 3/1/2006 14:27'! testAtIfAbsent "self run: #testAtIfAbsent" | dict | dict := SmallDictionary new. dict at: #a put: 666. self assert: (dict at: #a ifAbsent: [nil]) = 666. self assert: (dict at: #b ifAbsent: [nil]) isNil. ! ! !SmallDictionaryTest methodsFor: 'basic tests' stamp: 'NDCC 3/8/2006 09:28'! testAtPut "self run: #testAtPut" "self debug: #testAtPut" | adictionary | adictionary := SmallDictionary new. adictionary at: #a put: 3. self assert: (adictionary at: #a) = 3. adictionary at: #a put: 3. adictionary at: #a put: 4. self assert: (adictionary at: #a) = 4. adictionary at: nil put: 666. self assert: (adictionary at: nil) = 666! ! !SmallDictionaryTest methodsFor: 'basic tests' stamp: 'marcus.denker 9/14/2008 21:15'! testAtPutNil "self run: #testAtPut" "self debug: #testAtPut" | dict | dict := SmallDictionary new. dict at: nil put: 1. self assert: (dict at: nil) = 1. dict at: #a put: nil. self assert: (dict at: #a) isNil. dict at: nil put: nil. self assert: (dict at: nil) isNil. ! ! !SmallDictionaryTest methodsFor: 'basic tests' stamp: 'ndCollectionsTests-Unordered 3/16/2006 10:24'! testIncludesKey "self run:#testIncludesKey" "self debug:#testIncludesKey" | dict a1 a2 a3 | a1 := Association key: 'Italie'. a2 := Association new. a3 := Association key: 'France' value: 'Paris'. dict := SmallDictionary new. dict add: a1 . dict add: a2. dict add: a3. self assert: (dict includesKey: #France). self assert: (dict includesKey: 'France'). self assert: (dict includesKey: #Italie). self assert: (dict includesKey: nil). self assert: (dict at: 'France' ) = 'Paris'. ! ! !SmallDictionaryTest methodsFor: 'basic tests' stamp: 'NDCC 3/8/2006 09:41'! testOccurrencesOf "self run:#testOccurrencesOf" | dict | dict := SmallDictionary new. dict at: #a put: 1. dict at: #b put: 2. dict at: #c put: 1. dict at: #d put: 3. dict at: nil put: nil. dict at: #z put: nil. self assert: (dict occurrencesOf: 1 ) = 2. self assert: (dict occurrencesOf: nil ) = 2. ! ! !SmallDictionaryTest methodsFor: 'implementation tests' stamp: 'stephaneducasse 9/18/2005 10:48'! testAtNil "(self run: #testAtNil)" "nil is a valid key in squeak. In VW nil is not a valid key" "Ansi 1.9 p, 168 5.7.2.5 Message: at: key put: newElement Synopsis Store newElement at key in the receiver. Answer newElement. Definition: <abstractSmallDictionary> If lookup succeeds for key, then newElement replaces the element previously stored at key. Otherwise, the newElement is stored at the new key. In either case, subsequent successful lookups for key will answer newElement. Answer newElement. The result is undefined if the key is nil. This clearly indicates that different smalltalks where doing different assumptions." | dict1 | dict1 := SmallDictionary new. self shouldnt: [ dict1 at: nil put: #none] raise: Error. self assert: (dict1 at: nil) = #none. ! ! !SmallDictionaryTest methodsFor: 'implementation tests' stamp: 'ndCollectionsTests-Unordered 3/16/2006 10:29'! testPseudoVariablesAreValidKeys "(self run: #testPseudoVariablesAreValidKeys)" "true and false are valid keys" | dict1 | dict1 := SmallDictionary new. self shouldnt: [dict1 at: true put: #true] raise: Error. self assert: (dict1 at: true) = #true. self shouldnt: [dict1 at: false put: #false] raise: Error. self assert: (dict1 at: false) = #false.! ! !SmallDictionaryTest methodsFor: 'keys and value tests' stamp: 'nice 12/30/2008 22:43'! testKeyAtValue "self run: #testKeyAtValue" "self debug: #testKeyAtValue" | dict | dict := SmallDictionary new. dict at: #a put: 1. dict at: #b put: 2. dict at: #c put: 1. self assert: (dict keyAtValue: 2) = #b. self assert: (dict keyAtValue: 1) = #c | ((dict keyAtValue: 1) = #a). "ugly may be a bug, why not having a set #a and #c" self should: [dict keyAtValue: 0] raise: Error ! ! !SmallDictionaryTest methodsFor: 'keys and value tests' stamp: 'ndCollectionsTests-Unordered 3/16/2006 10:23'! testKeys "self run:#testKeys " | a1 a2 dict | a1 := Association key: 'France' value: 'Paris'. a2 := Association key: 'Italie' value: 'Rome'. dict := SmallDictionary new. dict add: a1. dict add: a2. self assert: (dict keys size) = 2. self assert: (dict keys includes: #France) ! ! !SmallDictionaryTest methodsFor: 'keys and value tests' stamp: 'NDCC 3/8/2006 09:13'! testKeysDo "self run: #testKeysDo" "self debug: #testKeysDo" | dict res | dict := SmallDictionary new. dict at: #a put: 33. dict at: #b put: 66. res := OrderedCollection new. dict keysDo: [ :each | res add: each]. self assert: res asSet = #(a b) asSet. ! ! !SmallDictionaryTest methodsFor: 'keys and value tests' stamp: 'NDCC 3/8/2006 08:56'! testRemoveKey "self run:#testRemoveKey " | dict | dict := SmallDictionary new. dict at: #a put: 1. dict at: #b put: 2. self assert: (dict keys size) = 2. dict removeKey: #a. self assert: dict keys size = 1. self should: [dict at: #a] raise: Error. self assert: (dict at: #b) = 2 ! ! !SmallDictionaryTest methodsFor: 'keys and value tests' stamp: 'NDCC 3/8/2006 08:16'! testSmallDictionaryConcatenation "self run: #testSmallDictionaryConcatenation" | dict1 dict2 dict3 | dict1 := SmallDictionary new. dict1 at: #a put: 'Nicolas' ; at: #b put: 'Damien'. dict2 := SmallDictionary new. dict2 at: #a put: 'Christophe' ; at: #c put: 'Anthony'. dict3 := dict1, dict2. self assert: (dict3 at: #a) = 'Christophe'. self assert: (dict3 at: #b) = 'Damien'. self assert: (dict3 at: #c) = 'Anthony'. ! ! !SmallDictionaryTest methodsFor: 'keys and value tests' stamp: 'ndCollectionsTests-Unordered 3/16/2006 10:23'! testValues "self run:#testValues " | a1 a2 a3 dict | a1 := Association key: 'France' value: 'Paris'. a2 := Association key: 'Italie' value: 'Rome'. dict := SmallDictionary new. dict add: a1. dict add: a2. self assert: (dict values size ) = 2. self assert: (dict values includes: 'Paris'). a3 := Association new. dict add: a3. self assert: (dict values size ) = 3. self assert: (dict values includes: nil). ! ! !SmallDictionaryTest methodsFor: 'tests' stamp: 'zz 12/7/2005 19:59'! testAdd | dict | dict := SmallDictionary new. dict add: #a -> 1. dict add: #b -> 2. self assert: (dict at: #a) = 1. self assert: (dict at: #b) = 2! ! !SmallDictionaryTest methodsFor: 'tests' stamp: 'zz 12/7/2005 19:55'! testAddAll | dict1 dict2 | dict1 := SmallDictionary new. dict1 at: #a put:1 ; at: #b put: 2. dict2 := SmallDictionary new. dict2 at: #a put: 3 ; at: #c put: 4. dict1 addAll: dict2. self assert: (dict1 at: #a) = 3. self assert: (dict1 at: #b) = 2. self assert: (dict1 at: #c) = 4.! ! !SmallDictionaryTest methodsFor: 'tests' stamp: 'zz 12/7/2005 19:57'! testComma | dict1 dict2 dict3 | dict1 := SmallDictionary new. dict1 at: #a put:1 ; at: #b put: 2. dict2 := SmallDictionary new. dict2 at: #a put: 3 ; at: #c put: 4. dict3 := dict1, dict2. self assert: (dict3 at: #a) = 3. self assert: (dict3 at: #b) = 2. self assert: (dict3 at: #c) = 4.! ! !SmallDictionaryTest methodsFor: 'tests' stamp: 'stephaneducasse 9/18/2005 10:45'! testPseudo "(self run: #testPseudo)" "true and false are valid keys" | dict1 | dict1 := SmallDictionary new. self shouldnt: [dict1 at: true put: #true] raise: Error. self assert: (dict1 at: true) = #true. self shouldnt: [dict1 at: false put: #false] raise: Error. self assert: (dict1 at: false) = #false.! ! "-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- "! SmallDictionaryTest class uses: TIncludesTest classTrait + TCloneTest classTrait instanceVariableNames: 'testToto pt1'!

2 1

[Pharo-project] Dictionary as a Set
by Alexandre Bergel Dec. 30, 2008

Dec. 30, 2008

Dear List, I was wondering whether I am the only one shocked when I see this: (Set new add: #b -> 'B'; yourself) includes: #b -> 'B' ====> true (Set new add: #b -> 'B'; yourself) includes: 'B' ====> false (Dictionary new add: #b -> 'B'; yourself) includes: #b -> 'B' ====> false (Dictionary new add: #b -> 'B'; yourself) includes: 'B' ====> true Dictionary inherits from Set. This means that if Set would have a contract, it would break in Dictionary. IMO, we should have (Dictionary new add: #b -> 'B'; yourself) includes: #b -> 'B' ====> true (Dictionary new add: #b -> 'B'; yourself) includes: 'B' ====> false No? Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

4 4