- Pharo-dev - lists.pharo.org

[Pharo-project] undeclared variables
by StÃ©phane Ducasse Feb. 16, 2009

Feb. 16, 2009

Hi all It would be good to fix such problems in their respective packages. Stef Checks for references to a variable in the Undeclared dictionary. If you remove a variable from a class that is accessed by a method, you will create an undeclared variable reference for those methods that accessed the variable. OBEnhancementColumn>>#selection: Project>>#finalEnterActions OBClosableDefinitionPanel>>#commands OBTextMorphEditorWithShout>>#correctFrom:to:with: OBCollaboratorsSearchNode>>#classes MCPackageManager>>#modifiedTimeStamp UITheme>>#sounds: UITheme>>#sounds InstallerCruft>>#user InstallerCruft>>#createRBforBug: InstallerCruft>>#user: OBEnrichedDefinitionPanel>>#selectReferencingCodeNodes: OBEnrichedDefinitionPanel>>#accept:notifying: OBMethodInvocationSearchNode>>#classes PasteUpMorph>>#scriptorForTextualScript:ofPlayer: Installer>>#installMCcs:from: Installer>>#printOn: OBEnrichedMethodInvocationNode>>#source OBEnrichedMethodInvocationNode>>#modelMethod OBEnrichedMethodInvocationNode>>#invokingClasses OBTreeColumnTests>>#test09JumpToE2 OBTreeColumnTests>>#test12JumpToD3 OBTreeColumnTests>>#test10JumpToD1 OBTreeColumnTests>>#test01AllInOneColumn OBTreeColumnTests>>#test17JumpToG1 OBTreeColumnTests>>#test06JumpToC2 OBTreeColumnTests>>#test19JumpToA1 OBTreeColumnTests>>#test02AllInOneColumn OBTreeColumnTests>>#test04JumpToB2 OBTreeColumnTests>>#test14JumpToF1 OBTreeColumnTests>>#test08JumpToE1 OBTreeColumnTests>>#test07JumpToC1 OBTreeColumnTests>>#test11JumpToD2 OBTreeColumnTests>>#test13JumpToD4 OBTreeColumnTests>>#test03NodeWithBothTreeChildrenAndDefaultChildren OBTreeColumnTests>>#test05JumpToB1 OBTreeColumnTests>>#test18JumpToG2 OBTreeColumnTests>>#columnPanelABCDEFGH OBTreeColumnTests>>#test16JumpToH1 OBTreeColumnTests>>#test15JumpToF2 OBEnrichedMethodNode>>#source OBEnrichedMethodNode>>#updateModelMethod OBEnrichedClassNode>>#formatter DictionaryTest>>#flattenOnStream OBEnhPackageNodeTest>>#testPackage OBEnhPackageNodeTest>>#testTemplate OBEnhPackageNodeTest>>#setUp OBPosition>>#asTreePosition Refactoring class>>#initializeRefactoringOptions OBEnrichedMessageNode class>>#on:inMethod:inClass:

3 3

[Pharo-project] methods equivalently defined in superclass
by StÃ©phane Ducasse Feb. 16, 2009

Feb. 16, 2009

I imagine that we could fix that too :) Check for methods that are equivalent to their superclass methods. Such methods don't add anything to the computation and can be removed since the superclass's method will work just fine. ParseNode>>#isComplex ParseNode>>#isLiteral Project>>#windowActiveOnFirstClick SortedCollectionTest>>#testIfNotEmptyifEmpty SortedCollectionTest>>#testIfNotEmptyDoifNotEmpty SortedCollectionTest>>#testIfNotEmptyDo SortedCollectionTest>>#testIfNotEmpty SortedCollectionTest>>#testIsEmpty SortedCollectionTest>>#testIsEmptyOrNil SortedCollectionTest>>#testIfEmptyifNotEmpty SortedCollectionTest>>#testIfEmptyifNotEmptyDo ClockMorph>>#stepTime SqueakInstvarInterfaceExtractor>>#popIntoTemporaryVariable: SqueakInstvarInterfaceExtractor>>#storeIntoTemporaryVariable: SqueakInstvarInterfaceExtractor>>#storeIntoLiteralVariable: DialogWindow>>#newText: MCDependentsWrapper>>#item OBCmdRenameCat>>#group Integer>>#printOn:base: StringSocketStream>>#shrinkInBuf FloatingBookControlsMorph>>#stepTime OBCmdViewChanges>>#group OBMonticelloClassCategoryNode>>#isDescendantOfClass: OBMultipleSelectionColumnPanel>>#emptyColumn PluggableListItemWrapper>>#item DisplayObject>>#isTransparent FreeTypeEmbeddedFileInfo>>#familyGroupName ProgressInitiationException>>#isResumable TableMorph>>#preferredCornerStyle RBPseudoNode>>#isBlock LintRule>>#initialize SetTest>>#test0TSizeTest SetTest>>#testSize UIThemeStandardSqueak>>#dockingBarNormalFillStyleFor: OBPluggableCommand>>#takesNodes OBPluggableCommand>>#group PluggableTreeItemNode>>#item RBToken>>#isLiteral UIThemeWatery2>>#controlButtonMouseOverFillStyleFor: AbstractType>>#initialize OBCmdCheckRecentStatus>>#group WeakKeyDictionary>>#scanFor: UPStable>>#changeUser:withPassword:toHavePassword:andNewEmail: UPStable>>#addUser:withPassword:andEmail: IslandVMTweaksTestCase>>#someObject PostscriptCanvas>>#fillRectangle:fillStyle: OBMonticelloPackageNode>>#isDescendantOfClass: OBMMethodInvocationQuery>>#keyWord FormCanvas>>#fillRectangle:fillStyle: OBCmdSearchGroupClassRefs>>#group FreeTypeFileInfo>>#familyGroupName OBCmdToggleBreak>>#group UIThemeSoftSqueak>>#tasklistFillStyleFor: UIThemeSoftSqueak>>#buttonPanelNormalFillStyleFor: UIThemeSoftSqueak>>#progressBarFillStyleFor: UIThemeSoftSqueak>>#taskbarFillStyleFor: UIThemeSoftSqueak>>#dockingBarNormalFillStyleFor: UIThemeSoftSqueak>>#progressBarProgressFillStyleFor: UIThemeSoftSqueak>>#scrollbarNormalFillStyleFor: OBCollaboratorsSearchNode>>#setRawQuery: OBCollaboratorsSearchNode>>#isDescendantOfClass: OBCmdAddSmartCategory>>#group OBCmdOpenMC>>#group OBSmartGroupBrowser>>#isSearchBrowser OBSmartGroupBrowser>>#cmdRemoveFromSmartGroup OBSmartGroupBrowser>>#cmdBrowse OBSmartGroupBrowser>>#cmdRenameSmartCategory OBSmartGroupBrowser>>#cmdAddToSmartGroup OBSmartGroupBrowser>>#cmdAddSmartCategory MethodContext>>#cachesStack PSMCChangeWrapper>>#isConflict Notification>>#isResumable OBCmdViewHistory>>#group OBMethodInvocationSearchNode>>#setRawQuery: ColumnMorph>>#preferredCornerStyle PluggableTreeMorph>>#getMenuSelector: OBMultipleDefinitionPanel>>#isDefinition RBProgramNodeVisitor>>#postCopy StandardWindow>>#preferredCornerStyle UIThemeVistary>>#scrollbarPressedButtonFillStyleFor: RefactoryChange>>#initialize RefactoryChange>>#postCopy OBCmdResetSearchSmartGroups>>#group OBCollectionNode>>#isEnvironment Refactoring>>#initialize OBCmdSearchGroupImplementors>>#group BagTest>>#expectedElementByDetect OBCmdBrowsePackage>>#group WeakSet>>#size ExampleBuilderMorph>>#preferredCornerStyle OBCmdAddWorkingCopy>>#group OBCmdMethodToExtendClass>>#group OBCmdSearchGroupSenders>>#group OBCmdImportPackage>>#group OBCmdUpdatePackage>>#group RxmLink>>#initialize PluggableMultiColumnListMorph>>#highlightSelection PluggableMultiColumnListMorph>>#unhighlightSelection PseudoClass>>#isTrait RxsCharacter>>#isNullable XMLNode>>#isText OBCodeNode>>#annotationString OBCodeNode>>#shouldBeStyledBy: OBCmdFocusOnClassInHierarchy>>#isActive RBScanner>>#flush FT2Face>>#handle RxsPredicate>>#isAtomic OBCmdPublishPackage>>#group RBSmallDictionary>>#size BorderStyle>>#isComplex BrowserEnvironment>>#initialize BrowserEnvironment>>#postCopy BrowserEnvironment>>#copy ArrayTest>>#element HostSystemMenus>>#initialize RBProgramNode>>#isBlock RBProgramNode>>#isLiteral RBProgramNode>>#isArray UMProtocolVers...

3 2

[Pharo-project] Possibly unnecessary yourself message
by StÃ©phane Ducasse Feb. 16, 2009

Feb. 16, 2009

Check for methods sending the yourself message when it is not necessary. SmartRefStream>>#initKnownRenames BookMorph>>#forgetURLs FontChooserMorph>>#newPointSizeList FontChooserMorph>>#newFontStyleList FontChooserMorph>>#newFontList OBButtonBar>>#initGeometry MIMEType class>>#standardMIMETypes2 MIMEType class>>#standardMIMETypes MIMEType class>>#initializeDefaultSuffixes HTTPClient class>>#examplePostArgs HTTPClient class>>#examplePostMultipart LanguageEditor class>>#initCheckMethods Locale class>>#migrateSystem Locale class>>#initializePlatformEncodings

2 1

[Pharo-project] unnecessary temporary variable assignment
by StÃ©phane Ducasse Feb. 16, 2009

Feb. 16, 2009

Collection>>#groupBy:having: XMLTokenizer>>#next MCFileRepositoryInspector>>#versionList ServerDirectory>>#exists

2 1

[Pharo-project] Pharo email list does not appear threaded
by Sean McGrath Feb. 16, 2009

Feb. 16, 2009

I view this list with Thunderbird. It does not appear threaded, unlike other lists. A look at the headers compared to squeak-dev, for example, show no obvious difference, but I am far from an expert in email. Do others have the same experience? -- Sean McGrath sean(a)manybits.net

4 3

[Pharo-project] Boring confirmation message...
by Alexandre Bergel Feb. 15, 2009

Feb. 15, 2009

Hi All, Often, I do a print-it in a debugger or browser. For some mysterious reason, I subsequently press the delete key that erases what was just print. Some changes occurred therefore. When I then select another method (or frame if I am in a debugger), a confirmation whether I want to save my changes is done. I find this very boring. Am i the only one ? A simple check whether the textual content has been modified would prevent this stupid question. Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

5 8

[Pharo-project] MimeType problems
by StÃ©phane Ducasse Feb. 15, 2009

Feb. 15, 2009

Begin forwarded message: > From: Philippe Marschall <philippe.marschall(a)gmail.com> > Date: February 15, 2009 4:02:05 PM CEST > To: Seaside - general discussion <seaside(a)lists.squeakfoundation.org> > Subject: Re: [Seaside] don't update to the latest Pharo > Reply-To: Seaside - general discussion <seaside(a)lists.squeakfoundation.org > > > > 2009/2/15, Adrian Lienhard <adi(a)netstyle.ch>: >> he filed an issue: http://code.google.com/p/pharo/issues/detail? >> id=527 > > Further analysis shows there are additional problems: > MIMEDocument defaultContentType > returns now an instance of MIMEType instead of a String which doesn't > understand #indexOf: > > *must not add troll comment about static typing* > > I see three ways how "we" (= you & Giovanni) can proceed > - make a fork of Kom for Pharo > - decouple Kom from MIMEDocument > - revert the changes done to MIMEDocument > > Additionally there is: > http://bugs.squeak.org/view.php?id=7285 > > Cheers > Philippe > _______________________________________________ > seaside mailing list > seaside(a)lists.squeakfoundation.org > http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside >

2 4

Feb. 15, 2009

addressed or tagged as addressed Issue 523: [SmallLint] Undeclared variables This check is similar to the "References an undeclared variable" check, but it looks for variables that are not defined in the class or in the undeclared dictionary. You probably had to work hard to get your code in this state. PasteUpMorph>>#makeNewDrawing:at: Project>>#storeSegmentNoFile CollectionRootTest>>#nonEmpty ScriptLoader>>#update10196 ScriptLoader>>#update10074 Issue 525: useless boolean checks on Morphic extras MorphicExtras Check for a =, ==, ~=, or ~~ message being sent to true/ false or with true/false as the argument. SqueakPage>>#write URLMorph>>#mouseUp: ClockMorph>>#addCustomMenuItems:hand: ClockMorph>>#step ClockMorph>>#toggleShowingSeconds ClockMorph>>#toggleShowing24hr MorphObjectOut>>#doesNotUnderstand: SketchEditorMorph>>#verifyState: SketchEditorMorph>>#deliverPainting:evt: FlapTab>>#inboard FlapTab>>#flapShowing FlapTab>>#tabSelected ReferenceMorph>>#isHighlighted SimpleSliderMorph>>#truncate

2 2

[Pharo-project] EventSensor>>createMouseEvent
by Igor Stasenko Feb. 15, 2009

Feb. 15, 2009

Hi, i found this method used only in two places in my image: Rectangle>>newRectFrom: Rectangle>>newRectButtonPressedDo: i think it could be candidate for removal along with #newRect's Still, i think it is useful to create graphics primitives based on user input. But i think that Rectangle is inappropriate place for it, where it hard-wiring with many globals and Morpic framework. -- Best regards, Igor Stasenko AKA sig.

4 5

Feb. 14, 2009

Hi guys some days ago with alex we wanted to identify the methods containing a reference to their class (Lint does it too). Now we thought that replacing them with self class is not equivalent since we could imagine that hardcoding the class name make sure that subclass cannot redefine methods. Now this is a bit against Smalltalk late bindinness and probably most of the time an newbie error. But I wanted to know what was your experiment to that regards. Stef

5 6