- Pharo-dev - lists.pharo.org

[Pharo-project] [update] #10487
by Adrian Lienhard Oct. 20, 2009

Oct. 20, 2009

10483 - 10487 ----- - Issue 1310: Make all tests green - Issue 1330: Better performance for tests Test result: 7168 run, 7150 passes, 18 expected failures, 0 failures, 0 errors, 0 unexpected passes ___________________ http://www.adrian-lienhard.ch/

9 24

Re: [Pharo-project] About TestCase >> assert:
by Dale Henrichs Oct. 20, 2009

Oct. 20, 2009

Nicolas, many very good points. Just to add food for thought... double dispatching is a technique that has the benefit of avoiding isXXXX messages completely allowing for maximum flexibility and if the message isn't understood, immediate feedback that the programmer has done something wrong (which can be fixed by implementing the appropriate dispatch method) ... better than an assertion failures perhaps... Of course, double dispatching is not without it's drawbacks. I prefer double dispatching to implementing isXXX messages, but then I'd like to eliminate Booleans, too:) Dale ----- "Nicolas Cellier" <nicolas.cellier.aka.nice(a)gmail.com> wrote: | 2009/10/16 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: | > | >> I think Smalltalk quality is based on a completly different plane | > | | First, my reference about quality is not Squeak, I rather mean st-80 | from ParcPlace :) | At least it used to have | - more generous class and method comments | - less bugs and obscure code (certainly because less code too !) | - a certain homogeneity (less programmers ?) | | So were is the Smalltalk quality ? | - the ability to test code as soon as written | - the ability to write small and simple code, | - the ability to write readable code, | - the ability to extend code | Are these essential properties in the quality standards used in static | typing ? | | > You mean not checkable documentation, absence of documentation, | > lack of static typing to document (because what would be good is to | > have a pluggable type system) | > | | I agree, lack of type can be seen as a weakness for documenting APIs. | As a workaround, we use funny parameter names (anArrayOfStrings). | Or we add a method comment (hem... at least we should). | I agree, all these comments will become false when code is changed, | and the quality will decrease... | As false as an outdated assertion... but silent... Maybe it's worse ? | Browsing senders, or inspecting the signature of message sent to, or | inserting a halt is sometimes our solutions... | I agree, this is not ideal. | | So yes, assertions as a public declaration of API could be good for | documenting. | And a good description of assertion failure can also provide | informative feedback to the user (more than a Debugger ?) | | What I do not like is defensive assertions as a potential barrier to | extendability, because they correspond to a static view of code, a | snapshot of current state. | Smalltalk state does and will change. The image is living, and class | structure not written on stone. | Rapidly changing code is definitely not accepted as a quality | standard... | | In a rapidly changing image, assertions could be a supplementary drag | against change... | Suppose I have a method accepting a String parameter P: p. | [p isString] assertWithDescription: 'method xxx only accept a | String as parameter P'. | Now maybe the method would have worked with a Text. I have been too | restrictive: | [p isCharacters] assertWithDescription: 'method xxx only accept | characters'. | Now someone introduce WideString, and my code only work with | ByteString. | [p isCharacters and: [p asString isByteString]] | assertWithDescription: 'method xxx only accept byte characters'. | Yes, but the method does not work with empty String, I add: | [p notEmpty] assertWithDescription: 'method xxx only accept non | empty strings'. | Nor does it with some control characters: | self assertPHasValidCharacters: p. | Fortunately someone then correct the WideString case, now I can | retract isByteString. | Unfortunately, p will be stored in an inst. var. with many public | interfaces... | Each time, I have to change all the false assertions in all senders | of | the core method that are in the public API... | And maybe some of these public APIs are driven by other public APIs | (you meet this in Smalltalk, didn't you?) | To avoid this I create a specific method | assertPIsValid: p | | sender | | sender := thisContext sender homeContext selector. | [p isCharacters] assertWithDescription: 'method ' , sender , ' | only accept characters'. | [p asString isByteString] assertWithDescription: 'method ' , | sender , ' only accept byte characters'. | [p notEmpty] assertWithDescription: 'method ' , sender , ' only | accept non empty strings'. | self assertPHasValidCharacters: p from: sender. | | But now, I can't see the assumption from within public API. I have to | browse implementors of assertPIsValid:, so I loose the immediate | documentation... | | And one day, a brilliant programmer decide a ReadStream on characters | would also be a good parameter P, with a minor change in the core | method... | Arghh, I don't want to advance the stream yet and do all my static | checks... | | In order to maximize extendability, can't we use extensible | assertions | like sending a message? | If we end up with | [p isAGoodParameterPForMyMessage] assert. | then I don't buy it ;) | | Maybe you have some better ideas about optional types as a | specification... | Semi-automatic RoelTyper like helper tools? | | Nicolas | | > _______________________________________________ | > Pharo-project mailing list | > Pharo-project(a)lists.gforge.inria.fr | > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project | > | | _______________________________________________ | Pharo-project mailing list | Pharo-project(a)lists.gforge.inria.fr | http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

2 1

[Pharo-project] [ANN] Pharo Core 1.0rc1
by Marcus Denker Oct. 19, 2009

Oct. 19, 2009

http://gforge.inria.fr/frs/download.php/24363/PharoCore-1.0-10491rc1.zip The zip contains a new sources file. Marcus

4 9

[Pharo-project] HostWindowTests>>testOne is failing in Windows
by Mariano Martinez Peck Oct. 19, 2009

Oct. 19, 2009

Hi adrian: I run all Pharo core tests in a Windows box and I get only one failure and 18 expected failures :) The only failure is HostWindowTests>>testOne. The assert with problem is: self shouldnt: [ hwindow open ] raise: Error. And the error raised is 'My subclass should have overridden #defaultWindowType' This is because in DisplayHostWindow>>open windowProxy is a HostWindowProxy and this class, the implementation of defaultWindowType is: defaultWindowType "set up my attributes to be a default window - a titlebar, usual decorations etc" ^self subclassResponsibility I opened a bug ticket: http://code.google.com/p/pharo/issues/detail?id=1338 Best, Mariano

1 1

[Pharo-project] Fwd: [squeak-dev] The Trunk: Collections-nice.167.mcz
by StÃ©phane Ducasse Oct. 19, 2009

Oct. 19, 2009

Begin forwarded message: > From: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> > Date: October 19, 2009 3:00:19 PM GMT+02:00 > To: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>, stephane ducasse <stephane.ducasse(a)gmail.com > > > Subject: Fwd: [squeak-dev] The Trunk: Collections-nice.167.mcz > > Salut bis, > > Minor change to be integrated in pharo... > > Nicolas > > ---------- Forwarded message ---------- > From: <commits(a)source.squeak.org> > Date: 2009/10/19 > Subject: [squeak-dev] The Trunk: Collections-nice.167.mcz > To: squeak-dev(a)lists.squeakfoundation.org > > > Nicolas Cellier uploaded a new version of Collections to project The > Trunk: > http://source.squeak.org/trunk/Collections-nice.167.mcz > > ==================== Summary ==================== > > Name: Collections-nice.167 > Author: nice > Time: 19 October 2009, 12:32:29 pm > UUID: 95819d6c-2419-0244-bce5-75e402e44ec3 > Ancestors: Collections-ar.166 > > http://bugs.squeak.org/view.php?id=7362 > use self class instead of Text, so that we can subclass Text > > =============== Diff against Collections-ar.166 =============== > > Item was changed: > ----- Method: Text>>reversed (in category 'converting') ----- > reversed > > "Answer a copy of the receiver with element order reversed." > > ^ self class string: string reversed runs: runs reversed. > > " It is assumed that self size = runs size holds. "! > > Item was changed: > ----- Method: Text>>copyFrom:to: (in category 'copying') ----- > copyFrom: start to: stop > "Answer a copied subrange of the receiver." > > | realStart realStop | > stop > self size > ifTrue: [realStop := self size] "handle > selection at end of string" > ifFalse: [realStop := stop]. > start < 1 > ifTrue: [realStart := 1] "handle > selection before start of string" > ifFalse: [realStart := start]. > + ^self class > - ^Text > string: (string copyFrom: realStart to: realStop) > runs: (runs copyFrom: realStart to: realStop)!

2 1

[Pharo-project] [update] #10488
by Adrian Lienhard Oct. 19, 2009

Oct. 19, 2009

This change will condense the sources file and clean out the changes file. 10488 ----- Condense sources ___________________ http://www.adrian-lienhard.ch/

5 5

[Pharo-project] Fwd: [squeak-dev] The Trunk: Kernel-nice.272.mcz
by StÃ©phane Ducasse Oct. 19, 2009

Oct. 19, 2009

Begin forwarded message: > From: Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> > Date: October 19, 2009 2:58:30 PM GMT+02:00 > To: StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>, stephane ducasse <stephane.ducasse(a)gmail.com > > > Subject: Fwd: [squeak-dev] The Trunk: Kernel-nice.272.mcz > > Salut, > > Minor change to be integrated in pharo... > > J'ai une insulte de mail delivery quand j'essaie de transfÃ©rer Ã > Pharo-project(a)lists.gforge.inria.fr ... > > Nicolas > > > ---------- Forwarded message ---------- > From: <commits(a)source.squeak.org> > Date: 2009/10/19 > Subject: [squeak-dev] The Trunk: Kernel-nice.272.mcz > To: squeak-dev(a)lists.squeakfoundation.org > > > Nicolas Cellier uploaded a new version of Kernel to project The Trunk: > http://source.squeak.org/trunk/Kernel-nice.272.mcz > > ==================== Summary ==================== > > Name: Kernel-nice.272 > Author: nice > Time: 19 October 2009, 2:39:18 am > UUID: 6ad59bb1-c97b-ad4f-aa05-ae19f0921ca5 > Ancestors: Kernel-ar.271 > > How to gain a factor x2 on speed of > String streamContents: [:strm | Float pi absPrintExactlyOn: strm > base: 10] > > 1) do not use d := r // s. r := r \\ s. This will evaluate the > quotient twice. > 2) s generally has a lot of trailing bits = 0, so it is faster to > evaluate: > d := (r >> (s lowBit - 1)) // (s >> (s lowBit - 1)). > especially s lowBit - 1 and (s >> (s lowBit - 1)) can go outside the > while loop > 3) revert the tests in tc1 and tc2: these tests are false but for the > last digit. > Since Float usually have more than 2 digits, it is statistically > faster to test for the false condition first. > 4) use and: or: when due instead of & | > > > =============== Diff against Kernel-ar.271 =============== > > Item was changed: > ----- Method: Float>>absPrintExactlyOn:base: (in category > 'printing') ----- > absPrintExactlyOn: aStream base: base > "Print my value on a stream in the given base. Assumes that my > value is strictly > positive; negative numbers, zero, and NaNs have already been > handled elsewhere. > Based upon the algorithm outlined in: > Robert G. Burger and R. Kent Dybvig > Printing Floating Point Numbers Quickly and Accurately > ACM SIGPLAN 1996 Conference on Programming Language Design and > Implementation > June 1996. > This version guarantees that the printed representation exactly > represents my value > by using exact integer arithmetic." > > + | fBase significand exp baseExpEstimate be be1 r s mPlus > mMinus scale roundingIncludesLimits d tc1 tc2 fixedFormat > decPointCount slowbit shead | > - | fBase significand exp baseExpEstimate be be1 r s mPlus > mMinus scale roundingIncludesLimits d tc1 tc2 fixedFormat > decPointCount | > self isInfinite ifTrue: [aStream nextPutAll: 'Infinity'. ^ > self]. > fBase := base asFloat. > significand := self significandAsInteger. > roundingIncludesLimits := significand even. > exp := (self exponent - 52) max: MinValLogBase2. > baseExpEstimate := (self exponent * fBase reciprocalLogBase2 - > 1.0e-10) ceiling. > exp >= 0 > ifTrue: > [be := 1 << exp. > significand ~= 16r10000000000000 > ifTrue: > [r := significand * be * 2. > s := 2. > mPlus := be. > mMinus := be] > ifFalse: > [be1 := be * 2. > r := significand * be1 * 2. > s := 4. > mPlus := be1. > mMinus := be]] > ifFalse: > + [(exp = MinValLogBase2 or: [significand ~= > 16r10000000000000]) > - [(exp = MinValLogBase2) | (significand ~= > 16r10000000000000) > ifTrue: > [r := significand * 2. > s := (1 << (exp negated)) * 2. > mPlus := 1. > mMinus := 1] > ifFalse: > [r := significand * 4. > s := (1 << (exp negated + 1)) > * 2. > mPlus := 2. > mMinus := 1]]. > baseExpEstimate >= 0 > ifTrue: [s := s * (base raisedToInteger: > baseExpEstimate)] > ifFalse: > [scale := base raisedToInteger: > baseExpEstimate negated. > r := r * scale. > mPlus := mPlus * scale. > mMinus := mMinus * scale]. > + ((r + mPlus < s) not and: [roundingIncludesLimits or: [r + > mPlus > s]]) > - (r + mPlus > s) | (roundingIncludesLimits & (r + mPlus = s)) > ifTrue: [baseExpEstimate := baseExpEstimate + 1] > ifFalse: > [r := r * base. > mPlus := mPlus * base. > mMinus := mMinus * base]. > (fixedFormat := baseExpEstimate between: -3 and: 6) > ifTrue: > [decPointCount := baseExpEstimate. > baseExpEstimate <= 0 > ifTrue: [aStream nextPutAll: > ('0.000000' truncateTo: 2 - baseExpEstimate)]] > ifFalse: > + [decPointCount := 1]. > + slowbit := s lowBit - 1. > + shead := s >> slowbit. > + [d := (r >> slowbit) // shead. > + r := r - (d*s). > + (tc1 := (r > mMinus) not and: [roundingIncludesLimits or: [r < > mMinus]]) | > + (tc2 := (r + mPlus < s) not and: [roundingIncludesLimits or: > [r + mPlus > s]])] whileFalse: > - [decPointCount := 1]. > - [d := r // s. > - r := r \\ s. > - (tc1 := (r < mMinus) | (roundingIncludesLimits & (r = > mMinus))) | > - (tc2 := (r + mPlus > s) | (roundingIncludesLimits & (r + mPlus > = s)))] whileFalse: > [aStream nextPut: (Character digitValue: d). > r := r * base. > mPlus := mPlus * base. > mMinus := mMinus * base. > decPointCount := decPointCount - 1. > decPointCount = 0 ifTrue: [aStream nextPut: $.]]. > tc2 ifTrue: > + [(tc1 not or: [r*2 >= s]) ifTrue: [d := d + 1]]. > - [tc1 not | (tc1 & (r*2 >= s)) ifTrue: [d := d + 1]]. > aStream nextPut: (Character digitValue: d). > decPointCount > 0 > ifTrue: > [decPointCount - 1 to: 1 by: -1 do: [:i | aStream > nextPut: $0]. > aStream nextPutAll: '.0']. > fixedFormat ifFalse: > [aStream nextPut: $e. > aStream nextPutAll: (baseExpEstimate - 1) printString]!

1 0

Oct. 19, 2009

11001 ----- - Issue 1322: Flap should be removed Stef

1 0

[Pharo-project] Immutable strings
by Niko Schwarz Oct. 19, 2009

Oct. 19, 2009

Hello list! I would like to propose the compiler spit out immutable strings as string literals. I'd like to do this by making a subclass of classical strings which throws error messages when it is attempted to change the string. The beginning of this discussion happened in the bug tracker, please see http://code.google.com/p/pharo/issues/detail?id=1332. I completely agree with Toon: String literals should be immutable. This can be done with almost no speed impact and would only break code that quite honestly deserves to break. My 2 cents. Regards, Niko

3 2

[Pharo-project] [update] #10489, #10490, #10491
by Adrian Lienhard Oct. 19, 2009

Oct. 19, 2009

10489, 10490, 10491 ----- Issue 1323: Input problems (fix) Switch to 1.1, or keep 1.0 RC1 We are preparing images for download now so that not everyone needs to go through the compression procedure. ___________________ http://www.adrian-lienhard.ch/

1 0