- Pharo-dev - lists.pharo.org

[Pharo-project] Pharo 1.1 failing tests testNewLineStartsIndentedWhenWrapped
by Nicolas Cellier Jan. 16, 2010

Jan. 16, 2010

If paragraph composition width is reduced by 24 instead of 20, the test works (taken from trunk) testNewLineStartsIndentedWhenWrapped "Checks whether the beginning of a new line starts at the indented position" | cb | para compositionRectangle: (0@0 extent: para width - 24@100); updateCompositionHeight. para clippingRectangle: (0@0 extent: 200@200). cb := para characterBlockForIndex: 8. self assert: cb top > 0. self assert: cb left = 24

2 1

[Pharo-project] Pharo 1.1 failing tests testToDoOutsideTempNotInlined
by Nicolas Cellier Jan. 16, 2010

Jan. 16, 2010

Sorry this is an effect of automatic move of temps inside blocks... testToDoOutsideTempNotInlined REQUIRES that | temp | be declared outside the block. Just revert to previous version from Lukas Nicolas

2 1

[Pharo-project] Pharo 1.1 failing tests testOtherClasses
by Nicolas Cellier Jan. 16, 2010

Jan. 16, 2010

DependentsArray is no more a subclass of ArrayedCollection. Apart this test, there is 0% chance to send byteSize nor bytesPerBasicElement to a DependentsArray. Simply remove DependentsArray from this test. Nicolas

2 1

[Pharo-project] Package Browser and Pharo
by Alexandre Bergel Jan. 16, 2010

Jan. 16, 2010

Hi! David arrived today and will spend few days among us. I would like to define a roadmap on how to improve the state of O2PackageBrowser. The main problem people have with O2PackageBrowser is the overrides made by O2PackageBrowser right? These overrides break OB. This is something we will fix. I would like that people who are using O2PackageBrowser to add their wishes and bug report on code.google please. Add David and me as Cc. We will look for the entries by entering O2 in the search field. Cheers, Alexandre

3 3

[Pharo-project] Fwd: ChangeSorter vs. ChangeOrganizer as entry point
by StÃ©phane Ducasse Jan. 16, 2010

Jan. 16, 2010

> > > > Hi guys > > may be one of you can confirm but I have the impression that the code > should use ChangesOrganizer instead of ChangeSorter for example in fileIntoNewChangeSet. > I do not see why we should rely on tools and instead of model? > > Stef > >

2 3

[Pharo-project] Toyota like process for 1.1
by StÃ©phane Ducasse Jan. 16, 2010

Jan. 16, 2010

Hi guys may be I'm wrong but I have the impression that fixing tests as soon as they are broken in the Unstable branch could be better. Now doing that may stall our energy. So what do you think? May be an alternate process is to make progress and to do green test session from time to time. Stef

6 8

[Pharo-project] Styles for Morphic
by Igor Stasenko Jan. 16, 2010

Jan. 16, 2010

Hello guys, thinking, how to easily define styles, based on simple selection rules, i sketched the class, MorphStyle. The principle how it works is simple: - you creating a style, add adding actions to it - you then applying style to morph or group of morphs. Example: | style | style := MorphStyle new submorphs model: #Browser; color: Color red. style applyTo: World. Let me describe in detail, what it does, when you applying it: style applyTo: World. Style initializing its current selection to be a collection with single element - { World }. Next thing, which it does is applying any actions , which we specified during building the style, namely: 'submorphs' - replacing the current selection by gathering all submorphs of it, i.e. selection before: #( World ) selection after: #( World's submorphs ) 'model: #Browser' - filter the current selection and leave only those entries, which respond to #model and model class name is #Browser selection before: #( world's submorphs ) selection after: { Browser SystemWindow#1. Browser SystemWindow#2. Browser SystemWindow#3.Browser SystemWindow#4. } 'color: Color red'. - since there's no such method in MorphStyle, it is trapped by DNU handler and converted to a #sendMessage: action. A #sendMessage: action sends a specified message to current selection, i.e.: { Browser SystemWindow#1. .... Browser SystemWindow#N. } do: [:morph | message sendTo: morph ]. So, as result, if you doIt : | style | style := MorphStyle new submorphs model: #Browser; color: Color red. style applyTo: World. all browser windows color will be changed to red color. Some words about potential uses of this stuff. - theming, (through defining own style sheets). In contrast to existing implementation, we're free to define anything, which morph understands , not just colors, border or fillstyle, but also, layout, fonts, position etc etc. - defining styles in various ways: following snippet sets the 'browse' button color to red for all browser windows and illustrating how one style could reuse another one. | browseButton buttonStyle browsers | buttonStyle := MorphStyle new color: Color blue. browseButton := MorphStyle new allSubmorphs; has: #label equalTo: 'browse'. browsers := MorphStyle new model: #Browser. browseButton style: buttonStyle. "browseButton reusing buttonStyle" browsers style: browseButton. "browser style reusing browseButton style" browsers applyTo: World submorphs. It can be easily integrated with Morphic when using some global theme, all we need is: - add Morph>>applyThemeStyles ^ World currentTheme applyStylesTo: self - send #applyStyles to morph, when its added to World. Also, we could integrate it with toolbuilder which will allow us to define morph layouts, fonts, colors & initial properties more flexibly than currently are . Non-morphic builders could just ignore the #setStyles: message. Comments, suggestions , as always welcome. -- Best regards, Igor Stasenko AKA sig.

2 2

[Pharo-project] Pharo 1.1 failing tests testIsUnsentMessagesInCategory
by Nicolas Cellier Jan. 16, 2010

Jan. 16, 2010

testIsUnsentMessagesInCategory testIsUnsentMessagesInClass testIsUnsentMessagesInPackage all fail because selectors does not answer a Set anymore. Just add #asSet in the assertion and all will be OK Nicolas

1 0

Jan. 16, 2010

I was wondering if this is of any interest to have the () and the compiled method with number because it breaks self evaluation for nothing. (Object>>#actionMap "a CompiledMethod(1891)") Stef

2 1

Jan. 16, 2010

11163 ----- - Issue 1834: File fixes from trunk prior readbuffer - Fixing Base64MimeConverterTest - Issue 1829: testIndenting: remove? rely on the current font Stef

1 0