- Pharo-dev - lists.pharo.org

[Pharo-project] OB failing test08Execution and
by Mariano Martinez Peck Sept. 26, 2010

Sept. 26, 2010

Hi Lukas. Both implementations of test08Execution fail in: n prompt = 'Create Category'. becasue "n prompt" -> 'Add Category' :) cheers mariano

2 2

Re: [Pharo-project] ECUntypedModelTest >> testNarrowWith failing
by Mariano Martinez Peck Sept. 26, 2010

Sept. 26, 2010

On Sun, Sep 26, 2010 at 6:58 PM, Romain Robbes <romain.robbes(a)gmail.com>wrote: > This one of the tests that were inherited from ECompletion I believe ... > I don't really know what to do with them. > > Same for your other email actually, although I seem to remember it > used to take a normal amount of time, maybe the implementation of some > method changed for the worse? > I remember there was some slowdown in certain type of collections in Pharo 1.1. I don't know if hashed, or sorted, weak...I don't know. Maybe it is something related to that? Thanks Mariano > > Romain > > On Sun, Sep 26, 2010 at 6:32 PM, Mariano Martinez Peck > <marianopeck(a)gmail.com> wrote: > > This fails where it does: > > > > self assert: count == model entries size. > > self assert: count > 100. > > > > > > since model entries size -> 85 > > > > > > Of course, if I change the test to > > > > self assert: count == model entries size. > > self assert: count > 80. > > > > it works :) > > > > Romain ? > > > > thanks > > > > mariano > > >

2 2

[Pharo-project] Cannot make latest OCompletion work with latest OB
by Mariano Martinez Peck Sept. 26, 2010

Sept. 26, 2010

Hi. I am trying to load OB and OCOmpletion in a PharoCore1.1 and OCompletion doesn't seem to work. However, OCOmpletion and OB tests are green. To reproduce take a PharoCore 1.1 and evaluate: Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfOmniBrowser'; load. (ConfigurationOfOmniBrowser project version: '1.2') load: #('Dev' 'Dev Tests') And you will see that you open OB, and you type....but OCompletion doesn't appear. Thanks Mariano

1 0

[Pharo-project] ECompletion/OCompletion tests takes A LIFE!!
by Mariano Martinez Peck Sept. 26, 2010

Sept. 26, 2010

Hi. I am loading OCompletion in PharoCore 1.1 while building the Dev image. If I just take a core image, load OCompletion and run tests, they take a lot of time, not acceptable. Now....if I build a Dev image (with OB, RB, etc) and at the end I try to run OCompletion tests, the tests takes HOURS. The image seems frozen, but actually is working. If I interrupt I see the problem is in ECUntypedModel >> initializeSelectors the part of [ Smalltalk environment keysDo: [ :each | selectors add: (ECGlobalEntry contents: each type: #globalVar) ]. takes a lot of time and it seems related to "ECPreferences caseSensitive" and "ECUntypedModel >> resetSelectors" I don't know what else to say. To reproduce, take a PharoCore 1.1 and evaluate: Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfOCompletion'; load. (ConfigurationOfOCompletion project version: '1.2') load: 'Core Tests' Then, run all the tests inside OCompletionTests. You will see that after running some threads....it will look like frozen. There, do an interrupt and analize. IF you do that for a Dev image, it takes muuuuch more. I guess this is because "Smalltalk environment keys" will have muuuuuch more elements than a simple core. Anyway, help is appreciated. Cheers Mariano

2 1

Re: [Pharo-project] MuTalk: Mutation Testing for Pharo Smalltalk
by StÃ©phane Ducasse Sept. 26, 2010

Sept. 26, 2010

cool! Did you run MuTalk on pharo tests and did you find place where they could be improved? Stef On Sep 26, 2010, at 2:26 AM, Gabriel Brunstein wrote: > Hi! > > I just want to let you know that MuTalk is available for Pharo-Dev versions 1.0 and 1.1 > > > you can load it with monticello from http://www.squeaksource.com/MutationTesting > > > MutationTesting-NicolasChillo.101 for loading last version in Pharo 1.1 (thanks to Francisco Ortiz PeÃ±aloza) > > MutationTesting-GabrielBrunstein.97 for loading last verion in Pharo 1.0 > > > More info here: http://code.google.com/p/mutalk/ > > > We developed it with Nicolas Chillo for our career thesis but we will continue working on it. > > Basically, Mutation Testing is a technique for measuring and improving tests quality. > > > > All suggestions are welcome. > > > > Bests, > > Gabriel > > > > PS: it doesn't work with CogVM but I think that this problem will be solved with Pharo 1.2 (we must adapt it to work there). > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

3 2

[Pharo-project] Squeak/Pharo Talk
by DeNigris Sean Sept. 26, 2010

Sept. 26, 2010

The presentation was great! There were about 10 Squeak/Pharo-ers there, from hobbyists to a surprise XEROX-PARC celebrity :) We had a dialogue, nudged along by a slideshow, which I posted at http://seandenigris.com/blog/?p=541 Sean

1 0

Re: [Pharo-project] [Vm-dev] VM Maker: VMMaker-oscog.33.mcz
by Mariano Martinez Peck Sept. 26, 2010

Sept. 26, 2010

On Sun, Sep 26, 2010 at 1:45 PM, stephane ducasse < stephane.ducasse(a)gmail.com> wrote: > > Eliot > > I wanted to understand what: ' Have various places check for > isOopCOmpiledMethod: > rather than isCompiledMethod: to allow SmallIntegers to be used as > methods.' > means > in which circumstances do we want to have smalltalkIntegers used as > methods? > when we put an object instead of a compiled method and that by > accident this is an integer? > > Eliot, first of all, thanks A LOT!!! This is really important for us....wiiii we have TestCoverage again :) BTW, I think I found something related to what Stef says....In normal squeakVM : testAddNumbers self assert: (self add: 3 with: 4) = 7. self assert: (self perform: #add:with: withArguments: #(3 4)) = 7. this is ok, since (self perform: #add:with: withArguments: #(3 4)) answers 7. But with this new CogVM, there is a primitiveError. so...we can update the test to: self should: (self perform: #add:with: withArguments: #(3 4)) rise: Error. or something like that....but this test will fail with normal VM.. what we should do? thanks mariano > Stef > > > > > > > > Name: VMMaker-oscog.33 > > Author: eem > > Time: 25 September 2010, 7:13:51 am > > UUID: 733b7c50-b973-4ca0-9831-5c84d09032bf > > Ancestors: VMMaker-oscog.32 > > > > OSCogVM: > > Support object-as-method: > > Eagerly evaluate the interpreter version of a primitive > > to ease the object-as-method implementation and to > > improve interpreter performance. > > Refuse to enter anything that isn't a CompiledMethod > > into the method-lookup cache to avoid open PICs having > > to check for valid compiled methods. > > Have various places check for isOopCOmpiledMethod: > > rather than isCompiledMethod: to allow SmallIntegers to > > be used as methods. > > Interpreter: > > Have various places check for isOopCOmpiledMethod: > > rather than isCompiledMethod: to allow SmallIntegers to > > be used as methods. > > Slang: > > support super sends by expanding them at translation > > time. This allows CoInterpreter>>addMethodToCache > > to avoid cacheing non-compiled methods via a super > > send, avoiding duplicating SrackInterpreter's method. > > > >

1 0

Sept. 26, 2010

On Sep 25, 2010, at 10:45 PM, Lukas Renggli wrote: > I think people want all packages by default. > > This package separation is more to make it possible to replace some > parts of PharoCore with the more modern and powerful mechanisms from > the refactoring engline, e.g. SystemNavigation -> BrowserEnvironment, > (e.g. SystemNavigation -> BrowserEnvironemnt and ChangeRecord -> > RefactoryChange). yes! > > Lukas > > 2010/9/25 Mariano Martinez Peck <marianopeck(a)gmail.com>: >> Thanks. And do you have an idea of better groups that the basic ones I have >> defined? (look at the end). >> I mean, imagine groups of packages that it is likely a user will load only >> them, and all together >> >> >> >> >> spec for: #pharo do: [ >> spec repository: 'http://www.squeaksource.com/rb'. >> spec >> package: 'AST-Core'; >> package: 'AST-Tests-Core' with: [ spec requires: 'AST-Core' ]; >> >> package: 'AST-Semantic' with: [ spec requires: 'AST-Core' ]; >> package: 'AST-Tests-Semantic' with: [ spec requires: >> 'AST-Semantic' ]; >> >> package: 'Refactoring-Environment' with: [ spec requires: >> 'AST-Core' ]; >> package: 'Refactoring-Tests-Environment' with: [ spec requires: >> 'Refactoring-Environment' ]; >> >> package: 'Refactoring-Changes' with: [ spec requires: >> 'Refactoring-Environment' ]; >> package: 'Refactoring-Tests-Changes' with: [ spec requires: >> 'Refactoring-Changes' ]; >> >> package: 'Refactoring-Core' with: [ spec requires: >> 'Refactoring-Changes' ]; >> package: 'Refactoring-Tests-Core' with: [ spec requires: >> 'Refactoring-Core' ]; >> >> package: 'Refactoring-Critics' with: [ spec requires: >> 'Refactoring-Changes' ]; >> package: 'Refactoring-Tests-Critics' with: [ spec requires: >> 'Refactoring-Critics' ]; >> >> package: 'Refactoring-Spelling' with: [ >> spec requires: 'Refactoring-Critics'. >> spec postLoadDoIt: #postLoadRBSpelling ]; >> package: 'Refactoring-Tests-Spelling' with: [ spec requires: >> 'Refactoring-Tests-Critics'. ]. >> >> spec >> group: 'default' with: #('Core' ); >> group: 'Core' with: #( 'AST-Core' 'AST-Semantic' >> 'Refactoring-Environment' 'Refactoring-Changes' 'Refactoring-Core' >> 'Refactoring-Critics' 'Refactoring-Spelling' ); >> group: 'Tests' with: #( 'AST-Tests-Core' 'AST-Tests-Semantic' >> 'Refactoring-Tests-Environment' 'Refactoring-Tests-Changes' >> 'Refactoring-Tests-Core' 'Refactoring-Tests-Critics' >> 'Refactoring-Tests-Spelling' ); >> group: 'Core Tests' with: #('Core' 'Tests' ); >> >> >> >> cheers >> >> mariano >> >> >> On Sat, Sep 25, 2010 at 10:18 PM, Lukas Renggli <renggli(a)gmail.com> wrote: >>> >>> Refactoring-Spelling depends on Refactoring-Critics. >>> Refactoring-Tests-Spelling depends on Refactoring-Tests-Critics. >>> >>> Lukas >>> >>> 2010/9/25 Mariano Martinez Peck <marianopeck(a)gmail.com>: >>>> >>>> >>>> 2010/9/5 Lukas Renggli <renggli(a)gmail.com> >>>>> >>>>> I've split the refactoring model into various packages as outlined in >>>>> the previous mail. >>>>> >>>>> The dependencies between the tests are slightly problematic, but will >>>>> eventually be fixed as depicted in red in the attached dependency >>>>> graph. It shouldn't matter for loading, so there is no hurry. >>>>> >>>> >>>> Lukas, and what happens with 'Refactoring-Spelling' ?? >>>> >>>> is this still valid? >>>> >>>> package: 'Refactoring-Spelling' with: [ >>>> spec requires: 'Refactoring-Core'. >>>> spec postLoadDoIt: #postLoadRBSpelling ]; >>>> package: 'Refactoring-Tests-Spelling' with: [ spec requires: >>>> 'Refactoring-Spelling'. ]. >>>> >>>> >>>> thanks >>>> >>>> mariano >>>> >>>> >>>>> >>>>> Thank you for updating the configuration Mariano. Note that >>>>> OB-Refactory depends on all the non-test packages. >>>>> >>>>> Lukas >>>>> >>>>> On 4 September 2010 14:01, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> >>>>> wrote: >>>>>> >>>>>> On Sep 4, 2010, at 1:08 PM, Lukas Renggli wrote: >>>>>> >>>>>>>>> I agree that SystemNavigation is ugly, but *a lot* of existing >>>>>>>>> code >>>>>>>>> depends on it. >>>>>>>> >>>>>>>> Well if I start forking all the classes that we should fix because >>>>>>>> there are used it will be endless. >>>>>>>> I was thinking to start also to look at senders and use deprecate. >>>>>>>> >>>>>>>> do you have a lot of external tools that use it? >>>>>>> >>>>>>> Yes, all tools use it: >>>>>>> >>>>>>> Monticello, Paragraph Editor (new and old), OmniBrowser, >>>>>>> eCompletion, Refactoring Engine. >>>>>>> >>>>>>> Now I removed its use from the BrowserEnvironment in the refactoring >>>>>>> engine itself. There are still a couple of references though, where >>>>>>> people used the wrong abstraction layer when implementing stuff >>>>>>> (platform code instead of the abstraction of the refactoring >>>>>>> engine). >>>>>>> >>>>>>>> So what do you suggest? >>>>>>>> Separating BrowserEnvironment and its superclass from RB and >>>>>>>> starting >>>>>>>> to >>>>>>>> - check its api >>>>>>>> - improve it >>>>>>>> - migrate caller of systemNavigation -> BrowserEnvironment >>>>>>>> (rename browserEnvironment) >>>>>>> >>>>>>> Yeah, maybe one step would be to split the refactoring engine into >>>>>>> smaller and independent packages: >>>>>>> >>>>>>> AST-Core (that already is separate) >>>>>>> Refactoring-Environment (this is currently part of >>>>>> >>>>>> yes this would be good so that we can start do the idea with the >>>>>> integration related to systemDictionary been a potential leave of the >>>>>> composition >>>>>> tree we talked last time you visit us. >>>>>> >>>>>>> Refactoring-Core, but would work independently) >>>>>>> Refactoring-Changes (this is currently part of Refactoring-Core, >>>>>>> but would work independently) >>>>>> >>>>>> yes I'm curious to see if/how we could use changes to represent >>>>>> changeset. >>>>>> >>>>>> >>>>>>> Refactoring-Refactorings (this is currently part of >>>>>>> Refactoring-Core and depends on all of the above) >>>>>>> Refactoring-Lint (this is currently part of Refactoring-Core and >>>>>>> depends on all of the above) >>>>>>> >>>>>>> Like this Pharo could integrate Refactoring-Environment and >>>>>>> Refactoring-Changes independently. >>>>>> >>>>>> :) >>>>>> >>>>>>> I'll see if I can repackage the refactoring browser a bit, might >>>>>>> take >>>>>>> a while though because the tests are not that nicely separated. >>>>>> >>>>>> I imagine. >>>>>> Now incremental changes is the only way for us :) >>>>>>> >>>>>>> Lukas >>>>>>> >>>>>>> -- >>>>>>> Lukas Renggli >>>>>>> www.lukas-renggli.ch >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Pharo-project mailing list >>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Lukas Renggli >>>>> www.lukas-renggli.ch >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> >>> -- >>> Lukas Renggli >>> www.lukas-renggli.ch >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

2 1

Sept. 26, 2010

+ 1 http://code.google.com/p/pharo/issues/detail?id=3004 Stef On Sep 26, 2010, at 2:21 AM, Levente Uzonyi wrote: > On Sat, 25 Sep 2010, Schwab,Wilhelm K wrote: > >> copy >> "Answer another instance just like the receiver. Subclasses typically override postCopy; they typically do not override shallowCopy. Copy is a template method in the sense of Design Patterns. So do not override it. Override shallowCopy instead. Pay attention that normally you should call postCopy of your superclass too." > > It should be: Override postCopy instead. > > > Levente > >> >> ^self shallowCopy postCopy >> >> >> >> shallowCopy >> "Answer a copy of the receiver which shares the receiver's instance variables. It should never be overridden. I'm invoked from the copy template method. Subclasses that need to specialize the copy should specialize the postCopy hook method." >> >> >> The references to #postCopy are probably valid, but the comments above can't both be correct. Right?? >> >> Bill >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

1 0

Sept. 26, 2010

Thanks Eliot Here this is the total pressure. Deadline yesterday and some for a week. So I hope that we will be back on track soon. Marcus will certainly check because this is something really important for us. Alex too. Stef > I would appreciate anyone interested in objects-as-methods on Cog pounding on the latest Cog VMs (http://www.mirandabanda.org/files/Cog/VM/VM.r2313/) as this involved substantial changes to method lookup/inline cacheing machinery and there could easily be bugs. The tests run, but they're insubstantial compared e.g. to a full coverage test. > > best > Eliot > > (repeat with fixed email address: squeakfountation => squeakfoundation) > > On Sat, Sep 25, 2010 at 9:20 PM, <squeak-dev-noreply(a)lists.squeakfoundation.org> wrote: > > Eliot Miranda uploaded a new version of VMMaker to project VM Maker: > http://www.squeaksource.com/VMMaker/VMMaker-oscog.33.mcz > > ==================== Summary ==================== > > Name: VMMaker-oscog.33 > Author: eem > Time: 25 September 2010, 7:13:51 am > UUID: 733b7c50-b973-4ca0-9831-5c84d09032bf > Ancestors: VMMaker-oscog.32 > > OSCogVM: > Support object-as-method: > Eagerly evaluate the interpreter version of a primitive > to ease the object-as-method implementation and to > improve interpreter performance. > Refuse to enter anything that isn't a CompiledMethod > into the method-lookup cache to avoid open PICs having > to check for valid compiled methods. > Have various places check for isOopCOmpiledMethod: > rather than isCompiledMethod: to allow SmallIntegers to > be used as methods. > Interpreter: > Have various places check for isOopCOmpiledMethod: > rather than isCompiledMethod: to allow SmallIntegers to > be used as methods. > Slang: > support super sends by expanding them at translation > time. This allows CoInterpreter>>addMethodToCache > to avoid cacheing non-compiled methods via a super > send, avoiding duplicating SrackInterpreter's method. > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

1 0