- Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3246 in pharo: Duplicated code on SUnit
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Status: Accepted Owner: estebanlm New issue 3246 by estebanlm: Duplicated code on SUnit http://code.google.com/p/pharo/issues/detail?id=3246 Pharo image: core Pharo core version: 1.2 SUnit class TestCase and trait TAssertable have duplicated code, and also TAssertable is not used anywhere. It should be only one!

1 0

Re: [Pharo-project] Issue 3180 in pharo: Failing Tests SUnit
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Updates: Status: Fixed Comment #1 on issue 3180 by estebanlm: Failing Tests SUnit http://code.google.com/p/pharo/issues/detail?id=3180 fixed on SUnit-EstebanLorenzano.40118

1 0

Re: [Pharo-project] Issue 2928 in pharo: Trying to change the category of traits method -> DNU
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Comment #1 on issue 2928 by luc.fabresse: Trying to change the category of traits method -> DNU http://code.google.com/p/pharo/issues/detail?id=2928 I tried to move a method from one protocol to another and it works perfectly. But I tried to add a new protocol on a trait and it produces a DNU. This bug comes from a UI bug. TraitBehavior>>allSuperclasses return an empty collection. and creating a requestFormWindow with empty collections through a DNU because it is not checked in PopupChoiceOrRequestDialogWindow>>handlesKeyboard: Try this : UIManager default chooseOrRequestFrom: #() lines: #() title: 'Test Empty'. I attached a really silly patch. I am sure that there is something better to do. Attachments: PopupChoiceDialogWindow.LucFabresse.1.cs 898 bytes

1 0

[Pharo-project] Issue 3245 in pharo: Cannot browse implementors
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Status: Accepted Owner: guillermopolito CC: alexandre.bergel New issue 3245 by guillermopolito: Cannot browse implementors http://code.google.com/p/pharo/issues/detail?id=3245 Pharo image:Core Pharo core version:1.2 Virtual machine used: Cog Steps to reproduce: 1. type testExtMethodModifed 2. browse implementors The browser doesnt show up

1 0

[Pharo-project] Pharo sprint starting now
by alexandre＠bergel.eu Nov. 11, 2010

Nov. 11, 2010

Here are some rules. Feel free to complete them: 1 - Download the image 12220 Core image from https://gforge.inria.fr/frs/download.php/27719/PharoCore-1.2-12220.zip 2 - Go to http://code.google.com/p/pharo/issues/list http://code.google.com/p/pharo/issues/list?can=2&q=milestone=1.2&sort=miles… and pick an issue you want to work on. Since we are working on releasing Pharo 1.2, please pick an issue marked as 1.2 3 - feel free to fix the issue, comment on it, pair-program, ... 4 - let us know which issue you picked, and how you're going. 18 people are in the room! Use the twitter #pharosprint tag please Cheers, Alexandre

2 1

[Pharo-project] Issue 3231 in pharo: Semaphore changes
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Status: FixedWaitingToBePharoed Owner: stephane.ducasse CC: siguctua Labels: Type-Squeak New issue 3231 by stephane.ducasse: Semaphore changes http://code.google.com/p/pharo/issues/detail?id=3231 Needs a really careful review.... A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ul.514.mcz ==================== Summary ==================== Name: Kernel-ul.514 Author: ul Time: 7 November 2010, 4:21:51.529 pm UUID: 5710b62a-4264-9947-acdc-11e0ce45021d Ancestors: Kernel-ul.513 A few changes to Semaphore: - save a block creation + activation + a possible context switch in #critical:ifCurtailed: - save a block creation + activation in #critical:ifError:, this changes the behavior when mutuallyExcludedBlock doesn't understand #ifError: - #critical:ifLocked: is guaranteed to not get locked. The earlier implementation sent #critical: which could cause a context change, so another process could enter the critical section before the original. - added a new method #passIfLocked: which is like #wait, but it doesn't wait for a signal if there's none, but evaluates the argument instead. =============== Diff against Kernel-ul.513 =============== Item was changed: ----- Method: Semaphore>>critical:ifCurtailed: (in category 'mutual exclusion') ----- critical: mutuallyExcludedBlock ifCurtailed: terminationBlock "Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished." + ^self critical: [ mutuallyExcludedBlock ifCurtailed: terminationBlock ] - ^self critical:[[mutuallyExcludedBlock value] ifCurtailed: terminationBlock] ! Item was changed: ----- Method: Semaphore>>critical:ifError: (in category 'mutual exclusion') ----- critical: mutuallyExcludedBlock ifError: errorBlock "Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished." | blockValue hasError errMsg errRcvr | hasError := false. blockValue := self critical:[ + mutuallyExcludedBlock ifError: [ :msg :rcvr | - [mutuallyExcludedBlock value] ifError:[:msg :rcvr| hasError := true. errMsg := msg. errRcvr := rcvr ]. ]. hasError ifTrue:[ ^errorBlock value: errMsg value: errRcvr]. ^blockValue! Item was changed: ----- Method: Semaphore>>critical:ifLocked: (in category 'mutual exclusion') ----- critical: mutuallyExcludedBlock ifLocked: alternativeBlock "Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished." - "Note: The following is tricky and depends on the fact that the VM will not switch between processes while executing byte codes (process switches happen only in real sends). The following test is written carefully so that it will result in bytecodes only." + + | caught | + caught := false. + ^[ + excessSignals = 0 + ifTrue: [ alternativeBlock value ] + ifFalse: [ + excessSignals := excessSignals - 1. + caught := true. + mutuallyExcludedBlock value ] ] + ensure: [ caught ifTrue: [ self signal ] ]! - excessSignals == 0 ifTrue:[ - "If we come here, then the semaphore was locked when the test executed. - Evaluate the alternative block and answer its result." - ^alternativeBlock value - ]. - ^self critical: mutuallyExcludedBlock! Item was added: + ----- Method: Semaphore>>passIfLocked: (in category 'communication') ----- + passIfLocked: aBlock + + excessSignals = 0 ifTrue: [ ^aBlock value ]. + excessSignals := excessSignals - 1!

1 1

[Pharo-project] Issue 3242 in pharo: BDFFontReader fixes
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Type-Squeak New issue 3242 by stephane.ducasse: BDFFontReader fixes http://code.google.com/p/pharo/issues/detail?id=3242 We should pay attention because some parts are different in pharo but the rest looks trivial. Levente Uzonyi uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-ul.153.mcz ==================== Summary ==================== Name: Graphics-ul.153 Author: ul Time: 3 November 2010, 6:50:09.075 am UUID: 030e6dfc-71b7-5144-9edd-76f529655456 Ancestors: Graphics-ul.152 - removed the last direct users of CrLfFileStream - replaced the download url of the bdf fonts, because the original doesn't work anymore - removed BDFFontReader class >> #new, because it ignores #initialize which breaks the font conversion process. This stuff is still broken btw. =============== Diff against Graphics-ul.152 =============== Item was changed: ----- Method: BDFFontReader class>>downloadFonts (in category 'resource download') ----- downloadFonts "BDFFontReader downloadFonts" "Download a standard set of BDF sources from x.org. The combined size of these source files is around 1.2M; after conversion to .sf2 format they may be deleted." | heads tails filenames baseUrl basePath | heads := #( 'charR' 'courR' 'helvR' 'lubR' 'luRS' 'lutRS' 'ncenR' 'timR' ). tails := #( '08' '10' '12' '14' '18' '24'). filenames := OrderedCollection new. heads do: [:head | filenames addAll: (tails collect: [:tail | head , tail , '.bdf']) ]. + baseUrl := 'http://cvsweb.xfree86.org/cvsweb/*checkout*/xc/fonts/bdf/75dpi/' asUrl. - - baseUrl := 'http://ftp.x.org/pub/R6.4/xc/fonts/bdf/75dpi/' asUrl. basePath := baseUrl path. + filenames do: [:filename | + | document newPath newUrl | - filenames do: [:filename | | document f newPath newUrl | newUrl := baseUrl clone. newPath := OrderedCollection newFrom: basePath. newPath addLast: filename. newUrl path: newPath. Utilities informUser: 'Fetching ' , filename during: [document := newUrl retrieveContents]. + MultiByteFileStream newFileNamed: filename do: [ :f | + f + wantsLineEndConversion: true; + nextPutAll: document content ] - f := CrLfFileStream newFileNamed: filename. - f nextPutAll: document content. - f close. ]. ! Item was removed: - ----- Method: BDFFontReader class>>new (in category 'file creation') ----- - new - - ^ self basicNew. - ! Item was changed: ----- Method: BDFFontReader>>openFileNamed: (in category 'initialize') ----- openFileNamed: fileName + file := MultiByteFileStream readOnlyFileNamed: fileName. + file wantsLineEndConversion: true! - file := CrLfFileStream readOnlyFileNamed: fileName.!

1 0

[Pharo-project] Issue 3241 in pharo: Eliot's stdio changes
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Type-Squeak New issue 3241 by stephane.ducasse: Eliot's stdio changes http://code.google.com/p/pharo/issues/detail?id=3241 Levente Uzonyi uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-ul.90.mcz ==================== Summary ==================== Name: Files-ul.90 Author: ul Time: 27 September 2010, 3:56:36.551 am UUID: aff6ed6c-5823-6342-b175-65f0f4e8f403 Ancestors: Files-ul.89 - Integrated Eliot's stdio changes with a minor fix/optimization =============== Diff against Files-ul.89 =============== Item was added: + ----- Method: CrLfFileStream class>>newForStdio (in category 'instance creation') ----- + newForStdio + "Circumvent CrLfFileStream new's retuning an instance of MultiBteFileStream" + ^super new! Item was added: + ----- Method: CrLfFileStream>>openOnHandle:name:forWrite: (in category 'open/close') ----- + openOnHandle: aFileID name: streamName forWrite: writeMode + "Initialize the file with the given handle. If writeMode is true then + allow writing, otherwise put the file in read-only mode." + super openOnHandle: aFileID name: streamName forWrite: writeMode. + lineEndConvention := LineEndDefault! Item was changed: ----- Method: DirectoryEntry>>fullName (in category 'access') ----- fullName + "The fully-qualified name. + Since this method falls into the equality test, make it safe when directory is nil." + ^ directory + ifNotNil: [ directory fullNameFor: self name ] + ifNil: [ self name ]! - "The fully-qualified name." - ^ directory fullNameFor: self name! Item was added: + ----- Method: FileDirectory>>directoryEntryForName: (in category 'private') ----- + directoryEntryForName: aFileName + + "Return a single DirectoryEntry for the given (non-path) entry name, + or nil if the entry could not be found. + Raises InvalidDirectoryError if this directory's path does not identify a directory." + + | entryArray sysPath sysName | + + sysPath := pathName asVmPathName. + sysName := aFileName asVmPathName. + + "New linear-time primitive." + entryArray := self primLookupEntryIn: sysPath name: sysName. + entryArray == #primFailed ifFalse:[ + ^ entryArray ifNotNil: [(DirectoryEntry fromArray: entryArray directory: self) convertFromSystemName] + ]. + + "If the new primitive fails, use the old slow method. + (This fallback can be changed to signal InvalidDirectoryError once + VM's with FilePlugin #primitiveDirectoryEntry have been distributed everywhere; + the new primitive was introduced 6/13/2007." + + ^self isCaseSensitive ifTrue: [ + self entries detect: [:entry | entry name = aFileName ] ifNone: [ nil ] + ] ifFalse: [ + self entries detect: [:entry | entry name sameAs: aFileName ] ifNone: [ nil ] + ] + ! Item was changed: FileStream subclass: #StandardFileStream instanceVariableNames: 'name fileID buffer1' + classVariableNames: 'Registry StdioHandles' - classVariableNames: 'Registry' poolDictionaries: '' category: 'Files-Kernel'! + StandardFileStream class + instanceVariableNames: 'stdioFiles'! !StandardFileStream commentStamp: 'ul 12/6/2009 05:13' prior: 0! Provides a simple, platform-independent, interface to a file system. The instance variable rwmode, inherited from class PositionableStream, here is used to hold a Boolean -- true means opened for read-write, false means opened for read-only. 2/12/96 sw I implement a simple read buffering scheme with the variables defined in PositionableStream (which are unused in me otherwise) in the following way: collection <ByteString> or <ByteArray> This is the buffer. position <Integer> The relative position in the buffer. Greater or equal to zero. readLimit <Integer> The number of bytes buffered. Greater or equal to zero. Read buffering is enabled with #enableReadBuffering, disabled with #disableReadBuffering and it is enabled by default. The buffer is filled when a read attempt of an unbuffered absolute position is requested, or when a negative repositioning is made (with #position: with an argument < than the current absolute position) to an absolute position which is not buffered. In the first case, the buffer is positioned to the given absolute position. In the latter case the repositioning is made to the requested absolute position minus fourth of the buffer size. This means that further small negative repositionings won't result in buffer flushing. This is really useful when filing in code. The read buffer is flushed (#flushReadBuffer) whenever a write attempt is made. The buffer state is valid if and only if collection is not nil and position < readLimit.! + StandardFileStream class + instanceVariableNames: 'stdioFiles'! Item was changed: ----- Method: StandardFileStream class>>fileExistsUserHandling: (in category 'error handling') ----- fileExistsUserHandling: fullFileName | dir localName choice newName newFullFileName | dir := FileDirectory forFileName: fullFileName. localName := FileDirectory localNameFor: fullFileName. + choice := (UIManager default + chooseFrom: #('overwrite that file' 'append (risky!!!!)' 'choose another name' 'cancel') + title: localName, ' already exists.'). - choice := UIManager default chooseFrom:{ - 'overwrite that file'. - 'choose another name'. - 'cancel' - } title: localName, ' - already exists.'. choice = 1 ifTrue: [ dir deleteFileNamed: localName ifAbsent: [self error: 'Could not delete the old version of that file']. ^ self new open: fullFileName forWrite: true]. choice = 2 ifTrue: [ + ^ (self new open: fullFileName forWrite: true) setToEnd]. + + choice = 3 ifTrue: [ newName := UIManager default request: 'Enter a new file name' initialAnswer: fullFileName. newFullFileName := self fullName: newName. ^ self newFileNamed: newFullFileName]. self error: 'Please close this to abort file opening'! Item was added: + ----- Method: StandardFileStream class>>flushAndVoidStdioFiles (in category 'class initialization') ----- + flushAndVoidStdioFiles + stdioFiles ifNotNil: + [stdioFiles do: + [:f| f isReadOnly ifFalse: [[f flush] on: Error do: [:ex|"care less"]]]. + stdioFiles := nil]! Item was added: + ----- Method: StandardFileStream class>>initialize (in category 'class initialization') ----- + initialize + "StandardFileStream initialize" + StdioHandles := Array new: 3. + Smalltalk + addToStartUpList: self after: SecurityManager; "the intent being before: AutoStart" + addToShutDownList: self after: SecurityManager! Item was added: + ----- Method: StandardFileStream class>>newForStdio (in category 'private-file creation') ----- + newForStdio + "Circumvent CrLfFileStream new's returning an instance of MultiBteFileStream" + ^self new! Item was added: + ----- Method: StandardFileStream class>>shutDown: (in category 'class initialization') ----- + shutDown: quitting + quitting ifTrue: + [self withAllSubclassesDo: + [:fileStreamClass| fileStreamClass flushAndVoidStdioFiles]]! Item was added: + ----- Method: StandardFileStream class>>standardIOStreamNamed:forWrite: (in category 'private-file creation') ----- + standardIOStreamNamed: moniker forWrite: forWrite + + | index | + index := #(stdin stdout stderr) identityIndexOf: moniker. + ^((stdioFiles ifNil: [ stdioFiles := Array new: 3 ]) at: index) + ifNil: [ + stdioFiles + at: index + put: ( + (StdioHandles at: index) + ifNil: [ ^self error: moniker, ' is unavailable' ] + ifNotNil: [ :handle| + self newForStdio + openOnHandle: handle + name: moniker + forWrite: forWrite ]) ]! Item was added: + ----- Method: StandardFileStream class>>startUp: (in category 'class initialization') ----- + startUp: resuming + (resuming and: [self == StandardFileStream]) ifTrue: + [self withAllSubclassesDo: + [:fileStreamClass| fileStreamClass voidStdioFiles]. + [StdioHandles := self stdioHandles] + on: Error + do: [:ex| + StdioHandles isArray ifFalse: + [StdioHandles := Array new: 3]]]! Item was added: + ----- Method: StandardFileStream class>>stderr (in category 'file creation') ----- + stderr + ^self standardIOStreamNamed: #stderr forWrite: true! Item was added: + ----- Method: StandardFileStream class>>stdin (in category 'file creation') ----- + stdin + ^self standardIOStreamNamed: #stdin forWrite: false! Item was added: + ----- Method: StandardFileStream class>>stdioHandles (in category 'private-file creation') ----- + stdioHandles + <primitive: 'primitiveFileStdioHandles' module: 'FilePlugin' error: ec> + self primitiveFailed! Item was added: + ----- Method: StandardFileStream class>>stdout (in category 'file creation') ----- + stdout + ^self standardIOStreamNamed: #stdout forWrite: true! Item was added: + ----- Method: StandardFileStream class>>voidStdioFiles (in category 'class initialization') ----- + voidStdioFiles + stdioFiles := nil! Item was added: + ----- Method: StandardFileStream>>openOnHandle:name:forWrite: (in category 'open/close') ----- + openOnHandle: aFileID name: streamName forWrite: writeMode + "Initialize the file with the given handle. If writeMode is true then + allow writing, otherwise put the file in read-only mode. + N.B. Do _not_ register the stream. We do not want it to be + closed implicitly (e.g. on GC). There may be multiple instances + accessing the same stream. The stream is not a file." + fileID := aFileID. + name := streamName. + rwmode := writeMode. + buffer1 := String new: 1. + self enableReadBuffering!

1 0

[Pharo-project] Issue 3238 in pharo: Use Class instead of TextDiffBuilder in changelist
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Status: Accepted Owner: stephane.ducasse Labels: Type-Squeak New issue 3238 by stephane.ducasse: Use Class instead of TextDiffBuilder in changelist http://code.google.com/p/pharo/issues/detail?id=3238 Should check how to invoke this method - use ClassDiffBuilder for diffing class definitions and comments in ChangeList =============== Diff against Tools-ul.275 =============== Item was changed: ----- Method: ChangeList>>contentsDiffedFromCurrent (in category 'viewing access') ----- contentsDiffedFromCurrent "Answer the contents diffed forward from current (in-memory) method version" | aChange aClass | listIndex = 0 ifTrue: [^ '']. aChange := changeList at: listIndex. (aChange type == #method and: [(aClass := aChange methodClass) notNil and: [aClass includesSelector: aChange methodSelector]]) ifTrue: [^Utilities methodDiffFor: aChange text class: aClass selector: aChange methodSelector prettyDiffs: self showingPrettyDiffs]. aChange type == #doIt ifTrue: [| tokens | tokens := Scanner new scanTokens: aChange string. ((tokens select: [:substr| #(subclass: variableByteSubclass: variableWordSubclass: instanceVariableNames: classVariableNames: ) includes: substr]) asSet size >= 3 and: [(aClass := Smalltalk at: tokens third ifAbsent: []) notNil and: [aClass isBehavior]]) ifTrue: + [^ClassDiffBuilder buildDisplayPatchFrom: aClass definition to: aChange string]. - [^TextDiffBuilder buildDisplayPatchFrom: aClass definition to: aChange string]. (tokens size = 4 and: [tokens second == #class and: [tokens third == #instanceVariableNames: and: [(aClass := Smalltalk at: tokens first ifAbsent: []) notNil and: [aClass isBehavior]]]]) ifTrue: + [^ClassDiffBuilder buildDisplayPatchFrom: aClass class definition to: aChange string]]. - [^TextDiffBuilder buildDisplayPatchFrom: aClass class definition to: aChange string]]. (aChange type == #classComment and: [(aClass := aChange commentClass) notNil]) ifTrue: + [^ClassDiffBuilder buildDisplayPatchFrom: aClass comment asString to: aChange string]. - [^TextDiffBuilder buildDisplayPatchFrom: aClass comment asString to: aChange string]. ^(changeList at: listIndex) text!

1 0

[Pharo-project] Issue 3237 in pharo: If MessageTally is not in memory
by pharo＠googlecode.com Nov. 11, 2010

Nov. 11, 2010

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Type-Squeak New issue 3237 by stephane.ducasse: If MessageTally is not in memory http://code.google.com/p/pharo/issues/detail?id=3237 we have to compare because the implementation in pharo is different. in pharo we do Smalltalk globals at: #MessageTally ifPresent: [ :c | c new close ]. ----- Method: Debugger>>process:controller:context: (in category 'private') ----- process: aProcess controller: aController context: aContext super initialize. + Smalltalk at: #MessageTally ifPresentAndInMemory: [ :tally | + tally terminateTimerProcess]. - Smalltalk at: #MessageTally ifPresent:[:tally| tally terminateTimerProcess]. contents := nil. interruptedProcess := aProcess. interruptedController := aController. contextStackTop := aContext. self newStack: (contextStackTop stackOfSize: 1). contextStackIndex := 1. externalInterrupt := false. selectingPC := true. Smalltalk isMorphic ifTrue: [errorWasInUIProcess := false]!

1 0