- Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3291 in pharo: Missing text field with completion
by pharo＠googlecode.com Nov. 30, 2010

Nov. 30, 2010

Status: Accepted Owner: aplantec Labels: Milestone-1.2 New issue 3291 by aplantec: Missing text field with completion http://code.google.com/p/pharo/issues/detail?id=3291 Could be added as an instrumentation of PluggableTextFieldMorph.

4 11

[Pharo-project] Issue 3338 in pharo: could not parse a '<historical>' time stamp
by pharo＠googlecode.com Nov. 30, 2010

Nov. 30, 2010

Status: Accepted Owner: hilaire.fernandes Labels: Milestone-1.2 Type-ReportDefect Importance-High New issue 3338 by hilaire.fernandes: could not parse a '<historical>' time stamp http://code.google.com/p/pharo/issues/detail?id=3338 In Pharo-core 1.2 (26 nov 2010), it looks like a bug was introduced. It could not parse a '<historical>' time stamp correctly. See fix in http://www.squeaksource.com/PharoInbox/System-Support-BertFreudenberg.410.m… I have not checked personally.

1 1

[Pharo-project] Issue 3354 in pharo: Clean of RecentMessageList
by pharo＠googlecode.com Nov. 30, 2010

Nov. 30, 2010

Status: Fixed Owner: Benjamin.VanRyseghem.Pharo New issue 3354 by Benjamin.VanRyseghem.Pharo: Clean of RecentMessageList http://code.google.com/p/pharo/issues/detail?id=3354 A fix is in PharoTaskForces

1 4

Re: [Pharo-project] TextConverter handling of binary streams
by StÃ©phane Ducasse Nov. 30, 2010

Nov. 30, 2010

fix fix fix :) Stef > I would even go further, the test UTF8TextConverterTest>>#testPutSingleCharacter is plain wrong, it seems to have been written as an afterthought: > > testPutSingleCharacter > | actual | > actual := ByteArray streamContents: [ :stream | > | converter | > converter := UTF8TextConverter new. > converter > nextPut: $a > toStream: stream. > converter > nextPut: (Unicode value: 16r20AC) > toStream: stream ]. > self assert: actual = #[97 0 0 32 172] > > The correct result is #[97 226 130 172] !! > > If you would give these bytes to any other system, they would never be able to decode them as UTF-8.

2 1

Re: [Pharo-project] TextConverter handling of binary streams
by StÃ©phane Ducasse Nov. 30, 2010

Nov. 30, 2010

On Nov 30, 2010, at 11:46 AM, Sven Van Caekenberghe wrote: > I understand very well that you are very busy, StÃ©phane, I am not asking for a solution. :) but I would love to have time :) > > It is exactly the same in Squeak. > > Like Philippe said, it looks wrong. so open a ticket > > On 29 Nov 2010, at 20:12, StÃ©phane Ducasse wrote: > >> sven >> >> I'm terribly and more than that busy until mid or more dec. >> Now did you check if the behavior is the same in squeak? >> S. >> >> On Nov 29, 2010, at 3:23 PM, Sven Van Caekenberghe wrote: >> >>> Hi, >>> >>> TextConverter and its subclasses seem to break the contract of #nextFromStream: and #nextPut:toStream: when the stream #isBinary. Consider the following two examples: >>> >>> ByteArray streamContents: [ :stream | | encoder | >>> encoder := UTF8TextConverter new. >>> 'Ã©lÃ¨ve en franÃ§ais' do: [ :each | encoder nextPut: each toStream: stream ] ]. >>> >>> #[233 108 232 118 101 32 101 110 32 102 114 97 110 231 97 105 115] >>> >>> (String streamContents: [ :stream | | encoder | >>> encoder := UTF8TextConverter new. >>> 'Ã©lÃ¨ve en franÃ§ais' do: [ :each | encoder nextPut: each toStream: stream ] ]) asByteArray. >>> >>> #[195 169 108 195 168 118 101 32 101 110 32 102 114 97 110 195 167 97 105 115] >>> >>> The first answer is incorrect, the second is correct (as far as I understand it). >>> >>> This is apparently on purpose, from the implementation of, for example, UTF8TextConverter>>#nextPut:toStream: >>> >>> nextPut: aCharacter toStream: aStream >>> | leadingChar nBytes mask shift ucs2code | >>> aStream isBinary ifTrue: [^aCharacter storeBinaryOn: aStream]. >>> leadingChar := aCharacter leadingChar. >>> (leadingChar = 0 and: [aCharacter asciiValue < 128]) ifTrue: [ >>> aStream basicNextPut: aCharacter. >>> ^ aStream. >>> ]. >>> >>> "leadingChar > 3 ifTrue: [^ aStream]." >>> >>> ucs2code := aCharacter asUnicode. >>> ucs2code ifNil: [^ aStream]. >>> >>> nBytes := ucs2code highBit + 3 // 5. >>> mask := #(128 192 224 240 248 252 254 255) at: nBytes. >>> shift := nBytes - 1 * -6. >>> aStream basicNextPut: (Character value: (ucs2code bitShift: shift) + mask). >>> 2 to: nBytes do: [:i | >>> shift := shift + 6. >>> aStream basicNextPut: (Character value: ((ucs2code bitShift: shift) bitAnd: 63) + 128). >>> ]. >>> >>> ^ aStream. >>> >>> I would say that the contract of #nextPut:toStream: is to take a Character object and write a binary representation using a specific encoding to a stream. However, when given a #isBinary stream, it does no longer do any encoding at all ! >>> >>> The same is true for the other converters as well as for #nextFromStream:. >>> >>> Does anyone know why that is the case ? >>> >>> And if it is by design, how should one do UTF8 encoding on a binary stream ?? >>> >>> Thx, >>> >>> Sven >>> >>> PS: If others also think this is strange, I could make an issue, I am just not sure this is a bug. >>> >>> >>> >> >> > >

1 0

Re: [Pharo-project] [ANN] Hudson build server for Pharo
by Marcus Denker Nov. 30, 2010

Nov. 30, 2010

On Nov 29, 2010, at 11:08 PM, Miguel CobÃ¡ wrote: > > One question, you have the pharo-project.org domain, why isn't this > hudson a subdomain of that domain. Hosted on inria, but accessible by > the official project domain? > One step at a time :-) > Anyway, very good news. I suppose that the download page of pharo will > point to the latest successful build link of the hudson server very > soon. Yes... that's the goal. The artefact that people download should be generated completely automatically. (This way we can move much faster). Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

4 3

[Pharo-project] TextConverter handling of binary streams
by Sven Van Caekenberghe Nov. 30, 2010

Nov. 30, 2010

Hi, TextConverter and its subclasses seem to break the contract of #nextFromStream: and #nextPut:toStream: when the stream #isBinary. Consider the following two examples: ByteArray streamContents: [ :stream | | encoder | encoder := UTF8TextConverter new. 'Ã©lÃ¨ve en franÃ§ais' do: [ :each | encoder nextPut: each toStream: stream ] ]. #[233 108 232 118 101 32 101 110 32 102 114 97 110 231 97 105 115] (String streamContents: [ :stream | | encoder | encoder := UTF8TextConverter new. 'Ã©lÃ¨ve en franÃ§ais' do: [ :each | encoder nextPut: each toStream: stream ] ]) asByteArray. #[195 169 108 195 168 118 101 32 101 110 32 102 114 97 110 195 167 97 105 115] The first answer is incorrect, the second is correct (as far as I understand it). This is apparently on purpose, from the implementation of, for example, UTF8TextConverter>>#nextPut:toStream: nextPut: aCharacter toStream: aStream | leadingChar nBytes mask shift ucs2code | aStream isBinary ifTrue: [^aCharacter storeBinaryOn: aStream]. leadingChar := aCharacter leadingChar. (leadingChar = 0 and: [aCharacter asciiValue < 128]) ifTrue: [ aStream basicNextPut: aCharacter. ^ aStream. ]. "leadingChar > 3 ifTrue: [^ aStream]." ucs2code := aCharacter asUnicode. ucs2code ifNil: [^ aStream]. nBytes := ucs2code highBit + 3 // 5. mask := #(128 192 224 240 248 252 254 255) at: nBytes. shift := nBytes - 1 * -6. aStream basicNextPut: (Character value: (ucs2code bitShift: shift) + mask). 2 to: nBytes do: [:i | shift := shift + 6. aStream basicNextPut: (Character value: ((ucs2code bitShift: shift) bitAnd: 63) + 128). ]. ^ aStream. I would say that the contract of #nextPut:toStream: is to take a Character object and write a binary representation using a specific encoding to a stream. However, when given a #isBinary stream, it does no longer do any encoding at all ! The same is true for the other converters as well as for #nextFromStream:. Does anyone know why that is the case ? And if it is by design, how should one do UTF8 encoding on a binary stream ?? Thx, Sven PS: If others also think this is strange, I could make an issue, I am just not sure this is a bug.

2 2

Nov. 30, 2010

sven I'm terribly and more than that busy until mid or more dec. Now did you check if the behavior is the same in squeak? S. On Nov 29, 2010, at 3:23 PM, Sven Van Caekenberghe wrote: > Hi, > > TextConverter and its subclasses seem to break the contract of #nextFromStream: and #nextPut:toStream: when the stream #isBinary. Consider the following two examples: > > ByteArray streamContents: [ :stream | | encoder | > encoder := UTF8TextConverter new. > 'Ã©lÃ¨ve en franÃ§ais' do: [ :each | encoder nextPut: each toStream: stream ] ]. > > #[233 108 232 118 101 32 101 110 32 102 114 97 110 231 97 105 115] > > (String streamContents: [ :stream | | encoder | > encoder := UTF8TextConverter new. > 'Ã©lÃ¨ve en franÃ§ais' do: [ :each | encoder nextPut: each toStream: stream ] ]) asByteArray. > > #[195 169 108 195 168 118 101 32 101 110 32 102 114 97 110 195 167 97 105 115] > > The first answer is incorrect, the second is correct (as far as I understand it). > > This is apparently on purpose, from the implementation of, for example, UTF8TextConverter>>#nextPut:toStream: > > nextPut: aCharacter toStream: aStream > | leadingChar nBytes mask shift ucs2code | > aStream isBinary ifTrue: [^aCharacter storeBinaryOn: aStream]. > leadingChar := aCharacter leadingChar. > (leadingChar = 0 and: [aCharacter asciiValue < 128]) ifTrue: [ > aStream basicNextPut: aCharacter. > ^ aStream. > ]. > > "leadingChar > 3 ifTrue: [^ aStream]." > > ucs2code := aCharacter asUnicode. > ucs2code ifNil: [^ aStream]. > > nBytes := ucs2code highBit + 3 // 5. > mask := #(128 192 224 240 248 252 254 255) at: nBytes. > shift := nBytes - 1 * -6. > aStream basicNextPut: (Character value: (ucs2code bitShift: shift) + mask). > 2 to: nBytes do: [:i | > shift := shift + 6. > aStream basicNextPut: (Character value: ((ucs2code bitShift: shift) bitAnd: 63) + 128). > ]. > > ^ aStream. > > I would say that the contract of #nextPut:toStream: is to take a Character object and write a binary representation using a specific encoding to a stream. However, when given a #isBinary stream, it does no longer do any encoding at all ! > > The same is true for the other converters as well as for #nextFromStream:. > > Does anyone know why that is the case ? > > And if it is by design, how should one do UTF8 encoding on a binary stream ?? > > Thx, > > Sven > > PS: If others also think this is strange, I could make an issue, I am just not sure this is a bug. > > >

2 1

Nov. 30, 2010

this is cool! > 12264 > ----- > > Issue 3359: categorize some methods > Issue 3358: Another fix for SourceReference > Issue 3351: Comments in MIMEDocument erroneously refer to MIMEObject > Issue 3344: No brainer fix for hasBindingThatBeginWith: > > ... and hudson auto-build was triggered successfully. > > https://pharo-ic.lille.inria.fr/hudson/job/Pharo%20Core%201.2/ > > -- > Marcus Denker -- http://www.marcusdenker.de > INRIA Lille -- Nord Europe. Team RMoD. > >

1 0

[Pharo-project] Issue 3344 in pharo: No brainer fix for hasBindingThatBeginWith:
by pharo＠googlecode.com Nov. 30, 2010

Nov. 30, 2010

Status: Fixed Owner: stephane.ducasse Labels: Milestone-1.2 New issue 3344 by stephane.ducasse: No brainer fix for hasBindingThatBeginWith: http://code.google.com/p/pharo/issues/detail?id=3344 SystemDictionary>>hasBindingThatBeginsWith: aString "Use the cached class and non-class names for better performance." | name searchBlock | searchBlock := [ :element | (element beginsWith: aString) ifTrue: [ 0 ] ifFalse: [ aString < element ifTrue: [ -1 ] ifFalse: [ 1 ] ] ]. name := self classNames findBinary: searchBlock + ifNone: [ nil ]. - ifNone: nil. name ifNotNil: [ ^true ]. name := self nonClassNames findBinary: searchBlock + ifNone: [ nil ]. - ifNone: nil. ^name notNil!

1 1