- Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3661 in pharo: fixed the calculation of base in PNGReadWriter>>copyPixelsGray: (floor vs ceil)
by pharo＠googlecode.com Feb. 10, 2011

Feb. 10, 2011

Status: FixedWaitingToBePharoed Owner: stephane...(a)gmail.com Labels: Milestone-1.3 Type-Squeak New issue 3661 by stephane...(a)gmail.com: fixed the calculation of base in PNGReadWriter>>copyPixelsGray: (floor vs ceil) http://code.google.com/p/pharo/issues/detail?id=3661 Name: Graphics-ul.177 Author: ul Time: 5 February 2011, 4:53:19.27 am UUID: dfac9cf3-85a4-3c4b-9256-1c8214f36fe6 Ancestors: Graphics-nice.176 - fixed the calculation of base in PNGReadWriter>>copyPixelsGray: (floor vs ceil) =============== Diff against Graphics-nice.176 =============== Item was changed: ----- Method: PNGReadWriter>>copyPixelsGray: (in category 'pixel copies') ----- copyPixelsGray: y "Handle non-interlaced grayscale color mode (colorType = 0)" | base bits bytesLeft word | bitsPerChannel = 16 ifTrue: [ "Warning: This is extremely slow. Besides we are downsampling to 8 bits!!" | blitter | blitter := BitBlt current bitPokerToForm: form. 0 to: width - 1 do: [ :x | blitter pixelAt: x @ y put: 255 - (thisScanline at: x * 2 + 1) ]. ^self ]. "Just copy the bits" "This Smalltalk version might be easier to understand than the others below." + base := y * (form width * bitsPerChannel + 31 // 32) + 1. - base := y * form width * bitsPerChannel // 32 + 1. bits := form bits. 0 to: thisScanline size // 4 - 1 do: [ :i | | ii | ii := i * 4. "This somewhat weird mixture of (#* and #+) with (#bitShift: and #bitOr:) is to make use of faster arithmetic bytecodes, but not of slow largeintegers." word := (((thisScanline at: ii + 1) * 256 + (thisScanline at: ii + 2) * 256 + (thisScanline at: ii + 3)) bitShift: 8) bitOr: (thisScanline at: ii + 4). bits at: base + i put: word ]. (bytesLeft := thisScanline size bitAnd: 3) = 0 ifFalse: [ word := 0. thisScanline size - bytesLeft + 1 to: thisScanline size do: [ :ii | word := word * 256 + (thisScanline at: ii) ]. word := word bitShift: 8 * (4 - bytesLeft). bits at: base + (thisScanline size // 4) put: word ]. "This interesting technique (By Andreas Raab) is faster for very large images, but might be slower for small ones" "^self copyPixelsGrayWeirdBitBltHack: y ". "It uses the following method: PNGReadWriter >> copyPixelsGrayWeirdBitBltHack: y ""Handle non-interlaced black and white color mode (colorType = 0) By Andreas Raab"" | source dest cmap | source := Form extent: 1 @ (thisScanline size // 4) depth: 32 bits: thisScanline. dest := Form extent: 1 @ (form bits size) depth: 32 bits: form bits. cmap := Smalltalk isLittleEndian ifTrue:[ColorMap shifts: #(-24 -8 8 24) masks: #(16rFF000000 16r00FF0000 16r0000FF00 16r000000FF)]. (BitBlt toForm: dest) sourceForm: source; destX: 0 destY: (y * form width*bitsPerChannel//32) width: 1 height: (form width+31*bitsPerChannel//32); colorMap: cmap; combinationRule: 3; copyBits." "This interesting technique (By Yoshiki Ohshima) is faster for very large images, but might be slower for small ones" "form bits copyFromByteArray2: thisScanline to: y * (form width* bitsPerChannel // 32)". "It uses the following method: BitMap >> copyFromByteArray2: byteArray to: i ""This method should work with either byte orderings"" | myHack byteHack | myHack := Form new hackBits: self. byteHack := Form new hackBits: byteArray. Smalltalk isLittleEndian ifTrue: [byteHack swapEndianness]. byteHack displayOn: myHack at: 0@i"!

1 3

[Pharo-project] Issue 3676 in pharo: Remove #example* class messages from HTTPClient
by pharo＠googlecode.com Feb. 10, 2011

Feb. 10, 2011

Status: New Owner: ---- New issue 3676 by patchi...(a)gmail.com: Remove #example* class messages from HTTPClient http://code.google.com/p/pharo/issues/detail?id=3676 Pharo image: Pharo-core Pharo core version: all of them Since we're documenting HTTPClient it would be great to remove class side messages #examplePostArgs and #examplePostMultipart

1 2

[Pharo-project] Issue 3609 in pharo: Integrate RPackage
by pharo＠googlecode.com Feb. 10, 2011

Feb. 10, 2011

Status: Accepted Owner: cy.delau...(a)gmail.com New issue 3609 by cy.delau...(a)gmail.com: Integrate RPackage http://code.google.com/p/pharo/issues/detail?id=3609 RPackage aims to replace PackageInfo with a faster and cleaner implementation. What RPackage is already able to do (or at least until you find something wrong;)) is: - synchronize and initialize with the current PackageOrganizer in the system (RPackageOrhanizer class>> initializeDefault) - update itself when changes are made in the system (new category, new class, new method, ... ) (see all tests in RPackageMCSynchronisationTest). To point I am working on is to modify monticello to make it work using RPackage. I have currently A version that does not seem to crash all (:) that means that it save and load from a repository without error, and viewing changes seems to match with what you would expect). Now what could be cool is that the monticello tests green. To have all this running in your image, that's what should evaluate: Gofer new squeaksource: 'PharoTaskForces'; package: 'ConfigurationOfRPackage'; load. (Smalltalk globals at: #ConfigurationOfRPackage) loadDefault. "to be sure that the organizer is initialized before loading anything else:" (Smalltalk globals at: #RPackageOrganizer) initializeDefault. Gofer new squeaksource: 'DelaunayTmpStuffs'; version: 'Monticello-cyrilledelaunay.505'; merge. Gofer new squeaksource: 'DelaunayTmpStuffs'; version: 'MonticelloGUI-cyrilledelaunay.88'; merge.

1 10

[Pharo-project] Issue 3688 in pharo: Network primitives missing in the image
by pharo＠googlecode.com Feb. 10, 2011

Feb. 10, 2011

Status: Accepted Owner: jannik.l...(a)gmail.com Labels: Difficulty-Easy New issue 3688 by jannik.l...(a)gmail.com: Network primitives missing in the image http://code.google.com/p/pharo/issues/detail?id=3688 There are some primitives missing in Pharo, there are in eToys. Maybe we can include them primGetAddressInfoFamily <primitive: 'primitiveResolverGetAddressInfoFamily' module: 'SocketPlugin'> self primitiveFailed === primGetAddressInfoHost: hostName service: servName flags: flags family: family type: type protocol: protocol <primitive: 'primitiveResolverGetAddressInfo' module: 'SocketPlugin'> self primitiveFailed === primGetAddressInfoNext <primitive: 'primitiveResolverGetAddressInfoNext' module: 'SocketPlugin'> self primitiveFailed === primGetAddressInfoProtocol <primitive: 'primitiveResolverGetAddressInfoProtocol' module: 'SocketPlugin'> self primitiveFailed === primGetAddressInfoResult: socketAddress <primitive: 'primitiveResolverGetAddressInfoResult' module: 'SocketPlugin'> self primitiveFailed === primGetAddressInfoSize <primitive: 'primitiveResolverGetAddressInfoSize' module: 'SocketPlugin'> self primitiveFailed === primGetAddressInfoType <primitive: 'primitiveResolverGetAddressInfoType' module: 'SocketPlugin'> self primitiveFailed === primGetNameInfo: socketAddress flags: flags <primitive: 'primitiveResolverGetNameInfo' module: 'SocketPlugin'> flags == 0 ifTrue: [^self primGetNameInfo: socketAddress flags: SocketAddressInformation numericFlag]. self primitiveFailed === primGetNameInfoHostResult: aString <primitive: 'primitiveResolverGetNameInfoHostResult' module: 'SocketPlugin'> self primitiveFailed === primGetNameInfoHostSize <primitive: 'primitiveResolverGetNameInfoHostSize' module: 'SocketPlugin'> self primitiveFailed === primGetNameInfoServiceResult: aString <primitive: 'primitiveResolverGetNameInfoServiceResult' module: 'SocketPlugin'> self primitiveFailed === primGetNameInfoServiceSize <primitive: 'primitiveResolverGetNameInfoServiceSize' module: 'SocketPlugin'> self primitiveFailed === primHostNameResult: aString <primitive: 'primitiveResolverHostNameResult' module: 'SocketPlugin'> self primitiveFailed === primHostNameSize <primitive: 'primitiveResolverHostNameSize' module: 'SocketPlugin'> self primitiveFailed

1 4

[Pharo-project] [update 1.3] #13045
by StÃ©phane Ducasse Feb. 10, 2011

Feb. 10, 2011

13045 ----- - Issue 3688: Network primitives missing in the image. Thanks Jannik Laval Stef and the Anneciens sprinting :)

1 0

[Pharo-project] Issue 3690 in pharo: Monticello Browser: improve submit slice dialog
by pharo＠googlecode.com Feb. 10, 2011

Feb. 10, 2011

Status: Accepted Owner: laurent....(a)gmail.com CC: aplan...(a)gmail.com New issue 3690 by laurent....(a)gmail.com: Monticello Browser: improve submit slice dialog http://code.google.com/p/pharo/issues/detail?id=3690 We are currently working on version 1.2, so please verify your issue with the latest 1.2 Unstable version before reporting it - we improved a lot the system. If you fill an issue for the first time, please read "How to report bugs" at http://www.pharo-project.org/community/issue-tracking Pharo image: Pharo-core Pharo core version: Pharo1.2rc2 Latest update: #12332 In Monticello Browser, improve GUI for submitting a fix: - +Slice -> rename to 'Contribute a fix' - in Slice GUI: - put a hint like 'Copy paste issue number and summary from http://code.google.com/p/pharo/issues' - change label 'Included packages' to 'Choose packages to include' - in packages list => checkbox From PharoConf Annecy 2011

1 1

[Pharo-project] Clipping
by StÃ©phane Ducasse Feb. 10, 2011

Feb. 10, 2011

In SMxCanvas>>copyClipRect: aRectangle ^ self copyOrigin: origin clipRect: (aRectangle translateBy: origin) SMxFormCanvas>>copyOrigin: aPoint clipRect: aRectangle "Return a copy of this canvas with the given origin. The clipping rectangle of this canvas is the intersection of the given rectangle and the receiver's current clipping rectangle. This allows the clipping rectangles of nested clipping morphs to be composed." ^ self copy setOrigin: aPoint clipRect: (clipRect intersect: aRectangle) Canvas>>copyClipRect: newClipRect ^ ClippingCanvas canvas: self clipRect: newClipRect FormCanvas>>copyOrigin: aPoint clipRect: aRectangle "Return a copy of this canvas with the given origin. The clipping rectangle of this canvas is the intersection of the given rectangle and the receiver's current clipping rectangle. This allows the clipping rectangles of nested clipping morphs to be composed." ^ self copy setOrigin: aPoint clipRect: (clipRect intersect: aRectangle) Do you think that we can remove ClippingCanvas. There are too many canvases in Pharo. Stef

2 1

[Pharo-project] [COTDC] 6 - StandardFonts
by Laurent Laffont Feb. 9, 2011

Feb. 9, 2011

Today: StandardFonts (really at random this time :) Comment Of The Day Contest - One Day One Comment Rules: #1: Each day a not commented class is elected. Each day the best comment will be integrated with name of the author(s). #2: If you cannot comment it, deprecate it. Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest Laurent

2 2

Feb. 9, 2011

The registration for the school: deep on Smalltalk organized at INRIA Lille Nord Europe is now open. http://www.inria.fr/centre-de-recherche-inria/lille-nord-europe/agenda/smal… Please register as soon as possible so that we can build some estimates. Please register even if you are local or close. ==== SCHOOL The objective of this school is to present on advanced Smalltalk topics such as compiler compiler, virtual machine, interaction with C, advanced UI, ... The school is structured around two main lectures on Virtual machines and a hand on sessions. â¢ Igor Stasenko RMOD Lille France â¢ Dr. Noury Bouraqadi â¢ Henrik Johansen Norway â¢ Jorge Ressia SCG Bern Switzerland â¢ Marcus Denker RMOD Lille France â¢ Prof. Theo D'Hondt VUB Belgium â¢ Dr. Tudor Girba Switzerland â¢ Dr. Eliot Miranda US â¢ Date : du 7 mars 2011 au 11 mars 2011 â¢ Lieu : Centre de recherche INRIA Lille Nord Europe ***There will be certainly a Pharo Sprint the saturday 15 of March. You are welcomed *** http://www.inria.fr/centre-de-recherche-inria/lille-nord-europe/agenda/smal… HOTEL ==== I'm negotiating with some hotels to provide fast a list. Now the first hotel that is cheap and good and that agreed to get better rooms for the same price is Hotel Agora 14 r Molinel 59000 LILLE Mail : agorahotel(a)yahoo.fr. 03 20 31 55 52 fax :.03 20 06 27 54 You should mention that you are coming to INRIA to get reduction. Stef

9 11

Feb. 9, 2011

Excellnt colin >> > I've published my changes to the SqueakSource FS repository. However, > I think we should abandon them, for several reasons: > > They're based on a quite old version of FS, and they touch a *lot* of > methods. So there are a ton of conflicts, and merging them into the > latest versions that are on SqueakSource is really difficult to do > correctly. > > Also, I think they're ultimately going in the wrong direction, and we > should try to come up with a better solution to the Path/Reference > naming problem. Ok I guess that with good comment and a bit of package reorganization as I did it we can leave with FSPath. > >> I will integrate the fixes of damien. >> I would like to have >> - a better help (already there). >> - Rename workingDirectory as workingDirectoryPath >> - add workingDirectory returning a FSReference > > Agreed. > >> - Every method with an adequate comment. The idea is that the comment should describe what the method does when we do not see its >> body: let us try to think a bit in JavaDoc or Ruby Yard fashion for once. > > Also agreed, at least for the public API. Comments should be more > sparse for the private stuff. > >> - Use rename primitives >> - Have the possibility to create empty file >> - Clean identification of implementation tests and black box tests >> - Integrate Gemstone fixes > > Agreed. > >> - Stream usage clearly identified to support Gemstone migration) >> - Onion like structure so that we can have one or two packages that are really the core >> (yes I still want a minimal kernel). > > I'd like to see FS split into separate packages: > > - Core (basic, API, resolvers, enumeration and exceptions) > - MemoryFS > - DiskFS > - ZipFS > - GitFS > - CurlFS > - FileStream compatibility > - ANSI streams > - Xtreams integration > > This will make it easier to have a minimal installation (just Core and > DiskFS) as well as port to platforms like VW and Gemstone > >> - Check the file API creation: >> old, new, exist.... > > Sure, but that stuff is actually much simpler when you have read-only > and write-only streams. > >> - Prepare a migration path for 1.3 >> - Fix filesystem workingDirectory isWorkingDirectory returns false. >> - rename fileDoesNotExist: and friends do convey that its goal is mainly to raise en exception >> raiseFileDoesNotExistsFor: > > Sure. > >> Of course I would like to avoid to throw away all that good energy so I hope to collaborate with colin. >> We will see what will happen. I can understand that he has another agenda/time frame but we should >> move on this front. So all my code will be publicly available in the SqueakSource/fs repository. > > Cool! > > Colin

1 0