- Pharo-dev - lists.pharo.org

[Pharo 8.0] Build #508: 3965-Minimal-image-calls-but-doesnt-include-SmalltalkImageplatformName
by ci-pharo-ci-jenkins2＠inria.fr July 17, 2019

July 17, 2019

There is a new Pharo build available! The status of the build #508 was: FAILURE. The Pull Request #3966 was integrated: "3965-Minimal-image-calls-but-doesnt-include-SmalltalkImageplatformName" Pull request url: https://github.com/pharo-project/pharo/pull/3966 Issue Url: https://github.com/pharo-project/pharo/issues/3965 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Re: [Pharo-dev] [Pharo-users] "whenSelectedItemChanged:" in Spec
by Ben Coman July 17, 2019

July 17, 2019

Following on from something I noticed commenting on "[Pharo-users] "whenSelectedItemChanged:" in Spec"... On Wed, 17 Jul 2019 at 08:38, Ben Coman <btc(a)openinworld.com> wrote: > Looking at ListPresenter>>whenSelectedItemChanged: aBlock > it is registering aBlock on selectionHolder using #whenChangedDo: > Reviewing selectionHolder "Code search...>References to it" I see that > selectionHolder is initialized as an instance of SelectionHolderClass. > > So it seems you are expecting whenSelectedItemChanged: to be called > every time the-selection-is-changed > when actually it is only called once (by your application) to register > the block-to-be-called when the-selection-is-changed. > You don't seem to have done any such registration. It seems awkward that the SelectionValueHolder used by ListPresenter allows #index: and #selection: to be set independently making it too easy to get insistent state. Multi-selection also has a completely different basis using IdentityDictionary with the boolean "multiSelection" indicating some widget specific handling to distinguish between the two selection-types that may be duplicated a lot elsewhere. It might be nice to have a generic SelectionWrapper class that behaved a bit like a PositionableStream to encapsulate any "collection" as its first instance variable, with "positions" as its only other instance variable. Selected-values would be a derivation of those two instance variables. "positions" is used rather than "index" since the latter feels 1-dimensional and it should work just as well with a 2-dimensional grid/table. For an event-driven facility it might subclass Model, or it may be simpler to have its own Announcer. WDYT? Would such a class be worthwhile? Where in the system might this reduce code duplication? (which would define its requirements) Are there any existing candidates? (Reviewing Spotter('selection') doesn't indicate anything. The closest is SelectionMorph which has baggage and works with items rather than positions) cheers -ben

1 0

[Pharo 8.0] Build #507: Use `anySatisfy:` or `detect:ifFound:*` instead of `detect:ifNone:[nil]` and a nil check
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #507 was: SUCCESS. The Pull Request #3962 was integrated: "Use `anySatisfy:` or `detect:ifFound:*` instead of `detect:ifNone:[nil]` and a nil check" Pull request url: https://github.com/pharo-project/pharo/pull/3962 Issue Url: https://github.com/pharo-project/pharo/issues/detectIfNoneAndNilMissuse Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #506: SharedPool Inspector: list all Shared pools
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #506 was: FAILURE. The Pull Request #3963 was integrated: "SharedPool Inspector: list all Shared pools" Pull request url: https://github.com/pharo-project/pharo/pull/3963 Issue Url: https://github.com/pharo-project/pharo/issues/SharedPool Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #505: Use #includesBehavior: instead of testing manually for class identityâ¦
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #505 was: FAILURE. The Pull Request #3952 was integrated: "Use #includesBehavior: instead of testing manually for class identityâ¦" Pull request url: https://github.com/pharo-project/pharo/pull/3952 Issue Url: https://github.com/pharo-project/pharo/issues/use_includesBehavior Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #504: Improve astnodes LiteralVariable
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #504 was: FAILURE. The Pull Request #3954 was integrated: "Improve astnodes LiteralVariable" Pull request url: https://github.com/pharo-project/pharo/pull/3954 Issue Url: https://github.com/pharo-project/pharo/issues/Improve Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #503: Adding package to reuse the commander commands in Spec2
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #503 was: FAILURE. The Pull Request #3957 was integrated: "Adding package to reuse the commander commands in Spec2" Pull request url: https://github.com/pharo-project/pharo/pull/3957 Issue Url: https://github.com/pharo-project/pharo/issues/feature/adding Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #502: SUCCESS
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #502 was: SUCCESS. Could not extract further issue information from commit message: Update stale.yml Lower bug timeout to ~6 months Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #501: FAILURE
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #501 was: FAILURE. Could not extract further issue information from commit message: Update weekly-digest.yml trying to fix config of weekly digest Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #500: More minor cleanup for portability
by ci-pharo-ci-jenkins2＠inria.fr July 16, 2019

July 16, 2019

There is a new Pharo build available! The status of the build #500 was: SUCCESS. The Pull Request #3953 was integrated: "More minor cleanup for portability" Pull request url: https://github.com/pharo-project/pharo/pull/3953 Issue Url: https://github.com/pharo-project/pharo/issues/PharoGs_cleanup Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0