- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] The Smalltalk Renaissance Program
by Ben Coman Dec. 30, 2014

Dec. 30, 2014

On Wednesday, December 31, 2014, Ben Coman wrote: > > > On Wednesday, December 31, 2014, horrido <horrido.hobbies(a)gmail.com > <javascript:_e(%7B%7D,'cvml','horrido.hobbies(a)gmail.com');>> wrote: > >> And, yes, I did not do my most thorough homework regarding Pharo, as >> several >> of you have pointed out. Frankly, I don't have /that/ much time and >> energy. >> I'm old and retired. I'm just doing this for pleasure. >> >> So I rely on /you/ to set me straight. > > > In process :) > > >> I remind you that I'm just the >> coordinator of the campaign, because I'm sure none of you have that much >> time to do what I'm doing. > > > > > >> >> Marcus suggested that anyone can create a Google+ page, but he misses the >> point. The Google+ page is just one brick in the foundation of the >> campaign. >> It's part of a whole. >> >> Norbert suggests that I think I know what to do. No, I have ideas and I >> have >> a plan. There's no guarantee that it will work. Either you buy into my >> plan, >> or you don't. Either I have your support, or I don't. If the latter, I >> shan't waste any more time (yours or mind). >> >> > > It's not just a matter of time, but inclination. If you are inclined to >> do this, then it should be supported - but it's a matter of getting the >> PR message aligned with the technical vision. We don't want the market >> being told one thing then getting a different message here in-list. So >> you made a misstep here. That's okay, you learn more that way than doing >> nothing. It may take some more back-n-forth. I hope you continue. > > > -Ben > >

2 1

A hidden treasure :)
by stepharo Dec. 30, 2014

Dec. 30, 2014

Thanks igor for his great class comments and help! Stef

2 2

Re: [Pharo-dev] What do you call someone who writes Pharo code?
by Torsten Bergmann Dec. 30, 2014

Dec. 30, 2014

5 6

ToolRegistry need to support multiple registrations per tool
by Nicolai Hess Dec. 29, 2014

Dec. 29, 2014

Issue 10529 <https://pharo.fogbugz.com/default.asp?10529> ToolRegistry need to support multiple registrations per tool My solution : A ToolRegistry subclass (PharoCommonTools) that memorized all registered tools. And, for some common tools, like browser, debugger, inspector, workspace, it provides settings entry to reset the registration to a prior tool. What do you think? (maybe a subclass of ToolRegistry isn't need and we can merge this. And I don't like to "hardcode" the tools support for inspector, debugger, ..., but I don't know how we can add the settings interface without proper names, maybe someone knows a more "generic" way to add the settings for every key that is/was used for a tool registration ) nicolai

4 4

Source code formatting guidelines
by Jan Vrany Dec. 29, 2014

Dec. 29, 2014

Hi guys, is there any document I can read on how Pharo source code is/should be formatted? I mean things like - tabs/spaces? How many spaces if spaces? - encoding of the source string - trailing newlines - trailing spaces - ... I don't care much about things like whether there should be a space after ^, opening [ and so on (because there's a little I can do about it :-) Best, Jan

9 14

[pharo-project/pharo-core]
by GitHub Dec. 29, 2014

Dec. 29, 2014

Branch: refs/tags/40425 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] e7f06f: 40425
by GitHub Dec. 29, 2014

Dec. 29, 2014

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: e7f06ff141a19305077d05c9c31c9dbf1665da66 https://github.com/pharo-project/pharo-core/commit/e7f06ff141a19305077d05c9… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-12-29 (Mon, 29 Dec 2014) Changed paths: M Compiler.package/Decompiler.class/instance/control/doClosureCopyCopiedValues_numArgs_blockSize_.st A Compiler.package/EncoderForSistaV1.class/class/block closure support/numLocalTempsForBlockAt_in_.st R Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/pcOfBlockCreationBytecodeForBlockStartingAt_in_.st R Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/pushClosureBytecodeSize.st M Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/unusedBytecode.st R Compiler.package/EncoderForSistaV1.class/class/compiled method support/createClosureScanBlock.st R Compiler.package/EncoderForSistaV1.class/class/compiled method support/interpretJumpIfCondIn_.st R Compiler.package/EncoderForSistaV1.class/class/compiled method support/interpretJumpIn_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/interpretJumpIfCondIn_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/interpretJumpIn_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isCreateBlockAt_in_.st A Compiler.package/EncoderForV3.class/class/compiled method support/supportsClosures.st A Compiler.package/EncoderForV3PlusClosures.class/class/block closure support/numLocalTempsForBlockAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/bytecode decoding/callPrimitiveCode.st A Compiler.package/EncoderForV3PlusClosures.class/class/bytecode decoding/stackDeltaForPrimitive_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/bytecode decoding/unusedBytecode.st A Compiler.package/EncoderForV3PlusClosures.class/class/compiled method support/bindingReadScanBlockFor_using_.st A Compiler.package/EncoderForV3PlusClosures.class/class/compiled method support/bindingWriteScanBlockFor_using_.st A Compiler.package/EncoderForV3PlusClosures.class/class/compiled method support/instVarReadScanBlockFor_using_.st A Compiler.package/EncoderForV3PlusClosures.class/class/compiled method support/instVarWriteScanBlockFor_using_.st A Compiler.package/EncoderForV3PlusClosures.class/class/compiled method support/supportsClosures.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/bytecodeSize_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/interpretJumpIfCondIn_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/interpretJumpIn_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/interpretNextInstructionFor_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isBlockReturnAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isBranchIfFalseAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isBranchIfTrueAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isCreateBlockAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isJumpAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isJustPopAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isReturnAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isSendAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isStoreAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/isStorePopAt_in_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instruction stream support/selectorToSendOrItselfFor_in_at_.st R Compiler.package/EncoderForV3PlusClosures.class/class/instructionStream support/interpretJumpIfCondIn_.st R Compiler.package/EncoderForV3PlusClosures.class/class/instructionStream support/interpretJumpIn_.st R Compiler.package/EncoderForV3PlusClosures.class/class/instructionStream support/interpretNextInstructionFor_in_.st M Kernel.package/BlockClosure.class/instance/accessing/numLocalTemps.st M Kernel.package/CompiledMethod.class/instance/scanning/readsField_.st M Kernel.package/CompiledMethod.class/instance/scanning/readsRef_.st M Kernel.package/CompiledMethod.class/instance/scanning/writesField_.st M Kernel.package/CompiledMethod.class/instance/scanning/writesRef_.st A Kernel.package/Context.class/instance/instruction decoding/pushActiveProcess.st M Kernel.package/InstructionStream.class/instance/private/nextPc_.st M Kernel.package/InstructionStream.class/instance/scanning/selectorToSendOrSelf.st M Kernel.package/InstructionStream.class/instance/scanning/skipBackBeforeJump.st M Kernel.package/InstructionStream.class/instance/testing/willBlockReturn.st M Kernel.package/InstructionStream.class/instance/testing/willCreateBlock.st M Kernel.package/InstructionStream.class/instance/testing/willJump.st M Kernel.package/InstructionStream.class/instance/testing/willJumpIfFalse.st M Kernel.package/InstructionStream.class/instance/testing/willJumpIfTrue.st M Kernel.package/InstructionStream.class/instance/testing/willJustPop.st M Kernel.package/InstructionStream.class/instance/testing/willReturn.st M Kernel.package/InstructionStream.class/instance/testing/willSend.st M Kernel.package/InstructionStream.class/instance/testing/willStore.st M Kernel.package/InstructionStream.class/instance/testing/willStorePop.st M OpalDecompiler.package/OCDecompiler.class/instance/control/doClosureCopyCopiedValues_numArgs_blockSize_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script425.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40425.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40425 14661 Integrating new bytecode set (part 2) Make CompiledMethod, InstructionStream and Decompiler independent from bytecode set https://pharo.fogbugz.com/f/cases/14661 http://files.pharo.org/image/40/40425.zip

1 0

[pharo-project/pharo-core]
by GitHub Dec. 29, 2014

Dec. 29, 2014

Branch: refs/tags/40424 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 7d7819: 40424
by GitHub Dec. 29, 2014

Dec. 29, 2014

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 7d781953a1b256775b2c900a6fd280ba84923c1f https://github.com/pharo-project/pharo-core/commit/7d781953a1b256775b2c900a… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-12-29 (Mon, 29 Dec 2014) Changed paths: A Compiler.package/BytecodeEncoder.class/class/bytecode decoding/stackDeltaForPrimitive_in_.st A Compiler.package/BytecodeEncoder.class/instance/opcode sizing/sizeTrapIfNotInstanceOf_.st A Compiler.package/Decompiler.class/instance/instruction decoding/blockReturnConstant_.st R Compiler.package/Decompiler.class/instance/private/interpretNextInstructionFor_.st A Compiler.package/EncoderForSistaV1.class/README.md A Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/callPrimitiveCode.st A Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/pcOfBlockCreationBytecodeForBlockStartingAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/pushClosureBytecodeSize.st A Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/stackDeltaForPrimitive_in_.st A Compiler.package/EncoderForSistaV1.class/class/bytecode decoding/unusedBytecode.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/bindingReadScanBlockFor_using_.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/bindingWriteScanBlockFor_using_.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/createClosureScanBlock.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/extensionsAt_in_into_.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/instVarReadScanBlockFor_using_.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/instVarWriteScanBlockFor_using_.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/interpretJumpIfCondIn_.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/interpretJumpIn_.st A Compiler.package/EncoderForSistaV1.class/class/compiled method support/supportsClosures.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/bytecodeSize_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/interpretNextInstructionFor_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isBlockReturnAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isBranchIfFalseAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isBranchIfTrueAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isExtension_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isJumpAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isJustPopAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isRealSendAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isReturnAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isReturnTopFromMethodAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isSendAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isStoreAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/isStorePopAt_in_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/selectorToSendOrItselfFor_in_at_.st A Compiler.package/EncoderForSistaV1.class/class/instruction stream support/superSendScanBlockUsing_.st A Compiler.package/EncoderForSistaV1.class/class/scanning/method_refersInBytecodeToLiteral_specialSelectorIndex_.st A Compiler.package/EncoderForSistaV1.class/definition.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genBranchPopFalseLong_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genBranchPopFalse_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genBranchPopTrueLong_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genBranchPopTrue_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genCallInlinePrimitive_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genCallPrimitive_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genDup.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genJumpLong_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genJump_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genNop.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPop.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushCharacter_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushClosureCopyNumCopiedValues_numArgs_jumpSize_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushConsArray_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushInstVarLong_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushInstVar_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushInteger_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushLiteralVar_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushLiteral_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushNewArray_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushReceiver.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushRemoteTemp_inVectorAt_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushSpecialLiteral_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushTemp_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genPushThisContext.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genReturnReceiver.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genReturnSpecialLiteral_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genReturnTop.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genReturnTopToCaller.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genSendSpecial_numArgs_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genSendSuper_numArgs_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genSend_numArgs_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genSignedSingleExtendB_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStoreInstVarLong_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStoreInstVar_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStoreLiteralVar_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStorePopInstVarLong_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStorePopInstVar_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStorePopLiteralVar_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStorePopRemoteTemp_inVectorAt_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStorePopTemp_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStoreRemoteTemp_inVectorAt_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genStoreTemp_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genTrapIfNotInstanceOf_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genUnsignedMultipleExtendA_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genUnsignedSingleExtendA_.st A Compiler.package/EncoderForSistaV1.class/instance/bytecode generation/genUnsignedSingleExtendB_.st A Compiler.package/EncoderForSistaV1.class/instance/in-line primitive generation/genInlineSmallIntegerAdd.st A Compiler.package/EncoderForV3PlusClosures.class/class/instructionStream support/interpretJumpIfCondIn_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instructionStream support/interpretJumpIn_.st A Compiler.package/EncoderForV3PlusClosures.class/class/instructionStream support/interpretNextInstructionFor_in_.st A Kernel.package/BlockLocalTempCounter.class/instance/instruction decoding/blockReturnConstant_.st M Kernel.package/CompiledMethod.class/instance/accessing/defaultSelector.st A Kernel.package/CompiledMethod.class/instance/accessing/encoderClass.st A Kernel.package/CompiledMethod.class/instance/accessing/signFlag.st A Kernel.package/Context.class/instance/instruction decoding/blockReturnConstant_.st A Kernel.package/Context.class/instance/instruction decoding/pushClosureTemps_.st A Kernel.package/InstructionClient.class/instance/instruction decoding/blockReturnConstant_.st A Kernel.package/InstructionClient.class/instance/instruction decoding/pushActiveProcess.st A Kernel.package/InstructionClient.class/instance/instruction decoding/pushClosureTemps_.st A Kernel.package/InstructionClient.class/instance/instruction decoding/trap.st A Kernel.package/InstructionClient.class/instance/instruction decoding/trapIfNotInstanceOf_.st M Kernel.package/InstructionStream.class/instance/decoding/interpretJump.st M Kernel.package/InstructionStream.class/instance/decoding/interpretJumpIfCond.st A Kernel.package/InstructionStream.class/instance/decoding/interpretNext2ByteSistaV1Instruction_for_extA_extB_startPC_.st A Kernel.package/InstructionStream.class/instance/decoding/interpretNext3ByteSistaV1Instruction_for_extA_extB_startPC_.st M Kernel.package/InstructionStream.class/instance/decoding/interpretNextInstructionFor_.st A Kernel.package/InstructionStream.class/instance/decoding/interpretNextSistaV1InstructionFor_.st A Kernel.package/InstructionStream.class/instance/decoding/interpretNextV3PlusClosureInstructionFor_.st A Kernel.package/InstructionStream.class/instance/decoding/interpretSistaV1ExtendedPush_for_.st A Kernel.package/InstructionStream.class/instance/decoding/interpretSistaV1Jump.st A Kernel.package/InstructionStream.class/instance/decoding/interpretSistaV1JumpIfCond.st A Kernel.package/InstructionStream.class/instance/decoding/interpretV3PlusClosureExtension_in_for_.st A Kernel.package/InstructionStream.class/instance/decoding/interpretV3PlusClosureJump.st A Kernel.package/InstructionStream.class/instance/decoding/interpretV3PlusClosureJumpIfCond.st R Kernel.package/InstructionStream.class/instance/private/interpretExtension_in_for_.st A Kernel.package/SymbolicBytecodeBuilder.class/instance/instruction decoding/blockReturnConstant_.st M Kernel.package/SymbolicBytecodeBuilder.class/instance/instruction decoding/pushActiveContext.st A Kernel.package/SymbolicBytecodeBuilder.class/instance/instruction decoding/pushActiveProcess.st A Kernel.package/SymbolicBytecodeBuilder.class/instance/instruction decoding/pushClosureTemps_.st A Kernel.package/SymbolicBytecodeBuilder.class/instance/instruction decoding/trap.st A Kernel.package/SymbolicBytecodeBuilder.class/instance/instruction decoding/trapIfNotInstanceOf_.st M OpalCompiler-Tests.package/OCBytecodeGeneratorTest.class/instance/tests - instructions/testPushThisContext.st A OpalDecompiler.package/OCDecompiler.class/instance/instruction decoding/blockReturnConstant_.st R OpalDecompiler.package/OCDecompiler.class/instance/private/interpretNextInstructionFor_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script424.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40424.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40424 14659 Integrating new bytecode set (part 1) https://pharo.fogbugz.com/f/cases/14659 14660 one test failing after integrating 14659 https://pharo.fogbugz.com/f/cases/14660 http://files.pharo.org/image/40/40424.zip

1 0

Artefact green on CI
by stephan＠stack.nl Dec. 29, 2014

Dec. 29, 2014

Name: ConfigurationOfArtefact-StephanEggermont.15 Author: StephanEggermont Time: 29 December 2014, 12:21:30.768 am UUID: f55adfa3-0a60-4695-be30-9dd2320cd944 Ancestors: ConfigurationOfArtefact-OlivierAuverlot.14 Promoted new version 1.4 to stable as current stable is broken, adding a Pharo20 compatibility package Name: Artefact-Pharo20-StephanEggermont.1 Author: StephanEggermont Time: 29 December 2014, 12:10:05.696 am UUID: e8475459-0316-4eca-a707-a1c5982ed650 Ancestors: convenience methods max: flattened, flattenOn: to make build green

2 1