- Pharo-dev - lists.pharo.org

[Pharo5][Slots] emitStore: should not send writeToSlot:of:
by Marcus Denker April 29, 2015

April 29, 2015

Hi, This small change: https://pharo.fogbugz.com/f/cases/15436 improves the code generated by Slots when using the default âreflective writeâ (instead of generating their own optimised code like InstanceVariableSlots). The helper method #writeToSlot:of: in Object was just needed as the arguments where in the wrong oder on the stack. We can use writeSlot:value: by generating code like this: emitStore: aMethodBuilder | tempName | tempName := Object new. aMethodBuilder addTemp: tempName; storeTemp: tempName; popTop; pushReceiver; pushLiteral: self; pushTemp: tempName; send: #writeSlot:value: For what needs to be done, see https://trello.com/b/d59lgZFB/slots Marcus

1 0

[Issue tracker] what about old issues?
by Marcus Denker April 29, 2015

April 29, 2015

Hi, we have 666 open issues on the issue tracker. It seems that older issues do not get looked at muchâ¦ the question is what to do: the more open issues we have, the less likely they will ever be looked at. I would like to -> automatically put them on âclosed, timeoutâ -> send a mail to the original submitter AND pharo-dev This way people can just re-open important issues, but those issues where the submitter does not care and nobody else, either, would be closed after one yearâ¦ (This would e.g. include lots of issues that got fixed in the meantimeâ¦ or non-important âit would be niceâ issues, or those where nobody (eve the submitter) understands what this is about anymoreâ¦) Marcus

5 6

[pharo-project/pharo-core]
by GitHub April 29, 2015

April 29, 2015

Branch: refs/tags/50018 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 4a1c70: 50018
by GitHub April 29, 2015

April 29, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 4a1c703d5083b3b76c1e46f9f551a8716bb6d6cd https://github.com/pharo-project/pharo-core/commit/4a1c703d5083b3b76c1e46f9… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-04-29 (Wed, 29 Apr 2015) Changed paths: A MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/menu spec/collectConfigurationMenuSpecs.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/menu spec/configurationMenuSpec.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/addMetacelloBaseline.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/baseLines.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/browseConfiguration.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/configurationClass.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/createDevelopmentVersion.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/createReleaseVersion.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/createVersionForBlessing_.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/dependentPackages.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/hasAnyBaseline.st R MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/metacello/lastBaseLine.st M MonticelloGUI.package/MCWorkingCopyBrowser.class/instance/morphic ui/workingCopyListMenu_.st M Morphic-Core.package/HandMorph.class/instance/halo handling/removeHalo.st A Morphic-Core.package/HandMorph.class/instance/halo handling/removeHaloAround_.st M Morphic-Core.package/Morph.class/instance/halos and balloon help/halo.st M Morphic-Core.package/Morph.class/instance/halos and balloon help/removeHalo.st M NECompletion.package/NECMenuMorph.class/class/preferences/convertToSHSymbol_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script626.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script627.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50017.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50018.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50018 15429 remove coupling from monticello GUI with metacello https://pharo.fogbugz.com/f/cases/15429 15433 issue 15426 breaks NEC-Completion https://pharo.fogbugz.com/f/cases/15433 15235 Faster Morphic>>removeHalo https://pharo.fogbugz.com/f/cases/15235 http://files.pharo.org/image/50/50018.zip

1 0

Tx Pass
by Sean P. DeNigris April 28, 2015

April 28, 2015

Just like Bloc (which has *great* class comments), I think it's crucial to document the high level design decisions in Tx. I did a first pass and noted some initial impressions... Design Questions: - TxModel - what is the advantage of a double linked list vs the old Text implementation? - TxLayoutViewMorph vs. TxTextEditorMorph - I'm not clear on the purpose/relationship/pattern here? Implementation Questions: - TxBasicSpan#< seems overly complex. Why two-way searching. Was it the result of profiling? Intuition? Random? - TxTextEditorMorph>>#openInWindowWithText: says not part of API, but this code is pretty much the only way to use it for now, right? - applyAttribute:to: sends an unimplemented message, but I'm not sure what should be done here - Why no strike fonts? Why is Verdana commented out in TxFontAttribute class>>#defaultValue? - TxLayoutViewMorph class>>#text: sends #asTxModel to argument, but TxTextEditorMorph doesn't. Which one is right? I think there's not much harm in sending it in both to make it a bit easier for users... - TxBasicViewMorph>>#fullDrawOnAthensCanvas: checks if fullBounds are visible on canvas, then checks #bounds again. Are both necessary? Tx already seems very usable! I'm starting to play with it in one of my projects... I've been dreaming about this for a long time :) ----- Cheers, Sean -- View this message in context: http://forum.world.st/Tx-Pass-tp4822173.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

5 11

Idea for playground
by Yuriy Tymchuk April 28, 2015

April 28, 2015

Hi, sometimes when I play in playground in order to achieve something I can go 10 levels deep or even more. Maybe we can implement an option to somehow construct one script from all executed parts, so then this script can be turned into a method or so on. Uko

5 6

Cherry Picking Doesn't Dirty MC Packages
by Sean P. DeNigris April 28, 2015

April 28, 2015

I was merging a slice in order to leave out some unwanted changes that got in accidentally. In the merge tool for each of those changes I chose to keep the current version, did the merge, recommitted the slice, and... All the unwanted changes were still there! Apparently, when cherry picking, the packages aren't marked dirty in MC, so they were not saved again with the slice. Only by browsing changes for each package via the working copy browser was I able to get them all marked dirty and commit the new versions. ----- Cheers, Sean -- View this message in context: http://forum.world.st/Cherry-Picking-Doesn-t-Dirty-MC-Packages-tp4822602.ht… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

1 0

[pharo-project/pharo-core]
by GitHub April 28, 2015

April 28, 2015

Branch: refs/tags/50017 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 46ecd2: 50017
by GitHub April 28, 2015

April 28, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 46ecd285add710a4703568f6814a021905d87e4a https://github.com/pharo-project/pharo-core/commit/46ecd285add710a4703568f6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-04-28 (Tue, 28 Apr 2015) Changed paths: R Graphics-Resources.package/extension/ThemeIcons/instance/paintTabIconContents.st R Polymorph-Widgets.package/ThemeIcons.class/instance/accessing - icons/paintTabIcon.st R Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/as yet unclassified/tagExec.st A Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tagging/tagExec.st A Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tests - links/testLinkWithCondition.st M Reflectivity-Tests.package/ReflectivityExamples.class/instance/examples/exampleMethod.st R Reflectivity.package/MetaLink.class/instance/ast/asLiteralNode.st M Reflectivity.package/MetaLink.class/instance/ast/hook.st A Reflectivity.package/extension/Object/instance/asLiteralNode.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script625.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script626.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50016.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50017.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Shout.package/SHTextStylerST80.class/class/style table/attributesFor_pixelHeight_.st Log Message: ----------- 50017 15426 SHRBTextStyler does not work for all predefined styles https://pharo.fogbugz.com/f/cases/15426 15427 Link Condition: Test + fix conditions for links https://pharo.fogbugz.com/f/cases/15427 15259 Remove paintTabIcon https://pharo.fogbugz.com/f/cases/15259 http://files.pharo.org/image/50/50017.zip

1 0

[Pharo5] Code Reviewers needed!
by Marcus Denker April 28, 2015

April 28, 2015

Hi, With Pharo5 starting to pick up steam, we need people to help commenting /testing fixes: https://pharo.fogbugz.com/f/filters/45/Review Marcus

1 0