- Pharo-dev - lists.pharo.org

[Reflectivity] Links on Class Variables
by Marcus Denker Sept. 17, 2015

Sept. 17, 2015

Hi, We can put meta links on AST Nodes. But with Variables being represented by Objects in Pharo, it is easy to allow those to be annotated, too. With the changes from https://pharo.fogbugz.com/f/cases/16596/before-for-Class-Variable <https://pharo.fogbugz.com/f/cases/16596/before-for-Class-Variable> it is now possible to put #before links on class variables: testBeforeClassVariable | classVar link | classVar := ReflectivityExamples classVariableNamed: #ClassVar. link := MetaLink new metaObject: self; selector: #tagExec. classVar link: link. self assert: classVar hasMetalinkBefore. self assert: (ReflectivityExamples >> #exampleClassVarRead) class = ReflectiveMethod. self assert: tag isNil. self assert: ReflectivityExamples new exampleClassVarRead isNil. self assert: tag = 'yes'. self assert: (ReflectivityExamples >> #exampleClassVarRead) class = CompiledMethod. self deny: (ReflectivityExamples >> #exampleClassVarRead) isQuick. link uninstall. ReflectivityExamples recompile: #exampleClassVarRead TODO: #after, #instead, then reifications (e.g. value), then tests for Globals, then the same for instance vars (slots) and tempsâ¦ step by step. Marcus

1 0

[pharo-project/pharo-core]
by GitHub Sept. 17, 2015

Sept. 17, 2015

Branch: refs/tags/50330 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] 7586c2: 50330
by GitHub Sept. 17, 2015

Sept. 17, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 7586c211f6842acc22a041ac7df29bc8fffbb659 https://github.com/pharo-project/pharo-core/commit/7586c211f6842acc22a041ac… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-17 (Thu, 17 Sep 2015) Changed paths: A Deprecated50.package/extension/SmalltalkImage/instance/logChange_.st R Monticello.package/MCVersionReader.class/class/System-FileRegistry/fileReaderServicesForFile_suffix_.st R Monticello.package/MCVersionReader.class/class/System-FileRegistry/loadVersionFile_.st R Monticello.package/MCVersionReader.class/class/System-FileRegistry/mergeVersionFile_.st R Monticello.package/MCVersionReader.class/class/System-FileRegistry/openVersionFile_.st R Monticello.package/MCVersionReader.class/class/System-FileRegistry/services.st A Monticello.package/MCVersionReader.class/class/actions - file/loadVersionFile_.st A Monticello.package/MCVersionReader.class/class/actions - file/mergeVersionFile_.st A Monticello.package/MCVersionReader.class/class/actions - file/openVersionFile_.st A MonticelloFileServices.package/extension/MCVersionReader/class/fileReaderServicesForFile_suffix_.st A MonticelloFileServices.package/extension/MCVersionReader/class/loadVersionStream_fromDirectory_.st A MonticelloFileServices.package/extension/MCVersionReader/class/mergeVersionStream_.st A MonticelloFileServices.package/extension/MCVersionReader/class/openVersionFromStream_.st A MonticelloFileServices.package/extension/MCVersionReader/class/serviceLoadVersion.st A MonticelloFileServices.package/extension/MCVersionReader/class/serviceMergeVersion.st A MonticelloFileServices.package/extension/MCVersionReader/class/serviceOpenVersion.st A MonticelloFileServices.package/extension/MCVersionReader/class/services.st M Nautilus.package/PackageTreeNautilusUI.class/instance/package filter/package_matchPackagePattern_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50329.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50330.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50329.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50330.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st R System-Support.package/SmalltalkImage.class/instance/sources%2C change log/logChange_.st Log Message: ----------- 50330 16523 Nautilus Regex Search Box borken https://pharo.fogbugz.com/f/cases/16523 16587 Deprecate SmalltalkImage>>#logChange: https://pharo.fogbugz.com/f/cases/16587 16573 Monticello should not depend on System-FileRegistry https://pharo.fogbugz.com/f/cases/16573 http://files.pharo.org/image/50/50330.zip

1 0

Remove rule "References an abstract class"
by Damien Cassou Sept. 17, 2015

Sept. 17, 2015

This lint rule pops up all the times and my code is always ok. I typically have to reference an abstract class when: - the abstract class takes care of choosing the concrete class to instantiate - the abstract class takes care of some shared variable for its subclasses (e.g., a cache or an shared external object) I propose to remove this rule which has never been useful for me. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill

5 9

SyntaxError: parentheses; cascades and yourself (Opal vs. old compilers parser)
by Nicolai Hess Sept. 17, 2015

Sept. 17, 2015

The following method compiles with Opal: createRedMorph ^ (self new color:Color red); yourself but gives a syntax error with the old compilers parser createRedMorph ^ (self new color:Color red)End of block expected -> ; yourself removing the parenthesis of course works for both. Who is right ? (for those who understand the ParseTreeSearcher syntax, how would a search expression look, for finding code like: "(some expression);yourself" nicolai

6 13

[pharo-project/pharo-core]
by GitHub Sept. 17, 2015

Sept. 17, 2015

Branch: refs/tags/50329 Home: https://github.com/pharo-project/pharo-core

1 0

[pharo-project/pharo-core] feb71a: 50329
by GitHub Sept. 17, 2015

Sept. 17, 2015

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: feb71a8705982cbb829e2678703c07d2131e71d8 https://github.com/pharo-project/pharo-core/commit/feb71a8705982cbb829e2678… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-17 (Thu, 17 Sep 2015) Changed paths: M CodeImport.package/CodeImporter.class/instance/evaluating/flushChangesFile.st A CodeImport.package/ManifestCodeImport.class/README.md A CodeImport.package/ManifestCodeImport.class/class/meta-data - dependency analyser/manuallyResolvedDependencies.st A CodeImport.package/ManifestCodeImport.class/definition.st M ConfigurationOfCatalog.package/ConfigurationOfCatalog.class/instance/symbolic versions/stable_.st A ConfigurationOfCatalog.package/ConfigurationOfCatalog.class/instance/versions/version09_.st A ConfigurationOfCodeImporter.package/ConfigurationOfCodeImporter.class/instance/baselines/baseline112_.st A ConfigurationOfCodeImporter.package/ConfigurationOfCodeImporter.class/instance/symbolic versions/development_.st A ConfigurationOfCodeImporter.package/ConfigurationOfCodeImporter.class/instance/symbolic versions/stable_.st A ConfigurationOfCodeImporter.package/ConfigurationOfCodeImporter.class/instance/versions/version112_.st A Reflectivity-Tests.package/ReflectivityControlTest.class/instance/tests - instead/testInsteadBlockSequence.st M Reflectivity.package/RFASTTranslatorForValue.class/instance/visitor-double dispatching/visitSequenceNode_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50328.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50329.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50328.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50329.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Tool-Catalog.package/CatalogBrowser.class/instance/actions/installStableVersion_onSuccess_.st M Tool-Catalog.package/CatalogBrowser.class/instance/private - events/onLoadFrom_.st M Tool-Catalog.package/extension/GTSpotter/instance/spotterCatalogProjectsFor_.st Log Message: ----------- 50329 16589 #instead for block sequence https://pharo.fogbugz.com/f/cases/16589 16588 Integrate Catalog 0.9 https://pharo.fogbugz.com/f/cases/16588 16586 Load latest version of CodeImporter https://pharo.fogbugz.com/f/cases/16586 http://files.pharo.org/image/50/50329.zip

1 0

[Reflectivity] Links on Block creation vs. execution
by Marcus Denker Sept. 17, 2015

Sept. 17, 2015

Hi, For blocks, we now have the correct model to destinguish âblock creationâ from âblock executionâ: 1) put a link on the block node, it will be called when the block definition (creation) is executed. e.g. when you put a before link on the block in this method, it will be called when you execute the method: TT>>method ^[1 + 2]. 2) put a link on the *body* of the block (the sequence of statements), it will be called when the block *executes*. For the example, it would not be called when executing âTT new methodâ, but only when you do âTT new method valueâ. Test: testBeforeBlockSequenceNoValue | sequence link | sequence := (ReflectivityExamples >> #exampleBlockNoValue) ast statements first value body. self assert: sequence isSequence. link := MetaLink new metaObject: self; selector: #tagExec. sequence link: link. self assert: sequence hasMetalinkBefore. self assert: (ReflectivityExamples >> #exampleBlockNoValue) class = ReflectiveMethod. self assert: tag isNil. ReflectivityExamples new exampleBlockNoValue. self assert: tag isNil. ReflectivityExamples new exampleBlockNoValue value. self assert: tag = 'yes'. self assert: (ReflectivityExamples >> #exampleBlockNoValue) class = CompiledMethod. link uninstall. ReflectivityExamples recompile: #exampleBlockNoValue Marcus

1 0

[Reflectivity] Support for primitive methods
by Marcus Denker Sept. 17, 2015

Sept. 17, 2015

Hi, One thing I added over the last weeks: support to put links on primitives. 1) fail code. You can put links into the smalltalk code that is executed in case of primitive failure. For all primitive methods, we generate code immediately when setting the link, we do not wait till the method is called. (this is in there since a while). 2) links on the method node itself. What we do here is to wrap the original method. It is interesting how simple this was to do: 1) when generating code for a ReflectiveMethod, check if it is a primitive: compileAndInstallCompiledMethod "we install the old one as the compiler might need itâ self installCompiledMethod. compiledMethod isRealPrimitive ifTrue: [ self generatePrimitiveWrapper ]. self recompileAST. self installCompiledMethod. 2) compile a wrapper by building an AST by hand: generatePrimitiveWrapper | wrappedMethod send wrapperMethod | ast compilationContext semanticAnalyzerClass: RFSemanticAnalyzer; astTranslatorClass: RFASTTranslator. ast doSemanticAnalysis. "force semantic analysis" wrappedMethod := ast generate: compiledMethod trailer. send := RBMessageNode receiver: (RBLiteralNode value: wrappedMethod) selector: #valueWithReceiver:arguments: arguments: {RBVariableNode named: #self . RBArrayNode statements: ast variableNodes }. wrapperMethod := RBMethodNode selector: ast selector arguments: ast variableNodes body: (RBReturnNode value: send) asSequenceNode. wrapperMethod methodClass: ast methodClass. wrapperMethod propertyAt: #wrappedPrimitive put: true. ast hasMetalink ifTrue: [wrapperMethod propertyAt: #links put: (ast propertyAt: #links)]. ast := wrapperMethod. This means we copy over the links to the new wrapper. the #wrappedPrimitive marker is there so that, when we destroy the twin when the last link is removed, we remember to unwrap. 3) the compiler plugin that takes the links into account ignores links on MethodNode if itâs a primitive. 4) when getting rid of the Twin (because we remove the last link), we detect if it was a primitive and unwrap: destroyTwin (ast hasProperty: #wrappedPrimitive) ifTrue: [ ast := compiledMethod parseTree]. self recompileAST. self installCompiledMethod. compiledMethod reflectiveMethod: nil. SystemAnnouncer uniqueInstance unsubscribe: self e.g. testBeforeMethodPrimitive | methodNode link | methodNode := (ReflectivityExamples >> #examplePrimitiveMethod) ast. link := MetaLink new metaObject: self; selector: #tagExec. self assert: (ReflectivityExamples>>#examplePrimitiveMethod) isRealPrimitive. methodNode link: link. self assert: methodNode hasMetalink. self assert: (ReflectivityExamples >> #examplePrimitiveMethod) class = CompiledMethod. self assert: tag isNil. self assert: ReflectivityExamples new examplePrimitiveMethod class = ByteString. self deny: (ReflectivityExamples>>#examplePrimitiveMethod) isRealPrimitive. self assert: tag = #yes. self assert: (ReflectivityExamples >> #examplePrimitiveMethod) class = CompiledMethod. link uninstall. self assert: (ReflectivityExamples>>#examplePrimitiveMethod) isRealPrimitive. ReflectivityExamples recompile: #examplePrimitiveMethod Marcus

1 0

[pharo-project/pharo-core]
by GitHub Sept. 16, 2015

Sept. 16, 2015

Branch: refs/tags/50328 Home: https://github.com/pharo-project/pharo-core

1 0