April 2021 - Pharo-dev - lists.pharo.org

Pharo 8.0 crash on resizing with Moom
by Bernhard Pieber April 11, 2021

April 11, 2021

Hi everyone, Is this the right place to report a Pharo 8.0 crash? I am on a MacBookPro16,4 on macOS Big Sur Version 11.2.3 (20D91) with an external 30" Apple Cinema Display (2500 x 1600). Here is what I did: I downloaded PharoLauncher. I created a new image using the official distribution Pharo 8.0 - 64bit (stable). I launched the new image. I clicked on light theme. I resized to full screen using Moom. => It crashed. I could reproduce it three out of five times I tried those steps. Let me add that Moom works very reliably with all other applications. Resizing like that is in my muscular memory. Cheers, Bernhard I dow

2 1

This week (14/2021) on the Pharo Issue Tracker
by Marcus Denker April 9, 2021

April 9, 2021

We merged 36 Pull Requests and closed 29 issues. https://github.com/pharo-project/pharo/pulse Merge newtools 0.6.2 #8951 ========================== - https://github.com/pharo-spec/NewTools/releases/tag/v0.6.2 - enhance control of spotter queries in a presenter (it should present "old" results to appear in new queries) - fixes pharo-spec/NewTools#209 - fixes pharo-spec/NewTools#196 - using a worker pool instead a regular "schedule" - fix a problem of entries being duplicated on history Spec 0.8.8 =========== - https://github.com/pharo-spec/Spec/releases/tag/v0.8.8 - "labelled" presenters moved to deprecated and not loaded by default. - tweak how overlay stack (still can be wrong) - fix a problem when assigning box layout sizes : it was not stacking widget sizes. Refactoring Tools ================ - RB - Method's Refactoring using selected scope #8950 https://github.com/pharo-project/pharo/pull/8950 - RB - Correct selection scope #8960 https://github.com/pharo-project/pharo/pull/8960 - RB - Clean use of "Smalltalk globals" #8959 https://github.com/pharo-project/pharo/pull/8959 Shadowing Variables =================== https://blog.marcusdenker.de/modeling-variable-shadowing-part-ii https://blog.marcusdenker.de/modeling-variable-shadowing-part-iii - Shadowing-Better-Implementation #8931 https://github.com/pharo-project/pharo/pull/8931 - Simplify-OCShadowVariableWarning #8943 https://github.com/pharo-project/pharo/pull/8943 - ReClassVariablesShadowingRule #8940 https://github.com/pharo-project/pharo/pull/8940 - ReClassVariablesShadowingRule-Improve #8965 https://github.com/pharo-project/pharo/pull/8965 - further improve testUndeclared #8964 https://github.com/pharo-project/pharo/pull/8964 Cleanup Shadowing Vars ======================= With the model for shadowing vars merged, we can cleanup. - LocalTimeZone class variable is shadowing the class of the same name. #8979 https://github.com/pharo-project/pharo/pull/8979 - ReleaseTest: testNoShadowedVariablesInMethods #8927 https://github.com/pharo-project/pharo/pull/8927 - reset the ASTCache in #testNoShadowedVariablesInMethods #8986 https://github.com/pharo-project/pharo/pull/8986 - 8935-add-release-test-for-shadowed-ivar--class-vars #8939 https://github.com/pharo-project/pharo/pull/8939 - ClassVariable in RBBrowserEnvironmentTest is shadowing a class #8982 https://github.com/pharo-project/pharo/pull/8982 - ClassVariable in OCOpalExamples is shadowing a class #8980 https://github.com/pharo-project/pharo/pull/8980 - Author in PoolDefiner and PoolDefiner2 is shadowing class #8981 https://github.com/pharo-project/pharo/pull/8981 - Link in ReflectivityDemos is shadowing a class #8983 https://github.com/pharo-project/pharo/pull/8983 - 8988-Failing-tests-ClassTest-testUsesPoolVarNamed-and-testHasPoolVarNamed- #8989 https://github.com/pharo-project/pharo/pull/8989 Fixes ===== - allow system to react to a theme change #8937 https://github.com/pharo-project/pharo/pull/8937 - 8861-Code-Coverage-in-Dr-Tests-is-misreporting-methods-implemented-as-subclassResponsibility #8954 https://github.com/pharo-project/pharo/pull/8954 - 7655-Epicea-fileout-should-produce-Pharo-code-and-not-ombu-definition #8969 https://github.com/pharo-project/pharo/pull/8969 - Don't make SDL_Texture autoRelease from renderer #8962 https://github.com/pharo-project/pharo/pull/8962 - ZdcSecureSocketStreamTest>>#testPlain and ZnHTTPSTests>>#testRequestRâ¦ #8977 https://github.com/pharo-project/pharo/pull/8977 - 8972-Class-instance-variable-menu-error #8973 https://github.com/pharo-project/pharo/pull/8973 - Float numbers are only immediates if the VM/Image has SmallFloats. #8975 https://github.com/pharo-project/pharo/pull/8975 - Use a Mutex instead of a Semaphore to prevent trouble in concurrent sâ¦ #8990 https://github.com/pharo-project/pharo/pull/8990 - CairoLibrary in windows: don't look for cairo.dll #8994 https://github.com/pharo-project/pharo/pull/8994 - fixes: #7599 finally class side fluid does not show anymore the brokeâ¦ #8987 https://github.com/pharo-project/pharo/pull/8987 Cleanups ======== - AST-Tag-ErrorNodes #8936 https://github.com/pharo-project/pharo/pull/8936 - 8932-CI-failure-ArrayTestClassTestCasetestMethodsOfTheClassShouldNotBeRepeatedInItsSuperclasses https://github.com/pharo-project/pharo/pull/8938 - #8942 another try: Cleanup some class name in Drtests #8948 https://github.com/pharo-project/pharo/pull/8948 - 8955-failing-test-on-CI-ReleaseTesttestUndeclared #8958 https://github.com/pharo-project/pharo/pull/8958 - CI - Fix broken test ReleaseTest >> #testUndeclared #8971 https://github.com/pharo-project/pharo/pull/8971 - 5388-Improving-RBNode-API: add #hasArguments #8949 https://github.com/pharo-project/pharo/pull/8949 - RBSequenceNode-children-no-accessor #8963 https://github.com/pharo-project/pharo/pull/8963 - 7827-oldDefinition-should-use-the-associated-class-definition-printer #8970 https://github.com/pharo-project/pharo/pull/8970

1 0

Broken window alert
by Guillermo Polito April 7, 2021

April 7, 2021

Hi Guys, With Pablo we were discussing that it would be nice to stop with the integrations until we fix the broken tests. We have crossed the 20 broken tests for more than 20 builds. We should put some energy in fixing those, but we are afraid that if we continue this way, eventually it will become unmanageable. Cheers, Guille

3 6

Proposal: Simplify How Pragmas are stored
by Marcus Denker April 5, 2021

April 5, 2021

In Pharo9, we have speed up Pragma access. https://blog.marcusdenker.de/speeding-up-pragma-access https://blog.marcusdenker.de/speeding-up-pragma-access-part-ii I think we further improve things, this time with regard to how Pragmas are stored in the method objects. **Describe the problem** Pragmas are stored mixed with associations in the AdditionalMethodState. I propose to store all Pragmas as one pre-allocated array as a property #pragmas instead. This will speedup both pragma access and property access and will radically simplify the code. **Classes involved** CompiledMethod, AdditionalMethodState, Compiler backed **Current Situation** This is how Pragmas are now stored. It is a bit strange: - if there is a pragma, we create a method with an AdditionalMethodState object, referenced from the second-last literal. - This is a variable subclass, implementing a dictionary, no hashing, just linear search (that is ok as dicts <10 are faster without hashing most likely) - What is *very* strange: it contains associations (for properties) and Pragmas, mixed. This means that all code very odd as it has to always check: ```smalltalk propertyAt: aKey ifAbsent: aBlock "Answer the property value associated with aKey or, if aKey isn't found, answer the result of evaluating aBlock." 1 to: self basicSize do: [:i | | propertyOrPragma "<Association|Pragma>" | propertyOrPragma := self basicAt: i. (propertyOrPragma isAssociation and: [propertyOrPragma key == aKey]) ifTrue: [^propertyOrPragma value]]. ^aBlock value ``` while we have a second api that gives us either a pragma or a property, whatever it finds first: ```smalltalk at: aKey ifAbsent: aBlock "Answer the property value or pragma associated with aKey or, if aKey isnt found, answer the result of evaluating aBlock." 1 to: self basicSize do: [:i | | propertyOrPragma "<Association|Pragma>" | (propertyOrPragma := self basicAt: i) key == aKey ifTrue: [^propertyOrPragma isAssociation ifTrue: [propertyOrPragma value] ifFalse: [propertyOrPragma]]]. ^aBlock value ``` and if you ask for #pragmas (which is the main API), it has to create the array, iterating and checking for each entry: ```smalltalk pragmas "Return the Pragma objects. Properties are stored as Associations" ^ Array new: self basicSize streamContents: [ :pragmaStream | 1 to: self basicSize do: [ :i | | propertyOrPragma "<Association|Pragma>" | (propertyOrPragma := self basicAt: i) isAssociation ifFalse: [ pragmaStream nextPut: propertyOrPragma ] ] ] ``` This is slow for pragmas, the array is created on demand. This is slow for properties, as we need to check an skip pragmas when searching. For speed, the code for pragmas on CompiledMethod has to do that: ```smalltalk pragmas | selectorOrProperties | ^(selectorOrProperties := self penultimateLiteral) isMethodProperties ifTrue: [selectorOrProperties pragmas] ifFalse: [#()] ``` Just to avoid creating an empty array via the streamContents: method. Which, if you ask for pragmas of all methods, does matter. And this is what "Senders Of" does... And this is very, very strange. In the past this lead to very odd things like "sender of" for #isFFIMethod giving all method that had the property #isFFIMethod set. (I fixed that already) I propose to clean this up. **Proposal** I want to have a clear layer: properties are there to add state to CompiledMethods, the Pragma implementation just uses this lower level layer. AdditionalMethodState should have *no* code related to Pragmas. So instead of putting pragmas into the AdditionalMethodState directly, we just add one property #pragmas for those methods where pragmas are used. The compiler then pre-allocates the array and puts it there. (Pragmas are statically known, properties can be set and removed at runtime). Which means that on CompiledMethod, we just have: ```smalltalk pragmas ^ self propertyAt: #pragmas ifAbsent: [ #() ] ``` pragmas and pragmasDo: on AdditionalMethodState can be removed, we can remove the propertyAt* API there and just use the Dictionary API (which makes sense, as AdditionalMethodState is just a property dictionary with a backpointer) The only thing we need to do for this to work is to change the code in the compiler backend to be: ```smalltalk addPragma: aPragma properties ifNil: [ properties := AdditionalMethodState new ]. properties at: #pragmas ifAbsent: [ properties := properties copyWith: #pragmas -> #( ) ]. properties at: #pragmas put: ((properties at: #pragmas) copyWith: aPragma) ``` (bit ugly... need to use copyWith: as the high level API needs the compiledMethod set in the AdditionalMethodState) And some smaller changes here and there (e.g. setting the backpointer in pragmas after the compiledMethod is created). I did first implementation, It seems to work but this showed that we have to take care with the bootrap. (see [here](https://github.com/pharo-project/pharo/pull/7930/files) for the closed PR)

2 1

Progress Report -> Refactoring Project - ( March 29 - April 1 )
by Evelyn Cusi Lopez April 5, 2021

April 5, 2021

Hello all, Last week I did these tasks: - Fix issue: Extract method in the superclass is not fully working #8871 <https://github.com/pharo-project/pharo/issues/8871> Now you can specify the class where you want the method to be extracted. Check PR to know the change <https://github.com/pharo-project/pharo/pull/8924>. You can see the new behavior in the following video: https://www.youtube.com/watch?v=fCCp9he8Zq0 - Add option to use scopes in refactorings. Check PR <https://github.com/pharo-project/pharo/pull/8950> to know the change. - Fix issue: Remove method (cmd-x) does not respect scoped mode #8638 <https://github.com/pharo-project/pharo/issues/8638> Check PR <https://github.com/pharo-project/pharo/pull/8950> to know the change. - Fix issue: RBExpandReferencedPoolRefactoring refers directly to Smalltalk globals #6510 <https://github.com/pharo-project/pharo/issues/6510>. Check PR <https://github.com/pharo-project/pharo/pull/8959> to know the change. - Start to fix the issue: Inline temp refactoring can create code with different behavior. #6056 <https://github.com/pharo-project/pharo/issues/6056>. Check the changes in this branch <https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:CreateCasc…> . Tasks for this week: - Correct the scope modal, when we launch a refactoring in a global mode (current vm). - Finish to fix: Create cascade issue <https://github.com/pharo-project/pharo/issues/6056>. - Fix issue: Inline senders refactoring does not correctly manage errors #6218 <https://github.com/pharo-project/pharo/issues/6218> - Fix issue: Incorrect message in Refactor push up with super sends #2656 <https://github.com/pharo-project/pharo/issues/2656> <https://github.com/pharo-project/pharo/issues/8871> - Fix issue: move to component refactoring issue. <https://github.com/pharo-project/pharo/issues/8499> - Fix issue: Move to package of defining class enh #8929 <https://github.com/pharo-project/pharo/issues/8929> <https://github.com/pharo-project/pharo/issues/6218> Regards, Evelyn C.

2 1

This week (13/2021) on the Pharo Issue Tracker
by Marcus Denker April 2, 2021

April 2, 2021

We merged 32 Pull Requests and closed 24 issues on the main repository. But some PRs combine multiple fixes and commits, thus the real number is far higher. Merge NewTools 0.6 #8876 ======================== - This version introduces new Spotter tool! - uses style contributor (thanks @tesonep) to add styles for each tool (using it in spotter) - fixes cmd+p, and cmd+i, etc on playground. - fixes pharo-spec/NewTools#171 - fixes #8765 - fixes pharo-spec/NewTools#161 - fixes pharo-spec/NewTools#176 - several debugger fixes - cleanups - https://github.com/pharo-spec/NewTools/releases/tag/v0.6 Merge newtools 0.6.1 #8922 ========================== - fixes #5551 - fixes pharo-spec/NewTools#189 - fixes pharo-spec/NewTools#197 - fixes pharo-spec/NewTools#192 - fixes pharo-spec/NewTools#205 - spotter: showing of tips configurable - spotter: several small bug fixes/enhancements - inspector: Avoid errors when printing in title - https://github.com/pharo-spec/NewTools/releases/tag/v0.6.1 Spec 0.8.6 ============ - add cursorPositionIndex: to input fields - add beEditable property to input fields - https://github.com/pharo-spec/Spec/releases/tag/v0.8.6 Spec2 0.8.7 ============ - fixes SpFilteringSelectableListPresenter>>selectItems: - fix missing style apply for just-built layouts - https://github.com/pharo-spec/Spec/releases/tag/v0.8.7 Refactoring Engine ================== - RB - Improve extract setUp Refactoring #8877 https://github.com/pharo-project/pharo/pull/8877 - RB - Add preview when use "extract method refactoring" #8898 https://github.com/pharo-project/pharo/pull/8898 - RB - Replace method's senders by another #8903 https://github.com/pharo-project/pharo/pull/8903 - RB - Improve Extract Method Refactoring #8924 https://github.com/pharo-project/pharo/pull/8924 Improved Rules ============ - ReVariableReferencedOnceRule-show-varname #8874 https://github.com/pharo-project/pharo/pull/8874 - ReVariableAssignedLiteralRule-Skip-PoolVars #8882 https://github.com/pharo-project/pharo/pull/8882 - 8009-Rule-required-for-shadowed-variables #8917 https://github.com/pharo-project/pharo/pull/8917 First Class Variables ================= - Variable-model-Shadowing #8909 https://blog.marcusdenker.de/modeling-variable-shadowing https://github.com/pharo-project/pharo/pull/8909 - add SystemDictionary>>#resetReservedVariables #8907 https://github.com/pharo-project/pharo/pull/8907 - Speedup-reflective-read-IndexedSlot #8928 https://blog.marcusdenker.de/first-class-variables-speeding-up-reflective-v… https://github.com/pharo-project/pharo/pull/8928 Features ======== - Add CairoLibrary>>versionString #8880 https://github.com/pharo-project/pharo/pull/8880 - Add SDL2 class >> version #8912 https://github.com/pharo-project/pharo/pull/8912 - add isDoubleQuote method #8896 https://github.com/pharo-project/pharo/pull/8896 - 8194-Enhance-Welcome-with-Build-Date #8919 https://github.com/pharo-project/pharo/pull/8919 - Added RewriteRuleEditor to world menu #8902 https://github.com/pharo-project/pharo/pull/8902 Fixes ===== - Use LibraryFinder in CairoLibrary>>macLibraryName #8879 https://github.com/pharo-project/pharo/pull/8879 - 8793-some-settings-for-code-completion-are-not-working #8885 https://github.com/pharo-project/pharo/pull/8885 - Rolling back to the old morphic behavior (but in OUPS) when opening debuggers #8893 https://github.com/pharo-project/pharo/pull/8893 - [fix] fixes #8878: Fluid class and more got broken by recent calypso... #8884 https://github.com/pharo-project/pharo/pull/8884 - taskbarCloseAllLikeThis closes windows with the same name #8914 https://github.com/pharo-project/pharo/pull/8914 - 8525-Errors--Insufficient-buffer-size-to-read-current-working-directory-at-the-launch-of https://github.com/pharo-project/pharo/pull/8911 - [Redo #8894] Introduce bestNodeForAtPosition: by moving selector extractor heuristic. #8905 https://github.com/pharo-project/pharo/pull/8905 - 8793-some-settings-for-code-completion-are-not-working Part 2 #8895 https://github.com/pharo-project/pharo/pull/8895 Cleanups ======== - 8921 gtDisplayString should be deprecated and use displayString #8923 https://github.com/pharo-project/pharo/pull/8923 - 8814-Is-registerBreakableIndex-still-needed #8920 https://github.com/pharo-project/pharo/pull/8920 - testNoUnusedInstanceVariablesLeft-down-to-19 #8915 https://github.com/pharo-project/pharo/pull/8915 Comments ======== - fixes #8904 Better class comment for some SUnit classes #8913 https://github.com/pharo-project/pharo/pull/8913 - 6970-win32ModuleName-not-implemented #8842 https://github.com/pharo-project/pharo/pull/8842

1 0

PharoJ now available for Pharo10
by Noury Bouraqadi April 1, 2021

April 1, 2021

Hi everyone, We continue to make progress during our weekly coding sessions. We are glad to announce that this week we made a huge leap forward. Now PharoJS is available for Pharo 10. To install it, run the following script in a Pharo 10 playground Metacello new baseline: 'PharoJS'; repository: 'github://PharoJS/PharoJS:pharo10'; load

6 9