February 2019 - Pharo-dev - lists.pharo.org

Spotter shortcut reset
by Ben Coman Feb. 3, 2019

Feb. 3, 2019

I upgraded Pharo 7.0.1 to latest Pharo 8.0 branch. Now when I hit <Ctrl-Enter> I get a debugger... Instance of AnObsoleteGTSpotterGlobalShortcut class did not understand #openGlobalSpotter Although not a certified way to upgrade, its maybe useful. I've looked through settings and class-side methods for some way to reset this. Is there some class reset or initialization that can be run to clear this up? cheers -ben

5 11

Debugger opening on user halt and not Object>>halt
by Thomas Dupriez Feb. 2, 2019

Feb. 2, 2019

Hello, Does someone know which is the code responsible for the debugger opening on the halt of the user instead of Object>>halt (see picture)? It's neat but it's not the regular behaviour so I'm guessing it is handled somewhere specifically for halt messages? Thomas

4 5

Re: [Pharo-dev] [Pharo-users] Class name with diacritic character and Pharo
by Sven Van Caekenberghe Feb. 2, 2019

Feb. 2, 2019

Hi Dominique, > On 27 Jan 2019, at 11:40, Dominique Dartois <dom(a)dartois.org> wrote: > > Hello all. > If a use french diacritic character in a class name, the code runs but I canât fileout the package nor save it with Monticello. > For example, the C cedilla in the class name drive me to an âZnInvalidUTF8:Illegal byte for utf-8 encoding' when filing out. > > Is it a bug or a feature? > Thank you > > <image.png>--- > Dominique Dartois Thanks for reporting this. This is most definitely a bug, I can confirm its occurrence. I'm CC pharo-dev as this is quite important. This will be a long mail. This is one manifestation of a problem that has been present for quite a while. I'll start by describing what I did, what went well and where/how this fails, some generic points, and two conceptual solutions (that need further verification). Like you, I created a new subclass: Object subclass: #ClasseFranÃ§aise instanceVariableNames: '' classVariableNames: '' package: '_UnpackagedPackage' With comment: I am ClasseFranÃ§aise. Try: ClasseFranÃ§aise new Ã©lÃ¨ve. ClasseFranÃ§aise new euro. And two methods (in the 'test' protocol): Ã©lÃ¨ve ^ 'Ã©lÃ¨ve' euro ^ 'â¬' I added the euro sign (because that is encoded in UTF-8 with 3 bytes, not 2 like Ã§). Like you said, the system can cope with such class and method names and seems to function fine. Looking at the .changes file, the correct source code was appended: ----SNAPSHOT----2019-01-26T23:36:18.548555+01:00 work.image priorSource: 339848! Object subclass: #ClasseFranÃ§aise instanceVariableNames: '' classVariableNames: '' package: '_UnpackagedPackage'! !ClasseFranÃ§aise commentStamp: 'SvenVanCaekenberghe 1/27/2019 12:25' prior: 0! I am ClasseFranÃ§aise.! !ClasseFranÃ§aise methodsFor: 'test' stamp: 'SvenVanCaekenberghe 1/27/2019 12:26'! Ã©lÃ¨ve ^ 'Ã©lÃ¨ve'! ! !ClasseFranÃ§aise commentStamp: 'SvenVanCaekenberghe 1/27/2019 12:27' prior: 33898360! I am ClasseFranÃ§aise. Try: ClasseFranÃ§aise new Ã©lÃ¨ve. ClasseFranÃ§aise new euro. ! !ClasseFranÃ§aise methodsFor: 'test' stamp: 'SvenVanCaekenberghe 1/27/2019 12:27'! euro ^ 'â¬'! ! Doing a file out (or otherwise saving the source code) fails. The reason is an incorrect manipulation of this source file while looking for what is called the method preamble, in SourcFileArray>>#getPreambleFrom:at: position An programmatic way to invoke the same error is by doing (ClasseFranÃ§aise>>#Ã©lÃ¨ve) timeStamp. (ClasseFranÃ§aise>>#Ã©lÃ¨ve) author. Both fail with the same error. The source code of methods is (currently) stored in a .sources or .changes file. CompiledMethods know their source pointer, an offset in one of these files. Right before the place where the source starts is a preamble that contains some meta information (including the author and timestamp). To access that preamble, the source code pointer is moved backwards to the beginning of the preamble (which begins and ends with a !). The current approach fails in the presence of non-ASCII characters. More specifically because of a mixup between the concept of byte position and character position when using UTF-8, a variable length encoding (both the .changes and the .sources are UTF-8 encoded). For example, consider 'Ã partir de 10 â¬' size. "16" 'Ã partir de 10 â¬' utf8Encoded size. "19" So although the string contains 16 characters, it is encoded as 19 bytes, Ã using 2 bytes and â¬ using 3 bytes. In general, moving backwards or forwards in UTF-8 encoded bytes cannot be done without understanding UTF-8 itself. ZnUTF8Encoder can do both (moving forward is #nextFromStream: while moving backwards is #backOnStream:). However, ZnUTF8Encoder is also strict: it will signal an error when forced to operate in between encoded characters, which is what happens here. It is thus not possible to move to arbitrary bytes positions and assume/hope to always arrive on the correct character boundaries and it is also wrong to take the difference between two byte positions as the count of characters present (since their encoding is of variable length). SourcFileArray>>#getPreambleFrom:at: is doing both of these wrong (but gets away with it in 99.99% of all cases since very few people name their classes like that). There are two solutions: operate mostly on the byte level or operate correctly on the character level. Here are two conceptual solutions (you must execute either solution 1 or 2, not both), with two different inputs. src := '!ClasseFranÃ§aise methodsFor: ''test'' stamp: ''SvenVanCaekenberghe 1/27/2019 12:27''! euro ^ ''â¬''! !'. "startPosition := 83" str := ZnCharacterReadStream on: (src utf8Encoded readStream). str position: 83. "at start of euro, the methods source string" str upToEnd. str position: (83 - 3). "before ! before euro" "find the previous ! before position" position := str position. binary := str wrappedStream. encoder := str encoder. "solution 1" [ position >= 0 and: [ binary position: position. binary next ~= 33 ] ] whileTrue: [ position := position - 1 ]. position. encoder decodeBytes: (binary next: 80 - position). "solution 2" count := 0. [ str position >= 0 and: [ str next ~= $! ] ] whileTrue: [ encoder backOnStream: binary; backOnStream: binary. count := count + 1 ]. str position. str next: count. Same code, different input (and starting position): src := '!ABC!ClasseFranÃ§aise methodsFor: ''test'' stamp: ''SvenVanCaekenberghe 1/27/2019 12:27''! euro ^ ''â¬''! !'. "startPosition := 87" str := ZnCharacterReadStream on: (src utf8Encoded readStream). str position: 87. "at start of euro, the methods source string" str upToEnd. str position: (87 - 3). "before ! before euro" "find the previous ! before position" position := str position. binary := str wrappedStream. encoder := str encoder. "solution 1" [ position >= 0 and: [ binary position: position. binary next ~= 33 ] ] whileTrue: [ position := position - 1 ]. position. encoder decodeBytes: (binary next: 80 - position). "solution 2" count := 0. [ str position >= 0 and: [ str next ~= $! ] ] whileTrue: [ encoder backOnStream: binary; backOnStream: binary. count := count + 1 ]. str position. str next: count. Solution 1 (at the byte level) works because $! (ASCII code 33) is also encoded as such in UTF-8 and this byte pattern cannot be part of a 2, 3 or 4 byte UTF-8 encoded character. The final byte segment must then be given to the proper encoder to turn it into characters. Solution 2 (at the character level) works because it essentially counts characters while moving backwards correctly (it moves back 2 steps each time because #next moves 1 step forward, while #peek would not help). Note that in Solution 1 the moving position is held in an external variable, while in Solution 2 it is held inside the stream. Implementing either solution requires more internal access of the streams (#wrappedStream), so SourcFileArray>>#getPreambleFrom:at: should at least be moved to SourceFile, IMHO. Obviously this is a sensitive/critical area to touch. We will also need a regression unit test. On a higher design level, I think that CompiledMethod>>#timeStamp and CompiledMethod>>#author should be cached at the instance level (a unix timestamp and a symbol would cost very little). Sven

3 6

[Pharo 8.0] Build #50: 2385 Badly formatted character/charset support code
by ci-pharo-ci-jenkins2＠inria.fr Feb. 2, 2019

Feb. 2, 2019

There is a new Pharo build available! The status of the build #50 was: FAILURE. The Pull Request #2386 was integrated: "2385 Badly formatted character/charset support code" Pull request url: https://github.com/pharo-project/pharo/pull/2386 Issue Url: https://pharo.fogbugz.com/f/cases/2385 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #49: 2395-Non-ASCII-class-and-author-names-break-SourceFileArraygetPreambleFromat
by ci-pharo-ci-jenkins2＠inria.fr Feb. 1, 2019

Feb. 1, 2019

There is a new Pharo build available! The status of the build #49 was: SUCCESS. The Pull Request #2433 was integrated: "2395-Non-ASCII-class-and-author-names-break-SourceFileArraygetPreambleFromat" Pull request url: https://github.com/pharo-project/pharo/pull/2433 Issue Url: https://pharo.fogbugz.com/f/cases/2395 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #48: 2393 integrate file attributes plugin
by ci-pharo-ci-jenkins2＠inria.fr Feb. 1, 2019

Feb. 1, 2019

There is a new Pharo build available! The status of the build #48 was: FAILURE. The Pull Request #2431 was integrated: "2393 integrate file attributes plugin" Pull request url: https://github.com/pharo-project/pharo/pull/2431 Issue Url: https://pharo.fogbugz.com/f/cases/21368 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Contribute to pharo8.0 ?
by Sven Van Caekenberghe Feb. 1, 2019

Feb. 1, 2019

Hi, I am trying my first contribution / PR to pharo8.0 I started with a latest zeroconfig 8.0 image/vm and I deleted my old fork and made a new one. But repairing the repository by fetching does not bring it to the detached state I also don't understand how to make an issue branch for https://github.com/pharo-project/pharo/issues/2395 Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? What is the difference ? What about the Remote ? Can I work with only an issue on GitHub ? Is the documentation https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo really up to date ? Sven

6 9

contribution workflow
by Ben Coman Feb. 1, 2019

Feb. 1, 2019

I'm not sure how closely my contribution workflow matches the standard advertised, so just wanted to share it for feedback. I may remember wrongly, but my understanding of the advertised process was forking the "pharo-project/pharo" repo, then cloning from my fork. However I found it awkward to keep the "master" branch of my fork synchronised with upstream. What I ended up finding easiest is *always* cloning "pharo-project/pharo" then adding my "bencoman/pharo" repo as a remote. Iceberg then makes it simple to push just my working branches to my fork from where I can issue a PR. I never need to trouble synchronising the master branch in my fork. How does that compare to your contribution workflow? cheers -ben

3 3