January 2019 - Pharo-dev - lists.pharo.org

[Pharo 7.0] Build #134: 22903-backport-to-P70fixes-on-bootstrap-scripts
by ci-pharo-ci-jenkins2＠inria.fr Jan. 22, 2019

Jan. 22, 2019

There is a new Pharo build available! The status of the build #134 was: FAILURE. The Pull Request #2285 was integrated: "22903-backport-to-P70fixes-on-bootstrap-scripts" Pull request url: https://github.com/pharo-project/pharo/pull/2285 Issue Url: https://pharo.fogbugz.com/f/cases/22903 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #16: FAILURE
by ci-pharo-ci-jenkins2＠inria.fr Jan. 21, 2019

Jan. 21, 2019

There is a new Pharo build available! The status of the build #16 was: FAILURE. Could not extract further issue information from commit message: Merge branch 'Pharo7.0' into Pharo8.0 # Conflicts: # bootstrap/scripts/envversion.sh # bootstrap/scripts/transform_32_into_64.sh Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0] Build #133: 22903-backport-to-P70fixes-on-bootstrap-scripts
by ci-pharo-ci-jenkins2＠inria.fr Jan. 21, 2019

Jan. 21, 2019

There is a new Pharo build available! The status of the build #133 was: FAILURE. The Pull Request #2285 was integrated: "22903-backport-to-P70fixes-on-bootstrap-scripts" Pull request url: https://github.com/pharo-project/pharo/pull/2285 Issue Url: https://pharo.fogbugz.com/f/cases/22903 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #15: Added tests about Context>>home and Context>>activeHome
by ci-pharo-ci-jenkins2＠inria.fr Jan. 21, 2019

Jan. 21, 2019

There is a new Pharo build available! The status of the build #15 was: FAILURE. The Pull Request #2278 was integrated: "Added tests about Context>>home and Context>>activeHome" Pull request url: https://github.com/pharo-project/pharo/pull/2278 Issue Url: https://pharo.fogbugz.com/f/cases/2277 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0] Build #132: 22887-TonelWritercreateDefaultOrganizationFrom-can-return-string
by ci-pharo-ci-jenkins2＠inria.fr Jan. 21, 2019

Jan. 21, 2019

There is a new Pharo build available! The status of the build #132 was: FAILURE. The Pull Request #2267 was integrated: "22887-TonelWritercreateDefaultOrganizationFrom-can-return-string" Pull request url: https://github.com/pharo-project/pharo/pull/2267 Issue Url: https://pharo.fogbugz.com/f/cases/22887 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 8.0] Build #14: Context>>methodReturnContext now uses Context>>home instead of repliâ¦
by ci-pharo-ci-jenkins2＠inria.fr Jan. 21, 2019

Jan. 21, 2019

There is a new Pharo build available! The status of the build #14 was: FAILURE. The Pull Request #2276 was integrated: " Context>>methodReturnContext now uses Context>>home instead of repliâ¦" Pull request url: https://github.com/pharo-project/pharo/pull/2276 Issue Url: https://pharo.fogbugz.com/f/cases/2270 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Esteban's ChangeLog week of 14 January 2019
by estebanlm＠gmail.com Jan. 21, 2019

Jan. 21, 2019

Hello! This is my weekly ChangeLog, from 14 January 2019 to 20 January 2019. You can see it in a better format by going here: http://log.smallworks.eu/web/search?from=14/1/2019&to=20/1/2019 ChangeLog ========= 14 January 2019: ---------------- * I just promoted a new VM as stable for Pharo 7.0. It is "201901051900-7a3c6b6" which is not the latest-latest (which is from 10/01), but it seems very likely to be stable enough :) cheers! Esteban

1 0

Re: [Pharo-dev] DebugSession>>activePC:
by ducasse Jan. 21, 2019

Jan. 21, 2019

I simply love the dynamic rewriting this is just too cool. We should systematically use it. I will continue to use it in any deprecation. Now I have a simple question (You can explain it to me over lunch one of these days). I do not get why RBAST would not be a good representation for the compiler? I would like to know what is the difference. You mean that before going from BC to AST was difficult? How opal performs it? It does not use the source of the method to recreate the AST but he can do it from the BC? Stef >> > > But I like the âhigh levelâ: using a shared AST between the compiler and the tools *and* having a mapping BC -> AST -> Text. > > Of course I understand that the choice to use the RB AST for the compiler is not a âtraditionalâ one.. but it turned out to work very well *and* it brings some amazing power, as we have now not only a mapping bc->text offset, but a mapping bc->AST, too. This e.g. (just a a simple example) makes the magic of the runtime transforming deprecations possible. See #transform on class Deprecation, the #sourceNodeExecuted: > > transform > | node rewriteRule aMethod | > self shouldTransform ifFalse: [ ^ self ]. > self rewriterClass ifNil:[ ^ self signal ]. > aMethod := self contextOfSender method. > aMethod isDoIt ifTrue:[^ self]. "no need to transform doits" > node := self contextOfSender sourceNodeExecuted. > rewriteRule := self rewriterClass new > replace: rule key with: rule value. > (rewriteRule executeTree: node) > ifFalse: [ ^ self ]. > node replaceWith: rewriteRule tree. > Author > useAuthor: 'AutoDeprecationRefactoring' > during: [aMethod origin compile: aMethod ast formattedCode classified: aMethod protocol]. > > > Marcus

4 4

Re: [Pharo-dev] DebugSession>>activePC:
by Eliot Miranda Jan. 21, 2019

Jan. 21, 2019

Hi Marcus, On Fri, Jan 18, 2019 at 5:15 AM Marcus Denker via Pharo-dev < pharo-dev(a)lists.pharo.org> wrote: > > > On 11 Jan 2019, at 20:28, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > > > Hi Thomas, > > > > forgive me, my first response was too terse. Having thought about it > in the shower it becomes clear :-) > > > >> On Jan 11, 2019, at 6:49 AM, Thomas Dupriez < > tdupriez(a)ens-paris-saclay.fr> wrote: > >> > >> Hi, > >> > >> Yes, my question was just of the form: "Hey there's this method in > DebugSession. What is it doing? What's the intention behind it? Does > someone know?". There was no hidden agenda behind it. > >> > >> @Eliot > >> > >> After taking another look at this method, there's something I don't > understand: > >> > >> activePC: aContext > >> ^ (self isLatestContext: aContext) > >> ifTrue: [ interruptedContext pc ] > >> ifFalse: [ self previousPC: aContext ] > >> > >> isLatestContext: checks whether its argument is the suspended context > (the context at the top of the stack of the interrupted process). And if > that's true, activePC: returns the pc of **interruptedContext**, not of the > suspended context. These two contexts are different when the debugger opens > on an exception, so this method is potentially returning a pc for another > context than its argument... > >> > >> Another question I have to improve the comment for this method is: > what's the high-level meaning of this concept of "activePC". You gave the > formal definition, but what's the point of defining this so to speak? What > makes this concept interesting enough to warrant defining it and giving it > a name? > > > > There are two âmodesâ where a pc us mapped to a source range. One is > when stepping a context in the debugger (the context is on top and is > actively executing bytecodes). Here the debugger stops immediately before > a send or assignment or return, so that for sends we can do into or over, > or for assignments or returns check stack top to see what will be assigned > or returned. In this mode we want the pc of the send, assign or return to > map to the source range for the send, or the expression being assigned or > returned. Since this is the âcommon caseâ, and since this is the only > choice that makes sense for assignments ta and returns, the bytecode > compiler constructs itâs pc to source range map in terms of the pc of the > first byte if the send, assign or return bytecode. > > > > The second âmodeâ is when selecting a context below the top context. > The pc for any context below the top context will be the return pc for a > send, because the send has already happened. The compiler could choose to > map this pc to the send, but it would not match what works for the common > case. Another choice would appear be to have two map entries, one for the > send and one for the return pc, both mapping to the source range. But this > wouldnât work because the result of a send might be assigned or returned > and so there is a potential conflict. I stead the reasonable solution is > to select the previous pc for contexts below the top of context, which will > be the pc for the start of the send bytecode. > > > > > I checked with Thomas > > -> for source mapping, we use the API of the method map. The map does the > âget the mapping for the instruction beforeâ, it just needs to be told that > we ask the range for an active context: > > #rangeForPC:contextIsActiveContext: > > it is called > > ^aContext debuggerMap > rangeForPC: aContext pc > contextIsActiveContext: (self isLatestContext: aContext) ] > > So the logic was move from the debugger to the Map. (I think this is even > your design?), and thus the logic inside the debugger is not needed > anymore. > "Design" is giving my code a little too much respect. I was desperately trying to get something to work to be able to deploy Cog with the new closure model. I happily admit that DebuggerMethodMap in Squeak is ugly code. It had to be extended recently to handle full blocks. But it would be great to rewrite it. I dream of a harmonisation of Squeak/Pharo/Cuis execution classes such that we have the same Context, CompiledCode, CompiledBlock, CompiledMethod, debuggerMap and BytecodeEncoder (which is effectively the back end of the compiler that generates bytecode, and the interface to the debugger when bytecode is analyses or executed in the debugger), which would make my life easier maintaining the VM and execution classes, especially as we introduce Sista. I think Opal as a separate compiler is great; the work you've done with mustBeBoleanMagic is superb. At the same time the Squeak compiler is fine for its job and I still find it easier to understand than Opal (probably because I'm not spending enough time with it). One major reason for the harmonization is bug fixes. Right now I use SistaV1 and 64-bits as my default work environment, in a 64-bit Squeak image that was compiled with V3PlusClosures, so that half the code base (the base image) is the old bytecode set, but all of VMMaker is the new bytecode set & full blocks. So far in the past few months I've fixed a few issues with pc mapping, debugging in the different bytecode sets, searching for literals with full blocks, fixing Slang for full blocks, etc. And I'd like these bug fixes to make it into Pharo too. If this speaks to you Marcus, maybe we can try and figure out a path that doesn't ruffle too many feathers. -> For the question why the AST node of the Block has no simple method to > check if it is an âisOptimizedâ block (e.g. in an ifTrue:): Yes, that might > be nice. The reason why is is not there is that the compiler internally > using OCOptimizedBlockScope and a check on the AST level was never needed. > I would have added it as soon as it would be needed (quite easy to do). > OK. isOptimized is something I use a lot when analyzing parse trees in looking at the relationship between bytecode and hit code. For example it is key to work I;'m doing right now on register allocation for Sista. On the AST level there is already a check, though, if a *send* is > optimized, which is used for code generation (#isInlined). > The Squeak versions here are MessageNode>>isOptimized, isOptimizedLoop & isOptimizedWhileLoop The question why we did not add more compatibility layers to the old AST is > that is is quite different.. so even with some methods here and there 99% > of clients need changes, so I did not even investigate it too much. With > the idea that if we end up in a situation where we need just a method, we > can just add it as needed. > Reasonable. I simply have to maintain compatibility for the two parse trees. > In general, I have no srtong feelings about the details of the > implementation of Opal. Itâs just what was possible, with the resources and > the understanding that I had at the point it was done. There are for sure > even mistakes. I always make mistakes. > I can join you in all of these for the Squeak compiler. It was not possible to have someone to pair with when modifying the Squeak compiler to conform to my closure design; I was in a tiny startup and had to do all execution technology work. And I always make mistakes too :-) > In addition, it is based on a prior compiler which was done for a > different closure model whose Design-choices influenced it too much I > think, sometimes good, sometimes not. > > But I like the âhigh levelâ: using a shared AST between the compiler and > the tools *and* having a mapping BC -> AST -> Text. > Yes, this is great. > Of course I understand that the choice to use the RB AST for the compiler > is not a âtraditionalâ one.. but it turned out to work very well *and* it > brings some amazing power, as we have now not only a mapping bc->text > offset, but a mapping bc->AST, too. This e.g. (just a a simple example) > makes the magic of the runtime transforming deprecations possible. See > #transform on class Deprecation, the #sourceNodeExecuted: > > transform > | node rewriteRule aMethod | > self shouldTransform ifFalse: [ ^ self ]. > self rewriterClass ifNil:[ ^ self signal ]. > aMethod := self contextOfSender method. > aMethod isDoIt ifTrue:[^ self]. "no need to transform doits" > node := self contextOfSender sourceNodeExecuted. > rewriteRule := self rewriterClass new > replace: rule key with: rule value. > (rewriteRule executeTree: node) > ifFalse: [ ^ self ]. > node replaceWith: rewriteRule tree. > Author > useAuthor: 'AutoDeprecationRefactoring' > during: [aMethod origin compile: aMethod ast formattedCode > classified: aMethod protocol]. > +10 > Marcus _,,,^..^,,,_ best, Eliot

1 0

Re: [Pharo-dev] Better management of encoding of environment variables
by Guillermo Polito Jan. 19, 2019

Jan. 19, 2019

On Fri, Jan 18, 2019 at 1:48 PM Ben Coman via Pharo-dev < pharo-dev(a)lists.pharo.org> wrote: > > > > > On Wed, 16 Jan 2019 at 18:37, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > >> Still, one of the conclusions of previous discussions about the encoding >> of environment variables was/is that there is no single correct solution. >> OS's are not consistent in how the encoding is done in all (historical) >> contexts (like sometimes, > > > >> 1 env var defines the encoding to use for others, > > > ouch. That one point nearly made my retract my comment next paragraph, > but is there much more complexity? > or just a case of utf8<==>appSpecificEncoding rather than > ascii<==>appSpecificEncoding ? > It's not muuuuch more complex. The problem is that usually the bugs that arise from wrongly managing such conversions can be super obscure. > Sorry if I'm rehashing past discussion (do you have a link?), but > considering... > * 92% of web pages are UTF8 encoded[1] such that pragmatically UTF8 *is* > the standard for text > * Strings so pervasive in a system > ...would there be an overall benefit to adopt UTF8 as the encoding for > Strings > consistently provided across the cross-platform vm interface? > (i.e. fixing platforms that don't comply to the standard due to their > historical baggage) > > And I found it interesting Microsoft are making some moves towards UTF8 > [2]... > "With insider build 17035 and the April 2018 update (nominal build 17134) > for Windows 10, a "Beta: Use Unicode UTF-8 for worldwide language support" > checkbox appeared for setting the locale code page to UTF-8.[a] This allows > for calling "narrow" functions, including fopen and SetWindowTextA, with > UTF-8 strings. " > > The approach vm-side could be similar to Section 10 How to do text on > Windows [3] > with the philosophy of "performing the [conversions] as close to API calls > as possible, > and never holding the [converted] data." > > [1] > https://w3techs.com/technologies/history_overview/character_encoding/ms/y > [2] https://en.wikipedia.org/wiki/Unicode_in_Microsoft_Windows > [3] http://utf8everywhere.org/ > > > different applications do different things, and other such nice stuff), >> and certainly not across platforms. >> >> So this is really complex. >> >> Do we want to hide this in some obscure VM C code that very few people >> can see, read, let alone help with ? >> >> The image side is perfectly capable of dealing with platform differences >> in a clean/clear way, and at least we can then use the full power of our >> language and our tools. >> > > Big question... Do we currently have primitives of the same name returning > different encodings on different platforms? I presume that would be > awkward. > If the image is handle encoding differences, should separate primitives be > used? e.g. utf8GetEnv & utf16getEnv > > Could I get some feedback on [4] saying... **The Single Most Important > Fact About Encodings** > If you completely forget everything I just explained, please remember one > extremely important fact. > It does not make sense to have a string without knowing what encoding it > uses. " > > And so... does our String nowadays require an 'encoding' instance variable > such that this is *always* associated? > This might remove any need for separate utf8GetEnv & utf16getEnv (if that > was even a reasonable idea). > I think that will just overcomplicate things. Right now, all Strings in Pharo are unicode strings. Characters are represented with their corresponding unicode codepoint. If all characters in a string have codepoints < 256 then they are just stored in a bytestring. Otherwise they are WideStrings. I think assuming a single representation for strings, and then encode when interacting with external apps/APIs is MUCH simpler. > cheers -ben > > [4] > https://www.joelonsoftware.com/2003/10/08/the-absolute-minimum-every-softwa… > > > >> > On 16 Jan 2019, at 10:59, Guillermo Polito <guillermopolito(a)gmail.com> >> wrote: >> > >> > Hi Nicolas, >> > >> > On Wed, Jan 16, 2019 at 10:25 AM Nicolas Cellier < >> nicolas.cellier.aka.nice(a)gmail.com> wrote: >> > IMO, windows VM (and plugins) should do the UCS2 -> UTF8 conversion >> because the purpose of a VM is to provide an OS independant faÃ§ade. >> > I made progress recently in this area, but we should finish the >> job/test/consolidate. >> > >> > I'm following your changes for windows from the shadows and I think >> they are awesome :). >> > >> > If someone bypass the VM and use direct windows API thru FFI, then he >> takes the responsibility, but uniformity doesn't hurt. >> > >> > So far we are using FFI for this, as you say we create first >> Win32WideStrings from utf8 strings and then we use ffi calls to the *W >> functions. >> > I don't think we can make it for Pharo7.0.0. The cycle to build, do >> some acceptance tests, and then bless a new VM as stable is far too long >> for our inminent release :). >> > >> > But this could be for a 7.1.0, and if you like I can surely give a hand >> on this. >> > >> > Guille >> >> >> -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

5 6