September 2018 - Pharo-dev - lists.pharo.org

Iceberg > review pull request & repo name clash
by Ben Coman Sept. 7, 2018

Sept. 7, 2018

Two concerns from one flow of events... I was trying out "review a pull request" feature for the first time. This looks very promising, but I got stuck. In Pharo 6.1... Downloaded http://files.pharo.org/platform/Pharo6.1-win.zip Updated Icerberg per https://github.com/pharo-vcs/iceberg#update-iceberg Iceberg > Settings > Use custom keys = Enabled > Add > Clone remote repository Remote URL = git@github.com:exercism/pharo.git ==> "pharo" repo appears, status "Not loaded" > "pharo" repo > Packages ==> BaselineOfExercism, Exercism, etc > "pharo" repo > Github > View pull request > origin > enter github account password ==> shows PR#98 "Move setup to class initialization..." > right-click 98 > Review pull request ==> an empty window titled "Browsing pull request: #98...." appeared (see attached) Trying the same in Pharo 7 gave a different problem... >From Launcher started Pharo-7.0.0-alpha.build.1231.sha.cf8aa48.arch.32bit... Iceberg > Settings > Use custom keys = Enabled > "pharo" repo > Forget Repository > Ticked "Also remove repository from file system" > Add > Clone remote repository Remote URL = git@github.com:exercism/pharo.git ==> "pharo" appears, status = "Fetch required. Unknown cf8aa48" > "pharo" repo > Fetch ==> no change in status, but I do see the the expected files in repo on disk > "pharo" repo > Packages ==> only shows LICENSE and README.md. Why did this "just work" in 6.1 ? It seems the source directory is wrong. From this point is it possible to update the source directory to "dev/src/" ? Maybe its due to the name clash "pharo-project/pharo" versus "exercism/pharo" and something was retained after the "Forget Repository". Such a name clash is unfortunate, but is a corner case that should be handled. This could be a useful test case. Before I log an issue, could someone check I'm not doing something wrong. cheers -ben P.S. A work around might have been giving a custom local name for the exercism/pharo repo, much like you can specify the folder created by command line 'git clone'. Is such a feature planned for Iceberg?

2 1

[Pharo 7.0-dev] Build #1236: 22424 Correctly deprecate Ring-Deprecated-Tests-Containers and Ring-Dâ¦
by ci-pharo-ci-jenkins2＠inria.fr Sept. 7, 2018

Sept. 7, 2018

There is a new Pharo build available! The status of the build #1236 was: SUCCESS. The Pull Request #1775 was integrated: "22424 Correctly deprecate Ring-Deprecated-Tests-Containers and Ring-Dâ¦" Pull request url: https://github.com/pharo-project/pharo/pull/1775 Issue Url: https://pharo.fogbugz.com/f/cases/22424 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1235: 22426 Cleanup LzwGifEncoder and GIFReadWriter
by ci-pharo-ci-jenkins2＠inria.fr Sept. 7, 2018

Sept. 7, 2018

There is a new Pharo build available! The status of the build #1235 was: SUCCESS. The Pull Request #1777 was integrated: "22426 Cleanup LzwGifEncoder and GIFReadWriter" Pull request url: https://github.com/pharo-project/pharo/pull/1777 Issue Url: https://pharo.fogbugz.com/f/cases/22426 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1234: 22420 Cleanup DateAndTimeLeapTest
by ci-pharo-ci-jenkins2＠inria.fr Sept. 7, 2018

Sept. 7, 2018

There is a new Pharo build available! The status of the build #1234 was: SUCCESS. The Pull Request #1771 was integrated: "22420 Cleanup DateAndTimeLeapTest" Pull request url: https://github.com/pharo-project/pharo/pull/1771 Issue Url: https://pharo.fogbugz.com/f/cases/22420 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1233: 22429-Enable-completion-for-the-selector-of-a-method
by ci-pharo-ci-jenkins2＠inria.fr Sept. 7, 2018

Sept. 7, 2018

There is a new Pharo build available! The status of the build #1233 was: SUCCESS. The Pull Request #1779 was integrated: "22429-Enable-completion-for-the-selector-of-a-method" Pull request url: https://github.com/pharo-project/pharo/pull/1779 Issue Url: https://pharo.fogbugz.com/f/cases/22429 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Bloc consideration - TextActions
by Ben Coman Sept. 7, 2018

Sept. 7, 2018

This is may not be worth investigating much in Morphic, but tips are welcome. Mainly this is a use case for consideration with the TextAction equivalent in Bloc. For the #text: of a TextEntryDialogWindow I wanted clickable link similar to the bottom of ```WelcomeHelp open``` which would open a link in a web browser using https://github.com/seandenigris/Pharo-Web-Browser. Experimenting in Playground, this[1] looked promising... ``` linkText := 'https://exercism.io/my/settings' asText addAttribute: (TextAction new actOnClickBlock: [ self inform: 'STUB: Invoke web browser here']); addAttribute: (TextColor new color: Color cyan). requestText := 'Enter your Exercism token (from ' asText, linkText, '):'. requestText inspect. ``` where clicking on the link displays the information message. But this[2] didn't work... ```UIManager default request: requestText``` or to be more explicit, diving in a few calls down and simplifying, neither did this... ```(TextEntryDialogWindow new text: requestText) openInWorld``` I tracked it down to [2] having a locked TextMorph for requestText. (observed using the following instrumentation...) TextMorph isLocked (text asString includesSubstring: 'Enter your Exercism token') ifTrue: [ Transcript show: (super isLocked ifTrue: 'x' ifFalse:'.')]. ^ super isLocked and confirmed with this experiment... ``` tm1 := TextMorph new newContents: requestText. tm2 := tm1 copy lock. tm1 openInWorld. "Test clicking the text - action is invoked" tm1 delete. tm2 openInWorld. "Test clicking the text - action not invoked" tm2 delete. ``` This is due to #isLocked call here...: ``` Morph>>rejectsEvent: anEvent "Return true to reject the given event. Rejecting an event means neither the receiver nor any of it's submorphs will be given any chance to handle it. If the event is a mouse wheel event then only reject if the receiver is not visible." (anEvent isMouse and: [anEvent isMouseWheel]) ifTrue: [^self visible not]. ^self isLocked or: [self visible not] ``` Now the functional paradox here is that: * an unlocked TextMorph is editable, which you don't want for a static UI label; * but a locked TextMorph doesn't pass events through to trigger the TextAction. Thus it you can't have a clickable link in a static UI label. Yet that is almost an essential feature in today's "linked" world and I hope Bloc will provide a facility for actions within static/locked text. cheers -ben P.S. Any tips on getting this to work in Pharo 6.1 would be appreciated.

1 1

[Pharo 7.0-dev] Build #1232: 22410-NECWorkspaceController-is-not-used
by ci-pharo-ci-jenkins2＠inria.fr Sept. 7, 2018

Sept. 7, 2018

There is a new Pharo build available! The status of the build #1232 was: FAILURE. The Pull Request #1778 was integrated: "22410-NECWorkspaceController-is-not-used" Pull request url: https://github.com/pharo-project/pharo/pull/1778 Issue Url: https://pharo.fogbugz.com/f/cases/22410 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Status fo Stream changes in Pharo 7
by Torsten Bergmann Sept. 6, 2018

Sept. 6, 2018

Hi, In Pharo 7 there were changes applied to rework the streams. I understand that we might have reasons to change it - but to me this looks incomplete and not finished. For instance "FileStream" is a deprecated class - but still a lot of code in the image is referencing it instead, Is there a guide or plan for all these methods being reworked to use a (hopefully compatible) alternative. Can anyone involved in this topic give an update on the status? Thanks T.

2 1

[Pharo 7.0-dev] Build #1231: 22423 Correctly deprecate MatrixTest
by ci-pharo-ci-jenkins2＠inria.fr Sept. 6, 2018

Sept. 6, 2018

There is a new Pharo build available! The status of the build #1231 was: SUCCESS. The Pull Request #1774 was integrated: "22423 Correctly deprecate MatrixTest" Pull request url: https://github.com/pharo-project/pharo/pull/1774 Issue Url: https://pharo.fogbugz.com/f/cases/22423 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1230: 22421 fogbugz is now manuscript
by ci-pharo-ci-jenkins2＠inria.fr Sept. 6, 2018

Sept. 6, 2018

There is a new Pharo build available! The status of the build #1230 was: FAILURE. The Pull Request #1772 was integrated: "22421 fogbugz is now manuscript" Pull request url: https://github.com/pharo-project/pharo/pull/1772 Issue Url: https://pharo.fogbugz.com/f/cases/22421 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0