August 2018 - Pharo-dev - lists.pharo.org

Stdio>>#standardIOStreamNamed:forWrite: bug?
by Alistair Grant Aug. 6, 2018

Aug. 6, 2018

Hi Damien, Vincent and Guille, Just a disclaimer: despite having done some work on this, I don't consider myself an expert. If someone else has a better explanation, please jump in. Damien wrote on discord: > is there a notion of standard input/output on windows ? Yes, console applications can use stdio. PharoConsole.exe when run from a command prompt has stdio. (Note that cygwin terminals are different and don't support stdio (since Pharo uses the native windows functions)). > looks like Alistair added the possibility to open files by number, Holger Freyther deserves the credit here. My clumsy git merging left his name out as the author (sorry Holger!). > that's probably what was missing at the time Stdio was introduced I'm not sure that opening files by fd would be useful in this particular case. There are three ways to access files on Windows: file descriptor - posix compatibility FILE* - posix compatibility HANDLE - windows native The VM uses native operations for file i/o on Windows, e.g. Read/WriteConsole() for stdio (including pipe redirection of stdio). Mixing file descriptors and FILE* is possible if you're careful. I don't know how to mix fd / FILE* and HANDLEs. It's probably better to stick with using native windows functions most of the time. We included these functions on Windows since they exist, and there are probably some use cases, but you need to know what you're doing. File class>>stdioHandles calls primitiveFileStdioHandles() which eventually opens the stdio streams (if possible) using the Windows native GetStdHandle() function. > I suspect File needs a nameless variant (I'm not certain how pipes > work in unix but I doubt echo foo | cat ever touches the filesystem) That's my understanding (it doesn't touch the file system). > hmm but the short-term bug is that the TTY logic in Stdio >> > #standardIOStreamNamed:forWrite: fails when all 3 standard streams are > redirected OK, my understanding of what you are saying is that if all 3 io streams are redirected the method incorrectly determines that a console isn't present and so falls back to calling #createStdioFileFor:. More below... > I also don't understand the assumption there Vincent Blondeau added / modified these methods, so he may be able to provide more information. I think the assumption is that if any of the stdio files are connected to a TTY. then it is possible to open all the stdio files. If none are present, then (on Windows) create regular files to act as a substitute. The problem is that it only tests for a TTY, when what we really want is a TTY or a file or a pipe. Assuming I've understood correctly, maybe try modifying (sorry for the loss of formatting, only the last line is changed): File class>>stdioDescriptorIsATTY ^ (0 to: 2) anySatisfy: [ :fdNum | | res | res := self fileDescriptorType: fdNum. res between: 1 and: 3 ] We'd need to rename the method, since it is misleading, but it looks like it better represents the intended use. Cheers, Alistair

4 8

[Pharo 7.0-dev] Build #1159: 22295-Integrate-new-Iceberg-Version
by ci-pharo-ci-jenkins2＠inria.fr Aug. 3, 2018

Aug. 3, 2018

There is a new Pharo build available! The status of the build #1159 was: SUCCESS. The Pull Request #1670 was integrated: "22295-Integrate-new-Iceberg-Version" Pull request url: https://github.com/pharo-project/pharo/pull/1670 Issue Url: https://pharo.fogbugz.com/f/cases/development Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1158: 22294-MCTraitDefinition-is-not-correctly-initialised-in-all-the-constructors
by ci-pharo-ci-jenkins2＠inria.fr Aug. 3, 2018

Aug. 3, 2018

There is a new Pharo build available! The status of the build #1158 was: FAILURE. The Pull Request #1669 was integrated: "22294-MCTraitDefinition-is-not-correctly-initialised-in-all-the-constructors" Pull request url: https://github.com/pharo-project/pharo/pull/1669 Issue Url: https://pharo.fogbugz.com/f/cases/22294 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1157: Fix https://pharo.fogbugz.com/f/cases/22241
by ci-pharo-ci-jenkins2＠inria.fr Aug. 3, 2018

Aug. 3, 2018

There is a new Pharo build available! The status of the build #1157 was: SUCCESS. The Pull Request #1627 was integrated: "Fix https://pharo.fogbugz.com/f/cases/22241" Pull request url: https://github.com/pharo-project/pharo/pull/1627 Issue Url: https://pharo.fogbugz.com/f/cases/development Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1156: changed the comment
by ci-pharo-ci-jenkins2＠inria.fr Aug. 3, 2018

Aug. 3, 2018

There is a new Pharo build available! The status of the build #1156 was: SUCCESS. The Pull Request #1652 was integrated: "changed the comment" Pull request url: https://github.com/pharo-project/pharo/pull/1652 Issue Url: https://pharo.fogbugz.com/f/cases/22144 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1155: 20243-Temporary-is-not-detected-as-written-only-when-assigned-in-a-nested-assignment
by ci-pharo-ci-jenkins2＠inria.fr Aug. 2, 2018

Aug. 2, 2018

There is a new Pharo build available! The status of the build #1155 was: SUCCESS. The Pull Request #1658 was integrated: "20243-Temporary-is-not-detected-as-written-only-when-assigned-in-a-nested-assignment" Pull request url: https://github.com/pharo-project/pharo/pull/1658 Issue Url: https://pharo.fogbugz.com/f/cases/20243 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1154: 22292-MCTraitDefinition-should-correctly-support-stateful-traits
by ci-pharo-ci-jenkins2＠inria.fr Aug. 2, 2018

Aug. 2, 2018

There is a new Pharo build available! The status of the build #1154 was: FAILURE. The Pull Request #1667 was integrated: "22292-MCTraitDefinition-should-correctly-support-stateful-traits" Pull request url: https://github.com/pharo-project/pharo/pull/1667 Issue Url: https://pharo.fogbugz.com/f/cases/22292 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1153: 22284-Freeze-during-startup
by ci-pharo-ci-jenkins2＠inria.fr Aug. 1, 2018

Aug. 1, 2018

There is a new Pharo build available! The status of the build #1153 was: SUCCESS. The Pull Request #1659 was integrated: "22284-Freeze-during-startup" Pull request url: https://github.com/pharo-project/pharo/pull/1659 Issue Url: https://pharo.fogbugz.com/f/cases/22284 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #1152: 22291-Deprecation-of-OSEnvironment-default-should-have-a-rewrite-tool
by ci-pharo-ci-jenkins2＠inria.fr Aug. 1, 2018

Aug. 1, 2018

There is a new Pharo build available! The status of the build #1152 was: SUCCESS. The Pull Request #1665 was integrated: "22291-Deprecation-of-OSEnvironment-default-should-have-a-rewrite-tool" Pull request url: https://github.com/pharo-project/pharo/pull/1665 Issue Url: https://pharo.fogbugz.com/f/cases/22291 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Problem with Iceberg and Working Branches
by Eric Gade Aug. 1, 2018

Aug. 1, 2018

I have already mentioned some of this on Discord so forgive me for being redundant if you've seen it. I'm having problems loading into the latest P7 images from Launcher a working branch of Pharo that I have forked. I perform the following steps: 1. "Repair" the missing local repository for Pharo and load from my forked version on Github 2. Now in the "detached working copy" state, I repair again 3. This time I select "Discard local changes and checkout existing branch". I select my working branch from the remotes 4. It will attempt to load, but eventually a popup appears (not a normal error) that simply says "origin: Error" and "Assertion failed". I'm not sure what's going on, since this procedure seemed to work a week or so ago if I remember correctly. As of a couple of days ago I can no longer load (ie work on) my working branch. I figure I'm doing something wrong, but need to know what. -- Eric

3 6