November 2017 - Pharo-dev - lists.pharo.org

float & fraction equality bug
by Tudor Girba Nov. 12, 2017

Nov. 12, 2017

Hi, I just stumbled across this bug related to the equality between fraction and float: https://pharo.fogbugz.com/f/cases/20488/x-y-iff-x-y-0-is-not-preserved-in-P… In essence, the problem can be seen that by doing this, you get a ZeroDivide: x := 0.1. y := (1/10). x = y ifFalse: [ 1 / (x - y) ] The issue seems to come from the Float being turned to a Fraction, rather than the Fraction being turned into a Float: Fraction(Number)>>adaptToFloat: rcvr andCompare: selector "If I am involved in comparison with a Float, convert rcvr to a Fraction. This way, no bit is lost and comparison is exact." rcvr isFinite ifFalse: [ selector == #= ifTrue: [^false]. selector == #~= ifTrue: [^true]. rcvr isNaN ifTrue: [^ false]. (selector = #< or: [selector = #'<=']) ifTrue: [^ rcvr positive not]. (selector = #> or: [selector = #'>=']) ifTrue: [^ rcvr positive]. ^self error: 'unknow comparison selector']. ^ rcvr asTrueFraction perform: selector with: self Even if the comment says that the comparison is exact, to me this is a bug because it seems to fail doing that. What do you think? Cheers, Doru -- www.tudorgirba.com www.feenk.com "Problem solving should be focused on describing the problem in a way that makes the solution obvious."

12 46

[Pharo 7.0-dev] Build #286: 20673 Categorize uncategorized methods in classes starting with H
by ci-pharo-ci-jenkins2＠inria.fr Nov. 12, 2017

Nov. 12, 2017

There is a new Pharo build available! The status of the build #286 was: SUCCESS. The Pull Request #467 was integrated: "20673 Categorize uncategorized methods in classes starting with H" Pull request url: https://github.com/pharo-project/pharo/pull/467 Issue Url: https://pharo.fogbugz.com/f/cases/20673 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #285: 20675 Categorize uncategorized methods in classes starting with D
by ci-pharo-ci-jenkins2＠inria.fr Nov. 12, 2017

Nov. 12, 2017

There is a new Pharo build available! The status of the build #285 was: SUCCESS. The Pull Request #469 was integrated: "20675 Categorize uncategorized methods in classes starting with D" Pull request url: https://github.com/pharo-project/pharo/pull/469 Issue Url: https://pharo.fogbugz.com/f/cases/20675 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

Encoding method source code in Tonel
by Sven Van Caekenberghe Nov. 11, 2017

Nov. 11, 2017

Hi, Right now, TonelParser>>#methodBody looks a bit dangerous (too complex), and Nicolas already found some breaking cases as well a one possible solution. I was thinking a bit along the same lines, so here is a proposal. Overall I think we should keep the current readability of Tonel as much as possible (it is very important for diffs), while still being correct - i.e. no method source, even convoluted ones, possibly in different languages should break the encoding. The problem is how to quickly scan a stream for the closing $] (which occurs as a single character on a line by its own). Especially in Pharo source code, that situation (a conflict between the proper marker and actual source) is very rare, since code is usually intended. But is can occur and must be dealt with. The proposal is to just double the $] but only on lines that could conflict (which are lines consisting of only $]'s). The code itself becomes quite simple and remains fast enough. Here is some code to play with (EOL fixed to #cr for demo purposes): writer := [ :stream :methodSourceString | stream nextPut: $[; cr. methodSourceString linesDo: [ :line | (line notEmpty and: [ line allSatisfy: [ :ch | ch = $] ] ]) ifTrue: [ stream << $] ]. stream << line; cr ]. stream nextPut: $]; cr ]. reader := [ :stream | | line | (stream peekFor: $[) ifTrue: [ stream nextLine ] ifFalse: [ self error ]. String streamContents: [ :out | [ (line := stream nextLine) = ']' ] whileFalse: [ (line notEmpty and: [ line allSatisfy: [ :ch | ch = $] ] ]) ifTrue: [ out << line allButFirst ] ifFalse: [ out << line ]. out cr ] ] ]. encoded := String streamContents: [ :out | writer value: out value: (Collection>>#inject:into:) sourceCode ]. (reader value: encoded readStream) = ((Collection>>#inject:into:) sourceCode, String cr). escapedEncoded := String streamContents: [ :out | writer value: out value: 'test "Make sure there is no whitespace at line start to force an escape" self isFoo ifTrue: [ #foo ] ifFalse: [ [ "block" #bar ]] ' ]. (reader value: escapedEncoded readStream). What do you think ? Did I miss any special cases ? Is the price (very occasional insertion of an extra #] in the source code) worth the advantage (a simple, safe scheme). Sven PS: Note that several tools line syntax highlighting and double-click next to brackets have problems with weird delimiters such as in the above code ;-)

7 19

Thanks for he TDD improvement!
by Stephane Ducasse Nov. 11, 2017

Nov. 11, 2017

Hi this is super cool to get tests refreshed in nautilus when we define the method in the debugger. I was always bored when I do demo to have the rerun the tests. TX because this is super cool We should continue to improve the user experience in Pharo. Stef

2 2

Alternative window manager
by Thomas Dupriez Nov. 11, 2017

Nov. 11, 2017

Hello, Does an alternative window manager for pharo exist? For some reasons I always end up with a tangled mess of windows when using the default one. My biggest gripe is that new windows tend to open on top of other windows, blocking the view even if there is still empty space elsewhere. I watched this video ( https://www.youtube.com/watch?v=Wx0eNaGzAZU ) about the i3 window manager for linux and how it paves the screen with the windows to optimise screen space and make things look less messy, and was wondering whether something like that existed for pharo. Cheers, Thomas

4 3

[Pharo 7.0-dev] Build #284: 20671-Extend-system-dependencies-tests-on-whole-image
by ci-pharo-ci-jenkins2＠inria.fr Nov. 10, 2017

Nov. 10, 2017

There is a new Pharo build available! The status of the build #284 was: SUCCESS. The Pull Request #464 was integrated: "20671-Extend-system-dependencies-tests-on-whole-image" Pull request url: https://github.com/pharo-project/pharo/pull/464 Issue Url: https://pharo.fogbugz.com/f/cases/20671 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #283: 20670-unused-var-in-generateDefaultFileOutResultsName
by ci-pharo-ci-jenkins2＠inria.fr Nov. 10, 2017

Nov. 10, 2017

There is a new Pharo build available! The status of the build #283 was: SUCCESS. The Pull Request #465 was integrated: "20670-unused-var-in-generateDefaultFileOutResultsName" Pull request url: https://github.com/pharo-project/pharo/pull/465 Issue Url: https://pharo.fogbugz.com/f/cases/20670 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #282: 20668-add-breakpoints-menu-to-Nautilus-segment-icons
by ci-pharo-ci-jenkins2＠inria.fr Nov. 10, 2017

Nov. 10, 2017

There is a new Pharo build available! The status of the build #282 was: SUCCESS. The Pull Request #463 was integrated: "20668-add-breakpoints-menu-to-Nautilus-segment-icons" Pull request url: https://github.com/pharo-project/pharo/pull/463 Issue Url: https://pharo.fogbugz.com/f/cases/20668 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0

[Pharo 7.0-dev] Build #281: 20055-immediateByteSubclass-is-deadcoe
by ci-pharo-ci-jenkins2＠inria.fr Nov. 10, 2017

Nov. 10, 2017

There is a new Pharo build available! The status of the build #281 was: SUCCESS. The Pull Request #462 was integrated: "20055-immediateByteSubclass-is-deadcoe" Pull request url: https://github.com/pharo-project/pharo/pull/462 Issue Url: https://pharo.fogbugz.com/f/cases/20055 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

1 0